Jump to content

Recommended Posts

Posted (edited)

So I decided to bump my modding into 1.12.2 to try and stay with the times. Wasn't too hard to migrate from 1.11.2 but I started fresh to and see a huge reliance now on JSON, which is fine. I understand it well enough. However I have run into a slight issue. I am sure I have to change something in my JSON to get this working but Im not sure what. 

 

I have an item, it has subtypes. The item registers just fine, gets added to the game just fine and has the correct name. The variatns register the different textures. No issues.

Only problem I seem to have is that the name for the item (And its variants/subtypes) is all item.item_runestone.name. It has the correct meta data values assigned to it from 0 - 5.

So I am guessing perhaps I have to indicate in my .JSON how it should be names?

 

Here is the JSON:

https://pastebin.com/5jS9ECNd

Each Respective Runestone JSON:

https://pastebin.com/mchBZipj (there are 5 more of these each named properly. The only thing that changes in each is the 

"layer0": "hsrs:items/runestones/rune_air"

To the proper runestone.

 

If you need anything else please let me know, but I'm imagining since nothing is erroring it isn't anything code related and purely the way i constructed the .json But then again I could be wrong.\

 

Is it supposed to be something like:

"variant=rune_basic": { "model": "hsrs:runestones/rune_basic", "displayName": "Basic Runestone" },

 

Maybe?

 

Edited by HalestormXV
Posted

Unlocalised names are controlled by the Item class and translations of those are specified in the lang files, there's no JSON involved.

 

If your variants were displaying their names correctly in 1.11.2, they should still do so in 1.12.2 unless you've changed something.

 

Post your Item class, the class where you register your Items and your en_us.lang file.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
8 hours ago, Choonster said:

Unlocalised names are controlled by the Item class and translations of those are specified in the lang files, there's no JSON involved.

 

If your variants were displaying their names correctly in 1.11.2, they should still do so in 1.12.2 unless you've changed something.

 

Post your Item class, the class where you register your Items and your en_us.lang file.

 

Found it. I forgot to add my:

@Override
public String getUnlocalizedName(ItemStack stack)
{
    return super.getUnlocalizedName()+ "_" + this.getSpecialName(stack);
}

 

into the class. That was an oversight on my part.

 

But for anyone who is interested on how I did it. (Not sure if it is the "conventional" way for whatever new standards are set for 1.12.2)

Here it is:

 

ItemRunes:

https://pastebin.com/rnddRz7c

 

RunesHandler:

https://pastebin.com/sB0x4exm

 

All items and blocks are registered in a separate class but that doesn't show any functionality on how the actual runes are handled and registered so I just left them out.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.