[Solved] Leave Visibility

[Setrion]

Hey guys, i have a small (i hope it is nothing that can be a big problem xD) texture/visibility bug with my leaves
the issue is, that i can see through them and the other leaves behind the first one are invisible
i think these 2 screenshots can show what my issue is (one is the Vanilla Oak Leaves & one are my leaves, i hope you can see what i want to say..)
Sorry for my bad english, try to be better by time
 

Edited March 27, 2018 by Setrion
Solved

[jhdoran]

Are you leaf blocks opaque?

[Setrion]

If true & false i got this issue, i tried it a lot times

[jabelar]

You need a few things all correct, such as the shouldSideBeRendered() and the render layer, etc. 

 

Is your block extending BlockLeaves? If so then it should already work unless you're overriding the block methods improperly. Otherwise just inspect BlockLeaves and make sure all the code related to rendering is copied.

[Setrion]

If i override the methods for rendering etc. they're like the picture of my leaves, if i delete them from my leaves file, they're the same, but with black in the transparent fields

I can paste you the code if you want

 

package com.setrion.koratio.blocks;

import java.util.List;
import java.util.Random;

import com.setrion.koratio.main.Koratio;

import net.minecraft.block.Block;
import net.minecraft.block.BlockLeaves;
import net.minecraft.block.BlockPlanks;
import net.minecraft.block.BlockPlanks.EnumType;
import net.minecraft.block.BlockSlab.EnumBlockHalf;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumParticleTypes;
import net.minecraft.util.NonNullList;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockJubanLeaves extends BlockLeaves {
	
	private boolean leavesFancy = GameSettings.Options.GRAPHICS != null;
	
	public BlockJubanLeaves() {
		this.setUnlocalizedName("juban_leaves");
		this.setRegistryName("juban_leaves");
		this.setCreativeTab(Koratio.blockTab);
		this.setDefaultState(this.blockState.getBaseState().withProperty(CHECK_DECAY, Boolean.valueOf(true)).withProperty(DECAYABLE, Boolean.valueOf(true)));
	}
	
	public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(DECAYABLE, Boolean.valueOf((meta & 2) == 0)).withProperty(CHECK_DECAY, Boolean.valueOf((meta & 4) > 0));
    }
	
	@Override
	public int getMetaFromState(IBlockState state) 
	{
		int i = 0;
		
		if(!((Boolean)state.getValue(DECAYABLE)).booleanValue())
		{
			i |= 2;
		}
		
		if(!((Boolean)state.getValue(CHECK_DECAY)).booleanValue())
		{
			i |= 4;
		}
		
		return i;
	}
	
	protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {CHECK_DECAY, DECAYABLE});
    }
	
	@Override
    public NonNullList<ItemStack> onSheared(ItemStack item, net.minecraft.world.IBlockAccess world, BlockPos pos, int fortune)
    {
        return NonNullList.withSize(1, new ItemStack(this, 1));
    }

	@Override
	public EnumType getWoodType(int meta) {
		return null;
	}
	
	@Override
    public void beginLeavesDecay(IBlockState state, World world, BlockPos pos)
    {
        if (!(Boolean)state.getValue(CHECK_DECAY))
        {
            world.setBlockState(pos, state.withProperty(CHECK_DECAY, true), 1);
        }
    }

	@Override public boolean isShearable(ItemStack item, IBlockAccess world, BlockPos pos){ return true; }
    @Override public boolean isLeaves(IBlockState state, IBlockAccess world, BlockPos pos){ return true; }

    public boolean isFullCube(IBlockState state)
    {
        return false;
    }
    
    public boolean isOpaqueCube(IBlockState state)
    {
        return !this.leavesFancy;
    }

    /**
     * Pass true to draw this block using fancy graphics, or false for fast graphics.
     */
    @SideOnly(Side.CLIENT)
    public void setGraphicsLevel(boolean fancy)
    {
        this.leavesFancy = fancy;
    }

    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer()
    {
        return this.leavesFancy ? BlockRenderLayer.CUTOUT_MIPPED : BlockRenderLayer.SOLID;
    }
    
    public boolean causesSuffocation(IBlockState state)
    {
        return false;
    }

    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return Item.getItemFromBlock(ModBlocks.blockJubanSapling);
    }

    protected int getSaplingDropChance(IBlockState state)
    {
        return 20;
    }
	
	public void registerItemModel(Item itemBlock) {
		Koratio.proxy.registerItemRenderer(itemBlock, 0, "juban_leaves");
	}
	
	public Item createItemBlock() {
		return new ItemBlock(this).setRegistryName(getRegistryName());
	}
	
	@SideOnly(Side.CLIENT)
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side)
    {
        return !this.leavesFancy && blockAccess.getBlockState(pos.offset(side)).getBlock() == this ? false : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
    }

}

 

Edited March 27, 2018 by Setrion

[jabelar]

The black in the transparent fields is a problem where leaves are hard-coded for honoring the fancy graphics setting. For custom leaves it is very difficult to make your leaves honor that setting, so I just make it always fancy for my own leaves.

 

You can look at how I do it in my own custom leaves: https://github.com/jabelar/ExampleMod-1.12/blob/master/src/main/java/com/blogspot/jabelarminecraft/examplemod/blocks/BlockLeavesCloud.java

 

In the constructor you can see I call a proxy method to set the graphics level to always be fancy. You should do the same -- you'll also need to look at my code in my ClientProxy and ServerProxy classes.

 

It is possible but tricky to get the fancy setting to work as a user setting. There are other threads on that if you really care. I personally think anyone who needs to turn off fancy settings should get a new computer!

[Setrion]

And your leaves are looking like the vanilla ones? you see the leaves behind other leaves? that's what i want to get

[jabelar]

1 hour ago, Setrion said:

And your leaves are looking like the vanilla ones? you see the leaves behind other leaves? that's what i want to get

Yes.

[Setrion]

It finally works thank you very much