Jump to content

Recommended Posts

Posted (edited)

Hi,

 

I'm working on updating my old mod from 1.7.10 to 1.12.2. I'm having trouble updating one of my entities (a projectile similar to a snowball). The entity itself works fine, but I haven't been able to get it to render; it's invisible. I've looked around tutorials and this forum for a while but haven't found anything that worked.

 

Here's my entity renderer class:

 

public class RenderMagicOrb extends Render<EntityMagicOrb> {

    private static ResourceLocation TEXTURE_RED = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_red.png");
    private static ResourceLocation TEXTURE_YELLOW = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_yellow.png");
    private static ResourceLocation TEXTURE_GREEN = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_green.png");
    private static ResourceLocation TEXTURE_BLUE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_blue.png");
    private static ResourceLocation TEXTURE_BLACK = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_black.png");
    private static ResourceLocation TEXTURE_WHITE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_white.png");

    public RenderMagicOrb(RenderManager renderManagerIn) {
        super(renderManagerIn);
    }

    public void doRender(@Nonnull EntityMagicOrb entity, double x, double y, double z,
                         float entityYaw, float partialTicks) {
        GlStateManager.pushMatrix();
        bindEntityTexture(entity);
        GlStateManager.translate((float)x, (float)y, (float)z);
        GlStateManager.enableRescaleNormal();
        GlStateManager.scale(2.0F, 2.0F, 2.0F);
        Tessellator tessellator = Tessellator.getInstance();
        BufferBuilder bufferbuilder = tessellator.getBuffer();

        GlStateManager.rotate(180.0F - this.renderManager.playerViewY, 0.0F, 1.0F, 0.0F);
        GlStateManager.rotate((float)(this.renderManager.options.thirdPersonView == 2 ? -1 : 1) * -this.renderManager.playerViewX, 1.0F, 0.0F, 0.0F);

        if (renderOutlines) {
            GlStateManager.enableColorMaterial();
            GlStateManager.enableOutlineMode(this.getTeamColor(entity));
        }

        bufferbuilder.begin(7, DefaultVertexFormats.POSITION_TEX_NORMAL);
        bufferbuilder.pos(-0.5D, -0.25D, 0.0D).tex(0.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, -0.25D, 0.0D).tex(1.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, 0.75D, 0.0D).tex(1.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(-0.5D, 0.75D, 0.0D).tex(0.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        tessellator.draw();

        if (renderOutlines) {
            GlStateManager.disableOutlineMode();
            GlStateManager.disableColorMaterial();
        }

        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, entityYaw, partialTicks);
    }

    @Override
    protected ResourceLocation getEntityTexture(@Nonnull EntityMagicOrb entity) {
        switch (entity.getElement()) {
            case RED:
                return TEXTURE_RED;
            case YELLOW:
                return TEXTURE_YELLOW;
            case GREEN:
                return TEXTURE_GREEN;
            case BLUE:
                return TEXTURE_BLUE;
            case BLACK:
                return TEXTURE_BLACK;
            case WHITE:
                return TEXTURE_WHITE;
        }
        //Default, should never happen
        return TEXTURE_RED;
    }
}

 

And here's my ClientProxy:

 

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {
    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);
        RenderingRegistry.registerEntityRenderingHandler(EntityMagicOrb.class, new IRenderFactory<EntityMagicOrb>() {
            @Override
            public Render<? super EntityMagicOrb> createRenderFor(RenderManager manager) {
                return new RenderMagicOrb(manager);
            }
        });
    }

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {

    }

    @Override
    public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(MagicMod.MODID + ":" + id, "inventory"));
    }
}

 

Here's the entity class itself, though I don't think it's the problem

 

public class EntityMagicOrb extends EntityThrowable implements IEntityAdditionalSpawnData {

    private SpellProjectile spell;
    private float gravity = 0.03F;

    public EntityMagicOrb(World world, EntityPlayer player, SpellProjectile spell) {
        super(world, player);
        this.shoot(player, player.rotationPitch, player.rotationYaw,
                0.0F, 1.5F, 1.0F);

        this.spell = spell;
    }

    @Override
    protected void onImpact(RayTraceResult result) {
        spell.projectileEffect(this, (EntityPlayer) this.getThrower(), this.getEntityWorld());

        if (!this.world.isRemote) {
            this.world.setEntityState(this, (byte)3);
            this.setDead();
        }
    }



    @Override
    public void onUpdate() {
        super.onUpdate();
        if (this.ticksExisted > 400)
            setDead();
    }

    public Element getElement() {
        return spell.getElement();
    }

    @Override
    protected float getGravityVelocity() {
        return gravity;
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
        super.writeToNBT(nbt);
        nbt.setByte("Spell", (byte) Spells.getPlaceInList(spell));
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        super.readFromNBT(nbt);
        spell = (SpellProjectile) Spells.getFromList(nbt.getByte("Spell"));
    }

    @Override
    public void writeSpawnData(ByteBuf buffer) {
        buffer.writeInt(Spells.getPlaceInList(spell));
    }
    @Override
    public void readSpawnData(ByteBuf additionalData) {
        spell = (SpellProjectile) Spells.getFromList(additionalData.readInt());
    }
}

 

What am I missing?

Edited by CactusCoffee
Problem Solved
Posted

It actually ended up being something even dumber that I overlooked. In the code I copied from 1.7.10 for spawning the projectile, I had an if (!world.isRemote) check before spawning the entity. So of course the entity didn't appear client-side. Getting rid of that check fixed the issue. Not sure why it worked in 1.7.10, but whatever.

 

Thank you.

Posted (edited)

Ah. I did have a feeling it wasn't quite right - i noticed after i marked this solved that the explosion caused by the projectile on impact was slightly off from where it appeared to hit. Thanks for calling that out. The World constructor in the entity class didn't do it, though.

 

Here are the constructors I added:

 

public EntityMagicOrb(World world) {
        super(world);
    }

    public EntityMagicOrb(World world, SpellProjectile spell) {
        super(world);
        this.spell = spell;
    }

 

Edited by CactusCoffee
Posted

It looks like my entity registration method isn't being called at all. The entity registration itself may be wrong too. Here's the registration method:

 

@SubscribeEvent
    public void registerEntities(RegistryEvent.Register<EntityEntry> event) {
        System.out.println("Registering Mod Entities");
        EntityEntry entry = EntityEntryBuilder.create()
                .entity(EntityMagicOrb.class)
                .id(new ResourceLocation(MagicMod.MODID, "magic_orb"), 0)
                .name("magic_orb")
                .tracker(64, 20, true)
                .build();
        event.getRegistry().register(entry);
    }

 

 

Posted

Found the problem.

 

It wasn't getting called because registerEntities wasn't static, since I'm using @Mod.EventBusSubscriber.

 

I knew this would be something stupid, but I didn't think it would be something that stupid.

 

Thank you.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.