Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I am the developer of the ResearchCraft mod, and while making the mod I found that I needed a small hook to check the position before the crafting happens. This would help me to finish the mod and might help others who want some recipe to be used only under certain circumstances, like for example a recipe to make ice from a water bucket. That recipe would be disabled unless the crafting occurs in a snow biome.

 

Ok, so I have the hook here, this is what I want it to be like.

Look at it and say if you like it or the coding is awful and must be replaced by some better code:

 

ICraftingHandler.java: with onTakenFromCrafting.

 

    /**
     * Called when checking if a recipe can be used.
     * @param the crafting matrix used
     * @param the recipe that needs confirmation to be crafted
     * @param whether there is world and position info (new findMatchingRecipe() method) or not (deprecated findMatchingRecipe() method)
     * @param the world where the crafting takes place (only if hasPosition is true)
     * @param x coordinate where the crafting takes place (only if hasPosition is true)
     * @param y coordinate where the crafting takes place (only if hasPosition is true)
     * @param z coordinate where the crafting takes place (only if hasPosition is true)
     * @return whether the recipe can be crafted or not.
     */
    public boolean onTryingToCraft(InventoryCrafting craftMatrix, IRecipe recipe, boolean hasPosition, World world, int x, int y, int z);

 

 

ForgeHooks.java: after or before onTakenFromCrafting.

 

    public static boolean onTryingToCraft(InventoryCrafting craftingMatrix, IRecipe recipe, boolean hasPosition, World world, int x, int y, int z)
    {
        for (ICraftingHandler handler : craftingHandlers)
        {
            if (!handler.onTryingToCraft(craftingMatrix, recipe, hasPosition, world, x, y, z))
            {
                return false;
            }
        }
        return true;
    }

 

 

CraftingManager: note that there is some code in the deprecated one.

 

    @Deprecated
    public ItemStack findMatchingRecipe(InventoryCrafting par1InventoryCrafting)
    {
        int var2 = 0;
        ItemStack var3 = null;
        ItemStack var4 = null;
        int var5;

        for (var5 = 0; var5 < par1InventoryCrafting.getSizeInventory(); ++var5)
        {
            ItemStack var6 = par1InventoryCrafting.getStackInSlot(var5);

            if (var6 != null)
            {
                if (var2 == 0)
                {
                    var3 = var6;
                }

                if (var2 == 1)
                {
                    var4 = var6;
                }

                ++var2;
            }
        }

        if (var2 == 2 && var3.itemID == var4.itemID && var3.stackSize == 1 && var4.stackSize == 1 && Item.itemsList[var3.itemID].isRepairable())
        {
            Item var11 = Item.itemsList[var3.itemID];
            int var10 = var11.getMaxDamage() - var3.getItemDamageForDisplay();
            int var7 = var11.getMaxDamage() - var4.getItemDamageForDisplay();
            int var8 = var10 + var7 + var11.getMaxDamage() * 10 / 100;
            int var9 = var11.getMaxDamage() - var8;

            if (var9 < 0)
            {
                var9 = 0;
            }

            return new ItemStack(var3.itemID, 1, var9);
        }
        else
        {
            for (var5 = 0; var5 < this.recipes.size(); ++var5)
            {
                IRecipe var12 = (IRecipe)this.recipes.get(var5);

                if (var12.matches(par1InventoryCrafting) && ForgeHooks.onTryingToCraft(par1InventoryCrafting, var12, false, null, 0, 0, 0))
                {
                    return var12.getCraftingResult(par1InventoryCrafting);
                }
            }

            return null;
        }
    }

    public ItemStack findMatchingRecipe(InventoryCrafting par1InventoryCrafting, World world, int x, int y, int z)
    {
        int var2 = 0;
        ItemStack var3 = null;
        ItemStack var4 = null;
        int var5;

        for (var5 = 0; var5 < par1InventoryCrafting.getSizeInventory(); ++var5)
        {
            ItemStack var6 = par1InventoryCrafting.getStackInSlot(var5);

            if (var6 != null)
            {
                if (var2 == 0)
                {
                    var3 = var6;
                }

                if (var2 == 1)
                {
                    var4 = var6;
                }

                ++var2;
            }
        }

        if (var2 == 2 && var3.itemID == var4.itemID && var3.stackSize == 1 && var4.stackSize == 1 && Item.itemsList[var3.itemID].isRepairable())
        {
            Item var11 = Item.itemsList[var3.itemID];
            int var10 = var11.getMaxDamage() - var3.getItemDamageForDisplay();
            int var7 = var11.getMaxDamage() - var4.getItemDamageForDisplay();
            int var8 = var10 + var7 + var11.getMaxDamage() * 10 / 100;
            int var9 = var11.getMaxDamage() - var8;

            if (var9 < 0)
            {
                var9 = 0;
            }

            return new ItemStack(var3.itemID, 1, var9);
        }
        else
        {
            for (var5 = 0; var5 < this.recipes.size(); ++var5)
            {
                IRecipe var12 = (IRecipe)this.recipes.get(var5);

                if (var12.matches(par1InventoryCrafting) && ForgeHooks.onTryingToCraft(par1InventoryCrafting, var12, true, world, x, y, z))
                {
                    return var12.getCraftingResult(par1InventoryCrafting);
                }
            }

            return null;
        }
    }

 

 

Now there are two base edits that aren't edited right now by forge. You'll not like this. :(

 

ContainerPlayer:

 

    public EntityPlayer player;

    .
    .
    .

    public ContainerPlayer(InventoryPlayer par1InventoryPlayer, boolean par2)
    {
        this.craftMatrix = new InventoryCrafting(this, 2, 2);
        this.craftResult = new InventoryCraftResult();
        this.player = par1InventoryPlayer.player;
        this.isLocalWorld = false;
        this.isLocalWorld = par2;
        this.addSlot(new SlotCrafting(par1InventoryPlayer.player, this.craftMatrix, this.craftResult, 0, 144, 36));
        int var3;
        int var4;

        for (var3 = 0; var3 < 2; ++var3)
        {
            for (var4 = 0; var4 < 2; ++var4)
            {
                this.addSlot(new Slot(this.craftMatrix, var4 + var3 * 2, 88 + var4 * 18, 26 + var3 * 18));
            }
        }

        for (var3 = 0; var3 < 4; ++var3)
        {
            this.addSlot(new SlotArmor(this, par1InventoryPlayer, par1InventoryPlayer.getSizeInventory() - 1 - var3, 8, 8 + var3 * 18, var3));
        }

        for (var3 = 0; var3 < 3; ++var3)
        {
            for (var4 = 0; var4 < 9; ++var4)
            {
                this.addSlot(new Slot(par1InventoryPlayer, var4 + (var3 + 1) * 9, 8 + var4 * 18, 84 + var3 * 18));
            }
        }

        for (var3 = 0; var3 < 9; ++var3)
        {
            this.addSlot(new Slot(par1InventoryPlayer, var3, 8 + var3 * 18, 142));
        }

        this.onCraftMatrixChanged(this.craftMatrix);
    }

    .
    .
    .

    /**
     * Callback for when the crafting matrix is changed.
     */
    public void onCraftMatrixChanged(IInventory par1IInventory)
    {
        this.craftResult.setInventorySlotContents(0, CraftingManager.getInstance().findMatchingRecipe(this.craftMatrix, this.player, this.player.worldObj, (int) this.player.posX, (int) this.player.posY, (int) this.player.posZ);
    }

 

 

ContainerWorkbench:

 

    /**
     * Callback for when the crafting matrix is changed.
     */
    public void onCraftMatrixChanged(IInventory par1IInventory)
    {
        this.craftResult.setInventorySlotContents(0, CraftingManager.getInstance().findMatchingRecipe(this.craftMatrix, this.worldObj, this.posX, this.posY, this.posZ));
    }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.