Jump to content

Hook to check the place where the crafting happens BEFORE it happens


Recommended Posts

Posted

I am the developer of the ResearchCraft mod, and while making the mod I found that I needed a small hook to check the position before the crafting happens. This would help me to finish the mod and might help others who want some recipe to be used only under certain circumstances, like for example a recipe to make ice from a water bucket. That recipe would be disabled unless the crafting occurs in a snow biome.

 

Ok, so I have the hook here, this is what I want it to be like.

Look at it and say if you like it or the coding is awful and must be replaced by some better code:

 

ICraftingHandler.java: with onTakenFromCrafting.

 

    /**
     * Called when checking if a recipe can be used.
     * @param the crafting matrix used
     * @param the recipe that needs confirmation to be crafted
     * @param whether there is world and position info (new findMatchingRecipe() method) or not (deprecated findMatchingRecipe() method)
     * @param the world where the crafting takes place (only if hasPosition is true)
     * @param x coordinate where the crafting takes place (only if hasPosition is true)
     * @param y coordinate where the crafting takes place (only if hasPosition is true)
     * @param z coordinate where the crafting takes place (only if hasPosition is true)
     * @return whether the recipe can be crafted or not.
     */
    public boolean onTryingToCraft(InventoryCrafting craftMatrix, IRecipe recipe, boolean hasPosition, World world, int x, int y, int z);

 

 

ForgeHooks.java: after or before onTakenFromCrafting.

 

    public static boolean onTryingToCraft(InventoryCrafting craftingMatrix, IRecipe recipe, boolean hasPosition, World world, int x, int y, int z)
    {
        for (ICraftingHandler handler : craftingHandlers)
        {
            if (!handler.onTryingToCraft(craftingMatrix, recipe, hasPosition, world, x, y, z))
            {
                return false;
            }
        }
        return true;
    }

 

 

CraftingManager: note that there is some code in the deprecated one.

 

    @Deprecated
    public ItemStack findMatchingRecipe(InventoryCrafting par1InventoryCrafting)
    {
        int var2 = 0;
        ItemStack var3 = null;
        ItemStack var4 = null;
        int var5;

        for (var5 = 0; var5 < par1InventoryCrafting.getSizeInventory(); ++var5)
        {
            ItemStack var6 = par1InventoryCrafting.getStackInSlot(var5);

            if (var6 != null)
            {
                if (var2 == 0)
                {
                    var3 = var6;
                }

                if (var2 == 1)
                {
                    var4 = var6;
                }

                ++var2;
            }
        }

        if (var2 == 2 && var3.itemID == var4.itemID && var3.stackSize == 1 && var4.stackSize == 1 && Item.itemsList[var3.itemID].isRepairable())
        {
            Item var11 = Item.itemsList[var3.itemID];
            int var10 = var11.getMaxDamage() - var3.getItemDamageForDisplay();
            int var7 = var11.getMaxDamage() - var4.getItemDamageForDisplay();
            int var8 = var10 + var7 + var11.getMaxDamage() * 10 / 100;
            int var9 = var11.getMaxDamage() - var8;

            if (var9 < 0)
            {
                var9 = 0;
            }

            return new ItemStack(var3.itemID, 1, var9);
        }
        else
        {
            for (var5 = 0; var5 < this.recipes.size(); ++var5)
            {
                IRecipe var12 = (IRecipe)this.recipes.get(var5);

                if (var12.matches(par1InventoryCrafting) && ForgeHooks.onTryingToCraft(par1InventoryCrafting, var12, false, null, 0, 0, 0))
                {
                    return var12.getCraftingResult(par1InventoryCrafting);
                }
            }

            return null;
        }
    }

    public ItemStack findMatchingRecipe(InventoryCrafting par1InventoryCrafting, World world, int x, int y, int z)
    {
        int var2 = 0;
        ItemStack var3 = null;
        ItemStack var4 = null;
        int var5;

        for (var5 = 0; var5 < par1InventoryCrafting.getSizeInventory(); ++var5)
        {
            ItemStack var6 = par1InventoryCrafting.getStackInSlot(var5);

            if (var6 != null)
            {
                if (var2 == 0)
                {
                    var3 = var6;
                }

                if (var2 == 1)
                {
                    var4 = var6;
                }

                ++var2;
            }
        }

        if (var2 == 2 && var3.itemID == var4.itemID && var3.stackSize == 1 && var4.stackSize == 1 && Item.itemsList[var3.itemID].isRepairable())
        {
            Item var11 = Item.itemsList[var3.itemID];
            int var10 = var11.getMaxDamage() - var3.getItemDamageForDisplay();
            int var7 = var11.getMaxDamage() - var4.getItemDamageForDisplay();
            int var8 = var10 + var7 + var11.getMaxDamage() * 10 / 100;
            int var9 = var11.getMaxDamage() - var8;

            if (var9 < 0)
            {
                var9 = 0;
            }

            return new ItemStack(var3.itemID, 1, var9);
        }
        else
        {
            for (var5 = 0; var5 < this.recipes.size(); ++var5)
            {
                IRecipe var12 = (IRecipe)this.recipes.get(var5);

                if (var12.matches(par1InventoryCrafting) && ForgeHooks.onTryingToCraft(par1InventoryCrafting, var12, true, world, x, y, z))
                {
                    return var12.getCraftingResult(par1InventoryCrafting);
                }
            }

            return null;
        }
    }

 

 

Now there are two base edits that aren't edited right now by forge. You'll not like this. :(

 

ContainerPlayer:

 

    public EntityPlayer player;

    .
    .
    .

    public ContainerPlayer(InventoryPlayer par1InventoryPlayer, boolean par2)
    {
        this.craftMatrix = new InventoryCrafting(this, 2, 2);
        this.craftResult = new InventoryCraftResult();
        this.player = par1InventoryPlayer.player;
        this.isLocalWorld = false;
        this.isLocalWorld = par2;
        this.addSlot(new SlotCrafting(par1InventoryPlayer.player, this.craftMatrix, this.craftResult, 0, 144, 36));
        int var3;
        int var4;

        for (var3 = 0; var3 < 2; ++var3)
        {
            for (var4 = 0; var4 < 2; ++var4)
            {
                this.addSlot(new Slot(this.craftMatrix, var4 + var3 * 2, 88 + var4 * 18, 26 + var3 * 18));
            }
        }

        for (var3 = 0; var3 < 4; ++var3)
        {
            this.addSlot(new SlotArmor(this, par1InventoryPlayer, par1InventoryPlayer.getSizeInventory() - 1 - var3, 8, 8 + var3 * 18, var3));
        }

        for (var3 = 0; var3 < 3; ++var3)
        {
            for (var4 = 0; var4 < 9; ++var4)
            {
                this.addSlot(new Slot(par1InventoryPlayer, var4 + (var3 + 1) * 9, 8 + var4 * 18, 84 + var3 * 18));
            }
        }

        for (var3 = 0; var3 < 9; ++var3)
        {
            this.addSlot(new Slot(par1InventoryPlayer, var3, 8 + var3 * 18, 142));
        }

        this.onCraftMatrixChanged(this.craftMatrix);
    }

    .
    .
    .

    /**
     * Callback for when the crafting matrix is changed.
     */
    public void onCraftMatrixChanged(IInventory par1IInventory)
    {
        this.craftResult.setInventorySlotContents(0, CraftingManager.getInstance().findMatchingRecipe(this.craftMatrix, this.player, this.player.worldObj, (int) this.player.posX, (int) this.player.posY, (int) this.player.posZ);
    }

 

 

ContainerWorkbench:

 

    /**
     * Callback for when the crafting matrix is changed.
     */
    public void onCraftMatrixChanged(IInventory par1IInventory)
    {
        this.craftResult.setInventorySlotContents(0, CraftingManager.getInstance().findMatchingRecipe(this.craftMatrix, this.worldObj, this.posX, this.posY, this.posZ));
    }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
    • That's just plain wrong... newer versions are much better optimised and start a lot faster than 1.8.9, both Forge and Minecraft itself. Comparing Fabric 1.21 with Forge 1.8 is like comparing apples and oranges... one's brand new and the other's over a decade old.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.