Get Container (Position) from gui?

[Insane96MCP]

I'm trying to get data from tileentity for the gui, but I can't figure out how to get the tileentity (or the position) from the gui.
I'm using network to get data, but I really don't know how to receive those.

GuiCode: https://github.com/Insane-96/XpHolder/blob/master/common/net/insane96mcp/xpholder/gui/TestGui.java#L108
Packet Used: https://github.com/Insane-96/XpHolder/blob/master/common/net/insane96mcp/xpholder/network/DepositMessage.java

And handler: https://github.com/Insane-96/XpHolder/blob/master/common/net/insane96mcp/xpholder/network/DepositMessageHandler.java

 

I'm stuck because I don't know how to get the pos from the gui.

[diesieben07]

You are already passing the position to your IGuiHandler when you open the GUI. Simply pass it on to the GuiScreen.

[Insane96MCP]

But how can I set a field in the TestGui from the packet handler? https://github.com/Insane-96/XpHolder/blob/master/common/net/insane96mcp/xpholder/network/GetXpHeldMessageHandler.java#L29

[diesieben07]

That packet is sent to the server. The server does not have GUIs.

[Insane96MCP]

Just had to send a response packet, get the gui and set the value
 

Spoiler

@Override
	public IMessage onMessage(GetXpHeldResponse message, MessageContext ctx) {
		EntityPlayerSP player = Minecraft.getMinecraft().player;
		int xpHeld = message.xpHeld;
		GuiScreen guiScreen = Minecraft.getMinecraft().currentScreen;
		if (guiScreen instanceof TestGui) {
			TestGui testGui = (TestGui) guiScreen;
			System.out.println("xp held: " + xpHeld);
			testGui.xpHeld = xpHeld;
		}

		
		return null;
	}

 

But now I'm having another problem.
I get a classCastException when trying to open the gui at https://github.com/Insane-96/XpHolder/blob/master/common/net/insane96mcp/xpholder/block/BlockXpHolder.java#L43

java.util.concurrent.ExecutionException: java.lang.ClassCastException: net.insane96mcp.xpholder.tileentity.TileEntityXpHolder cannot be cast to net.minecraft.inventory.Container
	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_161]
	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_161]
	at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:796) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:741) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:590) [MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]
Caused by: java.lang.ClassCastException: net.insane96mcp.xpholder.tileentity.TileEntityXpHolder cannot be cast to net.minecraft.inventory.Container
	at net.minecraftforge.fml.common.network.NetworkRegistry.getRemoteGuiContainer(NetworkRegistry.java:254) ~[NetworkRegistry.class:?]
	at net.minecraftforge.fml.common.network.internal.FMLNetworkHandler.openGui(FMLNetworkHandler.java:87) ~[FMLNetworkHandler.class:?]
	at net.minecraft.entity.player.EntityPlayer.openGui(EntityPlayer.java:2809) ~[EntityPlayer.class:?]
	at net.insane96mcp.xpholder.block.BlockXpHolder.onBlockActivated(BlockXpHolder.java:45) ~[BlockXpHolder.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:472) ~[PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:767) ~[NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_161]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_161]
	at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
	... 5 more

 

I don't need a container that's why I've extended a TileEntity and not a Container

Edited May 25, 2018 by Insane96MCP

[diesieben07]

If you do not need a Container then do not use IGuiHandler. Simply send a custom packet to the client which then uses Minecraft::displayGuiScreen to open the GUI. Or open the GUI from the client directly (i.e. when right-clicking a block).

 

Also, your message handlers are broken, read the warnings in the documentation.

[Insane96MCP]

7 hours ago, diesieben07 said:

Also, your message handlers are broken, read the warnings in the documentation.

Should I send a reply to a packet manually since I can't return a packet from the Runnable?

[diesieben07]

What would you send in that packet? 

[Insane96MCP]

Tileentity data to the client

[xieao]

4 minutes ago, Insane96MCP said:

Tileentity data to the client

 

Try to use this to sync your tileentity to the client side:

IBlockState state = getWorld().getBlockState(getPos());
getWorld().notifyBlockUpdate(getPos(), state, state, 3);

[diesieben07]

15 minutes ago, Insane96MCP said:

Tileentity data to the client

But you are already sending a packet to open the GUI. Send whatever data you need with that packet.

 

5 minutes ago, xieao said:

Try to use this to sync your tileentity to the client side:

IBlockState state = getWorld().getBlockState(getPos());
getWorld().notifyBlockUpdate(getPos(), state, state, 3);

This is completely pointless without further explanation.

[Insane96MCP]

9 hours ago, diesieben07 said:

But you are already sending a packet to open the GUI. Send whatever data you need with that packet.

Yeah but I need to update data during the use of the tile entity

[diesieben07]

Is the data only visible in the GUI? If so, just keep sending custom packets. But in this case using a Container might be a good idea, to keep track of which players are looking at the TE.

[Insane96MCP]

I have a strange problem. In LAN when a non-host opens the GUI, the GUI opens for the host too.

EDIT: doesn't happen on SMP

Edited May 28, 2018 by Insane96MCP

[diesieben07]

You are reaching across logical sides.

In LAN the server runs on the hosting player's machine. If a non-host right-clicks the block, that will run onBlockActivated on that integrated server, running on the host. You then open the GUI through the proxy, which is your client proxy (remember: @SidedProxy distinguishes between physical side!), so the host opens the GUI (reaching from the host's logical server over to the host's logical client, this will cause random crashes).

You must check for the logical side in onBlockActivated before opening the GUI.