items not showing in game or JEI [SOLVED | 1.12]

[urlordjames]

code link

mod shows in Forge mod list but item does not show up in creative inventory or JEI, no errors

log:

[16:50:51] [main/INFO]: Setting user: urlordjames
[16:50:55] [main/INFO]: LWJGL Version: 2.9.4
[16:51:00] [main/INFO]: Reloading ResourceManager: Default, FMLFileResourcePack:Forge Mod Loader, FMLFileResourcePack:Minecraft Forge, FMLFileResourcePack:Just Enough Items, FMLFileResourcePack:test mod
[16:51:01] [Sound Library Loader/INFO]: Starting up SoundSystem...
[16:51:01] [Thread-5/INFO]: Initializing LWJGL OpenAL
[16:51:01] [Thread-5/INFO]: (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
[16:51:02] [Thread-5/INFO]: OpenAL initialized.
[16:51:02] [Sound Library Loader/INFO]: Sound engine started
[16:51:07] [main/INFO]: Created: 512x512 textures-atlas
[16:51:09] [main/INFO]: [STDOUT]: test mod installed
[16:51:10] [main/INFO]: Narrator library for x64 successfully loaded
[16:51:16] [Server thread/INFO]: Starting integrated minecraft server version 1.12
[16:51:16] [Server thread/INFO]: Generating keypair
[16:51:17] [Server thread/INFO]: Loaded 488 advancements
[16:51:17] [Server thread/INFO]: Preparing start region for level 0
[16:51:18] [Server thread/INFO]: Preparing spawn area: 23%
[16:51:19] [Server thread/INFO]: Changing view distance to 8, from 10
[16:51:21] [Server thread/INFO]: urlordjames[local:E:400f2631] logged in with entity id 643 at (-41.851032292268, 62.0, 121.03756223186434)
[16:51:21] [Server thread/INFO]: urlordjames joined the game
[16:51:22] [Server thread/INFO]: Saving and pausing game...
[16:51:22] [Server thread/INFO]: Saving chunks for level 'asd'/overworld
[16:51:23] [main/INFO]: Loaded 7 advancements
[16:51:23] [Server thread/INFO]: Saving chunks for level 'asd'/the_nether
[16:51:23] [Server thread/INFO]: Saving chunks for level 'asd'/the_end
[16:51:23] [Server thread/INFO]: Saving and pausing game...
[16:51:23] [Server thread/INFO]: Saving chunks for level 'asd'/overworld
[16:51:23] [Server thread/INFO]: Saving chunks for level 'asd'/the_nether
[16:51:23] [Server thread/INFO]: Saving chunks for level 'asd'/the_end
[16:52:52] [Server thread/INFO]: Saving and pausing game...
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/overworld
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/the_nether
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/the_end
[16:52:52] [Server thread/INFO]: Stopping server
[16:52:52] [Server thread/INFO]: Saving players
[16:52:52] [Server thread/INFO]: urlordjames lost connection: Disconnected
[16:52:52] [Server thread/INFO]: urlordjames left the game
[16:52:52] [Server thread/INFO]: Stopping singleplayer server as player logged out
[16:52:52] [Server thread/INFO]: Saving worlds
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/overworld
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/the_nether
[16:52:52] [Server thread/INFO]: Saving chunks for level 'asd'/the_end
[16:52:56] [main/INFO]: Deleting level asd
[16:52:56] [main/INFO]: Attempt 1...
[16:52:58] [main/INFO]: Stopping!
[16:52:58] [main/INFO]: SoundSystem shutting down...
[16:52:58] [main/WARN]: Author: Paul Lamb, www.paulscode.com

 

Edited January 23, 2019 by urlordjames

[Zamion101]

Did you registered in

 

RegistryEvent#Register<Item> ?

 

https://mcforge.readthedocs.io/en/latest/concepts/registries/

[urlordjames]

package com.urlordjames.testmod.util.handlers;

import com.urlordjames.testmod.init.ModItems;
import com.urlordjames.testmod.util.IHasModel;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber
public class RegistryHandler {
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ModItems.Items.toArray(new Item[0]));
    }

    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event){
        for (Item item : ModItems.Items){
            if (item instanceof IHasModel){
                ((IHasModel)item).registerModels();
            }
        }
    }
}

Yes, at least I tried to, does this class look correct?

Edited January 23, 2019 by urlordjames

[Zamion101]

1 minute ago, urlordjames said:

@Mod.EventBusSubscriber
public class RegistryHandler {
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ModItems.Items.toArray(new Item[0]));
    }

Yes, at least I tried, does this code look correct?

You forget to add MOD_ID to @Mod.EventBusSubscriber

 

It should be like this;

@Mod.EventBusSubscriber(modid = "<MOD_ID>")

[Zamion101]

1 minute ago, Zamion101 said:

ModItems.Items.toArray(new Item[0])

Why you using this?

You should use List instead of Array.

[urlordjames]

3 minutes ago, Zamion101 said:

Why you using this?

You should use List instead of Array.

When I use a list I get cannot resolve method 'registerAll(java.util.List<net.minecraft.item.Item>)'

@Mod.EventBusSubscriber(modid = Reference.MOD_ID)
public class RegistryHandler {
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ModItems.Items);
    }

 

[Zamion101]

Just now, urlordjames said:

When I use a list I get cannot resolve method 'registerAll(java.util.List<net.minecraft.item.Item>)'

@Mod.EventBusSubscriber(modid = Reference.MOD_ID)
public class RegistryHandler {
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event){
        event.getRegistry().registerAll(ModItems.Items);
    }

 

You can use for statement

Example:

 

for(Item item : ModItems.Items){

event.getRegistry().register(item);

}

 

And code looks correct now.

[urlordjames]

1 minute ago, Zamion101 said:

You can use for statement

Example:

 

for(Item item : ModItems.Items){

event.getRegistry().register(item);

}

 

And code looks correct now.

Okay, I changed my code to it just registers the one item and it works.  Thanks for your help!  I'm aware that it's not very salable but it's just a test mod so I have a framework to look at when developing larger mods.

[Zamion101]

Just now, urlordjames said:

Okay, I changed my code to it just registers the one item and it works.  Thanks for your help!  I'm aware that it's not very salable but it's just a test mod so I have a framework to look at when developing larger mods.

Have a nice modding.