Search the Forums BEFORE making a new post.

[1.13.2] Would this code cause problems?

Posted March 24, 20196 yr

I've been working on a 1.13.2 mod that's still in its infancy. When adding blocks, I wanted to be able to add just one line of code for the Block itself and the ItemBlock. I wrote some code to do this, and it seems to work well. However, I want to be sure I'm not causing issues with compatibility or going against a style rule. Additionally, I'm not positive if I should be declaring my blocks and registering them in the same file or not. Here is my code:

package henryrichard.ewot.init;

import henryrichard.ewot.util.EwotReference;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.MaterialColor;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = EwotReference.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
@ObjectHolder(EwotReference.MODID)
public abstract class EwotBlocks {

    public static final Block amethyst_ore = null;
    public static final Block endust_ore = null;
    public static final Block aluminum_ore = null;
    public static final Block flint_ore = null;
    public static final Block amethyst_block = null;
    public static final Block endust_block = null;
    public static final Block aluminum_block = null;
    public static final Block unalloyed_endite_block = null;
    public static final Block endite_block = null;
    public static final Block nether_planks = null;
    public static final Block glowwool = null;
    public static final Block jeb_wool = null;

    private static final BlockCreator[] bcrArray = {
            new BlockCreator("amethyst_ore", Block.Properties.create(Material.ROCK, MaterialColor.NETHERRACK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("endust_ore", Block.Properties.create(Material.ROCK, MaterialColor.SAND).hardnessAndResistance(5.0F, 9.0F)),
            new BlockCreator("aluminum_ore", Block.Properties.create(Material.ROCK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("flint_ore", Block.Properties.create(Material.ROCK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("amethyst_block", Block.Properties.create(Material.IRON, MaterialColor.PURPLE).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("endust_block", Block.Properties.create(Material.IRON, MaterialColor.CYAN).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("aluminum_block", Block.Properties.create(Material.IRON, MaterialColor.IRON).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("unalloyed_endite_block", Block.Properties.create(Material.IRON, MaterialColor.LIGHT_BLUE_TERRACOTTA).hardnessAndResistance(6.0F, 10.0F).sound(SoundType.METAL)),
            new BlockCreator("endite_block", Block.Properties.create(Material.IRON, MaterialColor.CYAN).hardnessAndResistance(6.0F, 10.0F).sound(SoundType.METAL)),
            new BlockCreator("nether_planks", Block.Properties.create(Material.WOOD, MaterialColor.RED_TERRACOTTA).hardnessAndResistance(2.0F, 3.0F).sound(SoundType.WOOD)),
            new BlockCreator("glowwool", Block.Properties.create(Material.CLOTH, MaterialColor.YELLOW).hardnessAndResistance(0.8F).sound(SoundType.CLOTH).lightValue(15)),
            new BlockCreator("jeb_wool", Block.Properties.create(Material.CLOTH, MaterialColor.YELLOW).hardnessAndResistance(0.8F).sound(SoundType.CLOTH)),
    };

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event) {

        Block[] blocks = new Block[bcrArray.length];
        for(int i=0; i<bcrArray.length; i++) { blocks[i] = bcrArray[i].theBlock; }

        event.getRegistry().registerAll(blocks);
    }

    @SubscribeEvent
    public static void registerItemBlocks(RegistryEvent.Register<Item> event) {
        Item[] items = new Item[bcrArray.length];
        for(int i=0; i<bcrArray.length; i++) { items[i] = bcrArray[i].theItem; }

        event.getRegistry().registerAll(items);
    }

    //Nested class to create blocks more easily
    private static class BlockCreator {

        private Block.Properties blockProp;
        private Item.Properties itemProp;

        private Block theBlock;
        private Item theItem;

        private BlockCreator(String r, Block.Properties b, Item.Properties i) {
            blockProp = b;
            itemProp = i;

            theBlock = new Block(blockProp).setRegistryName(r);
            theItem = new ItemBlock(theBlock, itemProp).setRegistryName(r);
        }

        private BlockCreator(String r, Block.Properties b) {
            this(r, b, new Item.Properties().group(EwotItemGroups.EWOT_BLOCKS));
        }
    }

}

I'll put something here when I have something of value I need to put at the end of every post. For now it's this mostly pointless text.

Quote

March 24, 20196 yr

Author

Is this better?

package henryrichard.ewot.init;

import henryrichard.ewot.util.EwotReference;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.MaterialColor;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = EwotReference.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
@ObjectHolder(EwotReference.MODID)
public abstract class EwotBlocks {

    public static final Block amethyst_ore = null;
    public static final Block endust_ore = null;
    public static final Block aluminum_ore = null;
    public static final Block flint_ore = null;
    public static final Block amethyst_block = null;
    public static final Block endust_block = null;
    public static final Block aluminum_block = null;
    public static final Block unalloyed_endite_block = null;
    public static final Block endite_block = null;
    public static final Block nether_planks = null;
    public static final Block glowwool = null;
    public static final Block jeb_wool = null;

    private static final BlockCreator[] bcrArray = {
            new BlockCreator("amethyst_ore", Block.Properties.create(Material.ROCK, MaterialColor.NETHERRACK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("endust_ore", Block.Properties.create(Material.ROCK, MaterialColor.SAND).hardnessAndResistance(5.0F, 9.0F)),
            new BlockCreator("aluminum_ore", Block.Properties.create(Material.ROCK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("flint_ore", Block.Properties.create(Material.ROCK).hardnessAndResistance(3.0F, 3.0F)),
            new BlockCreator("amethyst_block", Block.Properties.create(Material.IRON, MaterialColor.PURPLE).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("endust_block", Block.Properties.create(Material.IRON, MaterialColor.CYAN).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("aluminum_block", Block.Properties.create(Material.IRON, MaterialColor.IRON).hardnessAndResistance(5.0F, 6.0F).sound(SoundType.METAL)),
            new BlockCreator("unalloyed_endite_block", Block.Properties.create(Material.IRON, MaterialColor.LIGHT_BLUE_TERRACOTTA).hardnessAndResistance(6.0F, 10.0F).sound(SoundType.METAL)),
            new BlockCreator("endite_block", Block.Properties.create(Material.IRON, MaterialColor.CYAN).hardnessAndResistance(6.0F, 10.0F).sound(SoundType.METAL)),
            new BlockCreator("nether_planks", Block.Properties.create(Material.WOOD, MaterialColor.RED_TERRACOTTA).hardnessAndResistance(2.0F, 3.0F).sound(SoundType.WOOD)),
            new BlockCreator("glowwool", Block.Properties.create(Material.CLOTH, MaterialColor.YELLOW).hardnessAndResistance(0.8F).sound(SoundType.CLOTH).lightValue(15)),
            new BlockCreator("jeb_wool", Block.Properties.create(Material.CLOTH, MaterialColor.SNOW).hardnessAndResistance(0.8F).sound(SoundType.CLOTH)),
    };

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event) {

        Block[] blocks = new Block[bcrArray.length];
        for(int i=0; i<bcrArray.length; i++) {
            blocks[i] = bcrArray[i].getBlock();
        }

        event.getRegistry().registerAll(blocks);
    }

    @SubscribeEvent
    public static void registerItemBlocks(RegistryEvent.Register<Item> event) {
        Item[] items = new Item[bcrArray.length];
        for(int i=0; i<bcrArray.length; i++) {
            items[i] = bcrArray[i].getItem();
        }

        event.getRegistry().registerAll(items);
    }

    //Nested class to create blocks more easily
    private static class BlockCreator {

        private Block.Properties blockProp;
        private Item.Properties itemProp;
        private String registryName;

        private Block theBlock;
        private Item theItem;

        private BlockCreator(String r, Block.Properties b, Item.Properties i) {
            blockProp = b;
            itemProp = i;
            registryName = r;
        }

        private BlockCreator(String r, Block.Properties b) {
            this(r, b, new Item.Properties().group(EwotItemGroups.EWOT_BLOCKS));
        }

        private Block getBlock() {
            if(theBlock == null) {
                theBlock = new Block(blockProp).setRegistryName(registryName);
            }
            return theBlock;
        }

        private Item getItem() {
            if(theItem == null) {
                theItem = new ItemBlock(getBlock(), itemProp).setRegistryName(registryName);
            }
            return theItem;
        }
    }

}

I'll put something here when I have something of value I need to put at the end of every post. For now it's this mostly pointless text.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/69673-1132-would-this-code-cause-problems/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Hey, sorry about this. There was an oversight with my fix so I've made a pull request to have it resolved. When LexManos or Paint_Ninja are available, it'll be merged. For now, please continue to use 60.0.5. Thanks for letting me know of the issue again. 🙏

By Jonathing · 6 hours ago6 hr
Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

OK, got a similar warning as above with .5 but FallingTree is working fine. I'm not sure if it's a FallingTree or Forge issue.

By Richy_T · 7 hours ago7 hr
Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Thanks. May still be issues.

[19:51:42] [main/WARN] [ne.mi.co.ForgeHooks/WP]: The following mods have version differences that were not resolved:
forge (version 59.0.1 -> 1.21.10-60.0.7)
Things may not work well.

Also had trouble running FallingTree mod but currently verifying that's not a me thing.

Yep, not a me thing.

[19:54:52] [main/ERROR] [ne.mi.fm.lo.ModSorter/LOADING]: Missing or unsupported
mandatory dependencies: Mod ID: 'forge', Requested by: 'fallingtree', Expected range: '[60,)', A
ctual version: '1.21.10-60.0.7'

Going to see how .5 does.

By Richy_T · 8 hours ago8 hr
Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

I've fixed this in Forge 60.0.7. Please update. Thank you!

By Jonathing · 8 hours ago8 hr
Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Was upgrading from 1.21.9. Failed with an error. Reinstalled 1.21.9, good. Installed 1.21.10-60.0.5, also good.

Error is

[17:35:50] [main/ERROR] [ne.mi.fm.lo.mo.ModDiscoverer/SCAN]: Locator net.minecra
ftforge.fml.loading.moddiscovery.ClasspathLocator@7dc51783 found an invalid mod
file net.minecraftforge.fml.loading.moddiscovery.ModFileInfo@4b61d0c6
net.minecraftforge.fml.loading.moddiscovery.InvalidModFileException: Illegal version number specified ${forge_version} (forge-1.21.10-60.0.6-universal.jar)

I can add more info if needed but I'm guessing this was just a whoops.

By Richy_T · Posted 10 hours ago10 hr

There are no registered users currently online

Sign In

[1.13.2] Would this code cause problems?

Featured Replies

Join the conversation

Posts

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Failure to Launch with 1.21.10-60.0.6 Linux server, Java 21.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)