Jump to content

Recommended Posts

Posted (edited)

Hi, I am trying to make an object with assigned sides, and I have never done this before. Based on my limited experience with jsons and looking at the vanilla jsons, this should work, but does not. I am left with the purple diagnostic texture. There are no specific errors in the console that are helpful. I tried doing it with a blockstate and a block model because thats what crafting table does in the jar, whereas typically I just use a single basic blockstate per block that does the job for me. Here's what I have:

Additionally, I am just reusing some textures already in my textures folder because I haven't done the wine barrel textures yet, just in case it seems weird why an empty barrel is being textures with ores and blocks.

Blockstate wineBarrel_Empty.json:

Spoiler

{
    "forge_marker": 1,
    "variants": {
        "normal": { "model": "wineBarrel_Empty" }
    }
}

 

 

Block Model wineBarrel_Empty.json:

Spoiler

{
    "parent": "block/cube",
    "textures": {
        "down": "blocks/lead_ore",
        "up": "blocks/lead_ore",
        "north": "blocks/lead_block",
        "east": "blocks/lead_ore",
        "south": "blocks/lead_block",
        "west": "blocks/lead_ore"
    }
}

 

 

ModBlocks.java (Doubt it'd be useful, all my other blocks and items work just fine, but JIC I thought I'd include it):

Spoiler

package vinum.bored.vinum.block;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.registries.IForgeRegistry;
import vinum.bored.vinum.Vinum;
public class ModBlocks {
	
	//Generic Blocks
	public static BlockGlass darkWineGlass = new BlockGlass("dark_wine_glass_block").setCreativeTab(Vinum.creativeTab);
	public static BlockGlass fineCrystal = new BlockGlass("fine_crystal_glass_block").setCreativeTab(Vinum.creativeTab);
	public static BlockStone leadOre = new BlockStone("lead_ore").setCreativeTab(Vinum.creativeTab);
	public static BlockStone leadBlock = new BlockStone("lead_block").setCreativeTab(Vinum.creativeTab);
	public static BlockSand refinedSand = new BlockSand("refined_sand").setCreativeTab(Vinum.creativeTab);
	public static BlockSand leadedSand = new BlockSand("leaded_sand").setCreativeTab(Vinum.creativeTab);
	public static BlockSand ferrousSand = new BlockSand("ferrous_sand").setCreativeTab(Vinum.creativeTab);
	//Wine Barrels
	public static BlockWood wineBarrel_Empty = new BlockWood("wine_barrel_empty").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Chardonnay = new BlockWood("wine_barrel_chardonnay").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Sauvignon_Blanc = new BlockWood("wine_barrel_sauvignon_blanc").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Cabernet_Sauvignon = new BlockWood("wine_barrel_cabernet_sauvignon").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Merlot = new BlockWood("wine_barrel_merlot").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Pinot_Noir = new BlockWood("wine_barrel_pinot_noir").setCreativeTab(Vinum.creativeTab);
	public static BlockWood wineBarrel_Zinfandel = new BlockWood("wine_barrel_zinfandel").setCreativeTab(Vinum.creativeTab);
	
	public static void register(IForgeRegistry<Block> registry) {
		registry.registerAll(
					darkWineGlass,
					fineCrystal,
					leadOre,
					leadBlock,
					refinedSand,
					leadedSand,
					ferrousSand,
					wineBarrel_Empty,
					wineBarrel_Chardonnay,
					wineBarrel_Sauvignon_Blanc,
					wineBarrel_Cabernet_Sauvignon,
					wineBarrel_Merlot,
					wineBarrel_Pinot_Noir,
					wineBarrel_Zinfandel
				);
	}
	
	public static void registerItemBlocks(IForgeRegistry<Item> registry) {
		registry.registerAll(
					darkWineGlass.createItemBlock(),
					fineCrystal.createItemBlock(),
					leadOre.createItemBlock(),
					leadBlock.createItemBlock(),
					refinedSand.createItemBlock(),
					leadedSand.createItemBlock(),
					ferrousSand.createItemBlock(),
					wineBarrel_Empty.createItemBlock(),
					wineBarrel_Chardonnay.createItemBlock(),
					wineBarrel_Sauvignon_Blanc.createItemBlock(),
					wineBarrel_Cabernet_Sauvignon.createItemBlock(),
					wineBarrel_Merlot.createItemBlock(),
					wineBarrel_Pinot_Noir.createItemBlock(),
					wineBarrel_Zinfandel.createItemBlock()
				);
	}
	
	public static void registerModels() {
		darkWineGlass.registerItemModel(Item.getItemFromBlock(darkWineGlass));
		fineCrystal.registerItemModel(Item.getItemFromBlock(fineCrystal));
		leadOre.registerItemModel(Item.getItemFromBlock(leadOre));
		leadBlock.registerItemModel(Item.getItemFromBlock(leadBlock));
		refinedSand.registerItemModel(Item.getItemFromBlock(refinedSand));
		leadedSand.registerItemModel(Item.getItemFromBlock(leadedSand));
		ferrousSand.registerItemModel(Item.getItemFromBlock(ferrousSand));
		wineBarrel_Empty.registerItemModel(Item.getItemFromBlock(wineBarrel_Empty));
		wineBarrel_Chardonnay.registerItemModel(Item.getItemFromBlock(wineBarrel_Chardonnay));
		wineBarrel_Sauvignon_Blanc.registerItemModel(Item.getItemFromBlock(wineBarrel_Sauvignon_Blanc));
		wineBarrel_Cabernet_Sauvignon.registerItemModel(Item.getItemFromBlock(wineBarrel_Cabernet_Sauvignon));
		wineBarrel_Merlot.registerItemModel(Item.getItemFromBlock(wineBarrel_Merlot));
		wineBarrel_Pinot_Noir.registerItemModel(Item.getItemFromBlock(wineBarrel_Pinot_Noir));
		wineBarrel_Zinfandel.registerItemModel(Item.getItemFromBlock(wineBarrel_Zinfandel));
	}
}

 

 

 

Edited by boredherobrine13
Posted

Why is your json file name not entirely lower-case and doesn't correspond to your block's registry name? Registry names must be entirely lower-cased and so should be your blockstates file and your model file.

 

You are also not specifying the modid that provides the textures/models in your blockstates and model files.

 

You are also using static initializers. Don't ever use static intializers for forge registry entries. Instantinate your stuff in the appropriate registry event.

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • You are using Create 6 - some addons are not compatible with it Remove all addons and add these one by one littlecontraptions is mentioned - keep this one removed
    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.