Jump to content

Recommended Posts

Posted (edited)

Hello.

I have a tile entity that looks for json crafting recipes like the furnace does, but it won't work. The function in my tile entity

IRecipe irecipe = this.world.getRecipeManager().getRecipe(new RecipeWrapper(this.inv, 0, 0), this.world, SoulMagic.SOUL_INFUSING_TYPE);

is returning null no matter what the items in the inventory are. I found the method in TileEntityFurnace.java, and I am using an item capability. (I need the RecipeWrapper to "wrap" it from capabilities to IInventory).

TileEntitySoulInfuser:

Spoiler

@Override
public void tick() {
	if(!this.world.isRemote) {
		if(!this.inv.getStackInSlot(9).isEmpty() && this.inv.getStackInSlot(9).getCapability(SoulManager.SOUL_CAPABILITY).isPresent()) {
			if(!this.inv.getStackInSlot(8).isEmpty()) {
				
				IRecipe irecipe = this.world.getRecipeManager().getRecipe(new RecipeWrapper(this.inv, 0, 0), this.world, SoulMagic.SOUL_INFUSING_TYPE);
				SoulMagic.LOGGER.info(irecipe);

//OTHER STUFFFFFF LATER
	}
}

 

I have all the conditionals met and it spams "null" in my terminal.

SoulMagic: (My main mod java class)

Spoiler

public static final IRecipeSerializer<SoulInfuserRecipe> SOUL_INFUSING = RecipeSerializers.register(new SoulInfuserRecipe.Serializer());
public static final RecipeType<SoulInfuserRecipe> SOUL_INFUSING_TYPE = RecipeType.get(new ResourceLocation(Reference.MOD_ID, "soul_infusing"), SoulInfuserRecipe.class);

 

I don't know where else to put it, I couldn't find an event for it easily.

SoulInfuserRecipe and SoulInfuserRecipe.Serializer:

Spoiler

public class SoulInfuserRecipe implements IRecipe {

	private ResourceLocation id;
	private NonNullList<Ingredient> inputs;
	private Spell spell;
	
	public SoulInfuserRecipe(ResourceLocation id, NonNullList<Ingredient> inputs, Spell spell) {
		this.id = id;
		this.inputs = inputs;
		this.spell = spell;
	}
	
	@Override
	public boolean matches(IInventory inv, World worldIn) {
      //It's just true atm to see if there's anyway to make it work somewhat, but it still doesn't with true
		return true;
	}

	@Override
	public ItemStack getCraftingResult(IInventory inv) {
      //Making it return something random just to see if does do something
		return new ItemStack(Items.ACACIA_BOAT);
	}

	@Override
	public boolean canFit(int width, int height) {
		return true;
	}

	@Override
	public ItemStack getRecipeOutput() {
       //Making it return something random just to see if does do something
		return new ItemStack(Items.ACACIA_BOAT);
	}
	
	@Override
	public NonNullList<Ingredient> getIngredients() {
		return this.inputs;
	}
	
	@Override
	public boolean isDynamic() {
		return true;
	}

	@Override
	public ResourceLocation getId() {
		return this.id;
	}

	@Override
	public IRecipeSerializer<?> getSerializer() {
		return SoulMagic.SOUL_INFUSING;
	}
	
  //THE JSON FILE IS BEING INTREPTED CORRECTLY
	public static class Serializer implements IRecipeSerializer<SoulInfuserRecipe> {

		private static final ResourceLocation NAME = new ResourceLocation(Reference.MOD_ID, "soul_infusing");
		
		@Override
          //After debugging I know this method works for a fact
		public SoulInfuserRecipe read(ResourceLocation recipeId, JsonObject json) {
			String spellS = JsonUtils.getString(json, "spell");
			IForgeRegistry<Spell> registry = GameRegistry.findRegistry(Spell.class);
			Spell s = registry.getValue(new ResourceLocation(spellS));
			
			NonNullList<Ingredient> inputs = readIngredients(JsonUtils.getJsonArray(json, "ingredients"));
			return new SoulInfuserRecipe(recipeId, inputs, s);
		}
		
		private static NonNullList<Ingredient> readIngredients(JsonArray array) {
			NonNullList<Ingredient> nonnulllist = NonNullList.create();

			for(int i = 0; i < array.size(); ++i) {
				Ingredient ingredient = Ingredient.fromJson(array.get(i));
				if (!ingredient.hasNoMatchingItems()) {
					nonnulllist.add(ingredient);
				}
			}
			
			return nonnulllist;
		}

      //I don't know when this gets called
		@Override
		public SoulInfuserRecipe read(ResourceLocation recipeId, PacketBuffer buffer) {
			int i = buffer.readVarInt();
			NonNullList<Ingredient> inputs = NonNullList.withSize(i, Ingredient.EMPTY);
			
			for(int j = 0; j < inputs.size(); j++) {
				inputs.set(j, Ingredient.fromBuffer(buffer));
			}

			IForgeRegistry<Spell> registry = GameRegistry.findRegistry(Spell.class);
			Spell s = registry.getValue(buffer.readResourceLocation());
			return new SoulInfuserRecipe(recipeId, inputs, s);
		}

      //Same here
		@Override
		public void write(PacketBuffer buffer, SoulInfuserRecipe recipe) {
			buffer.writeVarInt(recipe.getIngredients().size());
			
			for(Ingredient i : recipe.getIngredients()) {
				i.writeToBuffer(buffer);
			}
			
			buffer.writeResourceLocation(recipe.spell.getRegistryName());
		}

		@Override
		public ResourceLocation getName() {
			return NAME;
		}
		
	}
}

 

As stated, the json is being imported correctly.

flaming_touch.json

Spoiler

{
  "type": "soulmagic:soul_infusing",
  "spell": "soulmagic:flaming_touch",
  "ingredients": [
    {
      "item": "minecraft:magma_block"
    },
    {
      "item": "minecraft:stone"
    },
    {
      "item": "minecraft:flint_and_steel"
    },
    {
      "item": "minecraft:stone"
    },
    {
      "item": "minecraft:magma_block"
    },
    {
      "item": "minecraft:stone"
    },
    {
      "item": "minecraft:flint_and_steel"
    },
    {
      "item": "minecraft:stone"
    }
  ]
}

 

What the tileentity does is it adds something (a "spell") to another item's capability in the tileentity. That's why there's going to be no real "output". the "output" is the spell that the tileentity will add if there is a "recipe". I want json support with my mod. I don't know if my logic here is good or not.

I have forge 1.13.2-25.0.215. I don't have github quite yet.

 

Edit: I have tried to make the recipe wrapper an instance variable only created once, but that still doesn't work.

Edited by RainbowLuigi281

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I have this same problem. Did you manage to find a solution? Any help would be appreciated. Thanks.
    • log: https://mclo.gs/QJg3wYX as stated in the title, my game freezes upon loading into the server after i used a far-away waystone in it. The modpack i'm using is better minecraft V18. Issue only comes up in this specific server, singleplayer and other servers are A-okay. i've already experimented with removing possible culprits like modernfix and various others to no effect. i've also attempted a full reinstall of the modpack profile. Issue occurs shortly after the 'cancel' button dissapears on the 'loading world' section of the loading screen.   thanks in advance.
    • You would have better results asking a more specific question. What have you done? What exactly do you need help with? Please also read the FAQ regarding posting logs.
    • Hi, this is my second post with the same content as no one answered this and it's been a long time since I made the last post, I want to make a client-only mod, everything is ok, but when I use shaders, none of the textures rendered in RenderLevelStageEvent nor the crow entity model are rendered, I want them to be visible, because it's a horror themed mod I've already tried it with different shaders, but it didn't work with any of them and I really want to add support for shaders Here is how i render the crow model in the CrowEntityRenderer<CrowEntity>, by the time i use this method, i know is not the right method but i don't think this is the cause of the problem, the renderType i'm using is entityCutout @Override public void render(CrowEntity p_entity, float entityYaw, float partialTick, PoseStack poseStack, MultiBufferSource bufferSource, int packedLight) { super.render(p_entity, entityYaw, partialTick, poseStack, bufferSource, packedLight); ClientEventHandler.getClient().crow.renderToBuffer(poseStack, bufferSource.getBuffer(ClientEventHandler.getClient().crow .renderType(TEXTURE)), packedLight, OverlayTexture.NO_OVERLAY, Utils.rgb(255, 255, 255)); } Here renderLevelStage @Override public void renderWorld(RenderLevelStageEvent e) { horrorEvents.draw(e); } Here is how i render every event public void draw(RenderLevelStageEvent e) { for (HorrorEvent event : currentHorrorEvents) { event.tick(e.getPartialTick()); event.draw(e); } } Here is how i render the crow model on the event @Override public void draw(RenderLevelStageEvent e) { if(e.getStage() == RenderLevelStageEvent.Stage.AFTER_ENTITIES) { float arcProgress = getArcProgress(0.25f); int alpha = (int) Mth.lerp(arcProgress, 0, 255); int packedLight = LevelRenderer.getLightColor(Minecraft.getInstance().level, blockPos); VertexConsumer builder = ClientEventHandler.bufferSource.getBuffer(crow); Crow<CreepyBirdHorrorEvent> model = ClientEventHandler .getClient().crow; model.setupAnim(this); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, packedLight, OverlayTexture.NO_OVERLAY, alpha); builder = ClientEventHandler.bufferSource.getBuffer(eyes); RenderHelper.renderModelInWorld(model, position, offset, e.getCamera(), e.getPoseStack(), builder, 15728880, OverlayTexture.NO_OVERLAY, alpha); } } How i render the model public static void renderModelInWorld(Model model, Vector3f pos, Vector3f offset, Camera camera, PoseStack matrix, VertexConsumer builder, int light, int overlay, int alpha) { matrix.pushPose(); Vec3 cameraPos = camera.getPosition(); double finalX = pos.x - cameraPos.x + offset.x; double finalY = pos.y - cameraPos.y + offset.y; double finalZ = pos.z - cameraPos.z + offset.z; matrix.pushPose(); matrix.translate(finalX, finalY, finalZ); matrix.mulPose(Axis.XP.rotationDegrees(180f)); model.renderToBuffer(matrix, builder, light, overlay, Utils .rgba(255, 255, 255, alpha)); matrix.popPose(); matrix.popPose(); } Thanks in advance
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.