Jump to content

Recommended Posts

Posted

I am trying to create two log blocks (So blocks with different orientations and side textures) using variants for two types of tree, and although the item textures work fine, when I place the block, it has no texture. My code for the logs, enum, and jsons are below:

Log Class

package com.nerdyninja.tutorialmod.blocks.trees;

import javax.annotation.Nullable;

import com.google.common.base.Predicate;
import com.nerdyninja.tutorialmod.Main;
import com.nerdyninja.tutorialmod.blocks.item.ItemBlockVariants;
import com.nerdyninja.tutorialmod.init.ModBlocks;
import com.nerdyninja.tutorialmod.init.ModItems;
import com.nerdyninja.tutorialmod.util.IHasModel;
import com.nerdyninja.tutorialmod.util.IMetaName;
import com.nerdyninja.tutorialmod.util.handlers.EnumTreeHandler;

import net.minecraft.block.BlockLog;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.NonNullList;

public class BlockLogs extends BlockLog implements IHasModel, IMetaName {
	public static final PropertyEnum<EnumTreeHandler.EnumType> VARIANT = PropertyEnum.<EnumTreeHandler.EnumType>create("variant", EnumTreeHandler.EnumType.class, new Predicate<EnumTreeHandler.EnumType>() {
		public boolean apply(@Nullable EnumTreeHandler.EnumType apply) {
			return apply.getMeta() < 2;
		}
	});

	private String name;
	
	public BlockLogs(String name) {
		
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(Main.tutorialtab);
		setDefaultState(this.blockState.getBaseState().withProperty(VARIANT, EnumTreeHandler.EnumType.BAOBAB).withProperty(LOG_AXIS, EnumAxis.Y));
		
		setSoundType(SoundType.WOOD);
		setHardness(2.0F);
		setResistance(3.3F);
		setHarvestLevel("axe", 0);
		
		this.name = name;

		
		ModBlocks.BLOCKS.add(this);
		ModItems.ITEMS.add(new ItemBlockVariants(this).setRegistryName(this.getRegistryName()));
	}
	
	@Override
	public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items) {
		for(EnumTreeHandler.EnumType varient : EnumTreeHandler.EnumType.values()) {
			items.add(new ItemStack(this, 1, varient.getMeta()));
		}
	}
	
	@Override
	public IBlockState getStateFromMeta(int meta) {
		IBlockState state = this.getDefaultState().withProperty(VARIANT, EnumTreeHandler.EnumType.byMetadata((meta & 1) % 2));
		switch(meta & 6) {
		case 0 :
			state = state.withProperty(LOG_AXIS, EnumAxis.Y);
			break;
			
		case 2 :
			state = state.withProperty(LOG_AXIS, EnumAxis.X);
			break;
			
		case 4 :
			state = state.withProperty(LOG_AXIS, EnumAxis.Z);
			break;
			
		default :
			state = state.withProperty(LOG_AXIS, EnumAxis.NONE);
		}
		return state;
	}
	
	@SuppressWarnings("incomplete-switch")
	@Override
	public int getMetaFromState(IBlockState state) {
		int i = 0;
		i = i | ((EnumTreeHandler.EnumType)state.getValue(VARIANT)).getMeta();
		
		switch((BlockLogs.EnumAxis)state.getValue(LOG_AXIS)) {
		case X:
			i |= 2;
			break;
			
		case Y:
			i |= 4;
			break;
			
		case Z:
			i |= 6;
			break;
		}
		return i;
	}
	
	@Override
	protected BlockStateContainer createBlockState() {
		return new BlockStateContainer(this, new IProperty[] {VARIANT, LOG_AXIS});
	}
	
	@Override
	protected ItemStack getSilkTouchDrop(IBlockState state) {
		return new ItemStack(Item.getItemFromBlock(this), 1, ((EnumTreeHandler.EnumType)state.getValue(VARIANT)).getMeta());
	}
	
	@Override
	public int damageDropped(IBlockState state) {
		return ((EnumTreeHandler.EnumType)state.getValue(VARIANT)).getMeta();
	}

	@Override
	public String getSpecialName(ItemStack stack) {
		return EnumTreeHandler.EnumType.values()[stack.getItemDamage()].getName();
	}
	
	@Override
	public void registerModels() 
	{
		for (int i = 0; i < EnumTreeHandler.EnumType.values().length; i++) {
			Main.proxy.registerVariantRenderer(Item.getItemFromBlock(this), i, "logs_" + EnumTreeHandler.EnumType.values()[i].getName(), "inventory");
		}
	}
}

EnumHandler

package com.nerdyninja.tutorialmod.util.handlers;

import net.minecraft.util.IStringSerializable;

public class EnumTreeHandler {
	public static enum EnumType implements IStringSerializable {
		
		BAOBAB(0, "baobab"),
		POWERED(1, "powered");

		
		private static final EnumType[] META_LOOKUP = new EnumType[values().length];
		private final int meta;
		private final String name, unlocalisedName;
		
		private EnumType(int meta, String name) {
			this(meta, name, name);
		}
		private EnumType(int meta, String name, String unlocalizedName) {
			this.meta = meta;
			this.name = name;
			this.unlocalisedName = unlocalizedName;
		}
		
		@Override
		public String getName() {
			return this.name;
		}
		
		public int getMeta() {
			return this.meta;
		}
		
		public String getUnlocalisedName() {
			return this.unlocalisedName;
		}
		
		@Override
		public String toString() {
			return this.name;
		}
		
		public static EnumType byMetadata(int meta) {
			return META_LOOKUP[meta];
		}
		
		static {
			for(EnumType enumtype : values()) {
				META_LOOKUP[enumtype.getMeta()] = enumtype;
			}
		}
	}
}

BlockState Json

{
    "variants":
    {
        "axis=x, variant=baobab": { "model": "nntm:logs_baobab" },
        "axis=x, variant=powered": { "model": "nntm:logs_powered" },
        "axis=y, variant=baobab": { "model": "nntm:logs_baobab" },
        "axis=y, variant=powered": { "model": "nntm:logs_powered" },
        "axis=z, variant=baobab": { "model": "nntm:logs_baobab" },
        "axis=z, variant=powered": { "model": "nntm:logs_powered" },
        "axis=none, variant=baobab": { "model": "nntm:logs_baobab" },
        "axis=none, variant=powered": { "model": "nntm:logs_powered" }
    }
}

Model.Block Json

{
   "parent": "block/cube_column",
   "textures": {
       "end": "nntm:blocks/log_baobab_top",
       "side": "nntm:blocks/log_baobab_side"
   }
}

 

I'm very new to modding, so it may be just a silly error. Could anyone help?

Posted

The error in the log is here

  Reveal hidden contents

And the block json is also repeated for the other log

Posted (edited)

What's the name of your blockstate file and the path to it ?

It looks like it can't find it...

 

Caused by: java.io.FileNotFoundException: nntm:blockstates/log.json

Edited by Dipo
Posted
  Reveal hidden contents

Thanks Dipo, I renamed the blockstate file from logs to log. Now it still doesn't work, but the console report is shorter and without the FileNotFoundException.

Any other ideas of how to fix?

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Without Network protocol fix mod, I get kicked with a Network Protocol error when on LAN. Also, both of these issues are caused by a Null Pointer Exception/Screen cannot be null in a "Client Bound Player Combat Kill Packet".
    • You need a new "items" folder at  resources/assets/yourmodid/ there you add for every item model a .json file with the exact item/block name and fill it like this if it's an item: { "model": { "type": "minecraft:model", "model": "yourmodid:item/youritem" } } and so if its a block: { "model": { "type": "minecraft:model", "model": "yourmodid:block/youritem" } } There is also a generator for it you can do namy crazy things with it which replaces the previous hard coded Item Properties implementaion method (Bow pulling animation for example). https://misode.github.io/assets/item/
    • Hello! I'm playing a modpack (custom made) with some friends, and we have the server running on BisectHosting. We encountered a bug with an entity from The Box Of Horrors mod, that would crash the game whenever someone nearby it would log in. We tried to fix it by: 1) Editing the player.dat files to change the location of the affected players (something I had done successfully previously) 2) Updating the version of the mod we had (0.0.8.2) to the latest alpha version (0.0.8.3 However, after doing both of those, none of us are able to join the server, and we get the following errors: Server side: https://pastebin.com/J5sc3VQN Client side: Internal Server Error (that's basically all I've gotten) Please help! I've tried restoring the player data to how it was before I made the changes (Bisect allows you to restore deleted files) and deleting all of my player data files and I still get the same error. Deleting Box Of Horrors causes the error: Failed to load datapacks, cannot continue with server load.
    • Hey there! I'm trying to create a simple mod for Forge 1.21.1 that adds a few custom banner patterns that don't require any banner pattern items. To be completely honest, this is my first time modding for Minecraft, so after setting up the project in Intellij, I copied the parts of the source code from this mod on CurseForge that dealt with adding and registering banner patterns, including the lang and banner_pattern .json files. From what I understand, to add a banner pattern that doesn't require a banner pattern item, I only needed to create the registries for each pattern like in here and then register it in the main java class like here on Line 54. Additionally, in the lang/en_us.json file, add in the names for each respective banner color, and in the data/minecraft/tags/banner_pattern/no_items_required.json file, add each banner pattern that does not require a banner pattern item to make a banner. The project is able to compile when loading in Forge which makes me assume that the file structure I have is correct, but on loading a Minecraft world, this error appears in console and the loom is subsequently blank. [Worker-Main-1/ERROR] [minecraft/TagLoader]: Couldn't load tag minecraft:no_item_required as it is missing following references: *lists every added entry in no_item_required.json* The message clearly states something went wrong regarding when trying to load in the registries from the mod, but I have no clue what could be wrong with the code I have. Attached below are screenshots of what I currently have. Java Main Class Banner Registry Class File Structure Error in Console upon loading a Minecraft world What the loom shows without minecraft:no_item_required    The original mod I copied still functions completely, so if anyone can figure out why the registries for the mod I'm making isn't working, that would be greatly appreciated!    
    • Please someone help me to know how can I fix this generation error in the trees! I already uninstalled and reinstalled several mods in my modpack and can't figure out what is causing it.    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.