Jump to content

(1.14) Custom IRecipe RecipeManager Help


pancax

Recommended Posts

Hello, my friend and I recently started modding because we thought it would be fun, so far it has!

Unfortunately i have been hard-stuck on this particular problem and i really don't know why.

Basically i have made a custom recipe called a "grinding recipe" for my block the grinder (called firstblock for now) and i would like when you put a firstblock item into the top slot for it to "grind it" and transform it into a firstitem. This is really just a proof of concept before i implement it further with actual items. Once it works i can replicate the success easily (hopefully)

The problem code is this:

                       IRecipe<?> irecipe = this.world.getRecipeManager().getRecipe(Objects.requireNonNull((ModItems.FIRSTITEM).getRegistryName())/*(IRecipeType<AbstractGrindingRecipe>)this.recipeType,this,this.world*/).orElse(null);

getRecipe always returns null no matter what i give it. As you can see by the commented out section i have also tried the other method of getRecipe. 

 

My question is, is it not enough that i have registered my recipe like this

package orebesity.common.recipes;

import net.minecraft.item.crafting.IRecipeSerializer;
import net.minecraftforge.registries.ObjectHolder;

public class ModRecipes {
    @ObjectHolder("orebesity:grinding")
    public static IRecipeSerializer<GrindingRecipe> GRINDING;// = IRecipeSerializer.register("grinding",new GrindingRecipeSerializer<>(GrindingRecipe::new,100));

}

 

and made my recipes item file like this?

 

{
  "type": "orebesity:grinding",
  "ingredient": {
    "item": "orebesity:firstblock"
  },
  "result": "orebesity:firstitem",
  "experience": 0.7,
  "grindingtime": 200
}

 

I have no idea how forge adds recipes to the RecipeManager (or if i even have to) but it seems like minecraft doesn't recognize that my firstitem CAN be grinded from my firstblock. Here is my firstblock tile entity code if that is the problem.

class FirstBlockTile extends TileEntity implements ITickableTileEntity, INamedContainerProvider, IRecipeHolder, ISidedInventory {
    private LazyOptional<IItemHandler> handler = LazyOptional.of(this::getHandler);
    public FirstBlockTile() {
        super(FIRSTBLOCK_TILE);
        recipeType=null;
    }
    public FirstBlockTile(IRecipeType<? extends AbstractGrindingRecipe> recipeType) {
        super(FIRSTBLOCK_TILE);
        this.recipeType = recipeType;
    }
    protected final IRecipeType<? extends AbstractGrindingRecipe> recipeType;
    private int grindingTime=0;
    @Override
    public void tick() {
        if(!this.world.isRemote){

           handler.ifPresent(h->{
               boolean isOn=false;
               ItemStack stack = h.getStackInSlot(0);
               if(stack.getItem()==ModBlocks.FIRSTBLOCK.asItem()){
                   isOn=true;
                   if(!stack.isEmpty()){
                       IRecipe<?> irecipe = this.world.getRecipeManager().getRecipe(Objects.requireNonNull((ModItems.FIRSTITEM).getRegistryName())/*(IRecipeType<AbstractGrindingRecipe>)this.recipeType,this,this.world*/).orElse(null);
                       System.out.println("alligator"+ModItems.FIRSTITEM.getRegistryName());
                       System.out.println("crocodile"+irecipe);
                       if(this.canYouGrind(irecipe)){
                           if(stack.hasContainerItem()){

                           }
                           else{
                               if(!stack.isEmpty()){
                                   Item item = stack.getItem();
                                   stack.shrink(1);
                                   if(stack.isEmpty()){

                                   }
                               }
                           }
                       }

                       if(canYouGrind(irecipe)){
                           ++this.grindingTime;
                           if(this.grindingTime==getDefaultGrindTime(stack.getItem())){
                               this.grindingTime=0;
                               this.itemGrinded(irecipe);
                           }
                       }else{
                           this.grindingTime=0;
                       }

                   }


               }
               if(isOn){
                   this.world.setBlockState(pos,this.world.getBlockState(this.pos).with(FirstBlock.ON,Boolean.valueOf("true")));
               }
               else{
                   this.world.setBlockState(pos,this.world.getBlockState(this.pos).with(FirstBlock.ON,Boolean.valueOf("false")));
               }


           });

        }
    }

    protected int getDefaultGrindTime(Item item){
        if(item==ModBlocks.FIRSTBLOCK.asItem())
            return 100;
        return 0;
    }
    private void itemGrinded(@Nullable IRecipe<?> recipe) {
        if (recipe != null && this.canYouGrind(recipe)) {
            ItemStack itemstack1 = recipe.getRecipeOutput();
            handler.ifPresent(h-> {
                ItemStack itemstack = h.getStackInSlot(0);
                ItemStack itemstack2= h.getStackInSlot(1);
                if (itemstack2.isEmpty()) {
                    itemstack2=itemstack1;
                } else if (itemstack2.getItem() == itemstack1.getItem()) {
                    itemstack2.grow(itemstack1.getCount());
                }

                if (!this.world.isRemote) {
                    this.setRecipeUsed(recipe);
                }
                itemstack.shrink(1);
            });
        }
    }
    protected boolean canYouGrind(@Nullable IRecipe<?> recipeType){

        ItemStack stack = recipeType.getRecipeOutput();
        if(stack.isEmpty()){
            return true;
        }else{
            AtomicReference<ItemStack> resultSlot = null;
            handler.ifPresent((IItemHandler h) -> resultSlot.set(h.getStackInSlot(1)));
            if(resultSlot.get().isEmpty())
            {
                return true;
            }else if (!resultSlot.get().isItemEqual(resultSlot.get())) {
                return false;
            } else if (resultSlot.get().getCount() + resultSlot.get().getCount() <= this.getInventoryStackLimit() && resultSlot.get().getCount() + resultSlot.get().getCount() <= resultSlot.get().getMaxStackSize()) { // Forge fix: make furnace respect stack sizes in furnace recipes
                return true;
            } else {
                return resultSlot.get().getCount() + resultSlot.get().getCount() <= resultSlot.get().getMaxStackSize(); // Forge fix: make furnace respect stack sizes in furnace recipes
            }
        }

    }
    @Override
    public void read(CompoundNBT compound) {
        CompoundNBT invTag = compound.getCompound("inv");

        handler.ifPresent(new NonNullConsumer<IItemHandler>() {
            @Override
            public void accept(@Nonnull IItemHandler h) {
                ((INBTSerializable<CompoundNBT>) h).deserializeNBT(invTag);

            }
        });
        super.read(compound);
    }

    @Override
    public CompoundNBT write(CompoundNBT compound) {

        handler.ifPresent(new NonNullConsumer<IItemHandler>() {
            @Override
            public void accept(@Nonnull IItemHandler h) {
                CompoundNBT c = ((INBTSerializable<CompoundNBT>) h).serializeNBT();
                compound.put("inv", c);
            }
        });

        return super.write(compound);
    }
    private IItemHandler getHandler(){
        return new ItemStackHandler(2){
            @Override
            protected void onContentsChanged(int slot) {
                markDirty();
            }
        };
    }
    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {
        if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
            return handler.cast();
        }
        return super.getCapability(cap, side);
    }

    @Override
    public ITextComponent getDisplayName() {
        return new StringTextComponent(getType().getRegistryName().getPath());
    }

    @Nullable
    @Override
    public Container createMenu(int i, PlayerInventory playerInventory, PlayerEntity playerEntity) {
        return new FirstBlockContainer(i,pos,world,playerInventory,playerEntity);
    }

    @Override
    public void setRecipeUsed(@Nullable IRecipe<?> recipe) {

    }

    @Nullable
    @Override
    public IRecipe<?> getRecipeUsed() {
        return null;
    }

    @Override
    public int[] getSlotsForFace(Direction side) {
        return new int[0];
    }

    @Override
    public boolean canInsertItem(int index, ItemStack itemStackIn, @Nullable Direction direction) {
        return false;
    }

    @Override
    public boolean canExtractItem(int index, ItemStack stack, Direction direction) {
        return false;
    }

    @Override
    public int getSizeInventory() {
        return 0;
    }

    @Override
    public boolean isEmpty() {
        return false;
    }

    @Override
    public ItemStack getStackInSlot(int index) {
        return null;
    }

    @Override
    public ItemStack decrStackSize(int index, int count) {
        return null;
    }

    @Override
    public ItemStack removeStackFromSlot(int index) {
        return null;
    }

    @Override
    public void setInventorySlotContents(int index, ItemStack stack) {

    }

    @Override
    public boolean isUsableByPlayer(PlayerEntity player) {
        return false;
    }

    @Override
    public void clear() {

    }
}

 

Thanks for the help ❤️

Edited by pancax
Link to comment
Share on other sites

You haven't actually registered your recipeSerializer.

@ObjectHolder is just a reference to the registered serializer, it doesn't register anything. You need to subscribe to the registry event (Just like you do for items/blocks)

Link to comment
Share on other sites

Hello, Thanks for the replay AlpVax! Turns out i have already registered it ( i just forgot to include it in the original post) Here is how i registered it

@SubscribeEvent
        public static void registerRecipes(final RegistryEvent.Register<IRecipeSerializer<?>> event){
            event.getRegistry().register(new GrindingRecipeSerializer<>(GrindingRecipe::new,100));
            LOGGER.info("hello from recipes");

        }

And here is my Grinding Recipe Serializer

 

public class GrindingRecipeSerializer<T extends AbstractGrindingRecipe> extends net.minecraftforge.registries.ForgeRegistryEntry<IRecipeSerializer<?>> implements IRecipeSerializer<T> {
        private final int i;
        private final GrindingRecipeSerializer.IFactory<T> factory;

        public GrindingRecipeSerializer(GrindingRecipeSerializer.IFactory<T> factory, int i){
            this.factory=factory;
            this.i=i;
            setRegistryName("orebesity:grinding");
        }
        @Override
        public T read(ResourceLocation recipeId, JsonObject json) {
            String s = JSONUtils.getString(json, "group", "");
            JsonElement jsonelement = (JsonElement)(JSONUtils.isJsonArray(json, "ingredient") ? JSONUtils.getJsonArray(json, "ingredient") : JSONUtils.getJsonObject(json, "ingredient"));
            Ingredient ingredient = Ingredient.deserialize(jsonelement);
            String s1 = JSONUtils.getString(json, "result");
            ResourceLocation resourcelocation = new ResourceLocation(s1);
            ItemStack itemstack = new ItemStack(Registry.ITEM.getValue(resourcelocation).orElseThrow(() -> new IllegalStateException("Item: " + s1 + " does not exist")));
            float f = JSONUtils.getFloat(json, "experience", 0.0F);
            int i = JSONUtils.getInt(json, "grindingtime", this.i);
            return this.factory.create(recipeId, s, ingredient, itemstack, f, i);
        }

        @Override
        public T read(ResourceLocation recipeId, PacketBuffer buffer) {
            String s = buffer.readString(32767);
            Ingredient ingredient = Ingredient.read(buffer);
            ItemStack itemstack = buffer.readItemStack();
            float f = buffer.readFloat();
            int i = buffer.readVarInt();
            return this.factory.create(recipeId, s, ingredient, itemstack, f, i);
        }

        @Override
        public void write(PacketBuffer buffer, T recipe) {
            buffer.writeString(recipe.group);
            recipe.ingredient.write(buffer);
            buffer.writeItemStack(recipe.result);
            buffer.writeFloat(recipe.experience);
            buffer.writeVarInt(recipe.grindTime);
        }

        public interface IFactory<T extends AbstractGrindingRecipe>{
            T create(ResourceLocation resourcelocation, String name, Ingredient ingredient, ItemStack stack, float f , int i);
        }

}

 

I was wondering if i need to register anything else as well?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Falling victim to a scam is a distressing reality many face. I found myself in such a predicament not too long ago, having invested a significant amount of money in what I believed to be a promising platform, only to discover it was nothing more than a fraudulent scheme. The devastating realization that my hard-earned funds had vanished and left me feeling helpless and vulnerable until I found a glimmer of hope in the form of TECHNOCRATE RECOVERY. Discovering TECHNOCRATE RECOVERY felt like stumbling upon a lifeline amidst the turbulent sea of financial fraud. Their reputation as a remarkable team of professionals specializing in assisting individuals in recovering funds lost to scams preceded them, offering a ray of hope in my darkest hour. With trepidation and a flicker of optimism, I reached out to them, hoping against hope for a chance at redemption. From the very first interaction, TECHNOCRATE RECOVERY proved themselves to be true lifesavers. Their compassion, professionalism, and unwavering dedication to my cause were evident from the outset, instilling a sense of trust and reassurance in their abilities. They wasted no time in springing into action, meticulously gathering the necessary information, and laying out a strategic plan for the recovery process. What followed was nothing short of miraculous. With precision and expertise, TECHNOCRATE RECOVERY navigated the complexities of cryptocurrency scams, uncovering the deceit and reclaiming what was rightfully mine. MAIL BOX: Technocratrecovery(@)contractor(.)net   WEBSITE INFO: www (.)technocraterecovery(.)site
    • Hello, I have been suffering with consistent crashes either during load up or during play-time. I have updated all drivers, updated and reinstalled java versions, and tried curseforge, GDLauncher, and PrismLauncher. I am struggling to find the issue of the crash as it is inhibiting me from playing. Please help, thanks. https://pastebin.com/GnQHr6sZ https://pastebin.com/6EyR1Sgk
    • Hello, I am trying to join a server with mods, specifically a Custom Profile Modpack I made. I have no idea how to identify the problem, please help. I attached the error, Modpack, and the Crash Report it gave me. Mods: https://ibb.co/N7p6Pgr Modpack: https://drive.google.com/file/d/1KCEyq_sGAF9q7tilKbdGOubpKeUdHRHx/view?usp=sharing Minecraft Crash Report: https://paste.ee/p/zISCN Minecraft Launcher Error Image: https://ibb.co/sbwQRb4
    • Thanks for the response. I ended up going with this:   public class PlayerDeathHandler { @SubscribeEvent public void playerKilled(LivingDeathEvent event) { if (event.getEntity() instanceof Player player) { ItemStack poppetStack = new ItemStack(ModItems.DEATH_PROTECTION_POPPET.get()); if (player.getInventory().contains(poppetStack)) { event.setCanceled(true); player.setHealth(player.getMaxHealth()); for (int i = 0; i < player.getInventory().getContainerSize(); i++) { ItemStack stackInSlot = player.getInventory().getItem(i); if (stackInSlot.getItem() == poppetStack.getItem()) { stackInSlot.shrink(1); if (stackInSlot.isEmpty()) { player.getInventory().setItem(i, ItemStack.EMPTY); } break; } } } } } } It works like a charm, but are there any issues that COULD arise using this? I don't have much experience with Forge, so I'm not sure about the common issues and whatnot.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.