Jump to content

Recommended Posts

Posted

I've been playing around with Entities and decided to make a spawn egg. However, when I used the spawn egg, I got a NullPointerException when I built my EntityType inside of my event subscriber, like so (note the EntityType is built on line 16):

1     //Entities
2     @ObjectHolder("entity_test")
3     public static final EntityType<CreeperEntity> entity_test = null;
4
5     //SpawnEggs
6     @ObjectHolder("spawn_entity_test")
7     public static final Item spawn_entity_test = null;
8
9     @SubscribeEvent
10    public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {
11        LOGGER.debug("Wabbits: Registering Entities...");
12        event.getRegistry().registerAll(
13                EntityType.Builder
14                        .create(CreeperEntity::new, EntityClassification.AMBIENT)
15                        .size(0.4F, 0.7F)
16                        .build("entity_test").setRegistryName(Constants.MOD_ID, "entity_test")
17        );
18    } //registerEntities()
19
20    @SubscribeEvent
21    public static void registerSpawnEggs(final RegistryEvent.Register<Item> event) {
22        LOGGER.debug("Wabbits: Registering Spawn Eggs...");
23        event.getRegistry().registerAll(
24                new SpawnEggItem(entity_test, 0, 0, new Item.Properties().group(ItemGroups.MAIN_GROUP_WABBITS)).setRegistryName(Constants.MOD_ID, "spawn_entity_test")
25        );
26    } //registerSpawnEggs()


After exploring with the debugger, I discovered that Items are registered before Entities, which means the spawn egg is being registered before the ObjectHolder for my EntityType is set (resulting in the egg trying to spawn null). I messed around with SubscribeEvent priorities for a while, but Items always registered first. I then tried building the EntityType and assigning it before the register event (lines 3-6):
 

1     //Entities
2     @ObjectHolder("entity_test")
3     public static final EntityType<CreeperEntity> entity_test = EntityType.Builder
4             .create(CreeperEntity::new, EntityClassification.AMBIENT)
5             .size(0.4F, 0.7F)
6             .build("entity_test");
7 
8     //SpawnEggs
9     @ObjectHolder("spawn_entity_test")
10    public static final Item spawn_entity_test = null;
11
12
13    @SubscribeEvent
14    public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {
15        LOGGER.debug("Wabbits: Registering Entities...");
16        event.getRegistry().registerAll(
17                entity_test.setRegistryName(Constants.MOD_ID, "entity_test")
18        );
19    } //registerEntities()
20
21    @SubscribeEvent
22    public static void registerSpawnEggs(final RegistryEvent.Register<Item> event) {
23        LOGGER.debug("Wabbits: Registering Spawn Eggs...");
24        event.getRegistry().registerAll(
25                new SpawnEggItem(entity_test, 0, 0, new Item.Properties().group(ItemGroups.MAIN_GROUP_WABBITS)).setRegistryName(Constants.MOD_ID, "spawn_entity_test")
26        );
27    } //registerSpawnEggs()

This works, but seems odd since every other object (Blocks, Items, ect.) is built or constructed inside of #registerAll. Is there a better way to set up the Entity and SpawnEgg?

Thanks in advance!

Posted
11 hours ago, diesieben07 said:

You have to create (not register) the EntityTypes beforehand, then register them in the EntityType registry event, like you already do.

However you must not create registry entries in static initializers, in this case you can create the entity types in the item registry event.

Awesome, thank you!

  • TheMikeste1 changed the title to [SOLVED][1.14.4] Entities and SpawnEggs

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Im trying to build my mod using shade since i use the luaj library however i keep getting this error Reason: Task ':reobfJar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. So i try adding reobfJar.dependsOn shadowJar  Could not get unknown property 'reobfJar' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. my gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'com.github.johnrengelman.shadow' version '7.1.2' id 'org.spongepowered.mixin' version '0.7.+' } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'org.spongepowered.mixin' apply plugin: 'com.github.johnrengelman.shadow' version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) //jarJar.enable() println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: mapping_channel, version: mapping_version copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' arg "-mixin.config=derp.mixin.json" mods { "${mod_id}" { source sourceSets.main } } } client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { workingDirectory project.file('run-data') args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { flatDir { dirs './libs' } maven { url = "https://jitpack.io" } } configurations { shade implementation.extendsFrom shade } dependencies { minecraft "net.minecraftforge:forge:${minecraft_version}-${forge_version}" implementation 'org.luaj:luaj-jse-3.0.2' implementation fg.deobf("com.github.Virtuoel:Pehkui:${pehkui_version}") annotationProcessor 'org.spongepowered:mixin:0.8.5:processor' minecraftLibrary 'luaj:luaj-jse:3.0.2' shade 'luaj:luaj-jse:3.0.2' } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"), "TweakClass" : "org.spongepowered.asm.launch.MixinTweaker", "TweakOrder" : 0, "MixinConfigs" : "derp.mixin.json" ]) } rename 'mixin.refmap.json', 'derp.mixin-refmap.json' } shadowJar { archiveClassifier = '' configurations = [project.configurations.shade] finalizedBy 'reobfShadowJar' } assemble.dependsOn shadowJar reobf { re shadowJar {} } publishing { publications { mavenJava(MavenPublication) { artifact jar } } repositories { maven { url "file://${project.projectDir}/mcmodsrepo" } } }  
    • All versions of Minecraft Forge suddenly black screen even without mods (tried reinstalling original Minecraft, Java, updating drivers doesn't work)
    • When i join minecraft all ok, when i join world all working fine, but when i open indentity menu, i get this The game crashed whilst unexpected error Error: java.lang.NullPointerException: Cannot invoke "top.ribs.scguns.common.Gun$Projectile.getDamage()" because "this.projectile" is null crash report here https://paste.ee/p/0vKaf
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.