Jump to content

Recommended Posts

Posted

Hi

 

I had in the title "multiblock" because what I'm trying to achieve is pretty close to being a standard multiblock structure, but it would not function as a traditional one like a machine. A multiblock recognizing eight (8) blocks from vanilla which when recognizing the pattern will add a timer for n amount of time, and when it reaches 0 will turn the bottom four (4) into another block.

I would like to add a feature to make Clay renewable by submerging three (3) Dirt blocks and one (1) Gravel block in a 4x4 underwater, and will over time turn those four blocks into four Clay blocks ready to be harvested.

 

I do not know how to efficiently check for this without lagging the server. Checking for four Water blocks would be disastrous, checking for Dirt or Gravel would be pretty hard on the server too, and then there is the problem of adding a timer to a recognized multiblock of vanilla blocks. Something I could do to make the pattern recognizing more efficient would check for clear sky, I just thought of. But I do not know how to check for that underwater.

Posted

My current plan now is to make a capability and then attach it to every chunk, and then do a test searching for my multiblock:

 

Spoiler

PatternCreator.java


public class PatternCreator
{

    private final int x,y,z;


    private Block[][][] blocks;

    public PatternCreator(int width, int height, int depth, Block...blocks)
    {
        x = width;
        y = height;
        z = depth;


        this.blocks = new Block[width][height][depth];

        for (int x=0;x<this.x;x++) {
            for (int y=0;y<this.y;y++) {
                for (int z=0;z<this.z;z++) {
                    this.blocks[x][y][z] = blocks[x+y+z];
                }
            }
        }


    }

    public boolean checkPattern(World world, BlockPos pos)
    {
        for (int x=0;x<this.x;x++) {
            for (int y=0;y<this.y;y++) {
                for (int z=0;z<this.z;z++) {
                    BlockPos blockPos = new BlockPos(pos.getX()+x,pos.getY()+y,pos.getZ()+z);
                    if (!(world.getBlockState(blockPos).getBlock() == this.blocks[x][y][z]))
                        return false;
                }
            }
        }
        return true;
    }

    public Block[][][] getBlocks()
    {
        return blocks;
    }

    public Block getBlock(int x, int y, int z)
    {
        return blocks[x][y][z];
    }
}

 

Clay.java


public class Clay extends PatternCreator
{
    public Clay()
    {
        super(2,2,2,
                Blocks.DIRT,Blocks.DIRT,
                Blocks.DIRT,Blocks.GRAVEL,

                Blocks.WATER,Blocks.WATER,
                Blocks.WATER,Blocks.WATER
        );
    }
}

 

 

 

Then it should when it finds it adds that block as the origin.

Spoiler

Pattern.java


public class Pattern implements IPattern
{

    private List<PatternTracker> patterns;
    private Chunk chunk;


    public static final long timeTicks = 20 * 60 * 30;

    public Pattern(Chunk chunk)
    {
        patterns = new ArrayList<>();
        this.chunk = chunk;
    }


    @Override
    public void checkFor(PatternTypes type)
    {

        // TODO	look for the pattern, then add it to the list.




    }

    @Override
    public PatternTracker[] getPatterns()
    {
        return patterns.stream().toArray(PatternTracker[]::new);
    }
}

 

PatternTracker.java


public class PatternTracker
{

    private final BlockPos pos;
    private final Direction direction;


    public PatternTracker(BlockPos pos, @Nullable Direction direction)
    {
        this.pos = pos;
        this.direction = direction != null ? direction : Direction.NORTH;
    }


    public BlockPos getPosition()
    {
        return pos;
    }

    public Direction getDirection()
    {
        return direction;
    }
}

 

 

 

But here I've encountered my first problem: In order for the pattern recognizer to check it needs an origin block position to check from. And that would be the lowest x and z coordinate in the chunk, which I do not know how to check for. I think it would be best to check for just the very top layer in the chunk to avoid slowing down the server too much. But I do not know how to get the chunk's local (0-15) x and z coordinate and go from there. I can get the y coordinate but the other two are unknown.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.