Search the Forums BEFORE making a new post.

[1.14.2] [SOLVED] Button.IPressable not called

Posted September 7, 20196 yr

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

Button initialization:

buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

Spoiler


public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

I put a print on top of the button press callback, yet nothing is printed.

Edited September 7, 20196 yr by Big_Bad_E

Quote

September 7, 20196 yr

On 9/6/2019 at 8:20 PM, Big_Bad_E said:

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

Button initialization:

buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

Hide contents

public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

I put a print on top of the button press callback, yet nothing is printed.

Edited July 4Jul 4 by ProPane865

Quote

September 7, 20196 yr

Author

1 minute ago, ProPane865 said:

I don't see a print...

I removed it for the git push to make it more clean. It also closes the GUI which is a pretty obvious test statement.

Edited September 7, 20196 yr by Big_Bad_E

Quote

September 7, 20196 yr

On 9/6/2019 at 8:24 PM, Big_Bad_E said:

I removed it for the git push.

Edited July 4Jul 4 by ProPane865

Quote

September 7, 20196 yr

Author

14 hours ago, ProPane865 said:

Ok... and? This thread should be marked as "solved" if you removed the print statement.

No... that’s not how it works. removing a print statement didn’t fix my problem.

9 hours ago, diesieben07 said:

You need to use Screen#addButton to add buttons.

I will change the method, I’ve been looking at old code that worked without thinking of changes like this.

Quote

September 7, 20196 yr

Author

Yep Screen#addButton did it. Thanks!

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/75736-1142-solved-buttonipressable-not-called/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 5 hours ago5 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 11 hours ago11 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 18 hours ago18 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 22 hours ago22 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

Gabs1107

Sign In

[1.14.2] [SOLVED] Button.IPressable not called

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)