[1.14.2] [SOLVED] Button.IPressable not called

[Big_Bad_E]

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

 

Button initialization:

buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

 

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

  Reveal hidden contents

public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

 

 

I put a print on top of the button press callback, yet nothing is printed.

Edited September 7, 2019 by Big_Bad_E

[ProPane865]

  On 9/7/2019 at 3:20 AM, Big_Bad_E said:

I have a pretty simple GUI, where I add two buttons. Both are added but neither button's IPressable is called when I click the button. The button highlights on hover.

 

Button initialization:

buttons.clear();
buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(),	(button) -> {
    mc.player.closeScreen();
}));

 

Screen class:

https://github.com/BigBadE/BattlePets/blob/master/src/main/java/bigbade/battlepets/client/gui/PetScreen.java

  Reveal hidden contents

public class PetScreen extends ContainerScreen<PetContainer> {
    private static final ResourceLocation GUITEXTURE = new ResourceLocation("battlepets:textures/gui/pet.png");
    private PetEntity pet;
    private int currTexIndex = 0;
    private Widget texButton;

    public PetScreen(PetContainer container, PlayerInventory playerInventory, ITextComponent name) {
        super(container, playerInventory, container.getName());
        pet = container.getPet();
    }

    @Override
    public void init() {
        super.init();

        Minecraft mc = Minecraft.getInstance();

        buttons.clear();
        buttons.add(new Button(guiLeft + 8, guiTop + 39, 48, 20, new TranslationTextComponent("gui.battlepets.pet.skills").getFormattedText(), (button) -> {
            mc.player.closeScreen();
            //TODO skill inv
            //NetworkHooks.openGui(mc.player, new CulinaryWorkbenchContainerProvider(pos));
        }));

        buttons.add(texButton = new Button(guiLeft + 8, guiTop - 28, xSize - 16, 20, "<...>", (button) -> {
            PetType type = pet.getPetType();
            if (++currTexIndex >= type.textures.length) {
                currTexIndex = 0;
            }

            String tex = type.textures[currTexIndex];
            pet.setTexture(tex);

            updateTextureButton(false);
        }));

        updateTextureButton(true);
    }


    @Override
    protected void drawGuiContainerForegroundLayer(int par1, int par2) {
        FontRenderer fontRenderer = Minecraft.getInstance().fontRenderer;
        fontRenderer.drawString(container.getName().getFormattedText(), 8, 6, 4210752);
        fontRenderer.drawString(playerInventory.hasCustomName() ? playerInventory.getCustomName().getFormattedText() : playerInventory.getName().getFormattedText(), 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        texButton.render(mouseX, mouseY, partialTicks);
        Minecraft.getInstance().getTextureManager().bindTexture(GUITEXTURE);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;
        blit(k, l, 0, 0, this.xSize, this.ySize);

        if (pet.hasSkill(Skill.INVENTORY_ARMOR.id)) {
            blit(k + 7 + 18, l + 17, 0, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.TRAVEL_MOUNTABLE.id)) {
            blit(k + 7, l + 17, 18, 220, 18, 18);
        }
        if (pet.hasSkill(Skill.INVENTORY_WEAPON.id)) {
            blit(k + 7 + 36, l + 17, 36, 220, 18, 18);
        }

        if (pet.hasSkill(Skill.INVENTORY.id)) {
            int count = (pet.getPetInventory().getSizeInventory() - 3) / 3;

            int rows = Math.min(count, 3);
            blit(k + 115, l + 17, 0, 166, 54, 18 * rows);

            int cols = Math.max(count - 3, 0);
            blit(k + 115 + 18 * 3, l + 17, 18 * 3, 166, 18 * cols, 54);
        }

        InventoryScreen.drawEntityOnScreen(k + 88, l + 60, 17, (float)(k+88) - mouseX, (float)(l+45) - mouseY, this.pet);
    }

    @Override
    public void render(int mx, int my, float par3) {
        super.render(mx, my, par3);
    }

    private void updateTextureButton(boolean initial) {
        if (initial) {
            int tex = 0;
            for(int i = 0; i < pet.getPetType().textures.length; i++)
                if(pet.getPetType().textures[i].equals(pet.getTexture()))
                    tex = i;
            currTexIndex = tex;
        }
        texButton.setMessage(new TranslationTextComponent("pet.battlepets.texture").getFormattedText().replace("%s", new TranslationTextComponent("pet.battlepets.texture." + pet.getPetType().name().toLowerCase() + "." + pet.getTexture()).getFormattedText()));
    }
}

 

 

I put a print on top of the button press callback, yet nothing is printed.

Expand  

I don't see a print...

[Big_Bad_E]

  On 9/7/2019 at 3:22 AM, ProPane865 said:

I don't see a print...

Expand  

 

I removed it for the git push to make it more clean. It also closes the GUI which is a pretty obvious test statement.

Edited September 7, 2019 by Big_Bad_E

[ProPane865]

  On 9/7/2019 at 3:24 AM, Big_Bad_E said:

 

I removed it for the git push.

Expand  

Ok... and? This thread should be marked as "solved" if you removed the print statement.

Edited September 7, 2019 by ProPane865

[Big_Bad_E]

  On 9/7/2019 at 3:25 AM, ProPane865 said:

Ok... and? This thread should be marked as "solved" if you removed the print statement.

Expand  

No... that’s not how it works. removing a print statement didn’t fix my problem.

 

  On 9/7/2019 at 9:14 AM, diesieben07 said:

You need to use Screen#addButton to add buttons.

Expand  

I will change the method, I’ve been looking at old code that worked without thinking of changes like this.

[Big_Bad_E]

Yep Screen#addButton did it. Thanks!