Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12.2] TE persists when shouldRefresh() returns false


MSpace-Dev
 Share

Recommended Posts

I've set TileEntity#shouldRefresh to false so that I can update the blockstate without it resetting its values. However, this makes the tile entity persist when its block is broken.

I've added world.removeTileEntity(pos) in theBlock#blockBreak override function. However, the TE still persists. I can verify it is getting called. Am I missing something here?

 

@Override
public void breakBlock(World worldIn, BlockPos pos, IBlockState state)
{
    if (!worldIn.isRemote)
    {
        if (worldIn.getTileEntity(pos) != null)
        {
            if (worldIn.getTileEntity(pos) instanceof TileEntityTotemBase)
            {
                TileEntityTotemBase totemBase = (TileEntityTotemBase) worldIn.getTileEntity(pos);
        
                // Update totem on Client
                totemBase.setTotemProperties();
                totemBase.sendUpdates();
            }
        }
    }

    worldIn.removeTileEntity(pos); // Redundant as super() calls it anyways. Probably need some other calls to remove TE!

    super.breakBlock(worldIn, pos, state);
}
Edited by MSpace-Dev
ugly copy from Discord
Link to comment
Share on other sites

Ah, I see thanks. Got it working nicely like this

 

@Override
public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState)
{
  // Only refresh if new state is not an instance of BlockTotemBase
  return !(newState.getBlock() instanceof BlockTotemBase);
}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.