Search the Forums BEFORE making a new post.

Currently supported: All versions

[1.14.4] Make villagers / zombies recognize new type of door?

Posted December 2, 20195 yr

How do I add a new door that villagers / zombies can use?

Also:

- Vanilla doors are always placed on the edge of blocks.

- My modded doors are placed through the middle of blocks.

If this will affect their AI in any way I need to know.

Thanks.

Quote

December 2, 20195 yr

Author

3 hours ago, diesieben07 said:

AI checks for instanceof DoorBlock to check if something is a door. It checks for Material.WOOD to determine if it can be opened (iron doors can only be used with redstone).

DoorBlock#toggleDoor is called on your block to open / close the door. The property DoorBlock.OPEN is checked to determine if a door is open or closed.

Here is the code for my door:

package com.kenneth.hard_survival_craft.objects.blocks.construction;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.block.DoorBlock;
import net.minecraft.block.HorizontalBlock;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.PushReaction;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.item.ItemStack;
import net.minecraft.pathfinding.PathType;
import net.minecraft.state.BooleanProperty;
import net.minecraft.state.DirectionProperty;
import net.minecraft.state.EnumProperty;
import net.minecraft.state.StateContainer.Builder;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.state.properties.DoorHingeSide;
import net.minecraft.state.properties.DoubleBlockHalf;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.Mirror;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.util.math.MathHelper;
import net.minecraft.util.math.Vec3d;
import net.minecraft.util.math.shapes.ISelectionContext;
import net.minecraft.util.math.shapes.VoxelShape;
import net.minecraft.world.IBlockReader;
import net.minecraft.world.IWorld;
import net.minecraft.world.IWorldReader;
import net.minecraft.world.World;

public class CabinDoor extends DoorBlock {
	public static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING;
	public static final BooleanProperty OPEN = BlockStateProperties.OPEN;
	public static final EnumProperty<DoorHingeSide> HINGE = BlockStateProperties.DOOR_HINGE;
	public static final BooleanProperty POWERED = BlockStateProperties.POWERED;
	public static final EnumProperty<DoubleBlockHalf> HALF = BlockStateProperties.DOUBLE_BLOCK_HALF;
	
	protected static final VoxelShape default_shape = Block.makeCuboidShape(0, 0, 7, 16, 16, 9);
	
	protected static final VoxelShape north_south = Block.makeCuboidShape(0, 0, 7, 16, 16, 9);
	protected static final VoxelShape east_west = Block.makeCuboidShape(7, 0, 0, 9, 16, 16);
	
	protected static final VoxelShape south_l = Block.makeCuboidShape(13, 0, 7, 16, 16, 21);
	protected static final VoxelShape south_r = Block.makeCuboidShape(0, 0, 7, 3, 16, 21);
	
	protected static final VoxelShape north_l = Block.makeCuboidShape(0, 0, 9, 3, 16, -5);
	protected static final VoxelShape north_r = Block.makeCuboidShape(13, 0, 9, 16, 16, -5);
	
	protected static final VoxelShape east_l = Block.makeCuboidShape(7, 0, 0, 21, 16, 3);
	protected static final VoxelShape east_r = Block.makeCuboidShape(7, 0, 13, 21, 16, 16);
	
	protected static final VoxelShape west_l = Block.makeCuboidShape(9, 0, 13, -5, 16, 16);
	protected static final VoxelShape west_r = Block.makeCuboidShape(9, 0, 0, -5, 16, 3);
	
	public CabinDoor(Properties properties) {
		super(properties);
		this.setDefaultState(this.stateContainer.getBaseState().with(OPEN, Boolean.valueOf(false)));
	}
	
	@Override
	public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) {
		Direction dir = state.get(FACING);
		DoorHingeSide side = state.get(HINGE);
		Boolean open = state.get(OPEN);
		
		if((dir == Direction.NORTH || dir == Direction.SOUTH) && open == false) {
			return north_south;
		} else if ((dir == Direction.EAST || dir == Direction.WEST) && open == false) {
			return east_west;
		} else if(dir == Direction.NORTH && side == DoorHingeSide.LEFT) {
			return north_l;
		} else if (dir == Direction.NORTH && side == DoorHingeSide.RIGHT) {
			return north_r;
		} else if(dir == Direction.SOUTH && side == DoorHingeSide.LEFT) {
			return south_l;
		} else if (dir == Direction.SOUTH && side == DoorHingeSide.RIGHT) {
			return south_r;
		} else if (dir == Direction.EAST && side == DoorHingeSide.LEFT) {
			return east_l;
		} else if (dir == Direction.EAST && side == DoorHingeSide.RIGHT) {
			return east_r;
		} else if (dir == Direction.WEST && side == DoorHingeSide.LEFT) {
			return west_l;
		} else if (dir == Direction.WEST && side == DoorHingeSide.RIGHT) {
			return west_r;
		} else {
			return default_shape;
		}
	}
	
	@Override
	public BlockState updatePostPlacement(BlockState stateIn, Direction facing, BlockState facingState, IWorld worldIn, BlockPos currentPos, BlockPos facingPos) {
		DoubleBlockHalf doubleblockhalf = stateIn.get(HALF);
		if (facing.getAxis() == Direction.Axis.Y && doubleblockhalf == DoubleBlockHalf.LOWER == (facing == Direction.UP)) {
			return facingState.getBlock() == this && facingState.get(HALF) != doubleblockhalf ? stateIn.with(FACING, facingState.get(FACING)).with(OPEN, facingState.get(OPEN)).with(HINGE, facingState.get(HINGE)).with(POWERED, facingState.get(POWERED)) : Blocks.AIR.getDefaultState();
		} else {
			return doubleblockhalf == DoubleBlockHalf.LOWER && facing == Direction.DOWN && !stateIn.isValidPosition(worldIn, currentPos) ? Blocks.AIR.getDefaultState() : super.updatePostPlacement(stateIn, facing, facingState, worldIn, currentPos, facingPos);
		}
	}
	@Override
	public void harvestBlock(World worldIn, PlayerEntity player, BlockPos pos, BlockState state, TileEntity te, ItemStack stack) {
		super.harvestBlock(worldIn, player, pos, Blocks.AIR.getDefaultState(), te, stack);
	}
	@Override
	public void onBlockHarvested(World worldIn, BlockPos pos, BlockState state, PlayerEntity player) {
		DoubleBlockHalf doubleblockhalf = state.get(HALF);
		BlockPos blockpos = doubleblockhalf == DoubleBlockHalf.LOWER ? pos.up() : pos.down();
		BlockState blockstate = worldIn.getBlockState(blockpos);
		if (blockstate.getBlock() == this && blockstate.get(HALF) != doubleblockhalf) {
	         worldIn.setBlockState(blockpos, Blocks.AIR.getDefaultState(), 35);
	         worldIn.playEvent(player, 2001, blockpos, Block.getStateId(blockstate));
	         ItemStack itemstack = player.getHeldItemMainhand();
	         if (!worldIn.isRemote && !player.isCreative()) {
	        	 Block.spawnDrops(state, worldIn, pos, (TileEntity)null, player, itemstack);
	        	 Block.spawnDrops(blockstate, worldIn, blockpos, (TileEntity)null, player, itemstack);
	         }
		}
		super.onBlockHarvested(worldIn, pos, state, player);
	}
	@Override
	public boolean allowsMovement(BlockState state, IBlockReader worldIn, BlockPos pos, PathType type) {
		switch(type) {
		case LAND:
			return state.get(OPEN);
		case WATER:
			return false;
		case AIR:
			return state.get(OPEN);
		default:
			return false;
		}
	}
	private int getCloseSound() {
		return this.material == Material.IRON ? 1011 : 1012;
	}
	
	private int getOpenSound() {
		return this.material == Material.IRON ? 1005 : 1006;
	}
	@Override
	public BlockState getStateForPlacement(BlockItemUseContext context) {
		BlockPos blockpos = context.getPos();
		if (blockpos.getY() < 255 && context.getWorld().getBlockState(blockpos.up()).isReplaceable(context)) {
			World world = context.getWorld();
			boolean flag = world.isBlockPowered(blockpos) || world.isBlockPowered(blockpos.up());
			return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing()).with(HINGE, this.getHingeSide(context)).with(POWERED, Boolean.valueOf(flag)).with(OPEN, Boolean.valueOf(flag)).with(HALF, DoubleBlockHalf.LOWER);
		} else {
			return null;
		}
	}
	@Override
	public void onBlockPlacedBy(World worldIn, BlockPos pos, BlockState state, LivingEntity placer, ItemStack stack) {
		worldIn.setBlockState(pos.up(), state.with(HALF, DoubleBlockHalf.UPPER), 3);
	}
	private DoorHingeSide getHingeSide(BlockItemUseContext p_208073_1_) {
		IBlockReader iblockreader = p_208073_1_.getWorld();
		BlockPos blockpos = p_208073_1_.getPos();
		Direction direction = p_208073_1_.getPlacementHorizontalFacing();
		BlockPos blockpos1 = blockpos.up();
		Direction direction1 = direction.rotateYCCW();
		BlockPos blockpos2 = blockpos.offset(direction1);
		BlockState blockstate = iblockreader.getBlockState(blockpos2);
		BlockPos blockpos3 = blockpos1.offset(direction1);
		BlockState blockstate1 = iblockreader.getBlockState(blockpos3);
		Direction direction2 = direction.rotateY();
		BlockPos blockpos4 = blockpos.offset(direction2);
		BlockState blockstate2 = iblockreader.getBlockState(blockpos4);
		BlockPos blockpos5 = blockpos1.offset(direction2);
		BlockState blockstate3 = iblockreader.getBlockState(blockpos5);
		int i = (blockstate.func_224756_o(iblockreader, blockpos2) ? -1 : 0) + (blockstate1.func_224756_o(iblockreader, blockpos3) ? -1 : 0) + (blockstate2.func_224756_o(iblockreader, blockpos4) ? 1 : 0) + (blockstate3.func_224756_o(iblockreader, blockpos5) ? 1 : 0);
		boolean flag = blockstate.getBlock() == this && blockstate.get(HALF) == DoubleBlockHalf.LOWER;
		boolean flag1 = blockstate2.getBlock() == this && blockstate2.get(HALF) == DoubleBlockHalf.LOWER;
		if ((!flag || flag1) && i <= 0) {
			if ((!flag1 || flag) && i >= 0) {
				int j = direction.getXOffset();
	            int k = direction.getZOffset();
	            Vec3d vec3d = p_208073_1_.getHitVec();
	            double d0 = vec3d.x - (double)blockpos.getX();
	            double d1 = vec3d.z - (double)blockpos.getZ();
	            return (j >= 0 || !(d1 < 0.5D)) && (j <= 0 || !(d1 > 0.5D)) && (k >= 0 || !(d0 > 0.5D)) && (k <= 0 || !(d0 < 0.5D)) ? DoorHingeSide.LEFT : DoorHingeSide.RIGHT;
			} else {
				return DoorHingeSide.LEFT;
			}
		} else {
			return DoorHingeSide.RIGHT;
		}
	}
	@Override
	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		if (this.material == Material.IRON) {
			return false;
		} else {
			state = state.cycle(OPEN);
			worldIn.setBlockState(pos, state, 10);
			worldIn.playEvent(player, state.get(OPEN) ? this.getOpenSound() : this.getCloseSound(), pos, 0);
			return true;
		}
	}
	@Override
	public void toggleDoor(World worldIn, BlockPos pos, boolean open) {
		BlockState blockstate = worldIn.getBlockState(pos);
		if (blockstate.getBlock() == this && blockstate.get(OPEN) != open) {
			worldIn.setBlockState(pos, blockstate.with(OPEN, Boolean.valueOf(open)), 10);
			this.playSound(worldIn, pos, open);
		}
	}
	@Override
	public void neighborChanged(BlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos fromPos, boolean isMoving) {
		boolean flag = worldIn.isBlockPowered(pos) || worldIn.isBlockPowered(pos.offset(state.get(HALF) == DoubleBlockHalf.LOWER ? Direction.UP : Direction.DOWN));
		if (blockIn != this && flag != state.get(POWERED)) {
			if (flag != state.get(OPEN)) {
				this.playSound(worldIn, pos, flag);
			}
			worldIn.setBlockState(pos, state.with(POWERED, Boolean.valueOf(flag)).with(OPEN, Boolean.valueOf(flag)), 2);
		}
	}
	@Override
	public boolean isValidPosition(BlockState state, IWorldReader worldIn, BlockPos pos) {
		BlockPos blockpos = pos.down();
		BlockState blockstate = worldIn.getBlockState(blockpos);
		if (state.get(HALF) == DoubleBlockHalf.LOWER) {
			return blockstate.func_224755_d(worldIn, blockpos, Direction.UP);
		} else {
			return blockstate.getBlock() == this;
		}
	}
	private void playSound(World worldIn, BlockPos pos, boolean open) {
		worldIn.playEvent((PlayerEntity)null, open ? this.getOpenSound() : this.getCloseSound(), pos, 0);
	}
	@Override
	public PushReaction getPushReaction(BlockState state) {
		return PushReaction.DESTROY;
	}
	@Override
	public BlockState rotate(BlockState state, Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}
	@Override
	public BlockState mirror(BlockState state, Mirror mirrorIn) {
		return mirrorIn == Mirror.NONE ? state : state.rotate(mirrorIn.toRotation(state.get(FACING))).cycle(HINGE);
	}
	@Override
	public long getPositionRandom(BlockState state, BlockPos pos) {
		return MathHelper.getCoordinateRandom(pos.getX(), pos.down(state.get(HALF) == DoubleBlockHalf.LOWER ? 0 : 1).getY(), pos.getZ());
	}
	@Override
	public boolean isSolid(BlockState state) {
		return false;
	}
	@Override
	protected void fillStateContainer(Builder<Block, BlockState> builder) {
		builder.add(HALF, FACING, OPEN, HINGE, POWERED);
	}
}

They still don't interact with it. Remember the door goes through the middle of the block instead of at the edge.

Refer to my mod's images to see what the door looks like:

https://www.curseforge.com/minecraft/mc-mods/kenneths-log-cabin-blocks

EDIT:

The villagers crowd around the door but can't open it

Edited December 2, 20195 yr by Kenneth201998

Quote

December 2, 20195 yr

Author

Any way I can add to vanilla villagers to make them open my doors?

How could I code my own entities to open the door?

Edited December 2, 20195 yr by Kenneth201998

Quote

December 2, 20195 yr

Author

7 minutes ago, diesieben07 said:

You need to write your custom AI goal. Vanilla entity AI can be modified using EntityJoinWorldEvent.

could you show an example of how to create a goal?

Quote

December 2, 20195 yr

Author

What if I were to copy the villager code and add a goal to it? Where would the code be that I can do this?

Edit: How can I add a goal to an existing entity?

Edited December 2, 20195 yr by Kenneth201998

Quote

December 2, 20195 yr

Author

Ok so I have tried:

package com.kenneth.hard_survival_craft.objects.new_ai.join_handlers;

import com.kenneth.hard_survival_craft.KenmodMain;
import com.kenneth.hard_survival_craft.objects.new_ai.goal.CustomDoorGoal;

import net.minecraft.entity.merchant.villager.AbstractVillagerEntity;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;

public class CustomVillagerJoinHandler {
	@SubscribeEvent
	public void onJoinWorld(EntityJoinWorldEvent evt) {
		if(evt.getEntity() instanceof AbstractVillagerEntity) {
			AbstractVillagerEntity ent = (AbstractVillagerEntity)evt.getEntity();
			CustomDoorGoal test = new CustomDoorGoal(ent);
			ent.goalSelector.addGoal(1, test);
			KenmodMain.debugString("TEST 001");
		}
	}
}

And:

package com.kenneth.hard_survival_craft.objects.new_ai.goal;

import com.kenneth.hard_survival_craft.objects.blocks.construction.CabinDoor;

import net.minecraft.block.BlockState;
import net.minecraft.block.DoorBlock;
import net.minecraft.entity.MobEntity;
import net.minecraft.entity.ai.goal.InteractDoorGoal;
import net.minecraft.pathfinding.GroundPathNavigator;
import net.minecraft.util.math.BlockPos;

public class CustomDoorGoal extends InteractDoorGoal{
	
	protected MobEntity entity;
	protected BlockPos doorPosition = BlockPos.ZERO;
	protected boolean doorInteract;
	
	public CustomDoorGoal(MobEntity entityIn) {
		super(entityIn);
		this.entity = entityIn;
		if (!(entityIn.getNavigator() instanceof GroundPathNavigator)) {
			throw new IllegalArgumentException("Unsupported mob type for DoorInteractGoal");
		}
	}
	
	@Override
	protected void toggleDoor(boolean open) {
		if (this.doorInteract) {
			BlockState blockstate = this.entity.world.getBlockState(this.doorPosition);
			if (blockstate.getBlock() instanceof DoorBlock) {
				((DoorBlock)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			} else if (blockstate.getBlock() instanceof CabinDoor){
				((CabinDoor)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			}
		}
	}
}

And:

	private void clientRegistries (final FMLClientSetupEvent event) {
		
		MinecraftForge.EVENT_BUS.register(new CustomVillagerJoinHandler());
		debugString("Client registries method registered...");
		
	}

But still they don't open the doors.

Quote

December 2, 20195 yr

Author

What do I need to change then?

10 minutes ago, diesieben07 said:

Well, yes, you have not changed any of the logic.

Quote

December 2, 20195 yr

Author

4 hours ago, diesieben07 said:

The part where they check if they have collided with a door.

Ok so I have tried moving some things from the vanilla code and got this:

package com.kenneth.hard_survival_craft.objects.new_ai.goal;

import com.kenneth.hard_survival_craft.objects.blocks.construction.CabinDoor;

import net.minecraft.block.BlockState;
import net.minecraft.block.DoorBlock;
import net.minecraft.block.material.Material;
import net.minecraft.entity.MobEntity;
import net.minecraft.entity.ai.goal.InteractDoorGoal;
import net.minecraft.pathfinding.GroundPathNavigator;
import net.minecraft.pathfinding.Path;
import net.minecraft.pathfinding.PathPoint;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class CustomDoorGoal extends InteractDoorGoal{
	
	protected MobEntity entity;
	protected BlockPos doorPosition = BlockPos.ZERO;
	protected boolean doorInteract;
	private boolean hasStoppedDoorInteraction;
	private float entityPositionX;
	private float entityPositionZ;
	   
	public CustomDoorGoal(MobEntity entityIn) {
		super(entityIn);
		this.entity = entityIn;
		if (!(entityIn.getNavigator() instanceof GroundPathNavigator)) {
			throw new IllegalArgumentException("Unsupported mob type for DoorInteractGoal");
		}
	}
	@Override
	public boolean shouldExecute() {
		if(!this.entity.collidedHorizontally) {
			return false;
		} else {
			GroundPathNavigator groundPathNavigator = (GroundPathNavigator)this.entity.getNavigator();
			Path path = groundPathNavigator.getPath();
			if(path != null && !path.isFinished() && groundPathNavigator.getEnterDoors()) {
				for(int i = 0; i < Math.min(path.getCurrentPathIndex() + 2, path.getCurrentPathLength()); ++i) {
					PathPoint pathpoint = path.getPathPointFromIndex(i);
					this.doorPosition = new BlockPos(pathpoint.x, pathpoint.y + 1, pathpoint.z);
					if (!(this.entity.getDistanceSq((double)this.doorPosition.getX(), this.entity.posY, (double)this.doorPosition.getZ()) > 2.25D)) {
						this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
						if (this.doorInteract) {
							return true;
						}
					}
				}
				this.doorPosition = (new BlockPos(this.entity)).up();
	            this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
	            return this.doorInteract;
			} else {
				return false;
			}
		}
	}
	@Override
	public boolean shouldContinueExecuting() {
		return !this.hasStoppedDoorInteraction;
	}
	@Override
	public void startExecuting() {
		this.hasStoppedDoorInteraction = false;
		this.entityPositionX = (float)((double)((float)this.doorPosition.getX() + 0.5F) - this.entity.posX);
		this.entityPositionZ = (float)((double)((float)this.doorPosition.getZ() + 0.5F) - this.entity.posZ);
	}
	@Override
	protected void toggleDoor(boolean open) {
		if (this.doorInteract) {
			BlockState blockstate = this.entity.world.getBlockState(this.doorPosition);
			if (blockstate.getBlock() instanceof DoorBlock) {
				((DoorBlock)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			} else if (blockstate.getBlock() instanceof CabinDoor){
				((CabinDoor)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			}
		}
	}
	@Override
	public void tick() {
		float f = (float)((double)((float)this.doorPosition.getX() + 0.5F) - this.entity.posX);
		float f1 = (float)((double)((float)this.doorPosition.getZ() + 0.5F) - this.entity.posZ);
		float f2 = this.entityPositionX * f + this.entityPositionZ * f1;
		if (f2 < 0.0F) {
			this.hasStoppedDoorInteraction = true;
		}
	}
	public static boolean func_220695_a(World p_220695_0_, BlockPos p_220695_1_) {
		BlockState blockstate = p_220695_0_.getBlockState(p_220695_1_);
		return (blockstate.getBlock() instanceof DoorBlock || blockstate.getBlock() instanceof CabinDoor) && blockstate.getMaterial() == Material.WOOD;
	}
}

They still don't open the door.

EDIT:

package com.kenneth.hard_survival_craft.objects.new_ai.goal;

import com.kenneth.hard_survival_craft.objects.blocks.construction.CabinDoor;

import net.minecraft.block.BlockState;
import net.minecraft.block.DoorBlock;
import net.minecraft.block.material.Material;
import net.minecraft.entity.MobEntity;
import net.minecraft.entity.ai.goal.OpenDoorGoal;
import net.minecraft.pathfinding.GroundPathNavigator;
import net.minecraft.pathfinding.Path;
import net.minecraft.pathfinding.PathPoint;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class CustomDoorGoal extends OpenDoorGoal {
	
	protected MobEntity entity;
	protected BlockPos doorPosition = BlockPos.ZERO;
	protected boolean doorInteract;
	private int closeDoorTemporisation;
	private final boolean closeDoor;
	   
	public CustomDoorGoal(MobEntity entityIn, boolean shouldClose) {
		super(entityIn, shouldClose);
		this.entity = entityIn;
		this.closeDoor = shouldClose;
		if (!(entityIn.getNavigator() instanceof GroundPathNavigator)) {
			throw new IllegalArgumentException("Unsupported mob type for DoorInteractGoal");
		}
	}
	@Override
	public boolean shouldExecute() {
		if(!this.entity.collidedHorizontally) {
			return false;
		} else {
			GroundPathNavigator groundPathNavigator = (GroundPathNavigator)this.entity.getNavigator();
			Path path = groundPathNavigator.getPath();
			if(path != null && !path.isFinished() && groundPathNavigator.getEnterDoors()) {
				for(int i = 0; i < Math.min(path.getCurrentPathIndex() + 2, path.getCurrentPathLength()); ++i) {
					PathPoint pathpoint = path.getPathPointFromIndex(i);
					this.doorPosition = new BlockPos(pathpoint.x, pathpoint.y + 1, pathpoint.z);
					if (!(this.entity.getDistanceSq((double)this.doorPosition.getX(), this.entity.posY, (double)this.doorPosition.getZ()) > 2.25D)) {
						this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
						if (this.doorInteract) {
							return true;
						}
					}
				}
				this.doorPosition = (new BlockPos(this.entity)).up();
	            this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
	            return this.doorInteract;
			} else {
				return false;
			}
		}
	}
	@Override
	public boolean shouldContinueExecuting() {
		return this.closeDoor && this.closeDoorTemporisation > 0 && super.shouldContinueExecuting();
	}
	@Override
	public void startExecuting() {
		this.closeDoorTemporisation = 60;
		this.toggleDoor(true);
	}
	@Override
	protected void toggleDoor(boolean open) {
		if (this.doorInteract) {
			BlockState blockstate = this.entity.world.getBlockState(this.doorPosition);
			if (blockstate.getBlock() instanceof DoorBlock) {
				((DoorBlock)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			} else if (blockstate.getBlock() instanceof CabinDoor){
				((CabinDoor)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			}
		}
	}
	@Override
	public void resetTask() {
		this.toggleDoor(false);
	}
	@Override
	public void tick() {
		--this.closeDoorTemporisation;
		super.tick();
	}
	public static boolean func_220695_a(World p_220695_0_, BlockPos p_220695_1_) {
		BlockState blockstate = p_220695_0_.getBlockState(p_220695_1_);
		return (blockstate.getBlock() instanceof DoorBlock || blockstate.getBlock() instanceof CabinDoor) && blockstate.getMaterial() == Material.WOOD;
	}
}

They can now open doors but the door closes almost instantly upon opening. Its like the door opens then 1 tick later it closes. How to fix?

Edited December 2, 20195 yr by Kenneth201998

Quote

December 4, 20195 yr

Author

On 12/2/2019 at 4:17 PM, diesieben07 said:

Put a breakpoint in the door closing method and check why it was called.

Tried that, does not output anything.

Quote

December 4, 20195 yr

Author

10 minutes ago, diesieben07 said:

Breakpoints do not output anything. They pause the program execution.

It did not do that either.

Quote

December 4, 20195 yr

Author

12 minutes ago, diesieben07 said:

Then the breakpoint was not reached (place it properly) or your IDE is broken.

What I know is that resetTask() is called instantly upon opening the door.

Edited December 4, 20195 yr by Kenneth201998

Quote

December 4, 20195 yr

Author

8 minutes ago, diesieben07 said:

Okay, then check why.

I noticed this:

	@Override
	public void tick() {
		if(this.closeDoorTemporisation > 0) {
			--this.closeDoorTemporisation;
			KenmodMain.debugString("Test 1");
		}
		super.tick();
	}

Kenmod.debugString("Test 1");

is only called once.

And there is this:

	@Override
	public void startExecuting() {
		this.closeDoorTemporisation = 60;
		KenmodMain.debugString("Test 0");
		this.toggleDoor(true);
	}

Which is meant to set closeDoorTemporisation to 60.

Does this mean that tick() is not being called properly?

Quote

December 4, 20195 yr

Author

1 minute ago, diesieben07 said:

That's not what I meant by "use the debugger".

I know, but by using this, I found a clue as to what might be going wrong.

Quote

December 4, 20195 yr

Author

Fixed it:

package com.kenneth.hard_survival_craft.objects.new_ai.goal;

import com.kenneth.hard_survival_craft.KenmodMain;
import com.kenneth.hard_survival_craft.objects.blocks.construction.CabinDoor;

import net.minecraft.block.BlockState;
import net.minecraft.block.DoorBlock;
import net.minecraft.block.material.Material;
import net.minecraft.entity.MobEntity;
import net.minecraft.entity.ai.goal.OpenDoorGoal;
import net.minecraft.pathfinding.GroundPathNavigator;
import net.minecraft.pathfinding.Path;
import net.minecraft.pathfinding.PathPoint;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class CustomDoorGoal extends OpenDoorGoal {
	
	protected MobEntity entity;
	protected BlockPos doorPosition = BlockPos.ZERO;
	protected boolean doorInteract;
	protected boolean opened;
	private int closeDoorTemporisation;
	private final boolean closeDoor;
	   
	public CustomDoorGoal(MobEntity entityIn, boolean shouldClose) {
		super(entityIn, shouldClose);
		this.entity = entityIn;
		this.closeDoor = shouldClose;
		if (!(entityIn.getNavigator() instanceof GroundPathNavigator)) {
			throw new IllegalArgumentException("Unsupported mob type for DoorInteractGoal");
		}
	}
	@Override
	public boolean shouldExecute() {
		if(!this.entity.collidedHorizontally) {
			return false;
		} else {
			GroundPathNavigator groundPathNavigator = (GroundPathNavigator)this.entity.getNavigator();
			Path path = groundPathNavigator.getPath();
			if(path != null && !path.isFinished() && groundPathNavigator.getEnterDoors()) {
				for(int i = 0; i < Math.min(path.getCurrentPathIndex() + 2, path.getCurrentPathLength()); ++i) {
					PathPoint pathpoint = path.getPathPointFromIndex(i);
					this.doorPosition = new BlockPos(pathpoint.x, pathpoint.y + 1, pathpoint.z);
					if (!(this.entity.getDistanceSq((double)this.doorPosition.getX(), this.entity.posY, (double)this.doorPosition.getZ()) > 2.25D)) {
						this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
						if (this.doorInteract) {
							return true;
						}
					}
				}
				this.doorPosition = (new BlockPos(this.entity)).up();
	            this.doorInteract = func_220695_a(this.entity.world, this.doorPosition);
	            return this.doorInteract;
			} else {
				return false;
			}
		}
	}
	@Override
	public boolean shouldContinueExecuting() {
		boolean test = this.closeDoor && this.closeDoorTemporisation > 0;
		KenmodMain.debugString("Should Continue: " + test);
		return test;
	}
	@Override
	public void startExecuting() {
		this.closeDoorTemporisation = 60;
		KenmodMain.debugString("Test 0");
		this.toggleDoor(true);
	}
	@Override
	protected void toggleDoor(boolean open) {
		if (this.doorInteract) {
			BlockState blockstate = this.entity.world.getBlockState(this.doorPosition);
			if (blockstate.getBlock() instanceof DoorBlock) {
				((DoorBlock)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			} else if (blockstate.getBlock() instanceof CabinDoor){
				((CabinDoor)blockstate.getBlock()).toggleDoor(this.entity.world, this.doorPosition, open);
			}
		}
	}
	@Override
	public void tick() {
		if(this.closeDoorTemporisation > 0) {
			--this.closeDoorTemporisation;
			KenmodMain.debugString("Test 1");
		}
		KenmodMain.debugString("Test 2");
		super.tick();
	}
	@Override
	public void resetTask() {
		this.toggleDoor(false);
	}
	public static boolean func_220695_a(World p_220695_0_, BlockPos p_220695_1_) {
		BlockState blockstate = p_220695_0_.getBlockState(p_220695_1_);
		return (blockstate.getBlock() instanceof DoorBlock || blockstate.getBlock() instanceof CabinDoor) && blockstate.getMaterial() == Material.WOOD;
	}
}

Change:

	@Override
	public boolean shouldContinueExecuting() {
		return this.closeDoor && this.closeDoorTemporisation > 0 && super.shouldContinueExecuting();
	}

To:

	@Override
	public boolean shouldContinueExecuting() {
		return this.closeDoor && this.closeDoorTemporisation > 0;
	}

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/78456-1144-make-villagers-zombies-recognize-new-type-of-door/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

tysm

By ilov3gam3z · 6 minutes ago6 min
Orbital strike cannon fishing rod mod

was focused on school so didnt respond u think ur gonna get 1.21+ done by this week? @FoxyWoxy

By Astoxy · 7 hours ago7 hr
How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · 18 hours ago18 hr
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Yesterday at 12:07 AM1 day
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Wednesday at 04:08 PM2 days

Sign In

[1.14.4] Make villagers / zombies recognize new type of door?

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

Orbital strike cannon fishing rod mod

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)