Jump to content

[1.15.2 - Adding NBT tag to item is not working]


OrangeVillager61

Recommended Posts

Hello! In my code, I am trying to add an nbt tag when an item is taken from my machine. Problem is that the item is not getting the tag, which I know due to how the machine doesn't accept items that have the tag set to a certain value.

 

(Condensed code)

 

public class EnhancementContainer extends Container{   
	public void updateRepairOutput() {
	      ItemStack itemstack = this.inputSlots.getStackInSlot(0);
	      if (itemstack.isEmpty()) {
	         this.outputSlot.setInventorySlotContents(0, ItemStack.EMPTY);
	      } else {
	    	  	 ItemStack itemstack1 = EnhancementContainer.this.inputSlots.getStackInSlot(0);
		         ItemStack itemstack2 = EnhancementContainer.this.inputSlots.getStackInSlot(1);
		         CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag("has_bee_venom");
		         boolean has_venom = nbtvenom.getBoolean("has_bee_venom");
	             if (!itemstack2.isEmpty() && itemstack2.getCount() > 0 && !has_venom == true && itemstack2.getItem() == ItemList.bee_venom) {
	          	   if(itemstack2.getCount() > 0 && itemstack2.getCount() < 4)
	          	   {	                 
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean("has_bee_venom", true);
		                 nbt.putInt("bee_venom_strength", itemstack2.getCount());
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	          	   else {
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean("has_bee_venom", true);
		                 nbt.putInt("bee_venom_strength", 1);
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	             }
	      }
	   }
}

 

Link to comment
Share on other sites

7 hours ago, diesieben07 said:

1.13 brought the flattening, you should prefer separate items rather than NBT tags.

So your "has been venom" should be a separate item.

 

Please use IItemHandler instead of IInventory.

Why are you calling ItemStack#write? This doesn't make any sense in this context, especially with how you are using it.

The problem is that you don't clone the ItemStack, so you have the same stack in multiple slots.

Regarding the separate items and tags, I am trying to add data to items, in case, add bee venom to weapons so that they deal poison damage on hit (handled in an event). Should I use a capability instead of nbt tags and if so, how do I attach the capability to items in this container?

 

Thanks for letting me know to get rid of write, switch IItemHandler, and clone the itemstack I'll definitely go do so.

Link to comment
Share on other sites

26 minutes ago, diesieben07 said:

I meant the "has_bee_venom" tag should be handled via two separate items.

The bee_venom_strength is fine in NBT.

 

Also consider prefixing your NBT tags with your ModID to avoid collisions.

I'll definitely prefix the NBT tags, but what exactly do you mean by handling the boolean tag with two separate items? 

Link to comment
Share on other sites

Alright, so I started implementing the changes, but copying the itemstack still doesn't solve the problem of the tag not applying: (Still trying to figure out how to implement the itemhandler so that's not in yet)

 

public void updateRepairOutput() {
	      ItemStack itemstack = this.inputSlots.getStackInSlot(0);
	      if (itemstack.isEmpty()) {
	         this.outputSlot.setInventorySlotContents(0, ItemStack.EMPTY);
	      } else {
	    	  	 ItemStack itemstack1 = EnhancementContainer.this.inputSlots.getStackInSlot(0).copy();
		         ItemStack itemstack2 = EnhancementContainer.this.inputSlots.getStackInSlot(1);
		         CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag(MoDrops.modid + "has_bee_venom");
		         boolean has_venom = nbtvenom.getBoolean(MoDrops.modid + "has_bee_venom");
	             if (!itemstack2.isEmpty() && itemstack2.getCount() > 0 && !has_venom == true && itemstack2.getItem() == ItemList.bee_venom) {
	          	   if(itemstack2.getCount() > 0 && itemstack2.getCount() < 4)
	          	   {	                 
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean(MoDrops.modid + "has_bee_venom", true);
		                 nbt.putInt(MoDrops.modid + "bee_venom_strength", itemstack2.getCount());
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	          	   else {
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean(MoDrops.modid + "has_bee_venom", true);
		                 nbt.putInt(MoDrops.modid + "bee_venom_strength", 1);
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	             }
	      }
	   }

 

Edited by OrangeVillager61
Link to comment
Share on other sites

35 minutes ago, diesieben07 said:

Cloned the repo, put the "bone pickaxe" and "bee venom" into the container, took out the pickaxe.

Resulting pickaxe itemstack has the tag as can be seen in the player data:

image.thumb.png.a73329b7ed0ba046e0f34229e44318c8.png

 

Please debug properly before asking for help...

 

Oh, that's how you debugged it? I debugged it by checking the boolean has_venom below:

CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag(MoDrops.modid + "has_bee_venom");
boolean has_venom = nbtvenom.getBoolean(MoDrops.modid + "has_bee_venom");                 
MoDrops.logger.debug(has_venom);

I (clearly falsely) assumed that if it was there, it would pass that check. Since the tag is there how would I access the tag correctly?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I've been trying to make a mod pack for the last day or so now and I haven't been able to launch it once even with all mods disabled. It keeps showing up with Exit Code 1. I gave the modpack to a friend to try and it didn't launch on their pc either due to the same exit code, so I'm not entirely certain what the problem is or how to check it in the logs. So far I've attempted: - Changing from forge version 43.3.0 to 43.3.5 - Downloading Java - Disabling mods (both entirely and individually) I have an NVIDIA GeForce GTX 1070 driver, and I haven't tried to uninstall or reinstall it yet because I'm not certain how to and would have to mess anything up further. I have the latest .txt file of the crash report here: [16:24:34] [main/WARN]: Failed to add PDH Counter: \Paging File(_Total)\% Usage, Error code: 0xC0000BB8 [16:24:34] [main/WARN]: Failed to add counter for PDH counter: \Paging File(_Total)\% Usage [16:24:34] [main/WARN]: Disabling further attempts to query Paging File. [16:24:36] [main/WARN]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile [16:24:39] [Datafixer Bootstrap/INFO]: 198 Datafixer optimizations took 149 milliseconds [16:24:40] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD] [16:24:40] [Render thread/INFO]: Setting user: CatDoodlee [16:24:41] [Render thread/INFO]: Backend library: LWJGL version 3.3.2+13 [16:24:42] [Render thread/INFO]: Reloading ResourceManager: vanilla [16:24:42] [Worker-Main-11/INFO]: Found unifont_all_no_pua-15.1.04.hex, loading [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [16:24:44] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Speakers (Atrix Wired Elite Headset) [16:24:44] [Render thread/INFO]: Sound engine started [16:24:44] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas [16:24:44] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [16:24:45] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [16:24:45] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas [16:24:45] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [16:24:45] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [16:24:45] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas [16:25:41] [Render thread/INFO]: Stopping! any form of help is greatly appreciated ❤️
    • Tanks for answer, I added SleepTight and I removed Modernfix, but it still crashing: new log new crash log
    • Hi, I'm trying to hide specific vanilla effects such as levitation or slow falling from the inventory GUI, but I haven't been able to figure out how to do this. I need this because they are triggered by another effect and I don't need them all showing up. Unfortunately, I don't know of any mods that include this feature, and I couldn't find any documentation on the process. I've already looked into the IClientMobEffectExtensions interface, but I'm uncertain about how to implement it in my own effect, let alone in any existing vanilla effect. Please help I am using Forge 47.2.0. for Minecraft 1.20.1
    • Also wondering how to create these manually.  First time creating a forge server.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.