Jump to content

Recommended Posts

Posted

Hello! In my code, I am trying to add an nbt tag when an item is taken from my machine. Problem is that the item is not getting the tag, which I know due to how the machine doesn't accept items that have the tag set to a certain value.

 

(Condensed code)

 

public class EnhancementContainer extends Container{   
	public void updateRepairOutput() {
	      ItemStack itemstack = this.inputSlots.getStackInSlot(0);
	      if (itemstack.isEmpty()) {
	         this.outputSlot.setInventorySlotContents(0, ItemStack.EMPTY);
	      } else {
	    	  	 ItemStack itemstack1 = EnhancementContainer.this.inputSlots.getStackInSlot(0);
		         ItemStack itemstack2 = EnhancementContainer.this.inputSlots.getStackInSlot(1);
		         CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag("has_bee_venom");
		         boolean has_venom = nbtvenom.getBoolean("has_bee_venom");
	             if (!itemstack2.isEmpty() && itemstack2.getCount() > 0 && !has_venom == true && itemstack2.getItem() == ItemList.bee_venom) {
	          	   if(itemstack2.getCount() > 0 && itemstack2.getCount() < 4)
	          	   {	                 
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean("has_bee_venom", true);
		                 nbt.putInt("bee_venom_strength", itemstack2.getCount());
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	          	   else {
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean("has_bee_venom", true);
		                 nbt.putInt("bee_venom_strength", 1);
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	             }
	      }
	   }
}

 

Posted
7 hours ago, diesieben07 said:

1.13 brought the flattening, you should prefer separate items rather than NBT tags.

So your "has been venom" should be a separate item.

 

Please use IItemHandler instead of IInventory.

Why are you calling ItemStack#write? This doesn't make any sense in this context, especially with how you are using it.

The problem is that you don't clone the ItemStack, so you have the same stack in multiple slots.

Regarding the separate items and tags, I am trying to add data to items, in case, add bee venom to weapons so that they deal poison damage on hit (handled in an event). Should I use a capability instead of nbt tags and if so, how do I attach the capability to items in this container?

 

Thanks for letting me know to get rid of write, switch IItemHandler, and clone the itemstack I'll definitely go do so.

Posted
26 minutes ago, diesieben07 said:

I meant the "has_bee_venom" tag should be handled via two separate items.

The bee_venom_strength is fine in NBT.

 

Also consider prefixing your NBT tags with your ModID to avoid collisions.

I'll definitely prefix the NBT tags, but what exactly do you mean by handling the boolean tag with two separate items? 

Posted (edited)

Alright, so I started implementing the changes, but copying the itemstack still doesn't solve the problem of the tag not applying: (Still trying to figure out how to implement the itemhandler so that's not in yet)

 

public void updateRepairOutput() {
	      ItemStack itemstack = this.inputSlots.getStackInSlot(0);
	      if (itemstack.isEmpty()) {
	         this.outputSlot.setInventorySlotContents(0, ItemStack.EMPTY);
	      } else {
	    	  	 ItemStack itemstack1 = EnhancementContainer.this.inputSlots.getStackInSlot(0).copy();
		         ItemStack itemstack2 = EnhancementContainer.this.inputSlots.getStackInSlot(1);
		         CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag(MoDrops.modid + "has_bee_venom");
		         boolean has_venom = nbtvenom.getBoolean(MoDrops.modid + "has_bee_venom");
	             if (!itemstack2.isEmpty() && itemstack2.getCount() > 0 && !has_venom == true && itemstack2.getItem() == ItemList.bee_venom) {
	          	   if(itemstack2.getCount() > 0 && itemstack2.getCount() < 4)
	          	   {	                 
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean(MoDrops.modid + "has_bee_venom", true);
		                 nbt.putInt(MoDrops.modid + "bee_venom_strength", itemstack2.getCount());
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	          	   else {
	          		   CompoundNBT nbt = itemstack1.getOrCreateTag();
		                 nbt.putBoolean(MoDrops.modid + "has_bee_venom", true);
		                 nbt.putInt(MoDrops.modid + "bee_venom_strength", 1);
		                 itemstack1.write(nbt);
		                 itemstack1.setTag(nbt);
		                 EnhancementContainer.this.outputSlot.setInventorySlotContents(1, itemstack1);
	          	   }
	             }
	      }
	   }

 

Edited by OrangeVillager61
Posted
35 minutes ago, diesieben07 said:

Cloned the repo, put the "bone pickaxe" and "bee venom" into the container, took out the pickaxe.

Resulting pickaxe itemstack has the tag as can be seen in the player data:

image.thumb.png.a73329b7ed0ba046e0f34229e44318c8.png

 

Please debug properly before asking for help...

 

Oh, that's how you debugged it? I debugged it by checking the boolean has_venom below:

CompoundNBT nbtvenom = itemstack1.getOrCreateChildTag(MoDrops.modid + "has_bee_venom");
boolean has_venom = nbtvenom.getBoolean(MoDrops.modid + "has_bee_venom");                 
MoDrops.logger.debug(has_venom);

I (clearly falsely) assumed that if it was there, it would pass that check. Since the tag is there how would I access the tag correctly?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
    • https://paste.ee/p/h1JX9bbl
    • Add the latest.log from your logs-folder
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.