Search the Forums BEFORE making a new post.

[Solved] [1.14.4] NPE while generating structure

Posted February 23, 20205 yr

Hello,

I had a problem while Minecraft is trying to generate my structure (located in : "data/skillsstones/structures/"), the game produce a Null Pointer Exception, here is the entire error :

Spoiler


[17:43:31] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception
net.minecraft.crash.ReportedException: Exception generating new chunk
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:833) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:764) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:112) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:622) [?:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_221] {}
Caused by: java.lang.NullPointerException
	at net.minecraft.world.gen.feature.template.Template.func_215388_b(Template.java:541) ~[?:?] {re:classloading}
	at net.minecraft.world.gen.feature.structure.TemplateStructurePiece.setup(SourceFile:46) ~[?:?] {re:classloading}
	at com.zeide.skillsstones.common.generation.feature.NaturalTotemPiece.loadStructure(NaturalTotemPiece.java:51) ~[?:?] {re:classloading}
	at com.zeide.skillsstones.common.generation.feature.NaturalTotemPiece.<init>(NaturalTotemPiece.java:32) ~[?:?] {re:classloading}
	at com.zeide.skillsstones.common.generation.feature.NaturalTotemStructure$Start.init(NaturalTotemStructure.java:68) ~[?:?] {re:classloading}
	at net.minecraft.world.gen.ChunkGenerator.initStructureStarts(ChunkGenerator.java:162) ~[?:?] {re:classloading}
	at net.minecraft.world.chunk.ChunkStatus.lambda$static$2(ChunkStatus.java:41) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.chunk.ChunkStatus.func_223198_a(ChunkStatus.java:196) ~[?:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.server.ChunkManager.lambda$null$17(ChunkManager.java:509) ~[?:?] {re:classloading}
	at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-2.0.24.jar:?] {}
	at net.minecraft.world.server.ChunkManager.lambda$func_223156_b$19(ChunkManager.java:507) ~[?:?] {re:classloading}
	at java.util.concurrent.CompletableFuture.uniCompose(CompletableFuture.java:952) ~[?:1.8.0_221] {}
	at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:926) ~[?:1.8.0_221] {}
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442) ~[?:1.8.0_221] {}
	at net.minecraft.world.chunk.ChunkTaskPriorityQueueSorter.func_219083_b(SourceFile:58) ~[?:?] {re:classloading}
	at net.minecraft.util.concurrent.DelegatedTaskExecutor.driveOne(SourceFile:83) ~[?:?] {re:classloading}
	at net.minecraft.util.concurrent.DelegatedTaskExecutor.driveWhile(SourceFile:123) ~[?:?] {re:classloading}
	at net.minecraft.util.concurrent.DelegatedTaskExecutor.run(SourceFile:91) ~[?:?] {re:classloading}
	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) ~[?:1.8.0_221] {}
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_221] {}
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_221] {}
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) ~[?:1.8.0_221] {}
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[?:1.8.0_221] {}
[17:43:31] [Server thread/ERROR] [minecraft/MinecraftServer]: This crash report has been saved to: D:\Developpement\Java\Minecraft\Mod\Skills Stones\run\.\crash-reports\crash-2020-02-23_17.43.31-server.txt

Here is my Structure Piece :

Spoiler


import com.zeide.skillsstones.SkillsStones;
import com.zeide.skillsstones.common.generation.StructureGeneration;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MutableBoundingBox;
import net.minecraft.world.IWorld;
import net.minecraft.world.gen.feature.structure.TemplateStructurePiece;
import net.minecraft.world.gen.feature.template.BlockIgnoreStructureProcessor;
import net.minecraft.world.gen.feature.template.PlacementSettings;
import net.minecraft.world.gen.feature.template.Template;
import net.minecraft.world.gen.feature.template.TemplateManager;

import java.util.Random;

public class NaturalTotemPiece extends TemplateStructurePiece {

    public NaturalTotemPiece(TemplateManager templateManager) {

        super(StructureGeneration.NATURAL_TOTEM_PIECE, 0);

        loadStructure(templateManager);

    }

    public NaturalTotemPiece(TemplateManager templateManager, CompoundNBT compoundNBT) {

        super(StructureGeneration.NATURAL_TOTEM_PIECE, compoundNBT);

        loadStructure(templateManager);

    }

    private void loadStructure(TemplateManager templateManager) {

        Template template = templateManager.getTemplateDefaulted(new ResourceLocation(SkillsStones.MOD_ID, "natural_totem"));
        PlacementSettings placementSettings = new PlacementSettings().setIgnoreEntities(true).addProcessor(BlockIgnoreStructureProcessor.STRUCTURE_BLOCK);

        setup(template, templatePosition, placementSettings);

    }

    @Override
    protected void handleDataMarker(String s, BlockPos blockPos, IWorld iWorld, Random random, MutableBoundingBox mutableBoundingBox) {}
}

Here is my Structure :

Spoiler


import com.mojang.datafixers.Dynamic;
import net.minecraft.util.math.MutableBoundingBox;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.gen.ChunkGenerator;
import net.minecraft.world.gen.feature.NoFeatureConfig;
import net.minecraft.world.gen.feature.structure.ScatteredStructure;
import net.minecraft.world.gen.feature.structure.Structure;
import net.minecraft.world.gen.feature.structure.StructureStart;
import net.minecraft.world.gen.feature.template.TemplateManager;

import java.util.function.Function;

public class NaturalTotemStructure extends ScatteredStructure<NoFeatureConfig> {

    public NaturalTotemStructure(Function<Dynamic<?>, ? extends NoFeatureConfig> feature) {

        super(feature);

    }

    @Override
    protected int getSeedModifier() {

        return 165745296;

    }

    @Override
    public IStartFactory getStartFactory() {

        return Start::new;

    }

    @Override
    public String getStructureName() {

        return "natural_totem";

    }

    @Override
    public int getSize() {

        return 8;

    }

    public static class Start extends StructureStart {

        Start(Structure<?> structureIn, int p_i50515_2_, int p_i50515_3_, Biome p_i50515_4_, MutableBoundingBox p_i50515_5_, int p_i50515_6_, long p_i50515_7_) {
            super(structureIn, p_i50515_2_, p_i50515_3_, p_i50515_4_, p_i50515_5_, p_i50515_6_, p_i50515_7_);
        }

        @Override
        public void init(ChunkGenerator<?> generator, TemplateManager templateManagerIn, int chunkX, int chunkZ, Biome biomeIn) {

            NaturalTotemPiece naturalTotemPiece  = new NaturalTotemPiece(templateManagerIn);

            this.components.add(naturalTotemPiece);
            this.recalculateStructureSize();

        }

    }

}

Finally here is where i'm registering all : (I call initStructurePieceType() and createFeatures() in an other class)

Spoiler


import com.zeide.skillsstones.SkillsStones;
import com.zeide.skillsstones.common.generation.feature.NaturalTotemPiece;
import com.zeide.skillsstones.common.generation.feature.NaturalTotemStructure;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.registry.Registry;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.gen.GenerationStage;
import net.minecraft.world.gen.feature.Feature;
import net.minecraft.world.gen.feature.IFeatureConfig;
import net.minecraft.world.gen.feature.NoFeatureConfig;
import net.minecraft.world.gen.feature.structure.IStructurePieceType;
import net.minecraft.world.gen.feature.structure.Structure;
import net.minecraft.world.gen.placement.IPlacementConfig;
import net.minecraft.world.gen.placement.Placement;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.ForgeRegistries;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = SkillsStones.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
@ObjectHolder(SkillsStones.MOD_ID)
public class StructureGeneration {

    public static IStructurePieceType NATURAL_TOTEM_PIECE;

    @ObjectHolder(SkillsStones.MOD_ID + ":natural_totem")
    public static Structure<NoFeatureConfig> NATURAL_TOTEM_FEATURE;

    @SubscribeEvent
    public static void registerFeature(RegistryEvent.Register<Feature<?>> event) {

        event.getRegistry().register(new NaturalTotemStructure(NoFeatureConfig::deserialize).setRegistryName("skillsstones:natural_totem"));

    }

    public static void initStructurePieceType() {

        NATURAL_TOTEM_PIECE = Registry.register(Registry.STRUCTURE_PIECE, new ResourceLocation(SkillsStones.MOD_ID, "natural_totem"), NaturalTotemPiece::new);

    }

    public static void createFeatures() {

        for(Biome biome : ForgeRegistries.BIOMES) {

            if(biome.getCategory() != Biome.Category.NETHER && biome.getCategory() != Biome.Category.THEEND) {

                biome.addStructure(NATURAL_TOTEM_FEATURE, IFeatureConfig.NO_FEATURE_CONFIG);
                biome.addFeature(GenerationStage.Decoration.SURFACE_STRUCTURES, Biome.createDecoratedFeature(NATURAL_TOTEM_FEATURE, IFeatureConfig.NO_FEATURE_CONFIG, Placement.NOPE, IPlacementConfig.NO_PLACEMENT_CONFIG));

            }

        }

    }

}

Last thing, i saw that Minecraft use the seed modifier : "165745296". So, I use it but I don't know what does it change.

Also, I want to my structure be really really rare and i don't know how can I do this.

Thanks a lot.

EDIT :

I forgot to provide BlockPos with my Structure Piece.

Edited February 24, 20205 yr by Zeide

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/81209-solved-1144-npe-while-generating-structure/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

Well, needing help for this didn't last nearly as long as I expected, lol. I figured out the solution, and it's a real face palmer. Basically, the function Type.getInternalName(Class<?> clazz) does NOT work for classes that are obfuscated. This means that it won't work for basically every minecraft class. So running it with the argument EntityTrackerEntry.class won't work, but running it with CustomHandler.class will work! Annoying, but a still bit interesting. So I just replaced my call for Type.getInternalName(EntityTrackerEntry.class) with just "os", as that is the name of the actual class for EntityTrackerEntry at runtime. Hope this solution helps somebody. In the meantime, I'm going to mark this thread as solved.

By Jackson Perr · 1 hour ago1 hr
[1.20.1] Custom Effect Help

Can you send the code pertaining to your custom mod effect? I don't see anything wrong with how you "assemble" the food properties, btw.

By Jackson Perr · 3 hours ago3 hr
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

crazy

By Jonathing · 3 hours ago3 hr
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

For anyone who is running into this issue in the future: The fix for me was updating Intellij. I was using the 2022 version, which apparently had some issues with Java 21 (particularly around enums, which Direction is one).

By CravenCraft · 3 hours ago3 hr
How do you add a mob to spawn around a existing vanilla structure?

Hey dawg!

I think I might be able to help you out with your issue here. I say might because I don't know about 1.16.x or any later version, but I know how to do this kind of thing for 1.12.2 forge. Basically, in the pre-init or init (I don't really remember which one) you just gotta'

Okay, ykw, I just downloaded the 1.14.4 1.20.1 minecraft mdk. I think I actually can help you here. So, the 1.12.2 method actually doesn't work with 1.20.1 minecraft or later. Probably not too far before either. I see two options here for ya':

First, it's important to note that the game stores its spawn data for structures in, well, the Structures class. Here, the game initializes an instance of each Structure class and registers them with the BootstrapContext using its bootstrap function. Each instance of a Structure class is registered with a StructureSettings class as an argument. One of the arguments, the one that you're probably going to be particularly interested in here, would be the spawnOverrides argument. For this argument, the game uses a Map between MOB_CATEGORIES and StructureSpawnOverride. StructureSpawnOverride is essentially the juice of it here. It contains almost everything you would need to control how your custom mob spawns in Pillager Outposts. Now, if you want to change how the Structure class for the pillager outposts is registered with the BootstrapContext in the bootstrap function, you're going to want to change where the function's caller gets the function and replace it with your own custom version of this function. How might you do this? This is where it gets a little tricky. The bootstrap function for the structures class is referenced in VanillaRegistries.BUILDER. However, unfortunately, this field is private and final, so you can't directly change it with reflections, but you can still access it with reflections. Now the VanillaRegistries.BUILDER field is of the type RegistrySetBuilder, which uses a private final field "entires", which is set as a List<RegistrySetBuilder.RegistryStub<?>> type. So here, you could use reflections to access this list field and remove the entry for the structures bootstrap. Then you might be able to create your own structures class and add change the bootstrap function to reflect the changes you wish. Then finally, simply re-add the Structure entry that you made to the list, and you should be completely done! Keep in mind, I haven't actually tested this, so I'm not sure if it would actually work, and even if it did work it's really unorthodox, so I would recommend trying this next idea.

When the game is deciding whether or not to spawn an entity, if the entity is registered with the SpawnPlacements class, is uses the function you specify in the entity class to determine whether or not the entity can spawn in a certain spot. For example, the guardian cannot spawn on a block that is exposed to light from underwater because of this function. So what you could do is make a checkSelfSpawnRules function for your mob and register it with the SpawnPlacements function. Then, you could have your checkSelfSpawnRules function take into account if the block it's trying to spawn on is near a Pillager Outpost. Finally, you can get the coordinates to the chunk of your block and iterate through the ServerLevels in your MinecraftServer class and get their chunk sources and test if the chunk source has the chunk of your block position. If it does, you can then get the StructureManager from the ServerLevel. In there should be some very helpful functions for you to use. Although this is a bit more orthodox, it might be a bit laggy.

It's really up to you which of these options you choose. If you need some additional clarification then please let me know, I would be happy to help you out! Also let me know if any of these options hit your goals for what your looking for here or not. If not then just let me know; I could probably find another method you could try.

By Jackson Perr · 4 hours ago4 hr

Jackson Perr

Sign In

[Solved] [1.14.4] NPE while generating structure

Featured Replies

Join the conversation

Posts

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

[1.20.1] Custom Effect Help

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

How do you add a mob to spawn around a existing vanilla structure?

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)