[1.15.2] How to add a camera zoom like vanilla bow on aim?

[Torq]

I'm trying to add a long bow, as in the better archery 1.6.3 (last) mod. The versions are very different, which greatly complicates the study of its source code. I added my class ModBowItem inheriting from ShootableItem. It almost completely repeats Vanilla BowItem, but allows you to adjust the damage, arrow speed and pull time. The item has a model, texture (temporarily from the original mod).

It is necessary: add a camera zoom when aiming, like vanilla bow; repair enchantments.

What I would like from you: tell me which classes are responsible for these functions or better attach the examples, because I could not find; if I'm doing something wrong (anywhere in the mod), tell me about it.

 

I'm tired of decompiling mods for clues ...

I cannot inherit from BowItem, because in it the method of calculating velocity is static and I can’t access the properties of the class in it.

REPOSITORY

[Torq]

Perhaps the net.minecraft.client.renderer.FirstPersonRenderer class is responsible for this. Line 260, renderItemInFirstPerson (-) method. Line 330 Case: BOW
How can I replace the renderer with my own? Is there a corresponding event in which I could replace the renderer? What do i need to do? I am still not sure if this is what I am looking for. But I would like to try to duplicate this case for my longbow and see the result. But I do not know how to make the game use my renderer.

[Torq]

The bow has a getUseAction (ItemStack stack) method that returns an action that switches the case to renderItemInFirstPerson (-) net.minecraft.client.renderer.FirstPersonRenderer. My class, like the vanilla bow, returns the bow action, but the renderer does not change the field of view for some reason. Perhaps the case does not work, I will try to check it. Any ideas?

[Torq]

This thing works correctly, it turns the bow in the hand when pulling. You can change the action on NONE and make sure. I continue to search further. I hope my monologue will help someone in the future.

I'm still waiting for a clue which event will help me replace the renderer (for the future).

Edited March 25, 2020 by Torq

[_Bedrockbreaker_]

Looking at some old (1.12.2) code from redstoneflux, I traced its fov changes back to cofhcore. In there, they subscribe to the FOVUpdateEvent, and test if the active itemstack's item is an instance of their modded bow. The event given by the subscription has a method to setNewFov, where they take the current fov, and subtract off (the bow's "progress" (how far the bow is pulled back) squared, times an arbitrary modifier, aka "zoom").

Hopefully this transfers over to 1.15 more easily, but even if it doesn't, that should at least provide some more insight about what to do.

 

related links:
FOVUpdateEvent:
https://github.com/CoFH/CoFHCore/blob/dbab6db4bfa90dd0a4bb801330620dc34a0392a9/src/main/java/cofh/core/proxy/EventHandlerClient.java

Bow:
https://github.com/CoFH/CoFHCore/blob/1.12/src/main/java/cofh/core/item/tool/ItemBowCore.java

Edited March 25, 2020 by _Bedrockbreaker_
Added links for info

[Torq]

Their method doesn’t work, I don’t understand why ... I recorded changes in the repository, you can see the history of changes in the github so that you don’t look for a long time. It will also help you quickly compare my code and theirs.

 

Edited March 26, 2020 by Torq

[_Bedrockbreaker_]

The link you posted is invalid, and I can't find any relevant repo from that github account.

[Torq]

For some reason, the repository was closed ... It used to be a paid option, but now no) I opened the repository and checked access from another device (not logged in).

upd*  I forgot to add annotations over classes. The event in which the ore is recorded works again. The field of view update event does not work, the logger does not write anything (I deleted it in the commit).
EventHandler
Bow
FOV Update Interface

Edited March 26, 2020 by Torq
update info

[Torq]

I found vanilla code in AbstractClientPlayerEntity line124 getFovModifier. I checked the calls of vanilla methods in a chain, an event is generated at the end, but the method that is subscribed to this event does not work ...

[Alpvax]

If you are subscribing the events to the class, the methods have to be static (there is no instance to access the methods on).

[Torq]

I thought that was the point. For a long time I did not practice programming with normal object orientation programming (hello python). In CoFHCore 1.12, the methods are not static, I thought so. There was an idea that the problem is the lack of an instance, but I can’t think it through to the end. I changed the method to static, it still does not work) I inserted a line with a logger, but there is nothing in the log.

[Alpvax]

Just checked, you're listening to the wrong event bus. You want the Forge bus, not the Mod one. (bus = Mod.EventBusSubscriber.Bus.FORGE)

[Torq]

Why then in the TorqMod class ore is registered? Is the correct event bus there?

TorqMod

Edited March 26, 2020 by Torq

[Alpvax]

Registry events (and lifecycle events, config events etc.) are fired on the mod bus (anything to do with your mod).

Game events (player interaction, damage, crafting etc.) are fired on the forge bus.

 

If you aren't sure, it usually tells you which bus to use in the javadoc for the event.

Edited March 26, 2020 by Alpvax

[Torq]

I tried changing the bus and the method to static, but separately, this did not work)) Thank you, now everything works, but it moves closer than necessary. I will watch what it is connected with.

Thank you for explaining how event buses differ.