Jump to content

[1.15.2] MilkBucket still hardcoded as universal effect cure (Forge Bug)


Recommended Posts

EDIT: Created a pull request https://github.com/MinecraftForge/MinecraftForge/pull/6609




Not sure if I found a forge bug. Ill just elaborate:

- The Vanilla Effect class implements the Forge IForgeEffect interface

- IForgeEffect interface has a method "getCurativeItems" which returns a list of item stacks which cure the effect

- This has a default implementation containing only the milk bucket

- The MilkBucketItem class then appropriately calls the method which checks if it cures each effect and then removes it only if applicable

- So far so good

- Now here is the problem: In the same method it also calls a method which removes all potion effects regardless, kinda negating everything from above. Latest 1.15.2 version of forge


The code mentioned:

Inside MilkBucketItem::onItemUseFinish

Correct first call: LivingEntity::curePotionEffects

Unnecessary (I guess) call: LivingEntity::clearActivePotions

Edited by CAS_ual_TY
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.