Jump to content

Minecraft 1.12.2 Positioned Looping sound randomly stops


Hypherion

Recommended Posts

Hi Guys

 

I have a custom PositionedSound class in my mod with repeat set to true. The loop works, but sometimes it only plays for about 3 seconds then stops and other times it will play for 10+ seconds then stop. The sound also doesn't seamlessly loop. It's got some kind of gap in the loop, even though the loop is seamless and plays fine in Audacity

 

Below are my codes:

 

The PositionedSound class: 

 

@SideOnly(Side.CLIENT)
public class InverterLoop extends PositionedSound {

    private final TileEntityUPSInverter tileEntity;
    private final World world;
    private final BlockPos pos;
    private boolean donePlaying = false;

    public InverterLoop(TileEntityUPSInverter tile) {
        super(SoundsHandler.ENTITY_INVERTER_FAN, SoundCategory.BLOCKS);
        this.tileEntity = tile;

        this.world = tile.getWorld();
        this.pos = tile.getPos();

        this.xPosF = tile.getPos().getX();
        this.yPosF = tile.getPos().getY();
        this.zPosF = tile.getPos().getZ();


        this.attenuationType = AttenuationType.LINEAR;
        this.volume = 0.5f;
        this.pitch = 1.0f;

        this.repeat = true;
        this.repeatDelay = 0;


    }
}

 

This is the class that controls the loop:

 

@SideOnly(Side.CLIENT)
public class UPSSounds {
    private static final Map<BlockPos, PositionedSound> sounds = new HashMap<>();

    public static SoundEvent startSound;
    public static SoundEvent loopSound;
    public static SoundEvent stopSound;
    
    public static void init() {
        startSound = SoundsHandler.ENTITY_INVERTER_START;
        loopSound = SoundsHandler.ENTITY_INVERTER_FAN;
        stopSound = SoundsHandler.ENTITY_INVERTER_STOP;
    }

    private static SoundEvent registerSound(IForgeRegistry<SoundEvent> registry, ResourceLocation sound) {
        SoundEvent event = new SoundEvent(sound).setRegistryName(sound);
        registry.register(event);
        return event;
    }

    public static void stopSound(TileEntityUPSInverter tile, BlockPos pos) {

        if (sounds.containsKey(pos)) {
            PositionedSound movingSound = sounds.get(pos);
            FMLClientHandler.instance().getClient().getSoundHandler().stopSound(movingSound);
            sounds.remove(pos);
        }
    }

    private static void playSound(TileEntityUPSInverter tile, BlockPos pos, PositionedSound sound) {
        stopSound(tile, pos);
        FMLClientHandler.instance().getClient().getSoundHandler().playSound(sound);
        sounds.put(pos, sound);
    }
    
    public static void playStartup(TileEntityUPSInverter tile, BlockPos pos) {
        PositionedSound sound = new InverterStart(tile);
        playSound(tile, pos, sound);
    }

    public static void playLoop(TileEntityUPSInverter tile, BlockPos pos) {
        PositionedSound sound = new InverterLoop(tile);
        playSound(tile, pos, sound);
    }

    public static void playStop(TileEntityUPSInverter tile, BlockPos pos) {
        PositionedSound sound = new InverterStop(tile);
        playSound(tile, pos, sound);
    }

    public static boolean isStartupPlaying(World worldObj, BlockPos pos) {
        PositionedSound movingSound = sounds.get(pos);
        return movingSound instanceof InverterStart;
    }

    public static boolean isLoopPlaying(World worldObj, BlockPos pos) {
        PositionedSound movingSound = sounds.get(pos);
        return movingSound instanceof InverterLoop;
    }

    public static boolean isStopPlaying(World worldObj, BlockPos pos) {
        PositionedSound movingSound = sounds.get(pos);
        return movingSound instanceof InverterStop;
    }
}

 

And the finally this is the code that runs and stops the sounds based on the state of the tile (Called from TileEntity's Update loop (when world is remote):

 

public void handleAudio() {
        if (this.lastState != this.energy.getStte()) {
            if (this.energy.getStte() == 1) {
                if (!this.sounds.isStartupPlaying(world, this.getPos())) {
                    this.sounds.playStartup(this, this.getPos());
                }
                this.lastState = this.energy.getStte();
            } else if (this.energy.getStte() == 2) {
                if (!this.sounds.isLoopPlaying(world, this.getPos())) {
                    this.sounds.playLoop(this, this.getPos());
                }
                System.out.println("IT'S LOOPING!!!");
                this.lastState = this.energy.getStte();
            } else if (this.energy.getStte() == 4) {
                if (!this.sounds.isStopPlaying(world, this.getPos())) {
                    this.sounds.playStop(this, this.getPos());
                }
                this.lastState = this.energy.getStte();
            }
    }

 

 

I have Implemented a ITickableSound on the PositionedSound class and made it write to the debug output whenever the Update event runs. At the moment the audio stops working, the Update event also stops.

 

(Don't mind my naming methods, I just made them up to try to get this thing to work.)

 

I can confirm that handleAudio() is being called on every tick, so my guess is the issue is somewhere in the other classes.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Me and my friend started a server using Better Minecraft and added about 10 mods on top of it. Everything works fine until we hover over any armor item in the game. Doesnt matter what mod its from it just crashes. We can hover over armor in JEI but it just gives us a tooltip error. Here is my crash message after hovering over armor The game crashed whilst rendering screen Error: java.lang.NullPointerException: Registry Object not present: feathers:lightweight Here is my Crash Report https://pastebin.com/FWQ7n3HS
    • I am unable to resolve my current issue, I have successfully downloaded the forge extension. I downloaded the correct Java link with Javafix included. I log into the game and it shows the "forge" launcher active menu. I double checked to make sure it was the right release number of minecraft and it matched the forge download as well, this also including the most recent forge client. The issue is when I go into a new minecraft server it doesn't allow me to do //wand. No matter what I try the same issue is following me, it almost seems as if the client is fully active but something isn't allowing it to run on my computer. I would appreciate some assistance regarding my problem.   Thank you
    • Came here for the same reason. But for me it's the client. After following your instructions with the jar, I ended up with the following error. I assume to have chosen the right jar   -jar "${lminecraft_library_path}/net/minecraftforge/forge/1.20.4-49.0.3/forge-1.20.4-49.0.3-shim.jar"   Minecraft 1.20.4 Forge: 1.20.4 - 49.0.3   ;--- cut here --- [7.633s][info][class,load] cpw.mods.jarhandling.SecureJar$ModuleDataProvider source: file:/home/habibiboy/.minecraft/libraries/net/minecraftforge/securemodules/2.2.7/securemodules-2.2.7.jar [7.636s][info][class,load] java.security.CodeSigner source: jrt:/java.base [7.636s][info][class,load] java.nio.file.spi.FileSystemProvider$1 source: jrt:/java.base [7.637s][info][class,load] java.util.ServiceLoader source: shared objects file [7.639s][info][class,load] java.util.ServiceLoader$ModuleServicesLookupIterator source: shared objects file [7.639s][info][class,load] java.util.Spliterators$ArraySpliterator source: shared objects file [7.640s][info][class,load] java.util.Spliterators$1Adapter source: shared objects file [7.643s][info][class,load] java.util.Arrays$ArrayList source: shared objects file [7.648s][info][class,load] java.util.concurrent.CopyOnWriteArrayList$COWIterator source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$LazyClassPathLookupIterator source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$2 source: shared objects file [7.649s][info][class,load] java.util.ServiceLoader$3 source: shared objects file [7.652s][info][class,load] jdk.internal.module.ModulePatcher$PatchedModuleReader source: jrt:/java.base [7.654s][info][class,load] sun.net.www.protocol.jrt.Handler source: jrt:/java.base [7.663s][info][class,load] jdk.nio.zipfs.ZipFileSystemProvider source: jrt:/jdk.zipfs [7.667s][info][class,load] java.nio.file.FileSystemNotFoundException source: jrt:/java.base [7.672s][info][class,load] jdk.nio.zipfs.ZipFileSystem source: jrt:/jdk.zipfs [7.675s][info][class,load] java.lang.UnsupportedOperationException source: jrt:/java.base [7.676s][info][class,load] java.util.zip.ZipException source: jrt:/java.base [7.677s][info][class,load] java.nio.file.ProviderMismatchException source: jrt:/java.base [7.680s][info][class,load] java.nio.file.AccessMode source: jrt:/java.base [7.681s][info][class,load] java.nio.file.DirectoryStream$Filter source: jrt:/java.base [7.683s][info][class,load] java.nio.file.DirectoryStream source: jrt:/java.base [7.684s][info][class,load] java.nio.file.FileStore source: jrt:/java.base [7.688s][info][class,load] java.util.concurrent.Executor source: shared objects file [7.688s][info][class,load] java.util.concurrent.ExecutorService source: shared objects file [7.690s][info][class,load] java.nio.channels.AsynchronousChannel source: jrt:/java.base [7.690s][info][class,load] java.nio.channels.AsynchronousFileChannel source: jrt:/java.base [7.691s][info][class,load] java.util.ServiceLoader$1 source: shared objects file [7.692s][info][class,load] java.util.ServiceLoader$Provider source: shared objects file [7.692s][info][class,load] java.util.ServiceLoader$ProviderImpl source: shared objects file [7.693s][info][class,load] jdk.internal.reflect.DirectConstructorHandleAccessor source: shared objects file [7.695s][info][class,load] jdk.internal.jrtfs.JrtFileSystemProvider source: jrt:/java.base [7.699s][info][class,load] java.util.Collections$EmptyEnumeration source: shared objects file [7.699s][info][class,load] jdk.internal.loader.BuiltinClassLoader$1 source: shared objects file [7.700s][info][class,load] java.lang.CompoundEnumeration source: shared objects file [7.701s][info][class,load] jdk.internal.loader.URLClassPath$1 source: shared objects file [7.702s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection source: jrt:/java.base [7.710s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection$$Lambda/0x00007f5d70055728 source: sun.net.www.protocol.jrt.JavaRuntimeURLConnection [7.719s][info][class,load] sun.net.www.protocol.jrt.JavaRuntimeURLConnection$1 source: jrt:/java.base [7.720s][info][class,load] jdk.internal.jimage.ImageBufferCache source: jrt:/java.base [7.722s][info][class,load] jdk.internal.jimage.ImageBufferCache$1 source: jrt:/java.base [7.723s][info][class,load] jdk.internal.jimage.ImageBufferCache$2 source: jrt:/java.base [7.724s][info][class,load] java.util.AbstractMap$SimpleEntry source: jrt:/java.base [7.727s][info][class,load] java.util.LinkedHashMap$LinkedKeySet source: jrt:/java.base [7.731s][info][class,load] java.util.LinkedHashMap$LinkedHashIterator source: shared objects file [7.731s][info][class,load] java.util.LinkedHashMap$LinkedKeyIterator source: jrt:/java.base [7.732s][info][class,load] java.util.Collections$UnmodifiableList source: shared objects file [7.732s][info][class,load] java.util.Collections$UnmodifiableRandomAccessList source: shared objects file [7.736s][info][class,load] java.lang.invoke.LambdaForm$DMH/0x00007f5d7000c400 source: __JVM_LookupDefineClass__ [7.741s][info][class,load] cpw.mods.jarhandling.impl.Jar$$Lambda/0x00007f5d7000adb0 source: cpw.mods.jarhandling.impl.Jar [7.746s][info][class,load] cpw.mods.jarhandling.impl.Jar$$Lambda/0x00007f5d7000aff8 source: cpw.mods.jarhandling.impl.Jar [7.748s][info][class,load] java.lang.ExceptionInInitializerError source: jrt:/java.base [7.749s][info][class,load] java.lang.StackTraceElement$HashedModules source: jrt:/java.base [7.751s][info][class,load] java.lang.invoke.WrongMethodTypeException source: jrt:/java.base [7.751s][info][class,load] java.lang.reflect.InvocationTargetException source: jrt:/java.base Exception in thread "main" [7.758s][info][class,load] java.lang.Throwable$PrintStreamOrWriter source: jrt:/java.base [7.759s][info][class,load] java.lang.Throwable$WrappedPrintStream source: jrt:/java.base java.lang.reflect.InvocationTargetException     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)     at java.base/java.lang.reflect.Method.invoke(Method.java:580)     at net.minecraftforge.bootstrap.shim.Main.main(Main.java:94) Caused by: java.lang.ExceptionInInitializerError     at cpw.mods.jarhandling.SecureJar.from(SecureJar.java:64)     at cpw.mods.jarhandling.SecureJar.from(SecureJar.java:60)     at net.minecraftforge.bootstrap.ClassPathHelper.getCleanedClassPathImpl(ClassPathHelper.java:178)     at net.minecraftforge.bootstrap.ClassPathHelper.getCleanedClassPath(ClassPathHelper.java:46)     at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:28)     at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18)     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)     ... 2 more Caused by: java.lang.IllegalStateException: Couldn't find UnionFileSystemProvider     at cpw.mods.jarhandling.impl.Jar.lambda$static$1(Jar.java:48)     at java.base/java.util.Optional.orElseThrow(Optional.java:403)     at cpw.mods.jarhandling.impl.Jar.<clinit>(Jar.java:48)     ... 9 more [7.783s][info][class,load] java.util.IdentityHashMap$IdentityHashMapIterator source: shared objects file [7.784s][info][class,load] java.util.IdentityHashMap$KeyIterator source: shared objects file [7.787s][info][class,load] java.lang.Shutdown source: shared objects file [7.789s][info][class,load] java.lang.Shutdown$Lock source: shared objects file ;--- cut here ---   I tried various things here. Java 17, then Java 21, Searched for missing objects, used strace -ff java ... and so on. The securejar class is there, accessible, permissions all fine. Still running into this issue.
    • sorry for the late answer, I tried it but i hadthe same result crash reportlog
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.