[1.15.2] ItemCraftedEvent problem

[SirCaptainCaleb]

When an Itemstack is shift clicked from the crafting table result slot, a copy of that itemstack is created and placed in the player's inventory, as opposed to the Itemstack stored in the ItemCraftedEvent. This causes changes to the itemstack to be ignored when the player shift clicks, but the changes are applied if the player simply left click. In the following example, any PickAxeItem crafted by the player will be maximally damaged when the player left clicks the item to pick it up. But if the player shift clicks the item, it is moved to the inventory without damaging it. I have been scratching my head for a while on how to get around this. Any ideas?

 

    @SubscribeEvent
    public void onPickaxeCraft(ItemCraftedEvent craftedEvent){
        ItemStack craftedItemStack = craftedEvent.getCrafting().getStack();
        if(craftedItemStack.isEmpty() || !(craftedItemStack.getItem() instanceof PickaxeItem)) return;
        craftedItemStack.setDamage(craftedItemStack.getMaxDamage());
    }

 

Edited June 15, 2020 by SirCaptainCaleb

[SirCaptainCaleb]

I see. Is there some other way to conditionally modify a crafting result?

[SirCaptainCaleb]

Okay, thanks for responding. I guess I'll try to find a way to make it work with recipes

[SirCaptainCaleb]

As strange as it may sound, I actually want to maximally damage all crafted pickaxes (modded or vanilla items which are classified as a PickAxeItem)

Edited June 15, 2020 by SirCaptainCaleb

[SirCaptainCaleb]

Overwriting vanilla recipes is simple enough. Is there a way to overwrite all modified pickaxe items? If not, maybe items with the word pickaxe in the name?

[Zeram]

I believe the problem still actual. The behavior is inconsistent across those two use cases. It should either be mutable or immutable. I would enhance the quick craft case with either move slot.onQuickCraft() into moveItemStackTo or add simulate mode to moveItemStackTo and first check if the move possible then call that slot.onQuickCraft() and do actual moveItemStackTo.

[Zacomat]

Hi all

I am making a mod that creates a map. In my Recipe class in the ItemStack assemble (CraftingContainer) method I can compute all the data, but I don't think the Level.getFreeMapId method should also be called. I do this in onItemCrafted (ItemCraftedEvent e): I add the map id in the compound tag, effectively modifying the result of the recipe. And I don't know how to intercept right shift-click on the result item. When quick crafting the resulting map does not have a map id. In this case the onItemCrafted (ItemCraftedEvent e) method does not work properly.

I'm using the 1.19 41.1.0 version atm.

The way around the problem I made is the following: I search in the player's inventory for a slot with an item equal to the one I just crafted and replace it with the one returned by the event.    

@SubscribeEvent
    public void onItemCrafted(ItemCraftedEvent e) {

        Player player = e.getEntity();
        ItemStack crafting = e.getCrafting();
	CompoundTag tag = crafting.getTag();
	if (tag == null || !tag.contains("my_tag")) {
		return;
	}

        Inventory inventory = player.getInventory();
        int slot = inventory.findSlotMatchingItem(crafting);
        if (slot != -1) {
            inventory.setItem(slot, crafting);
        }
		
	tag.remove("my_tag");

	...

    }

 

Edited September 8, 2022 by Zacomat