Jump to content

Recommended Posts

Posted (edited)

So I've got a custom entity set up and it works just fine when spawned with an egg. I then wanted to have it spawn naturally, so I went and added a spawn to the entity registry of my mob's class (and to its placement registry), and gave it a set of biomes to spawn in. However, WorldEntitySpawner gets a nullptr here with the entity:

 

image.thumb.png.e379b8698aae9ec74dcde9a39cbb042e.png

 

Anyone know why this could be?

Edited by k-off
Posted

Still can't figure this out for the life of me, I also tried adding the mob to the list of biomes and still nothing, the same crash.

Posted

So you have an entry in EntitySpawnPlacementRegistry and you've added a SpawnListEntry in the biomes to spawn in? I have no idea what this is:

3 hours ago, k-off said:

so I went and added a spawn to the entity registry of my mob's class

It always nice if you can show code and an error log rather than showing us where the error is.

 

I also don't even see where this class is which leads me to believe that this is an outdated version based on the variable names.

 

So, update to at least the LTS 1.15.2 if you want support.

 

 

Posted
35 minutes ago, ChampionAsh5357 said:

So you have an entry in EntitySpawnPlacementRegistry and you've added a SpawnListEntry in the biomes to spawn in? I have no idea what this is:

It always nice if you can show code and an error log rather than showing us where the error is.

 

I also don't even see where this class is which leads me to believe that this is an outdated version based on the variable names.

 

So, update to at least the LTS 1.15.2 if you want support.

 

 

worldentityspawner is a 1.14.4 class (also in previous versions as well but i digress) fyi

 

Anyway the exact error isn't very helpful, it's just a standard nullptr exception which is what i was talking about above:

Quote

java.lang.NullPointerException: Exception ticking world
    at net.minecraft.world.WorldEntitySpawner.findChunksForSpawning(WorldEntitySpawner.java:154)
    at net.minecraft.world.WorldServer.tick(WorldServer.java:212)
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:831)
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743)
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592)
    at java.lang.Thread.run(Thread.java:748)

and worldentityspawner is that class I showed above.

Quote

So you have an entry in EntitySpawnPlacementRegistry and you've added a SpawnListEntry in the biomes to spawn in? I have no idea what this is:

Using forgeregistries I tried doing this which I found on another post here:

	public static void spawnMobs() {

		ForgeRegistries.BIOMES.getValues().stream()
          		//This is just some randsom filtering but do whatever you want her, or dont filter at all 
          		//if you want your entity to appear anywhere.
				.filter(biome -> biome.getRegistryName().toString().equals("minecraft:mushroom_fields")
						|| biome.getRegistryName().toString().equals("minecraft:mushroom_fields_field_shore"))
				
          		//this is the main dish
				.forEach(biome -> {
					biome.getSpawns(EntityClassification.<depends on what you want>)
                      		//min and max refer to number of entities in a group.
							.add(new SpawnListEntry(<static reference to your entity>, <weight>, <min>, <max>));
				});

	}

 

 

Posted
42 minutes ago, k-off said:

worldentityspawner is a 1.14.4 class (also in previous versions as well but i digress) fyi

I meant that section within the method in the class. I still don't find it since its called from an entity type.

 

42 minutes ago, k-off said:

net.minecraft.world.WorldServer.tick(WorldServer.java:212)

Also, as much as you tell me this is 1.14.4, WorldServer was renamed to ServerWorld and WorldEntitySpawner was moved to a different package in that version making your statement a lie.

 

Just for a bit more research, this line of code was referenced in at latest 1.13.2. There are things known as EntityTypes now.

 

So once again. 1.13.2 is not supported on this forum. Update to at least LTS if you want support on your code.

Posted
24 minutes ago, ChampionAsh5357 said:

I meant that section within the method in the class. I still don't find it since its called from an entity type.

 

Also, as much as you tell me this is 1.14.4, WorldServer was renamed to ServerWorld and WorldEntitySpawner was moved to a different package in that version making your statement a lie.

 

Just for a bit more research, this line of code was referenced in at latest 1.13.2. There are things known as EntityTypes now.

 

So once again. 1.13.2 is not supported on this forum. Update to at least LTS if you want support on your code.

Yeah that's fair, life moves on and so do minecraft forge versions 👍 This thread should be locked then.

 

For anyone with a similar problem in the future, I wasn't registering the entity correctly (make sure you're registering stuff that's supposed to happen in pre vs post, etc) and resolving that fixed it.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
    • Hi here is an update. I was able to fix the code so my mod does not crash Minecraft. Please understand that I am new to modding but I honestly am having a hard time understanding how anyone can get this to work without having extensive programming and debugging experience as well as searching across the Internet, multiple gen AI bots (claude, grok, openai), and examining source code hidden in the gradle directory and in various github repositories. I guess I am wrong because clearly there are thousands of mods so maybe I am just a newbie. Ok, rant over, here is a step by step summary so others can save the 3 days it took me to figure this out.   1. First, I am using forge 54.1.0 and Minecraft 1.21.4 2. I am creating a mod to add a shotgun to Minecraft 3. After creating the mod and compiling it, I installed the .jar file to the proper directory in Minecraft and used 1.21.4-forge-54.1.0 4. The mod immediately crashed with the error: Caused by: java.lang.NullPointerException: Item id not set 5. Using the stack trace, I determined that the Exception was being thrown from the net.minecraft.world.item.Item.Properties class 6. It seems that there are no javadocs for this class, so I used IntelliJ which was able to provide a decompiled version of the class, which I then examined to see the source of the error. Side question: Are there javadocs? 7. This method, specifically, was the culprit: protected String effectiveDescriptionId() {      return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));  } 8. Now my quest was to determine how to set this.id. Looking at the same source file, I determined there was another method:  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } 9. So now, I need to figure out how to call setId(). This required working backwards a bit. Starting from the constructor, I stubbed out the variable p which is of type Item.Properties public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); Rather than putting this all on one line, I split it up for readability like this: private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); Here is was the missing function, setId(), which takes a type of ResourceKey<Item>. My next problem is that due to the apparent lack of documentation (I tried searching the docs on this site) I could not determine the full import path to ResourceKey. I did some random searching on the Internet and stumbled across a Github repository which gave two clues: import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; Then I created the rk variable like this: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); And now putting it all together in order: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); This compiled and the mod no longer crashes. I still have more to do on it, but hopefully this will save someone hours. I welcome any feedback and if I missed some obvious modding resource or tutorial that has this information. If not, I might suggest we add it somewhere for people trying to write a mod that doesn't crash. Thank you !!!  
    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.