Jump to content

Recommended Posts

Posted (edited)

Hello! I've had this figured out in the 1.14 versions but I can't manage to get it work on 1.15 +

I want a block that gets LIT - on when it stops raining and LIT - off when it starts raining. 

The only part that works is when it starts raining it gets LIT - off, I can't get the part working when it stops raining to change the blockstate.

public SpecialFire() {
    super(Properties.create(Material.IRON)
            .sound(SoundType.METAL)
            .hardnessAndResistance(1.25f, 3.5f)
            .harvestTool(ToolType.PICKAXE)
            .harvestLevel(1)      
            .tickRandomly()
    );
}
   

@Override
public VoxelShape getShape(BlockState state, IBlockReader blockReader, BlockPos pos, ISelectionContext selectionContext)
{
    switch (state.get(FACING)) {
        case WEST:
            return WEST;

        case EAST:
            return EAST;

        case SOUTH:
            return SOUTH;

        default: case NORTH:
            return NORTH;
    }
}


public VoxelShape getBoundingBox(BlockState state, BlockPos pos) 
{
	switch((state.get(FACING)))
    {
     
        default:
        case SOUTH:
            return SOUTH;
        case NORTH:
            return NORTH;
        case EAST:
            return EAST;
        case WEST:
            return WEST;
    }
}

public SpecialFire(Block.Properties properties) {
super(properties);
this.setDefaultState(this.stateContainer.getBaseState().with(LIT, Boolean.valueOf(false)).with(WATERLOGGED, Boolean.valueOf(false)).with(FACING, Direction.NORTH));
}

public BlockState getStateForPlacement(BlockItemUseContext context) {
return this.getDefaultState().with(LIT, Boolean.valueOf(false)).with(WATERLOGGED, Boolean.valueOf(false)).with(FACING, context.getPlacementHorizontalFacing().rotateY());
}

protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
builder.add(LIT, FACING, WATERLOGGED);
}

public boolean ticksRandomly(BlockState state) {
	      return true;
	   }

// this is the part that is not working, but it works in 1.14
	   public void NonRain(BlockState state, World worldIn, BlockPos pos, Random random) {
	      if (state.get(LIT) == false && (worldIn.rand.nextInt(2) == 1) && (!worldIn.isRainingAt(pos.up()))) {
	    	  worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)));
	      }
	   }

//this part works fine
public void Raining(World worldIn, BlockPos pos) {
	         float f = worldIn.func_226691_t_(pos).func_225486_c(pos);
	         if (!(f < 0.15F)) {
	            BlockState blockstate = worldIn.getBlockState(pos);
	            if (blockstate.get(LIT) == true) {
	               worldIn.setBlockState(pos, blockstate.with(LIT, Boolean.valueOf(false)));
	            }
	         }
	      }

 

Edited by Kikoz
Posted
25 minutes ago, diesieben07 said:

Where do you call the "Raining" and "NonRain" methods? They certainly aren't overrides from the block class.

I'm just calling it in this class by .tickrandomly() , the Raining method works, the NonRain doesn't.

Posted
2 minutes ago, diesieben07 said:

??? You said you did call it. Now suddenly you don't?

 

 

I thought .tickrandomly()  is calling it

Posted
2 minutes ago, diesieben07 said:

That is not how method calls work.

Do you know basic Java?

Well I tried, but it still didn't work


public static void main(BlockState state, World worldIn, BlockPos pos, Random random) {
	NonRain(state, worldIn, pos, random);
  }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.