Block replace while generating a tree

[Rizen]

Good day Gentlemen,

 

I'm programming a Mod for 1.16. and I've created a custom tree, 

futhermore I wanted to use a event (SaplingGrowTreeEvent) to change a block in the trunk.

 

Sadly I haven't found a solution to actually get it to work,

the problem I'm facing, which I pressume is that the event is executed before the tree is grown, thuse hindering the tree to actually grow.

 

If anyone know a way to fix it I would be very gratefull.

 

Here the code:

 

@Mod.EventBusSubscriber(modid = AdvancedIndustries.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE, value =  Dist.CLIENT)
public class ModClientEvents {      

			@SubscribeEvent
            public static void onRubberTreeGrown(SaplingGrowTreeEvent event) {

            BlockPos blockPos = event.getPos();
            IWorld world = event.getWorld();



            if (!(event.getWorld().getBlockState(event.getPos()).getBlock() instanceof RubberTreeSapling))
                return;

            if (event.hasResult()) {
                
                 if (world.getBlockState(blockPos).getBlock() == RegistryHandler.RUBBER_TREE_SAPLING.get()) {

                    AdvancedIndustries.LOGGER.info("Generator running");
                     world.setBlockState(blockPos.add(0,2,0), Blocks.DIAMOND_BLOCK.getDefaultState(), 1);

            }
        }
    }
}

 

If you required more inedepth view to my code, notfiy me please.

 

Yours truthfully

Rizen

 

[ChampionAsh5357]

There are two questions I would like you to ask yourself. First, is there a point to using this event? If you are creating the class RubberTreeSapling, you can just as easily override the method SaplingBlock#placeTree and return your own tree growth. Second, if you're passing in an instance of the Tree to place when the sapling grows, is there any need for checking in manually instead of making your own tree instance that returns exactly what you're looking for?

 

If your answer to either of these questions are yes, I would reevaluate how you are doing this. The event shouldn't really be used for your purpose as it's called directly before the sapling attempts to create the tree and is more of a cancelable type setting. Hopefully I have answered your question.

[Rizen]

Thank you for the fast respond

 

Well the reason to why I want to use this event, is that I want to replace a block in the trunk, because I don't know if there is a way to already implement that into the growing of the tree,

for the seconed one, it's just there because of my previouse test and I would have probably removed that.

[Luminaire]

I'd like to know the answer to this question, because I am thinking of replacing a block on generation of normal trees as a possible mod.

[ChampionAsh5357]

  On 9/16/2020 at 1:15 PM, Rizen said:

Well the reason to why I want to use this event, is that I want to replace a block in the trunk, because I don't know if there is a way to already implement that into the growing of the tree,

Expand  

You are given an abstract class for the tree so you can make it do anything. If I wanted to, I could spawn a woodland mansion on tree growth. You just need to define the tree such that it allows it to happen.

 

  On 9/16/2020 at 1:32 PM, Luminaire said:

I'd like to know the answer to this question, because I am thinking of replacing a block on generation of normal trees as a possible mod.

Expand  

That is something completely different Luminaire, you should look into either replacing the tree with your own generation or doing something with mixins to replace only the first instance.

[Rizen]

Mh, I see, I'll try to look into it.

 

Anyways thank you for your help

[Rizen]

Well I'm not sure if I excactly have the right thing, but for me when it comes to tree generation,

I use the BaseTreeFeatureConfig and this only allowes 5 arguments.

Thuse hindering me of adding a third block.

 

I'm not sure if I have to edit the TreeFeature class.

Edited September 16, 2020 by Rizen

[ChampionAsh5357]

  On 9/16/2020 at 2:29 PM, Rizen said:

Well I'm not sure if I excactly have the right thing, but for me when it comes to tree generation,

I use the BaseTreeFeatureConfig and this only allowes 5 arguments.

Thuse hindering me of adding a third block.

Expand  

Once again, you are not required to use this. You can make your own that allows this or rewrite it from scratch. That's the beauty of having an abstract class with the required methods being public/protected.

[Rizen]

I see, sorry for having you tell me that again