Jump to content

Model randomly vanishes depending on where I look..


Flenix

Recommended Posts

Hey guys,

 

 

I'm adding my blocks to the game as TileEntities. However, when I look around, the blocks randomly disappear if I look in certain directions...

When they disappear, the bounding box vanishes too, so I can walk through it (if I stand on the block and look around, I'll just fall down when it vanishes)

 

Screenshots:

There's three blocks you can see here:

51bf111234252.jpg

 

Then I look slightly to the left, and the right one vanishes!

51bf11027d175.jpg

 

 

 

Code:

Block:

 

package co.uk.silvania.roads.tileentities;

import co.uk.silvania.roads.Roads;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.EntityLiving;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class TileEntityBarrierBlock extends BlockContainer {

public TileEntityBarrierBlock(int id) {
	super(id, Material.iron);
	this.setCreativeTab(Roads.tabRoads);
}

@Override
public TileEntity createNewTileEntity(World world) {
	return new TileEntityBarrierEntity();
}

@Override
public int getRenderType() {
	return -1;
}

@Override
public boolean isOpaqueCube() {
	return false;
}

public boolean renderAsNormalBlock() {
	return false;
}

public void registerIcons(IconRegister icon) {
	this.blockIcon = icon.registerIcon("Roads:CementBlock");
}

@Override
public void onBlockPlacedBy(World par1World, int par2, int par3, int par4,
		EntityLiving par5EntityLiving, ItemStack par6ItemStack) {
	int var6 = MathHelper
			.floor_double(par5EntityLiving.rotationYaw * 4.0F / 360.0F + 0.5D) & 3;

	if (var6 == 0) {
		par1World.setBlockMetadataWithNotify(par2, par3, par4, 2, 0);
	}

	if (var6 == 1) {
		par1World.setBlockMetadataWithNotify(par2, par3, par4, 5, 0);
	}

	if (var6 == 2) {
		par1World.setBlockMetadataWithNotify(par2, par3, par4, 3, 0);
	}

	if (var6 == 3) {
		par1World.setBlockMetadataWithNotify(par2, par3, par4, 4, 0);
	}
}

    public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z) {
    	int meta = world.getBlockMetadata(x, y, z);
    	if ((meta) == 3)
    		setBlockBounds(0.0F, 0.25F, 0.875F, 1.0F, 0.75F, 1.0F);
    	else if ((meta) == 5)
            setBlockBounds(0.875F, 0.25F, 0.0F, 1.0F, 0.75F, 1.0F);
    	else if ((meta) == 2)
    		setBlockBounds(0.0F, 0.25F, 0.0F, 1.0F, 0.75F, 0.125F);
    	else
    		setBlockBounds(0.0F, 0.25F, 0.0F, 0.125F, 0.75F, 1.0F);
    }

}

 

 

 

Renderer:

 

package co.uk.silvania.roads.tileentities;

import org.lwjgl.opengl.GL11;


import co.uk.silvania.roads.Roads;
import co.uk.silvania.roads.client.BarrierModel;
import co.uk.silvania.roads.client.LightBollardModel;
import co.uk.silvania.roads.client.TrafficLightModel;

import cpw.mods.fml.client.registry.ISimpleBlockRenderingHandler;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.OpenGlHelper;
import net.minecraft.client.renderer.RenderBlocks;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer;
import net.minecraft.entity.Entity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;


public class TileEntityBarrierRenderer extends TileEntitySpecialRenderer {

private final BarrierModel model;

public TileEntityBarrierRenderer() {
	this.model = new BarrierModel();
}


@Override
public void renderTileEntityAt(TileEntity te, double x, double y, double z, float scale) {
	int i = te.getBlockMetadata();
	int j = 180;

	if (i == 3) {
		j = 0;
	}

	if (i == 5) {
		j = 90;
	}

	if (i == 2) {
		j = 180;
	}

	if (i == 4) {
		j = 270;
	}

	bindTextureByName("/mods/roads/textures/blocks/Barrier.png");
	GL11.glPushMatrix();
	GL11.glTranslatef((float) x + 0.5F, (float) y + 1.5F, (float) z + 0.5F);
	GL11.glRotatef(j, 0.0F, 1.0F, 0.0F);
	GL11.glScalef(1.0F, -1F, -1F);
	this.model.render((Entity)null, 0.0F, 0.0F, -0.1F, 0.0F, 0.0F, 0.0625F);
	GL11.glPopMatrix();
}

private void adjustRotatePivotViaMeta(World world, int x, int y, int z) {
	int meta = world.getBlockMetadata(x, y, z);
	GL11.glPushMatrix();
	GL11.glRotatef(meta, 0.0F, 0.0F, 1.0F);
	GL11.glPopMatrix();
}

private void adjustLightFixture(World world, int i, int j, int k, Block block) {
	Tessellator tess = Tessellator.instance;
	float brightness = block.getBlockBrightness(world, i, j, k);
	int skyLight = world.getLightBrightnessForSkyBlocks(i, j, k, 0);
	int modulousModifier = skyLight % 65536;
	int divModifier = skyLight / 65536;
	tess.setColorOpaque_F(brightness, brightness, brightness);
	OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit,  (float) modulousModifier,  divModifier);
}
}

 

 

The TileEntity is empty at the moment.

 

Any ideas?

 

 

Someone also told me to try using "GL11.glRotatef(((TileEntityBarrierEntity)tile).getRotationPivot()), 0.0F, 1.0F, 0.0F);" instead of the if statements I have for rotation, but they didn't go as far as to telling me how to use getRotationPivot so right now, that's useless for me. At any rate, removing the rotation code altogether doesn't fix the issue.

width=463 height=200

http://s13.postimg.org/z9mlly2av/siglogo.png[/img]

My mods (Links coming soon)

Cities | Roads | Remula | SilvaniaMod | MoreStats

Link to comment
Share on other sites

It's disappearing because your bounding box is outside the field of vision. Expand it to take up the whole entity (here is a helpful post.)

 

It's not at all O.o I spent a bit of time lining up the bounding boxes perfectly with the models; It's the exact right size, so that can't be the issue or I'd never notice it...

width=463 height=200

http://s13.postimg.org/z9mlly2av/siglogo.png[/img]

My mods (Links coming soon)

Cities | Roads | Remula | SilvaniaMod | MoreStats

Link to comment
Share on other sites

It's disappearing because your bounding box is outside the field of vision. Expand it to take up the whole entity (here is a helpful post.)

 

It's not at all O.o I spent a bit of time lining up the bounding boxes perfectly with the models; It's the exact right size, so that can't be the issue or I'd never notice it...

Oh. Okay then. I have no idea.

 

Unless perhaps the bounding box is in the wrong place? But if you can bump into it, then I'm out of ideas.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

It may well be something in the bounding box actually.

 

I'd only tested it with the eclipse testing environment. I just compiled it all and put it in a real forge environment, and the vanishing bug stopped.

BUT, the bounding boxes are bugging out at the same time. When I look at them the black lines are in the right place, but if I move into the full block area, my character glitches out. Did you play minecraft in alpha/early beta? Remember when you jumped on a fence and it bugged? Same kind of thing.

 

 

Any ideas?

width=463 height=200

http://s13.postimg.org/z9mlly2av/siglogo.png[/img]

My mods (Links coming soon)

Cities | Roads | Remula | SilvaniaMod | MoreStats

Link to comment
Share on other sites

I believe, dont quote me on this, but it to do with the origin block placement of the tile entity, Thaumcraft has the issue with its scribing tools and i dont think it can be helped. The issue is when minecraft looks dfor blocks in view to render the origin block of the tile entity is not on the screen hence it srops rendering.

 

(this could be a load of rubbish but after looking through that is what i've found.)

Link to comment
Share on other sites

I think a way to solve that is to modify the collision boxes, just like you did with the bounding boxes. There's a method in the block class that you can put in your block class,  but it's very messy.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Your mod is probably lagging during world generation due to how it replaces blocks around your custom ore. Right now, it randomly picks spots around the ore and changes blocks there. This process can be slow, especially if it's dealing with lots of blocks or a big area. To fix it, try replacing fewer blocks, picking spots more efficiently, and changing blocks in a smarter way. This should help your mod run smoother when generating worlds. Here is an example of how you can do this // Inside the if (placed) block if (placed) { BlockState surroundingBlockState = BlockInit.ABERRANT_MINERALOID.get().defaultBlockState(); int veinSize = ctx.config().size; int maxBlocksToReplace = (int) Math.ceil(veinSize * 0.1); // Replace 10% of vein size int numBlocksToCorrupt = Math.min(maxBlocksToReplace, 1000); // Limit to 1000 blocks List<BlockPos> positionsToReplace = new ArrayList<>(); // Loop until reaching the limit of blocks to replace while (positionsToReplace.size() < numBlocksToCorrupt) { BlockPos randomPos = offsetOrigin.offset( ctx.random().nextInt(2 * areaSizeX + 1) - areaSizeX, ctx.random().nextInt(2 * areaSizeY + 1) - areaSizeY, ctx.random().nextInt(2 * areaSizeZ + 1) - areaSizeZ ); if (world.getBlockState(randomPos).is(ModBlockTags.STONE_ABERRANTABLE)) { positionsToReplace.add(randomPos); } } // Replace blocks in bulk for (BlockPos pos : positionsToReplace) { world.setBlock(pos, surroundingBlockState, 2); } } If you've tried more effective ways to generate your blocks around your ores, it may also be because of issues on your side, not the mod. Adjust the parameters as needed based on your performance testing and requirements.
    • So i have a custom ore and, arround the ore, a bunch of randomly placed custom stone blocks should be placed. After applying it, i've found that it causes moderate to extreme world generation lag (new chunks refusing to load after moving for a while, height slices of the same chunk appearing and disappearing as I get into them instead of the usual long continous chunk, new chunks generating extremely close to me instead of to the set render distance...) I've been debugging for a while and I know for a fact this is causing the lag (and sometimes freeze of the world loading screen on a new world and/or the saving world screen when quitting), since comenting it just makes the worldgen work as usual and I want to see if its really that computationally expensive, if there are other ways of doing it or if the process can be simplfied or optimized. I've tried a lot of combinations for the same code but I am just stuck. Is it some kind of generation cascading im missing?   Here is the code for the class. The code inside the if (placed) is the one causing this mess. I can see that the code might not be the most optimized thing, but it does what's supposed to... but at the cost of causing all this. Any tips? package es.nullbyte.relativedimensions.worldgen.oregen.oreplacements; import es.nullbyte.relativedimensions.blocks.BlockInit; import es.nullbyte.relativedimensions.blocks.ModBlockTags; import net.minecraft.core.BlockPos; import net.minecraft.world.level.WorldGenLevel; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.level.levelgen.feature.FeaturePlaceContext; import net.minecraft.world.level.levelgen.feature.OreFeature; import net.minecraft.world.level.levelgen.feature.configurations.OreConfiguration; import java.util.Optional; public class AberrantOreFeature extends OreFeature { public AberrantOreFeature() { super(OreConfiguration.CODEC); } @Override public boolean place(FeaturePlaceContext<OreConfiguration> ctx) { // Get the world and the position from the context WorldGenLevel world = ctx.level(); BlockPos origin = ctx.origin(); // Offset the origin by 8 in the x and z directions to avoid cascading chunk generation BlockPos offsetOrigin = origin.offset(8, 0, 8); // Create a new context with the offset origin FeaturePlaceContext<OreConfiguration> offsetCtx = new FeaturePlaceContext<>( Optional.empty(), world, ctx.chunkGenerator(), ctx.random(), offsetOrigin, ctx.config() ); // Generate the entire vein of ore at the offset origin boolean placed = super.place(offsetCtx); // If the vein was generated successfully if (placed) { // Define the block to replace surrounding blocks with BlockState surroundingBlockState = BlockInit.ABERRANT_MINERALOID.get().defaultBlockState(); // Generate a random size for the area of corruption int areaSizeX = ctx.random().nextInt(3) + 1; // between 1 and 4 int areaSizeY = ctx.random().nextInt(3) + 1; // between 1 and 4 int areaSizeZ = ctx.random().nextInt(3) + 1; // between 1 and 4 // Calculate the number of blocks to be corrupted based on the area size double numBlocksToCorrupt = (areaSizeX + areaSizeY + areaSizeZ / 2.0) ; // Counter for the number of blocks corrupted int numBlocksCorrupted = 0; // Loop for each block to be corrupted while (numBlocksCorrupted < numBlocksToCorrupt) { // Generate a random position within the area, using the offset origin BlockPos randomPos = offsetOrigin.offset( ctx.random().nextInt(2 * areaSizeX + 1) - areaSizeX, // between -areaSize and areaSize ctx.random().nextInt(2 * areaSizeY + 1) - areaSizeY, ctx.random().nextInt(2 * areaSizeZ + 1) - areaSizeZ ); // If the block at the random position is in the IS_ORE_ABERRANTABLE tag, replace it if (world.getBlockState(randomPos).is(ModBlockTags.STONE_ABERRANTABLE)) { world.setBlock(randomPos, surroundingBlockState, 2); numBlocksCorrupted++; } } } return placed; } }  
    • Here is a tutorial from this same forum that I tried and kinda made work. Take into account that you will have to manage the offset (like rotation, and the offset relative to things like the main hand, offhand etc) by yourself and that can get very troublesome at times.  
    • I have done this now but have got the error:   'food(net.minecraft.world.food.FoodProperties)' in 'net.minecraft.world.item.Item.Properties' cannot be applied to                '(net.minecraftforge.registries.RegistryObject<net.minecraft.world.item.Item>)' public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register( "lemon_juice", () -> new Item( new HoneyBottleItem.Properties().stacksTo(1).food( (new FoodProperties.Builder()) .nutrition(3) .saturationMod(0.25F) .effect(() -> new MobEffectInstance(MobEffects.DAMAGE_RESISTANCE, 1500), 0.01f ) .build() ) )); The code above is from the ModFoods class, the one below from the ModItems class. public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register("lemon_juice", () -> new Item(new Item.Properties().food(ModFoods.LEMON_JUICE)));   I shall keep going between them to try and figure out the cause. I am sorry if this is too much for you to help with, though I thank you greatly for your patience and all the effort you have put in to help me.
    • I have been following these exact tutorials for quite a while, I must agree that they are amazing and easy to follow. I have registered the item in the ModFoods class, I tried to do it in ModItems (Where all the items should be registered) but got errors, I think I may need to revert this and figure it out from there. Once again, thank you for your help! 👍 Just looking back, I have noticed in your code you added ITEMS.register, which I am guessing means that they are being registered in ModFoods, I shall go through the process of trial and error to figure this out.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.