Help with Plant [Solved]

[wookiederk]

Hi, I'm trying to make a tomato plant. I have based much of it off the tutorial, but I have come across some problems.

 

1. I want to make it when the plant is right clicked with shears, it will drop tomato and go down a plant growth. When i implemented IShearable, it didnt work on right clicking, and I dont want the same effect with left clicking.

 

2. Pictures arent updating. The first growth upon planting is correct, but when it ticks to the next growth nothing happens. I'm guessing it is incorrect usage of world.setBlock?

 

TomatoCrop.class:

public class TomatoCrop extends Block implements IShearable {

@SideOnly(Side.CLIENT)
private Icon[] icons;

public TomatoCrop(int id) {
	super(id, Material.plants);
	this.setStepSound(soundGrassFootstep);
	this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 0.5F, 1.0F);
	this.setTickRandomly(true);
}

public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int x,
		int y, int z) {
	return null;
}

public int getRenderType() {
	return 6; // Magic number.
}

public boolean isOpaqueCube() {
	return false;
}

@Override
public void updateTick(World world, int x, int y, int z, Random random) {
	System.out.println("TICK");
	if (world.getBlockMetadata(x, y, z) == 1) {
		System.out.println("already");
		return;
	}

	if (world.getBlockLightValue(x, y + 1, z) < 9) {
		System.out.println("light not good");
		return;
	}

	if (random.nextInt(isFertile(world, x, y - 1, z) ? 12 : 25) != 0) {
		System.out.println("nope");
		return;
	}

	world.setBlock(x, y, z, EatMe.tomatoCrop.blockID, 1, 2);
	System.out.println("yep");
}

@Override
public void onNeighborBlockChange(World world, int x, int y, int z,
		int neighborId) {
	if (!canBlockStay(world, x, y, z)) {
		dropBlockAsItem(world, x, y, z, world.getBlockMetadata(x, y, z), 0);
		world.setBlock(x, y, z, 0);
	}
}

@Override
public boolean canBlockStay(World world, int x, int y, int z) {
	Block soil = blocksList[world.getBlockId(x, y - 1, z)];
	return (world.getFullBlockLightValue(x, y, z) >= 8 || world
			.canBlockSeeTheSky(x, y, z))
			&& (soil != null && soil.canSustainPlant(world, x, y - 1, z,
					ForgeDirection.UP, (IPlantable) EatMe.tomatoSeeds));
}

@Override
public int idDropped(int metadata, Random random, int par2) {
	switch (metadata) {
	case 0:
		return EatMe.tomatoSeeds.itemID;
	case 1:
		return EatMe.tomato.itemID;
	default: // Error case!
		return -1; // no item
	}
}

@Override
public int idPicked(World world, int x, int y, int z) {
	return EatMe.tomatoSeeds.itemID;
}

@Override
@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister) {
	icons = new Icon[2];

	for (int i = 0; i < icons.length; i++) {
		icons[i] = par1IconRegister.registerIcon("crops_" + i);
		blockIcon = icons[i];
	}
}

@Override
public boolean isShearable(ItemStack item, World world, int x, int y, int z) {
	return true;
}

@Override
public ArrayList<ItemStack> onSheared(ItemStack item, World world, int x,
		int y, int z, int fortune) {
	Random random = new Random();
	ArrayList<ItemStack> ret = new ArrayList<ItemStack>();
	world.setBlock(x, y, z, EatMe.tomatoCrop.blockID, 0, 2);
	int i = 1 + random.nextInt(3);
	for (int j = 0; j < i; j++) {
		ret.add(new ItemStack(EatMe.tomato, 1));
	}
	return ret;
}

}

[ObsequiousNewt]

(1) That's how IShearable works. If you want to make it right-click-shearable, you'll have to override onBlockActivated.

(2) You would seem to be setting the metadata to 2 every time.

[wookiederk]

Doesn't setBlock say X,Y,Z, new BlockID, new metadata, flag?

[ObsequiousNewt]

Doesn't setBlock say X,Y,Z, new BlockID, new metadata, flag?

Um, yes. Read the javadocs.

[wookiederk]

par5 should be the metadata. according to the description im setting the metadata and 2 is the flag thingy that is best at 2 for client rendering. I'm not sure what your saying

[ObsequiousNewt]

Derp. I didn't understand what you mean.

 

In that case, you're setting the metadata to 1 every time.

[wookiederk]

Ok, but the problem is that when it changes from 0 to 1 the picture doesnt update. Do you know why that is?

[ObsequiousNewt]

Ok, but the problem is that when it changes from 0 to 1 the picture doesnt update. Do you know why that is?

If you have metadata-dependent icons, you need to override... um, I think it's getIcon(side, meta).

[wookiederk]

yeah I just realized it. solution:

	@SideOnly(Side.CLIENT)
public Icon getIcon(int par1, int par2) {
	return this.icons[par2];
} 

thanks for the help