[1.15.2] General Question - Biomes, Dimension, Sound

[HalestormXV]

So this is more of a General Question as opposed to a "problem." 

I made my Dimension, I made my Biome(s), everything works its wonderful.

 

I want to spice up the Dimension abit and add my own music to it. I read something that 1.15.2 "didn't yet" implement that. It was a completely random source, and who knows how long ago it was. So I am curious to know if some type of method exists to set custom music to your entire Dimension. Or perhaps it is done on the Biome level with the builder? Any guidance/example/shove in the right direction is helpful. I imagine it isn't done with a ClientTickEvent anymore.

[ChampionAsh5357]

If you're talking about the background ambience, then that is still hardcoded in 1.15.2. A PR to forge is needed to expose the necessary fields to set the values.

[HalestormXV]

35 minutes ago, ChampionAsh5357 said:

If you're talking about the background ambience, then that is still hardcoded in 1.15.2. A PR to forge is needed to expose the necessary fields to set the values.

 

If indeed Background music (i.e. Creative mode music, survival mode music, "Overworld" (you know like the "calm1", "hal2"  music etc.) is indeed part of the ambience then it would seem a ClientTickEvent still is indeed the way to go about it to accomplish that effect. I'm not in front of the code atm but I imagine there is a way to check if a sound is playing and if so stop it and then start a new one? As I imagine that would be the most effective way to handle that?

[ChampionAsh5357]

1 minute ago, HalestormXV said:

If indeed Background music (i.e. Creative mode music, survival mode music, "Overworld" (you know like the "calm1", "hal2"  music etc.) is indeed part of the ambience then it would seem a ClientTickEvent still is indeed the way to go about it to accomplish that effect. I'm not in front of the code atm but I imagine there is a way to check if a sound is playing and if so stop it and then start a new one? As I imagine that would be the most effective way to handle that?

I would have suggested that. However, there is a slight issue. You would need to stop the sound every time it's about to play which since it's not the same sound, you would need to stop all sounds. That would stop your sound as well causing random cuts in the ambience. This is why I suggested making a PR to whatever handles music in 1.15.2. I remember Mcjty mentioning it's an enum that needs to be extensible and probably a method hook to an event to handle when should it change.

[HalestormXV]

6 minutes ago, ChampionAsh5357 said:

I would have suggested that. However, there is a slight issue. You would need to stop the sound every time it's about to play which since it's not the same sound, you would need to stop all sounds. That would stop your sound as well causing random cuts in the ambience. This is why I suggested making a PR to whatever handles music in 1.15.2. I remember Mcjty mentioning it's an enum that needs to be extensible and probably a method hook to an event to handle when should it change.

 

Noted. Alright thanks for the info.