Hello there,

 

I'm working on an Item that should work like a really powerful highlighter. So if you right click on any mob, it should be set Glowing and if you click again, set not Glowing.

But I ran into a problem with the Event so I cant get it to work properly. I tested with Villagers and it worked, but with Pigs, Cows and Foxes it didnt. I want it to work on all Animals and Monsters.

 

So here is my Event Code where I think the Problem is:

package com.stevenpaw.awesomeshop.events;

import com.stevenpaw.awesomeshop.AwesomeShop;
import com.stevenpaw.awesomeshop.init.ModItems;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(modid = AwesomeShop.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class ModClientEvents
{
    @SubscribeEvent
    public static void onInteractEntity(PlayerInteractEvent.EntityInteract event)
    {
        PlayerEntity player = event.getPlayer();

        if(player.getHeldItemMainhand().getItem() == ModItems.HIGHLIGHTER.get())
        {
            Entity target = (Entity) event.getTarget();

            if(target.isGlowing())
            {
                target.setGlowing(false);
            } else {
                target.setGlowing(true);
            }
        }
    }
}

ModItems.HIGHLIGHTER is the custom Item that I created and AwesomeShop.MOD_ID is the ModID.

Maybe it's the wrong Event i'm working with? I tried many things but nothing helps. Maybe you can help me! Thank you!

If you need anything else from me to help, please comment.

 

newest Forge 1.16.4

GitHub for the full Repository

1 hour ago, diesieben07 said:

Your event handler runs a total of 4 times every time you right-click an entity. Why?

Once for each hand, once for each logical side (server, client). You need to:

1. Check the hand given to you in the event, not always the main hand.
2. Check World#isRemote for false to only run this on the server.
3. Move this out of your Dist.CLIENT only event handler, why on earth did you put it there?

Thank you very much! With your help it works now for every mob I tested. My code now:

@SubscribeEvent
public static void onInteractEntity(PlayerInteractEvent.EntityInteract event)
{
    PlayerEntity player = event.getPlayer();

    Item usedItem;

    if(event.getHand() == MAIN_HAND)
    {
        usedItem = player.getHeldItemMainhand().getItem();
    } else {
        usedItem = player.getHeldItemOffhand().getItem();
    }

    if(!player.world.isRemote) {
        if (usedItem == ModItems.HIGHLIGHTER.get()) {
            Entity target = (Entity) event.getTarget();

            if (target.isGlowing()) {
                target.setGlowing(false);
            } else {
                target.setGlowing(true);
            }
        }
    }
}

 

Thank you very much!