Bug: Nether Quarz Ore does not have toolType

[DancZer 0]

Nether Quarz Ore Block state does not returns the tool type. it returns null.

 

[diesieben07 7697]

Unfortunately not all blocks specify a tool type, quartz is just one. Forge tries to assign tool types to vanilla blocks on a best-effort basis. However vanilla simply has a giant if-statement in PickaxeItem which checks for various blocks. However it also checks for materials, anything that has Material.ROCK (and some others) can be harvested using a pickaxe (see PickaxeItem#canHarvestBlock).

 

Feel free to submit a PR that patches getHarvestTool to check for the material by default as well.

[DancZer 0]

What would be the ideal way to check if I can break a a block by a pickaxe or a shovel? 

 

I rewrote the whole logic and now I use the Item.canHarvestBlock, but it doesn't work reliable neither. For dirt the shovel returns false. 😔

 

Here is my logic: Github code

 

Do you have any suggestion? 

 

Thank you in advance and I will let you know when the PR is ready. 

Edited January 25 by DancZer

[diesieben07 7697]

The only true way to know is to call BlockState#canHarvestBlock, which requires a player and will check the item the player is currently holding or other arbitrary things about the player (mods may have all kinds of arbitrary requirements for harvesting).