[1.16.4] Change Texture onBlockActivated

[BentiGorlich 0]

Hallo Modders,

 

I want to have my Block change the texture to the texture of the block it is right clicked with. I honestly have no idea how this would be done other than override the `onBlockActivated` method.

Any idea how this could be done? It would be helpful if you could name a mod on 1.16 that does this in some regard, too.

 

Thanks in advance

 

[diesieben07 7586]

Make two different blocks or a Boolean block state property. Then use onBlockActivated to switch between the two. You might want to look at the fence gate, which switches between open and closed.

[BentiGorlich 0]

Ok i was not clear enough. I want it to be able to use any texture of any block on this. So if i right click it with oak planks it becomes an oak plank block (texture wise), if i right click it with stone it becomes stone and so on.

[diesieben07 7586]

You will need to do the following:

1. Make a TileEntity and store the "mimiced" block state there. This is firstly not trivial, because the ItemStack => "block it would place" conversion is not trivial.
2. Ensure this data is synced to the client.
3. Override getModelData in your tile entity and return a data that contains the current block state.
4. Call requestModelDataUpdate on the client on your TileEntity whenever the contained block state changes (a good place is onDataPacket, after the server has told the client the new block state).
5. Make a custom model loader, which creates a special model that will mimic whatever blockstate your tile entity currently contains - it knows which block state it is based on the model data from step 3.

[BentiGorlich 0]

Ok tanks, that is very helpful.
I will try that later on. But I do have one question already: where do I get the texture I have to render from, or is it contained in the BlockState and I dont really have to worry about that?

[diesieben07 7586]

You don't use the texture. You need to use the model that the contained block state uses (it may not be a cube, it may not even have a texture).

You can use BlockRendererDispatcher#getModelForState to get the model for a block state.

[BentiGorlich 0]

It would be ok if there was the limitation that it could only look like other cubes and not like a torch for example. Thats why I thought, that shouldn't be that hard, just replace the texture from it with the texture from the right clicked block.

Override getModelData in your tile entity and return a data that contains the current block state.

how do I get an IModelData object from a BlockState? BlockRendererDispatcher#getModelForState is not static, how would I get an instance of that?

[diesieben07 7586]

1 hour ago, BentiGorlich said:

Thats why I thought, that shouldn't be that hard, just replace the texture from it with the texture from the right clicked block.

It's not trivial to determine if a model is a cube. It's also not trivial to get the texture from a model.

 

1 hour ago, BentiGorlich said:

how do I get an IModelData object from a BlockState?

Implement IModelData and add a field to your class that can store the BlockState.

 

1 hour ago, BentiGorlich said:

BlockRendererDispatcher#getModelForState is not static, how would I get an instance of that?

Minecraft#getBlockRendererDispatcher. Please try to use your IDE

[BentiGorlich 0]

43 minutes ago, diesieben07 said:

Minecraft#getBlockRendererDispatcher. Please try to use your IDE

Yeah you were right, I could have found that by mysqlf, sorry.
 

 

43 minutes ago, diesieben07 said:

Implement IModelData and add a field to your class that can store the BlockState

Done

 

2 hours ago, diesieben07 said:

Ensure this data is synced to the client.

I don't know how to do that. The only time i really synced something to a client was through a open gui call, how would i send something to sync that up in the `onBlockActivated` method?

 

2 hours ago, diesieben07 said:

Make a custom model loader, which creates a special model that will mimic whatever blockstate your tile entity currently contains - it knows which block state it is based on the model data from step 3.

Can you give me a class to refer to? I really don't know which class I would have to extend for that, nor where to register it

 

I really appreciate your help

[diesieben07 7586]

24 minutes ago, BentiGorlich said:

I don't know how to do that. The only time i really synced something to a client was through a open gui call, how would i send something to sync that up in the `onBlockActivated` method?

https://mcforge.readthedocs.io/en/latest/tileentities/tileentity/#synchronizing-the-data-to-the-client

 

25 minutes ago, BentiGorlich said:

Can you give me a class to refer to? I really don't know which class I would have to extend for that, nor where to register it

IModelLoader. There are several implementations in Forge already which you could look at for reference.

[BentiGorlich 0]

So I started looking into it. Sadly forge only has examples with the bucket item that are helpful, so I could not get the gist of it.

 

I have these 2 classes now:

public class GatePlacerModelLoader implements IModelLoader<GatePlacerModelConfiguration> {

	public static GatePlacerModelLoader INSTANCE = new GatePlacerModelLoader();
	
	@Override
	public void onResourceManagerReload(IResourceManager resourceManager) {
		// TODO Auto-generated method stub
	}

	@Override
	public GatePlacerModelConfiguration read(JsonDeserializationContext deserializationContext, JsonObject modelContents) {
		// TODO Auto-generated method stub
		return null;
	}
}

public class GatePlacerModelConfiguration implements IModelGeometry<GatePlacerModelConfiguration> {

	@Override
	public IBakedModel bake(IModelConfiguration owner, ModelBakery bakery, Function spriteGetter, IModelTransform modelTransform, ItemOverrideList overrides, ResourceLocation modelLocation) {
		
		return null;
	}

	@Override
	public Collection getTextures(IModelConfiguration owner, Function modelGetter, Set missingTextureErrors) {
		// TODO Auto-generated method stub
		return null;
	}
}

And I register the loader like so:

public void init(FMLServerStartingEvent event) {
	ModelLoaderRegistry.registerLoader(new ResourceLocation(MODID, "gate_placer"), GatePlacerModelLoader.INSTANCE);
}

My problem is, that I couldn't find a reference to how these are called for rendering

- how to tell them which block they should render through my render model

- how do I get the blockstate of the mimiced block (I can't get the normal block state eigher...)

[diesieben07 7586]

32 minutes ago, BentiGorlich said:

 

public void init(FMLServerStartingEvent event) {
	ModelLoaderRegistry.registerLoader(new ResourceLocation(MODID, "gate_placer"), GatePlacerModelLoader.INSTANCE);
}

 

Use ModelRegistryEvent instead.

 

36 minutes ago, BentiGorlich said:

how to tell them which block they should render through my render model

In your model you need to delegate the methods (the most important one is probably just getQuads) to the other model. Which "other model" you use depends on the model data (it has the mimiced block state in it). By delegating to the other model here, your block will appear as if it had that other model.

 

37 minutes ago, BentiGorlich said:

how do I get the blockstate of the mimiced block (I can't get the normal block state eigher...)

Its given to you as the IModelData in your IBakedModel. This is the same model data you returned from your tile entity.

[BentiGorlich 0]

6 minutes ago, diesieben07 said:

Use ModelRegistryEvent instead.

Done

6 minutes ago, diesieben07 said:

43 minutes ago, BentiGorlich said:

how to tell them which block they should render through my render model

In your model you need to delegate the methods (the most important one is probably just getQuads) to the other model. Which "other model" you use depends on the model data (it has the mimiced block state in it). By delegating to the other model here, your block will appear as if it had that other model.

Which class do you mean with "model"? I do not have a method called `getQuads()` in the GatePlacerModelLoader class, the GatePlacerModelConfiguration class, the GatePlacerBlock class, or the GatePlacerTileEntity class. So do I have to make another class class GatePlacerModel? and where would I register it, so it renders my block?

 

9 minutes ago, diesieben07 said:

47 minutes ago, BentiGorlich said:

how do I get the blockstate of the mimiced block (I can't get the normal block state eigher...)

Its given to you as the IModelData in your IBakedModel. This is the same model data you returned from your tile entity.

In the GatePlacerModelConfiguration class I have to return a `IBakedModel` in the bake method. How do I build it?
And where would I have a method for using the baked model?

[diesieben07 7586]

18 minutes ago, BentiGorlich said:

Which class do you mean with "model"? I do not have a method called `getQuads()` in the GatePlacerModelLoader class, the GatePlacerModelConfiguration class, the GatePlacerBlock class, or the GatePlacerTileEntity class. So do I have to make another class class GatePlacerModel? and where would I register it, so it renders my block?

In your IModelGeometry implementation you need to return an IBakedModel in bake(). This IBakedModel has getQuads.

 

19 minutes ago, BentiGorlich said:

In the GatePlacerModelConfiguration class I have to return a `IBakedModel` in the bake method. How do I build it?

You make a class that implements IBakedModel.

 

19 minutes ago, BentiGorlich said:

And where would I have a method for using the baked model?

Not sure what you mean by this.

[BentiGorlich 0]

6 minutes ago, diesieben07 said:

You make a class that implements IBakedModel.

Ok, so that was the part I missed before. Thank you, I will try that

[BentiGorlich 0]

Ok so I have run into a problem again. How do I get the model of the mimiced block from its blockstate?

50 minutes ago, diesieben07 said:

Not sure what you mean by this.

To clarify: where do I register my created model so that my block is rendered by it?

[diesieben07 7586]

12 minutes ago, BentiGorlich said:

How do I get the model of the mimiced block from its blockstate?

22 hours ago, diesieben07 said:

You can use BlockRendererDispatcher#getModelForState to get the model for a block state.

 

13 minutes ago, BentiGorlich said:

where do I register my created model so that my block is rendered by it?

You make a normal JSON model for your block like you would with a "normal" block model. Then in that JSON model you specify "loader": "yourmod:yourloader". This will then load that JSON model using your loader (IModelLoader#read) and use the result as the model for your block.

You can even configure what your loader does by reading additional data from the JSON object - but that is not necessary, just the "loader" property will already make it so your loader is used.

[BentiGorlich 0]

I have the problem, that nothing is happening. I have the loader and the model in the blockstate.json:
(if I remove the model property it just renders as the default black/pink block)

{
    "variants": {
        "": { 
            "loader": "gates:gate_placer_loader",
            "model": "gates:block/gate_placer"
        }
    }
}

But my GatePlacerModel class is never called.

ModelLoader:

public class GatePlacerModelLoader implements IModelLoader<GatePlacerModelConfiguration> {

	public static GatePlacerModelLoader INSTANCE = new GatePlacerModelLoader();
	
	@Override
	public void onResourceManagerReload(IResourceManager resourceManager) {
		// TODO Auto-generated method stub
	}

	@Override
	public GatePlacerModelConfiguration read(JsonDeserializationContext deserializationContext, JsonObject modelContents) {
		return new GatePlacerModelConfiguration();
	}
}

ModelConfiguration:

public class GatePlacerModelConfiguration implements IModelGeometry<GatePlacerModelConfiguration> {

	@Override
	public IBakedModel bake(IModelConfiguration owner, ModelBakery bakery, Function spriteGetter, IModelTransform modelTransform, ItemOverrideList overrides, ResourceLocation modelLocation) {
		return new GatePlacerModel(overrides);
	}

	@Override
	public Collection getTextures(IModelConfiguration owner, Function modelGetter, Set missingTextureErrors) {
		Set<RenderMaterial> texs = Sets.newHashSet();

        if (owner.isTexturePresent("base")) texs.add(owner.resolveTexture("base"));
        if (owner.isTexturePresent("all")) texs.add(owner.resolveTexture("all"));

        return texs;
	}
}

Model:

public class GatePlacerModel extends BakedModel {

	public GatePlacerModel(ItemOverrideList overrides) {
		super(false, false, false, null, overrides, null, null);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public List<BakedQuad> getQuads(BlockState state, Direction side, Random rand, IModelData extraData) {
		if(extraData.hasProperty(GatePlacerTileEntity.MIMICED_BLOCKSTATE_PROPERTY)) {
			BlockState mimiced = extraData.getData(GatePlacerTileEntity.MIMICED_BLOCKSTATE_PROPERTY);
			IBakedModel mimicedModel = Minecraft.getInstance().getBlockRendererDispatcher().getModelForState(mimiced);
			return mimicedModel.getQuads(mimiced, side, rand, extraData);
		} else {
			return super.getQuads(state, side, rand, extraData);
		}
	}
}

Inside of my block i have this method:

	@Override
	public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		ItemStack activeStack = player.getHeldItem(handIn);
		if(activeStack.getItem() instanceof BlockItem) {
			Block block = ((BlockItem)activeStack.getItem()).getBlock();
			((GatePlacerTileEntity)worldIn.getTileEntity(pos)).setMimicedBlockState(block.getDefaultState());
			// notify for block update, so the new mimiced block is synced in the tileentity class
			worldIn.notifyBlockUpdate(pos, state, state.with(MIMICED, Boolean.valueOf(true)), 2);
			return ActionResultType.SUCCESS;
		}
		return ActionResultType.FAIL;
	}

Am I doing something wrong?

[diesieben07 7586]

13 hours ago, BentiGorlich said:

I have the problem, that nothing is happening. I have the loader and the model in the blockstate.json:
(if I remove the model property it just renders as the default black/pink block)

{
    "variants": {
        "": { 
            "loader": "gates:gate_placer_loader",
            "model": "gates:block/gate_placer"
        }
    }
}

But my GatePlacerModel class is never called.

This looks like a block state file, not a model file. The "loader" property needs to be in your model JSON.