Jump to content

GUI Issue - Buttons rendering behind background .png


Zetal

Recommended Posts

Despite rendering/adding the buttons after the background image, they still insist on hiding behind it. I'm honestly just not sure why. I'm using

 

        GuiButton guibutton = new GuiButton(6, k + x, l + y, 72, 20, myStringArray[0]);
        guibutton.enabled = true;
        guibutton.displayString = myStringArray[0];
        this.buttonList.add(guibutton);

 

for buttons and

 

        this.drawTexturedModalRect(k + x, l + y, 0, 198, 72, 58);

 

for the background images.

Everything is where you would expect it, but the buttons hide behind the textured rectangles for some reason. Rect's are added in the 'background' phase- buttons are added in the 'foreground' phase. Am I missing something obvious? I've exhausted all of my options.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

Can you show us the code/method which actually does all the rendering, perhaps even the whole class so we don't have to chase stuff down later on.

 

If you want an example of a GUI to help you I have three on my guthub (link below, package: mtech.client.gui.*).

Link to comment
Share on other sites

Sorry, I don't like having a go at people over messy code but...  :o

 

cleaned it up a bit and removed a few things I couldn't see uses for. Also fixed where your methods should be to the ones which are already provided, so should work. Button rendering gets handled by GuiScreen in drawScreen() so you don't have to deal with that, unless you override the super.

 

try this code, also made it so that yo don't have to rework your entire code if you add another class, just add it to the array.

 

http://pastebin.com/K2p1SnTa

Link to comment
Share on other sites

Thank you for your efforts but unfortunately the changes are not entirely applicable. The buttons, even in my messy code, still appear and function. However- the problem is that they are BEHIND the this.drawTexturedModalRect(k + x, l + y, 0, 198, 72, 58); rectangles.

 

For clarity, the rectangles being created are not for the purpose of button rendering, but are background images that are drawn to the screen out of necessity.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

yes, I got that. The re-write was mostly for my benefit when reading it, and to try and be helpful. It "should" fix it,

 

the problem in your code is

 

        super.drawScreen(par1, par2, par3); // draws buttons
        this.drawGuiContainerBackgroundLayer(par3, par1, par2);//draws background
        this.drawGuiContainerForegroundLayer(par1, par2); // is empty

Link to comment
Share on other sites

also there were a few things which could cause problems in your mod, such as how you were adding your buttons (doing this every tick could possible sabotage people (like me) who are running on old/low end PCs, each time you declare a variable in java it has to be given some memory space, doing this every tick slows it down (marginally). If you make it once and save it as local (such as in buttonList) this does not have to be re done every time therefore slightly faster and better coding practice)

 

also you were giving some of them the same ID

Link to comment
Share on other sites

I initially had the buttons created in the foreground method, but when that didn't work I checked out the code for other GUI's. Many of them had the buttons added in the 'updateScreen' method, so I tried putting it in that method instead. No matter what method I put it in, and no matter what order the buttons are rendered, the background image still appears on top of the buttons. I understand where you're coming from because in theory it seems like it should be working (so we seek out some minor unrelated issues) but regardless of those changes, it still does not render correctly.

Thank you for your attempt regardless.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

huh... that's odd.

Here's my only GUI with buttons & a background, have a look through it if you want as it definitely works https://github.com/Yagoki/MTech/blob/master/MTech/mtech/client/gui/GuiAlter.java

 

important method for this stuff is just the drawScreen method, It's for MC 1.6, but nothing has really changed since 1.5 in this, other than how you bind textures. Also there is a lot of stuff you don't need in this (all the GL11 is because this is fancy :) )

 

Also try looking through vanilla classes to see what they do. The only one which springs to mind is the achievements gui, (which the above is a cleaned up ripoff of), but there may be others that you can think of.

 

P.S. sorry if I was a bit offensive/rude in my earlier posts, a touch grumpy after having to update all my classes + real life stuff.

Link to comment
Share on other sites

I actually just figured it out thanks to you! I didn't catch it the first time

        super.drawScreen(par1, par2, par3); // draws buttons
        this.drawGuiContainerBackgroundLayer(par3, par1, par2);//draws background
        this.drawGuiContainerForegroundLayer(par1, par2); // is empty

 

But in this segment, I only just caught on that the 'draws buttons' comment you added was to suggest that the super.drawScreen(par1, par2, par3); should go AFTER my call to draw the background. *facepalm* Anyway, I moved that down without really thinking about it, and that worked. I only afterwards caught on that that was what you were trying to tell me.  ;D

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.