[Solved][1.16.5] Biomes make game crash

[QuantumSoul]

Hello,

When I try to load a world or open the world gen settings menu, the game crashes.

I realized this error happens only when I register my Biomes but I don't understand why.

 

My Biomes are registered like this:

public static final DeferredRegister<Biome> BIOMES = DeferredRegister.create(ForgeRegistries.BIOMES, BinaryMod.MOD_ID);
public static final RegistryObject<Biome> MY_BIOME = BIOMES.register("my_biome", Biomes::makeMyBiome);

Biomes#makeMyBiome method:

    private static final Lazy<ConfiguredSurfaceBuilder<SurfaceBuilderConfig>> BINARY_SURFACE_BUILDER = () -> GenerationInit.BINARY_SURFACE_BUILDER.get().func_242929_a(new SurfaceBuilderConfig(BlockInit.BINARY_BLOCK.get().getDefaultState(), BlockInit.ON_BINARY_BLOCK.get().getDefaultState(), null));

    public static Biome makeBinaryBiome()
    {
        MobSpawnInfo.Builder spawns = new MobSpawnInfo.Builder();
        BinDimBiomeFeatures.addBinDimSpawns(spawns);

        BiomeGenerationSettings.Builder gen = new BiomeGenerationSettings.Builder();
        gen.withSurfaceBuilder(BINARY_SURFACE_BUILDER::get);

        BinDimBiomeFeatures.addOres(gen);
        BinDimBiomeFeatures.addBugVirus(gen);
        BinDimBiomeFeatures.addStructures(gen);

        int color = 0x00ff00;

        return new Biome.Builder()
            .precipitation(Biome.RainType.NONE).category(Biome.Category.NONE).depth(0.1F).downfall(0F).scale(0.02F).temperature(1.5F)
            .setEffects(new BiomeAmbience.Builder().setWaterColor(color).setWaterFogColor(color).setFogColor(color).withSkyColor(color).build())
            .withMobSpawnSettings(spawns.copy())
            .withGenerationSettings(gen.build()).build();
    }

BinDimBiomeFeatures basically adds features to the BiomeGenerationSettings.Builder

 

Here's my whole project: https://github.com/BinaryQuantumSoul/BinaryMod/tree/1.16.5/src/main/java/com/quantumsoul/binarymod/world/biomes (1.16.5 Branch)

 

Has anyone an idea about why it crashes ?

Thanks in advance.

Edited February 21, 2021 by QuantumSoul

[QuantumSoul]

Solved, the problem was that I gave a null BlockState to my SurfaceBuilderConfig. I also had to register features, placements(decorators) and ruletests

 

Edited February 21, 2021 by QuantumSoul