Jump to content

Replacing a single method of a vanilla class


chrixian

Recommended Posts

First-- Thank you for looking at the thread... any help is appreciated.

 

I'm using Forge 9.10.0.786 and Mincraft 1.6.2. My end goal is to replace the drawItemStackTooltip method of the GuiContainer class.

 

I initially started by simply editing the GuiContainer file directly and now that I have it doing what I want I'm trying to figure out how I would go about implementing my changes to a fresh Forge install without modifying the original GuiContainer source directly.

 

All signs seem to point to having to use ASM, specifically implementing IFMLLoadingPlugin and IClassTransformer; however when I create a class that extends DummyModContainer and create classes that implement IFMLLoadingPlugin & IClassTransformer, when I hit the debug button to run the client there is no message in the console that FML or Forge has seen/recognized my classes and/or done anything with them.

 

When I create a class and annotate it with @Mod() etc as per the usual way I'd create a mod, it works as expected when I hit the debug button... Am I missing something special that has to be done from the deobfuscated environment ran from the IDE to use IFMLLoadingPlugin and IClassTransformer? Can I do class transformation from the FMLPreInitializationEvent or that not possible? Or perhaps there is a way to do what I want without IClassTransformer?

 

As I said, any insight/direction/correction/guidance/help is greatly appreciated.

Link to comment
Share on other sites

Use this tutorial: http://www.minecraftforge.net/wiki/Using_Access_Transformers

 

That covers the basics. If you know what you are doing then you can go from there :D

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Use this tutorial: http://www.minecraftforge.net/wiki/Using_Access_Transformers

 

That covers the basics. If you know what you are doing then you can go from there :D

 

According to that tutorial I do indeed have to compile and reobfuscate and drop the jar in the coremod or mod folder etc etc to have it work... bleh. So I guess that's that? Seems so strange that there is no way to transform classes on the fly within the development environment.. frustrating.. okay thanks for pointing me to that tutorial I'll read it thoroughly just to try to absorb anything more.

 

Link to comment
Share on other sites

Your welcome mate :D

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

I have now found that my CoreMod aint loading... Why would this be? I have everything I need :/

 

[hidden]

Main file:

package mrmewniverse.core;

import java.util.Map;

import cpw.mods.fml.relauncher.IFMLLoadingPlugin;
import cpw.mods.fml.relauncher.IFMLLoadingPlugin.TransformerExclusions;

@TransformerExclusions({
        "mrmewniverse.core", "mrmewniverse.core.transformer"
})
public class Core implements IFMLLoadingPlugin {

    @Override
    /*
     * Use if you want to download libraries. Returns a list of classes that
     * implement the ILibrarySet interface eg return new String[] {
     * "tutorial.asm.downloaders.DownloadUsefulLibrary " };
     */
    public String[] getLibraryRequestClass() {
        return null;
    }

    @Override
    /*
     * The class(es) that do(es) the transforming. Needs to implement
     * IClassTransformer in some way
     */
    public String[] getASMTransformerClass() {
        return new String[] {
                "mrmewniverse.core.transformer.CoreTransformer"
        };
    }

    @Override
    /*
     * The class that acts similarly to the @Mod annotation.
     */
    public String getModContainerClass() {
        return "mrmewniverse.core.CoreModContainer";
    }

    @Override
    /*
     * If you want to do stuff BEFORE minecraft starts, but after your mod is
     * loaded.
     */
    public String getSetupClass() {
        return null;
    }

    @Override
    /*
     * Gives the mod coremod data if it wants it.
     */
    public void injectData(Map<String, Object> data) {

    }
}

 

Mod Container:

package mrmewniverse.core;

import java.util.Arrays;

import net.minecraftforge.event.EventBus;
import net.minecraftforge.event.ForgeSubscribe;
import cpw.mods.fml.common.DummyModContainer;
import cpw.mods.fml.common.LoadController;
import cpw.mods.fml.common.ModMetadata;
import cpw.mods.fml.common.event.FMLServerStartingEvent;

public class CoreModContainer extends DummyModContainer {

    public CoreModContainer() {
        super(new ModMetadata());

        // The equivalent to mod metadata
        ModMetadata metadata = super.getMetadata();
        metadata.authorList = Arrays.asList(new String[] {
            "MrMewniverse"
        });
        metadata.description = "A test Core mod that will be further developed.";
        metadata.modId = CoreReference.MOD_ID;
        metadata.version = CoreReference.VERSION;
        metadata.name = CoreReference.NAME;
    }

    public boolean registerBus(EventBus par1EventBus, LoadController par2LoadController) {
        par1EventBus.register(this);
        return true;
    }

    @ForgeSubscribe
    public void onServerStarting(FMLServerStartingEvent event) {
        event.getServer().worldServerForDimension(0).spawnHostileMobs = false;
    }
}

 

Class transformer:

package mrmewniverse.core.transformer;

import java.io.IOException;
import java.lang.reflect.Method;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;

import cpw.mods.fml.common.asm.transformers.AccessTransformer;

public class CoreTransformer extends AccessTransformer {

    private static CoreTransformer instance;
    @SuppressWarnings({
            "rawtypes", "unchecked"
    })
    private static List<String> mapFiles = new LinkedList();

    public CoreTransformer() throws IOException {
        super();
        instance = this;

        // Add the transformers here
        mapFiles.add("mrmewniverse_at.cfg");

        Iterator<String> iterator = mapFiles.iterator();
        while (iterator.hasNext()) {
            String file = iterator.next();
            this.readMapFiles(file);
        }
    }

    public CoreTransformer(String par1Str) throws IOException {

    }

    public static void addTransformermap(String par1Str) {
        if (instance == null)
            mapFiles.add(par1Str);
        else
            instance.readMapFiles(par1Str);
    }

    private void readMapFiles(String par1Str) {
        System.out.println("Adding transformer mapping: " + par1Str);
        try {
            Method method = AccessTransformer.class.getDeclaredMethod("readMapFile", new Class[] {
                String.class
            });
            method.setAccessible(true);
            method.invoke(this, new Object[] {
                par1Str
            });
        } catch (Exception exception) {
            throw new RuntimeException(exception);
        }
    }
}

 

the _at.cfg

# MrMewniverse Access Transformer

# World Transformer
public up.G # spawnHostileMobs

# EntityPlayer Transformer
public og.m()V # increaseLevel

# Crafting Manage Transformer
public-f td.a # instance

 

And lastly the metainf stuff

Manifest-Version: 1.0
FMLCorePlugin: mrmewniverse.core.Core

 

And the reference file if needed:

package mrmewniverse.core;

public class CoreReference {

    public static final String MOD_ID = "mrmewniversecore";
    public static final String VERSION = "1.0.0";
    public static final String NAME = "MrMewniverse Core";
}

[/hidden]

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Coremods won't load by default in the Eclipse environment. You have to specify them as an argument in the run configuration.

 

Go to Run > Run Configurations..., select your main configuration (probably Client if you use the default setup), and select the Arguments tab. Insert "-Dfml.coreMods.load=com.example.mod.CoremodPlugin" into the VM Arguments box, just remove the quotes and insert the package/name of your IFMLLoadingPlugin class.

Link to comment
Share on other sites

Coremods won't load by default in the Eclipse environment. You have to specify them as an argument in the run configuration.

 

Go to Run > Run Configurations..., select your main configuration (probably Client if you use the default setup), and select the Arguments tab. Insert "-Dfml.coreMods.load=com.example.mod.CoremodPlugin" into the VM Arguments box, just remove the quotes and insert the package/name of your IFMLLoadingPlugin class.

 

omg  voidzm you've opened up new doors for me  :o :o :o :o :o

 

ty ty ty ty :D

Link to comment
Share on other sites

Seems so strange that there is no way to transform classes on the fly within the development environment..

ClassTransformers work just fine within eclipse. You just need to keep in mind that your mod code can't rely on the changes then, because eclipse doesn't know about them.

 

Ya I just meant it seems like such a common thing that people would want to do that it wouldn't have been suprising to me to find FML had something as simple as FMLMethodOverrideOMatic("class.oldmethod", "class.newmethod") and CPW/Lex/whoever do whatever sorcery they do and just make it happen automatically lol

Link to comment
Share on other sites

And now I am getting the WIERDEST error I have ever seen...

 

package mrmewniverse.core;

 

import java.util.Arrays;

 

import net.minecraftforge.event.ForgeSubscribe;

import cpw.mods.fml.common.DummyModContainer;

import cpw.mods.fml.common.LoadController;

import cpw.mods.fml.common.ModMetadata;

import cpw.mods.fml.common.event.FMLServerStartingEvent;

 

public class CoreModContainer extends DummyModContainer {

 

 

The bold p in the package declaration is underlined red with an error. This is the error:

"The type com.google.common.eventbus.EventBus cannot be resolved. It is indirectly referenced from required .class files"

 

Anyone know how to fix this? Minecraft launches as if there are no errors, but then it DOES crash when it gets to loading my core mod it gets this error:

2013-07-11 07:54:39 [iNFO] [sTDERR] Exception in thread "Minecraft main thread" java.lang.Error: Unresolved compilation problem:

2013-07-11 07:54:39 [iNFO] [sTDERR] The type com.google.common.eventbus.EventBus cannot be resolved. It is indirectly referenced from required .class files

2013-07-11 07:54:39 [iNFO] [sTDERR]

2013-07-11 07:54:39 [iNFO] [sTDERR] at mrmewniverse.core.CoreModContainer.<init>(CoreModContainer.java:1)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.reflect.Constructor.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.Class.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.identifyMods(Loader.java:331)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:480)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

 

[EDIT] Also note that this error doesn't appear until I extend DummyModContainer. If I remove it (thus stopping being a core mod) the error disappears...

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Use this tutorial: http://www.minecraftforge.net/wiki/Using_Access_Transformers

 

That covers the basics. If you know what you are doing then you can go from there :D

 

This tutorial is outdated and keeps misleading a lot of people.

 

The goal of AccessTransformers is just to change a vanilla access level:

 

i.e

private int var;

 

into

 

public int var;

 

and I also see a lot of people doing the same cfg stuff and call without understanding what it does.

 

public up.G # spawnHostileMobs

 

and

 

event.getServer().worldServerForDimension(0).spawnHostileMobs = false;

 

 

as for running in eclipse, you don't have to use the argument, you can create a dummy jar and in the manifest file point to the loading plugin. then copy that jar into mcp/jars/mods

 

I wrote a tutorial on coremods here http://www.minecraftforum.net/topic/1854988-

 

Link to comment
Share on other sites

Use this tutorial: http://www.minecraftforge.net/wiki/Using_Access_Transformers

 

That covers the basics. If you know what you are doing then you can go from there :D

 

This tutorial is outdated and keeps misleading a lot of people.

 

The goal of AccessTransformers is just to change a vanilla access level:

 

i.e

private int var;

 

into

 

public int var;

 

and I also see a lot of people doing the same cfg stuff and call without understanding what it does.

 

public up.G # spawnHostileMobs

 

and

 

event.getServer().worldServerForDimension(0).spawnHostileMobs = false;

 

 

as for running in eclipse, you don't have to use the argument, you can create a dummy jar and in the manifest file point to the loading plugin. then copy that jar into mcp/jars/mods

 

I wrote a tutorial on coremods here http://www.minecraftforum.net/topic/1854988-

 

Yeah I realize that now :/ oops... Anyway. Do you know anything about the error I am getting? It is really starting to bug me... :S

 

Any help is appreciated

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

And now I am getting the WIERDEST error I have ever seen...

 

package mrmewniverse.core;

 

import java.util.Arrays;

 

import net.minecraftforge.event.ForgeSubscribe;

import cpw.mods.fml.common.DummyModContainer;

import cpw.mods.fml.common.LoadController;

import cpw.mods.fml.common.ModMetadata;

import cpw.mods.fml.common.event.FMLServerStartingEvent;

 

public class CoreModContainer extends DummyModContainer {

 

 

The bold p in the package declaration is underlined red with an error. This is the error:

"The type com.google.common.eventbus.EventBus cannot be resolved. It is indirectly referenced from required .class files"

 

Anyone know how to fix this? Minecraft launches as if there are no errors, but then it DOES crash when it gets to loading my core mod it gets this error:

2013-07-11 07:54:39 [iNFO] [sTDERR] Exception in thread "Minecraft main thread" java.lang.Error: Unresolved compilation problem:

2013-07-11 07:54:39 [iNFO] [sTDERR] The type com.google.common.eventbus.EventBus cannot be resolved. It is indirectly referenced from required .class files

2013-07-11 07:54:39 [iNFO] [sTDERR]

2013-07-11 07:54:39 [iNFO] [sTDERR] at mrmewniverse.core.CoreModContainer.<init>(CoreModContainer.java:1)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.reflect.Constructor.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.Class.newInstance(Unknown Source)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.identifyMods(Loader.java:331)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:480)

2013-07-11 07:54:39 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-07-11 07:54:39 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-07-11 07:54:39 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

 

[EDIT] Also note that this error doesn't appear until I extend DummyModContainer. If I remove it (thus stopping being a core mod) the error disappears...

 

Well it's complaining about not being able to resolve a class from google guava, make sure guava's jar is added as a library on your projects build path

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.