Jump to content

[1.8] [SOLVED] Block summoning lightning on tick - lighting invisible


Brickfix

Recommended Posts

Hi Guys,

I am currently working on a block that spawns a lightning bolt into the world. This is for a structure to add some ambient or "scary moment".

Unfortunately, the lightning is invisible. I have worked out everything, and there even is a loud "Kabumm" the lightning makes and fire spawned exactly where I want it, but the lightning itself is not to be seen. I tested if it was my computer, but if I summon the lightning it works, I can definitly see it.

 

Here is the WGBlockLightning class:

package com.brickfix.worldgenmod.blocks;

import java.util.Random;

import com.brickfix.worldgenmod.WorldGenMod;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.effect.EntityLightningBolt;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class WGBlockLightning extends Block
{

private final String name = "lightningBlock";

public WGBlockLightning()
{
	super(Material.rock);
	GameRegistry.registerBlock(this, name);
	setUnlocalizedName(WorldGenMod.MODID + "_" + name);
	setCreativeTab(CreativeTabs.tabBlock);

	this.setTickRandomly(true);

}

public String getName()
{
	return name;
}

public int quantityDropped(Random random)
    {
        return 0;
    }

protected boolean canSilkHarvest()
    {
        return true;
    }

public void updateTick(World world, BlockPos pos, IBlockState state, Random random)
    {
        Entity lightning = new EntityLightningBolt(world, (double)pos.getX()+0.5, (double)pos.getY()+1, (double)pos.getZ()+0.5);
        

	world.spawnEntityInWorld(lightning);
    }

}

 

Thanks in advance for any help, it would be great if you could help me out :)

 

~Brickfix

 

 

 

Link to comment
Share on other sites

Hi

 

Lighting is not an entity same as mobs, you need to spawn it differently

 

Vanilla uses this in WorldServer::

                    if (this.canLightningStrike(blockpos))
                    {
                        this.addWeatherEffect(new EntityLightningBolt(this, (double)blockpos.getX(), (double)blockpos.getY(), (double)blockpos.getZ()));
                    }

or this in CommandSummon::

world.addWeatherEffect(new EntityLightningBolt(world, d0, d1, d2));

 

-TGG

Link to comment
Share on other sites

Hi TheGreyGhost,

thanks for your fast reply. I tried it out, but there are some problems - the world.canLightningStrike checks if it is actually raining  - but I want the lightning to spawn even if it does not rain. So at first nothing happened. Than I tried it without the if-statement, and again, I heard the lightning - but I didn't see it. There wasn't even the fire, which I had befor.

There is a command for spawning a lightning: /summon LightingBolt x y z , so I thought it should work simiular with the block I am using... Well, I'll check that out for than.

Anyway, thanks for your reply

~Brickfix

 

EDIT:

I solved the problem - I looked into the commandSummon code and there was the solution right befor my nose!

For all who are interested in this, here is the code that makes it work:

 

public void updateTick(World world, BlockPos pos, IBlockState state, Random random)
    {
        //System.out.println("updated");
	double dx = (double)pos.getX();
	double dy = (double)pos.getY();
	double dz = (double) pos.getZ();

	String sx = String.valueOf(pos.getX());
	String sy = String.valueOf(pos.getY());
	String sz = String.valueOf(pos.getZ());

	try 
	{
		dx = CommandBase.func_175761_b(dx, sx, true);
		dy = CommandBase.func_175761_b(dy, sy, false);
		dz = CommandBase.func_175761_b(dz, sz, true);
	} 
	catch (NumberInvalidException e) 
	{
		// TODO Auto-generated catch block
		e.printStackTrace();
	}
        
        
        world.addWeatherEffect(new EntityLightningBolt(world, dx, dy, dz));
        

    }

Thanks again for any help given :)

Link to comment
Share on other sites

Hi

 

Well that's odd.  The lightning summoning event (CommandSummon) you talked about does world.addWeatherEffect(new EntityLightningBolt(world, d0, d1, d2));

 

are you sure you're using the correct block [x,y,z]?

 

You should only spawn it on the server side, i.e. as below, but I can't see why that would cause your symptom.  Perhaps try a breakpoint in EntityLightningBolt.onUpdate() and RenderLightningBolt.doRender and inspect some of the variables /trace it through to see what is wrong.

 

if (!world.isRemote) {
  world.addWeatherEffect(new EntityLightningBolt(world, (double)pos.getX()+0.5, (double)pos.getY()+1, (double)pos.getZ()+0.5));
}

 

-TGG

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am not using hardcoded recipes, I'm using Vanilla's already existing code for leather armor dying. (via extending and implementing DyeableArmorItem / DyeableLeatherItem respectively) I have actually figured out that it's something to do with registering item colors to the ItemColors instance, but I'm trying to figure out where exactly in my mod's code I would be placing a call to the required event handler. Unfortunately the tutorial is criminally undescriptive. The most I've found is that it has to be done during client initialization. I'm currently trying to do the necessary setup via hijacking the item registry since trying to modify the item classes directly (via using SubscribeEvent in the item's constructor didn't work. Class so far: // mrrp mrow - mcmod item painter v1.0 - catzrule ch package catzadvitems.init; import net.minecraft.client.color.item.ItemColors; import net.minecraft.world.item.Item; import net.minecraftforge.registries.ObjectHolder; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.client.event.ColorHandlerEvent; import catzadvitems.item.DyeableWoolArmorItem; @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) public class Painter { @ObjectHolder("cai:dyeable_wool_chestplate") public static final Item W_CHEST = null; @ObjectHolder("cai:dyeable_wool_leggings") public static final Item W_LEGS = null; @ObjectHolder("cai:dyeable_wool_boots") public static final Item W_SOCKS = null; public Painter() { // left blank, idk if forge throws a fit if constructors are missing, not taking the chance of it happening. } @SubscribeEvent public static void init(FMLClientSetupEvent event) { new Painter(); } @Mod.EventBusSubscriber private static class ForgeBusEvents { @SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event) { ItemColors col = event.getItemColors(); col.register(DyeableUnderArmorItem::getItemDyedColor, W_CHEST, W_LEGS, W_SOCKS); //placeholder for other dye-able items here later.. } } } (for those wondering, i couldn't think of a creative wool helmet name)
    • nvm found out it was because i had create h and not f
    • Maybe there's something happening in the 'leather armor + dye' recipe itself that would be updating the held item texture?
    • @SubscribeEvent public static void onRenderPlayer(RenderPlayerEvent.Pre e) { e.setCanceled(true); model.renderToBuffer(e.getPoseStack(), pBuffer, e.getPackedLight(), 0f, 0f, 0f, 0f, 0f); //ToaPlayerRenderer.render(); } Since getting the render method from a separate class is proving to be bit of a brick wall for me (but seems to be the solution in older versions of minecraft/forge) I've decided to try and pursue using the renderToBuffer method directly from the model itself. I've tried this route before but can't figure out what variables to feed it for the vertexConsumer and still can't seem to figure it out; if this is even a path to pursue.  The vanilla model files do not include any form of render methods, and seem to be fully constructed from their layer definitions? Their renderer files seem to take their layers which are used by the render method in the vanilla MobRenderer class. But for modded entities we @Override this function and don't have to feed the method variables because of that? I assume that the render method in the extended renderer takes the layer definitions from the renderer classes which take those from the model files. Or maybe instead of trying to use a render method I should be calling the super from the renderer like   new ToaPlayerRenderer(context, false); Except I'm not sure what I would provide for context? There's a context method in the vanilla EntityRendererProvider class which doesn't look especially helpful. I've been trying something like <e.getEntity(), model<e.getEntity()>> since that generally seems to be what is provided to the renderers for context, but I don't know if it's THE context I'm looking for? Especially since the method being called doesn't want to take this or variations of this.   In short; I feel like I'm super super close but I have to be missing something obvious? Maybe this insane inane ramble post will provide some insight into this puzzle?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.