grand_gibus

Thanks for your answers. I cant send the logs right now (gonna do later) but I've checked them, and oddly enough I couldnt find any error at all. The meta/state getters seem to be working for me. So I tried to make a vanilla blockstate, and it worked somehow. It would be intrusting to know what didnt work though.

Help?

Thanks for the quick answer. I forgot to mention it, but there are no errors in the console, which I don't understand. Also, I put this blockstate json to make sure that it was not a simple json error. Maybe I was wrong. Here is the original json blockstate: maize.json { "forge_marker": 1, "defaults": { "model": "millenaire:maize", "textures": { "crop": "millenaire:blocks/maize_bottom_stage_0" }, "uvlock": true }, "variants": { "age=0,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_0"}}, "age=1,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_1"}}, "age=2,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_2"}}, "age=3,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_3"}}, "age=4,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_4"}}, "age=5,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_5"}}, "age=6,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_6"}}, "age=7,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_7"}}, "age=0,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_0"}}, "age=1,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_1"}}, "age=2,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_2"}}, "age=3,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_3"}}, "age=4,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_4"}}, "age=5,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_5"}}, "age=6,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_6"}}, "age=7,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_7"}} } }

Hello, so I have been working on a double crop block with two properties, HALF and AGE. It all works great, except when I try to load the models and textures through the blockstate json. I have no idea where to look for a solution to my problem. Even with a json blockstate that should always load only a stone model. The result in-game: maize.json { "forge_marker": 1, "defaults": { "model": "stone", "uvlock": true } } BlockMaize.java package org.millenaire.block.maya; import org.millenaire.MillenaireConstants.BlocksConstants; import org.millenaire.block.global.BlockDoubleCrops; import org.millenaire.init.MillenaireItems; import net.minecraft.item.Item; public class BlockMaize extends BlockDoubleCrops{ public BlockMaize() { super(); this.setRegistryName(BlocksConstants.MAIZE.getRegistryName()); this.setUnlocalizedName(BlocksConstants.MAIZE.getUnlocalizedName()); } protected Item getSeed() { return MillenaireItems.maize; } protected Item getCrop() { return MillenaireItems.maize; } @Override protected int getNewBlockCropHeight() { return 4; } } BlockDoubleCrops.java package org.millenaire.block.global; import java.util.Random; import net.minecraft.block.BlockCrops; import net.minecraft.block.properties.IProperty; import net.minecraft.block.properties.PropertyEnum; import net.minecraft.block.state.BlockStateContainer; import net.minecraft.block.state.IBlockState; import net.minecraft.init.Blocks; import net.minecraft.item.ItemStack; import net.minecraft.util.EnumFacing; import net.minecraft.util.IStringSerializable; import net.minecraft.util.math.AxisAlignedBB; import net.minecraft.util.math.BlockPos; import net.minecraft.world.Explosion; import net.minecraft.world.IBlockAccess; import net.minecraft.world.World; public abstract class BlockDoubleCrops extends BlockCrops{ public static final PropertyEnum<BlockDoubleCrops.DoubleCropsHalf> HALF = PropertyEnum.create("half", BlockDoubleCrops.DoubleCropsHalf.class); public BlockDoubleCrops() { super(); this.setDefaultState(this.getDefaultState().withProperty(HALF, DoubleCropsHalf.BOTTOM)); } @Override protected void checkAndDropBlock(World worldIn, BlockPos pos, IBlockState state) { if (!this.canBlockStay(worldIn, pos, state)) { this.dropBlockAsItem(worldIn, pos, state, 0); this.destroyPlant(state, pos, worldIn); } } @Override public boolean canBlockStay(World worldIn, BlockPos pos, IBlockState state) { BlockPos bottomCrop = this.getBottomCrop(worldIn, state, pos); if(bottomCrop.equals(pos)){ IBlockState soil = worldIn.getBlockState(pos.down()); return (worldIn.getLight(pos) >= 8 || worldIn.canSeeSky(pos)) && soil.getBlock().canSustainPlant(soil, worldIn, pos.down(), net.minecraft.util.EnumFacing.UP, this); }else{ if(pos.getY() - bottomCrop.getY() == 1){ return true; }else{ return false; } } } public void destroyPlant(IBlockState state, BlockPos pos, World world){ BlockPos bottomCrop = this.getBottomCrop(world, state, pos); BlockPos topCrop = this.getAllCrop(world, pos, EnumFacing.UP); while(topCrop.getY() >= bottomCrop.getY()){ world.setBlockState(topCrop, Blocks.AIR.getDefaultState(), 3); topCrop = topCrop.down(); } } @Override public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand){ if (worldIn.getLightFromNeighbors(pos.up()) >= 9) { int i = this.getAge(state); if (i < this.getMaxAge()) { float f = getGrowthChance(this, worldIn, pos); if(net.minecraftforge.common.ForgeHooks.onCropsGrowPre(worldIn, pos, state, rand.nextInt((int)(25.0F / f) + 1) == 0)) { this.tryGrow(worldIn, pos, state, i + 1); net.minecraftforge.common.ForgeHooks.onCropsGrowPost(worldIn, pos, state, worldIn.getBlockState(pos)); } } } } @Override public void grow(World worldIn, BlockPos pos, IBlockState state) { int i = this.getAge(state) + this.getBonemealAgeIncrease(worldIn); int j = this.getMaxAge(); if (i > j) { i = j; } this.tryGrow(worldIn, pos, state, i); } public boolean tryGrow(World worldIn, BlockPos pos, IBlockState state, int i){ if(this.isBottomCrop(worldIn, state, pos)){ boolean canGrow = true; if(i >= this.getNewBlockCropHeight()){ canGrow = false; BlockPos topPos = pos.up(); IBlockState topCrop = worldIn.getBlockState(topPos); if(topCrop.getBlock() == this){ worldIn.setBlockState(topPos, this.setAge(topCrop.withProperty(HALF, DoubleCropsHalf.TOP), i), 2); canGrow = true; }else if(worldIn.isAirBlock(topPos)){ worldIn.setBlockState(topPos, this.setAge(this.getDefaultState().withProperty(HALF, DoubleCropsHalf.TOP), i), 2); canGrow = true; } } if(canGrow){ worldIn.setBlockState(pos, this.setAge(state.withProperty(HALF, DoubleCropsHalf.BOTTOM), i), 2); } return canGrow; } return false; } @Override public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) { boolean top = state.getValue(HALF) == DoubleCropsHalf.TOP; return new AxisAlignedBB(0.0D, top ? -1.0D : 0.0D, 0.0D, 1.0D, getCropHeightAtAge(state.getValue(AGE)) + (top ? -1.0D : 0.0D), 1.0D); } protected double getCropHeightAtAge(int age){ return (age + 1) * 0.25D; } @Override public void onBlockDestroyedByExplosion(World worldIn, BlockPos pos, Explosion explosionIn) { this.destroyPlant(worldIn.getBlockState(pos), pos, worldIn); } @Override public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state) { this.destroyPlant(state, pos, worldIn); } @Override public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune) { if(this.isBottomCrop(world, state, pos) && state.getValue(HALF) == DoubleCropsHalf.BOTTOM){ this.getDoubleCropsDrops(drops, world, pos, state, fortune); } } public void getDoubleCropsDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune) { super.getDrops(drops, world, pos, state, fortune); } private IBlockState setAge(IBlockState state, int age){ return state.withProperty(AGE, Integer.valueOf(age)); } private boolean isBottomCrop(IBlockAccess world, IBlockState state, BlockPos pos){ return pos.equals(getBottomCrop(world, state, pos)); } public BlockPos getBottomCrop(IBlockAccess world, IBlockState state, BlockPos pos){ return getAllCrop(world, pos, EnumFacing.DOWN); } public BlockPos getAllCrop(IBlockAccess world, BlockPos pos, EnumFacing direction){ BlockPos bottom = pos; while(world.getBlockState(bottom.offset(direction)).getBlock() == this){ bottom = bottom.offset(direction); } return bottom; } @Override public IBlockState getStateFromMeta(int meta) { DoubleCropsHalf half = DoubleCropsHalf.BOTTOM; if((meta & 1) > 0){ half = DoubleCropsHalf.TOP; } meta >>= 1; return this.withAge(meta).withProperty(HALF, half); } @Override public int getMetaFromState(IBlockState state) { boolean top = state.getValue(HALF) == DoubleCropsHalf.TOP; int meta = this.getAge(state); meta <<= 1; if(top){ meta = meta | 1; } return meta; } @Override protected BlockStateContainer createBlockState() { return new BlockStateContainer(this, new IProperty[] {AGE, HALF}); } protected abstract int getNewBlockCropHeight(); public enum DoubleCropsHalf implements IStringSerializable{ BOTTOM("bottom"), TOP("top"); private String name; private DoubleCropsHalf(String name){ this.name = name; } @Override public String getName() { return this.name; }} } BlockCrops.java (from minecraft) package net.minecraft.block; import java.util.Random; import net.minecraft.block.properties.IProperty; import net.minecraft.block.properties.PropertyInteger; import net.minecraft.block.state.BlockStateContainer; import net.minecraft.block.state.IBlockState; import net.minecraft.creativetab.CreativeTabs; import net.minecraft.init.Blocks; import net.minecraft.init.Items; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.util.math.AxisAlignedBB; import net.minecraft.util.math.BlockPos; import net.minecraft.util.math.MathHelper; import net.minecraft.world.IBlockAccess; import net.minecraft.world.World; public class BlockCrops extends BlockBush implements IGrowable { public static final PropertyInteger AGE = PropertyInteger.create("age", 0, 7); private static final AxisAlignedBB[] CROPS_AABB = new AxisAlignedBB[] {new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.125D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.25D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.375D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.5D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.625D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.75D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.875D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 1.0D, 1.0D)}; protected BlockCrops() { this.setDefaultState(this.blockState.getBaseState().withProperty(this.getAgeProperty(), Integer.valueOf(0))); this.setTickRandomly(true); this.setCreativeTab((CreativeTabs)null); this.setHardness(0.0F); this.setSoundType(SoundType.PLANT); this.disableStats(); } public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) { return CROPS_AABB[((Integer)state.getValue(this.getAgeProperty())).intValue()]; } /** * Return true if the block can sustain a Bush */ protected boolean canSustainBush(IBlockState state) { return state.getBlock() == Blocks.FARMLAND; } protected PropertyInteger getAgeProperty() { return AGE; } public int getMaxAge() { return 7; } protected int getAge(IBlockState state) { return ((Integer)state.getValue(this.getAgeProperty())).intValue(); } public IBlockState withAge(int age) { return this.getDefaultState().withProperty(this.getAgeProperty(), Integer.valueOf(age)); } public boolean isMaxAge(IBlockState state) { return ((Integer)state.getValue(this.getAgeProperty())).intValue() >= this.getMaxAge(); } public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand) { super.updateTick(worldIn, pos, state, rand); if (worldIn.getLightFromNeighbors(pos.up()) >= 9) { int i = this.getAge(state); if (i < this.getMaxAge()) { float f = getGrowthChance(this, worldIn, pos); if(net.minecraftforge.common.ForgeHooks.onCropsGrowPre(worldIn, pos, state, rand.nextInt((int)(25.0F / f) + 1) == 0)) { worldIn.setBlockState(pos, this.withAge(i + 1), 2); net.minecraftforge.common.ForgeHooks.onCropsGrowPost(worldIn, pos, state, worldIn.getBlockState(pos)); } } } } public void grow(World worldIn, BlockPos pos, IBlockState state) { int i = this.getAge(state) + this.getBonemealAgeIncrease(worldIn); int j = this.getMaxAge(); if (i > j) { i = j; } worldIn.setBlockState(pos, this.withAge(i), 2); } protected int getBonemealAgeIncrease(World worldIn) { return MathHelper.getInt(worldIn.rand, 2, 5); } protected static float getGrowthChance(Block blockIn, World worldIn, BlockPos pos) { float f = 1.0F; BlockPos blockpos = pos.down(); for (int i = -1; i <= 1; ++i) { for (int j = -1; j <= 1; ++j) { float f1 = 0.0F; IBlockState iblockstate = worldIn.getBlockState(blockpos.add(i, 0, j)); if (iblockstate.getBlock().canSustainPlant(iblockstate, worldIn, blockpos.add(i, 0, j), net.minecraft.util.EnumFacing.UP, (net.minecraftforge.common.IPlantable)blockIn)) { f1 = 1.0F; if (iblockstate.getBlock().isFertile(worldIn, blockpos.add(i, 0, j))) { f1 = 3.0F; } } if (i != 0 || j != 0) { f1 /= 4.0F; } f += f1; } } BlockPos blockpos1 = pos.north(); BlockPos blockpos2 = pos.south(); BlockPos blockpos3 = pos.west(); BlockPos blockpos4 = pos.east(); boolean flag = blockIn == worldIn.getBlockState(blockpos3).getBlock() || blockIn == worldIn.getBlockState(blockpos4).getBlock(); boolean flag1 = blockIn == worldIn.getBlockState(blockpos1).getBlock() || blockIn == worldIn.getBlockState(blockpos2).getBlock(); if (flag && flag1) { f /= 2.0F; } else { boolean flag2 = blockIn == worldIn.getBlockState(blockpos3.north()).getBlock() || blockIn == worldIn.getBlockState(blockpos4.north()).getBlock() || blockIn == worldIn.getBlockState(blockpos4.south()).getBlock() || blockIn == worldIn.getBlockState(blockpos3.south()).getBlock(); if (flag2) { f /= 2.0F; } } return f; } public boolean canBlockStay(World worldIn, BlockPos pos, IBlockState state) { IBlockState soil = worldIn.getBlockState(pos.down()); return (worldIn.getLight(pos) >= 8 || worldIn.canSeeSky(pos)) && soil.getBlock().canSustainPlant(soil, worldIn, pos.down(), net.minecraft.util.EnumFacing.UP, this); } protected Item getSeed() { return Items.WHEAT_SEEDS; } protected Item getCrop() { return Items.WHEAT; } @Override public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune) { super.getDrops(drops, world, pos, state, fortune); int age = getAge(state); Random rand = world instanceof World ? ((World)world).rand : new Random(); if (age >= getMaxAge()) { int k = 3 + fortune; for (int i = 0; i < 3 + fortune; ++i) { if (rand.nextInt(2 * getMaxAge()) <= age) { drops.add(new ItemStack(this.getSeed(), 1, 0)); } } } } /** * Spawns this Block's drops into the World as EntityItems. */ public void dropBlockAsItemWithChance(World worldIn, BlockPos pos, IBlockState state, float chance, int fortune) { super.dropBlockAsItemWithChance(worldIn, pos, state, chance, 0); if (false && !worldIn.isRemote) // Forge: NOP all this. { int i = this.getAge(state); if (i >= this.getMaxAge()) { int j = 3 + fortune; for (int k = 0; k < j; ++k) { if (worldIn.rand.nextInt(2 * this.getMaxAge()) <= i) { spawnAsEntity(worldIn, pos, new ItemStack(this.getSeed())); } } } } } /** * Get the Item that this Block should drop when harvested. */ public Item getItemDropped(IBlockState state, Random rand, int fortune) { return this.isMaxAge(state) ? this.getCrop() : this.getSeed(); } public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state) { return new ItemStack(this.getSeed()); } /** * Whether this IGrowable can grow */ public boolean canGrow(World worldIn, BlockPos pos, IBlockState state, boolean isClient) { return !this.isMaxAge(state); } public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, IBlockState state) { return true; } public void grow(World worldIn, Random rand, BlockPos pos, IBlockState state) { this.grow(worldIn, pos, state); } /** * Convert the given metadata into a BlockState for this Block */ public IBlockState getStateFromMeta(int meta) { return this.withAge(meta); } /** * Convert the BlockState into the correct metadata value */ public int getMetaFromState(IBlockState state) { return this.getAge(state); } protected BlockStateContainer createBlockState() { return new BlockStateContainer(this, new IProperty[] {AGE}); } } Any help would be reaaally apreciated, I don't have a clue on whats wrong. Thanks in advance!

Ok so I figured it out by myself, luckily enough. So if someone needs to know, you need to subscribe to the RenderWorldLastEvent and put your render code there. The render coordinates are the player coordinates (Minecraft.getMinecraft().player) - the absolute coordinate where you want the element to render. If you need the partialTicks value, idk if its good but i subscribed the TickEvent.RenderTickEvent and got the partial tick value from there, its maybe trash but it works

Hello, so I'd like to know how, considering I have world coordinates, render a cube/shape in the world. Do I have to make an event handler for the RenderTick event? What do I have to write to render the cube? Do I have to extend a Render class? I have no idea how to do it, thanks in advance!

Thank you so much! I feel like it's going to be a huge pain to implement but at least I'm not stuck anymore

Hello, I'd like to know how to bind an entity a texture located outside of the jar. I've worked in an IDE and now realise I needed to move my custom assets outside of the .jar, if I want my code to be able to read them. Thanks. I'm so dumb, the whole mod I'm making is litterally useless if I don't figure it out

Ok, thank you a lot for your replies. I'm going to look into that.

Hello, so I'm making a mod and I'd like to use the CTM mod to make connected textures (https://minecraft.curseforge.com/projects/ctm) My question is, is it possible (if I have the permission) to directly combine it with my mod so there's only one .jar to download? Thanks in advance

Ok, thank you very much for the quick reply! I'm going to try it.

Hello, is there still a way to make special item renderers? I heard about IItemRenderer, but it got removed. I need it because I need to color an item depending on it's NBT, but only a part of it so I can't use the default minecraft coloring system. Thanks in advance!

Hello everyone, I'd like to know how to do dynamic connected textures. I don't wish to use blockstates because it would need way too many. I have no idea on how to do that. Thanks in advance!

Thank you Abastro! It didn't really work out in the first place but then I messed a bit around and it ended up working by adding an onDataPacket() override . Here is my code if anyone from the future has this problem: @Override public void readFromNBT(NBTTagCompound compound) { this.schematicName = compound.getString("schematicName"); super.readFromNBT(compound); } @Override public NBTTagCompound writeToNBT(NBTTagCompound compound) { NBTTagCompound nbt = super.writeToNBT(compound); nbt.setString("schematicName", schematicName); return nbt; } @Override public NBTTagCompound getUpdateTag() { return this.writeToNBT(new NBTTagCompound()); } @Nullable @Override public SPacketUpdateTileEntity getUpdatePacket() { return new SPacketUpdateTileEntity(this.getPos(), 1, this.getUpdateTag()); } @Override public void onDataPacket(net.minecraft.network.NetworkManager net, net.minecraft.network.play.server.SPacketUpdateTileEntity pkt) { this.readFromNBT(pkt.getNbtCompound()); } When the client the custom server packet handler recieve a message from the client gui, it executes this code: public static void updateWorkBenchInfo(ServerMessage message, WorldServer world){ NBTTagCompound nbt = message.tag; TileEntityWorkBench workbench = (TileEntityWorkBench) world.getTileEntity(new BlockPos(nbt.getInteger("x"), nbt.getInteger("y"), nbt.getInteger("z"))); workbench.updateSchematicName(nbt.getString("schematicname")); BlockPos pos = new BlockPos(nbt.getInteger("x"), nbt.getInteger("y"), nbt.getInteger("z")); world.markAndNotifyBlock(pos, null, world.getBlockState(pos), world.getBlockState(pos), 2); return; }

This is the code from ItemSword public Multimap<String, AttributeModifier> getItemAttributeModifiers(EntityEquipmentSlot equipmentSlot) { Multimap<String, AttributeModifier> multimap = super.getItemAttributeModifiers(equipmentSlot); if (equipmentSlot == EntityEquipmentSlot.MAINHAND) { multimap.put(SharedMonsterAttributes.ATTACK_DAMAGE.getName(), new AttributeModifier(ATTACK_DAMAGE_MODIFIER, "Weapon modifier", (double)this.attackDamage, 0)); multimap.put(SharedMonsterAttributes.ATTACK_SPEED.getName(), new AttributeModifier(ATTACK_SPEED_MODIFIER, "Weapon modifier", -2.4000000953674316D, 0)); } return multimap; } I think it's the ATTACK_SPEED modifier, but I'm not 100% sure Edit: Oops didn't see the "for every item" part ^^ Edit 2: Maybe that will work? (According to the wiki) public double getAttackSpeed(Item item){ double x = 0; if(item.getAttributeModifiers(EntityEquipmentSlot.MAINHAND, new ItemStack(item)).containsKey("generic.attackSpeed")){ for(AttributeModifier mod : item.getAttributeModifiers(EntityEquipmentSlot.MAINHAND, new ItemStack(item)).get("generic.attackSpeed")){ if(mod.getOperation() == 0){ x += mod.getAmount(); } } y = x; for(AttributeModifier mod : item.getAttributeModifiers(EntityEquipmentSlot.MAINHAND, new ItemStack(item)).get("generic.attackSpeed")){ if(mod.getOperation() == 1){ y += x * mod.getAmount(); } } for(AttributeModifier mod : item.getAttributeModifiers(EntityEquipmentSlot.MAINHAND, new ItemStack(item)).get("generic.attackSpeed")){ if(mod.getOperation() == 2){ y += y * mod.getAmount(); } } } return y; } The wiki says that this is how attribute modfiers are calculated, but I don't know if an item can contains multiple attack speed modifiers. You might only do mod.getAmount() once aswell