I'm trying to add a custom 5 by 5 crafting table into my forge 1.12.2 mod. I want so that when a button in the gui is pressed (The craft button) it crafts an item, this is run through the craftitem() function in the tile entity class. The problem however is that when I try to craft in game, is shows up the correct item but when I try to click it to take it out (or update the container in some way), everything resets to how it was before I pressed the craft button.
Can anyone see anything wrong or missing from my code that would cause this problem?
Tile Entity
package com.mindstorm3223.songsofwarmod.blocks.craftinganvil;
import net.minecraft.client.renderer.texture.ITickable;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.ItemStackHelper;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.NonNullList;
import net.minecraft.util.math.MathHelper;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.items.ItemStackHandler;
public class TileEntityCraftingAnvil extends TileEntity implements IInventory{
private NonNullList<ItemStack> inventory = NonNullList.<ItemStack>withSize(26, ItemStack.EMPTY);
private String customName;
@Override
public String getName() {
return this.hasCustomName() ? this.customName : "container.crafting_anvil";
}
@Override
public boolean hasCustomName() {
return this.customName != null && !this.customName.isEmpty();
}
public void setCustomName(String customName) {
this.customName = customName;
}
@Override
public ITextComponent getDisplayName() {
return this.hasCustomName() ? new TextComponentString(this.getName()) : new TextComponentTranslation(this.getName());
}
@Override
public int getSizeInventory() {
return this.inventory.size();
}
@Override
public boolean isEmpty() {
for(ItemStack stack : this.inventory) {
if(!stack.isEmpty()) return false;
}
return true;
}
@Override
public ItemStack getStackInSlot(int index) {
return (ItemStack)this.inventory.get(index);
}
@Override
public ItemStack decrStackSize(int index, int count) {
return ItemStackHelper.getAndSplit(this.inventory, index, count);
}
@Override
public ItemStack removeStackFromSlot(int index) {
return ItemStackHelper.getAndRemove(this.inventory, index);
}
@Override
public void setInventorySlotContents(int index, ItemStack stack) {
ItemStack itemstack = (ItemStack)this.inventory.get(index);
boolean flag =!stack.isEmpty() && stack.isItemEqual(itemstack) && ItemStack.areItemStackTagsEqual(stack, itemstack);
this.inventory.set(index, stack);
if(stack.getCount() > this.getInventoryStackLimit()) stack.setCount(this.getInventoryStackLimit());
if(index == 0 && index + 1 == 1 && !flag) {
ItemStack stack1 = (ItemStack)this.inventory.get(index + 1);
this.markDirty();
}
}
@Override
public void readFromNBT(NBTTagCompound compound) {
super.readFromNBT(compound);
this.inventory = NonNullList.<ItemStack>withSize(this.getSizeInventory(), ItemStack.EMPTY);
ItemStackHelper.loadAllItems(compound, this.inventory);
if(compound.hasKey("CustomName", 8)) this.setCustomName(compound.getString("CustomName"));
}
@Override
public NBTTagCompound writeToNBT(NBTTagCompound compound) {
super.writeToNBT(compound);
ItemStackHelper.saveAllItems(compound, this.inventory);
if(this.hasCustomName()) compound.setString("CustomName", this.customName);
return compound;
}
@Override
public int getInventoryStackLimit() {
return 64;
}
public int getCraftTime() {
return 200;
}
private boolean canCraft() {
ItemStack result = CraftingAnvilRecipes.getInstance().getCraftingResult((ItemStack)this.inventory.get(0), (ItemStack)this.inventory.get(1), (ItemStack)this.inventory.get(2), (ItemStack)this.inventory.get(3), (ItemStack)this.inventory.get(4), (ItemStack)this.inventory.get(5), (ItemStack)this.inventory.get(6), (ItemStack)this.inventory.get(7), (ItemStack)this.inventory.get(8), (ItemStack)this.inventory.get(9), (ItemStack)this.inventory.get(10), (ItemStack)this.inventory.get(11), (ItemStack)this.inventory.get(12), (ItemStack)this.inventory.get(13), (ItemStack)this.inventory.get(14), (ItemStack)this.inventory.get(15), (ItemStack)this.inventory.get(16), (ItemStack)this.inventory.get(17), (ItemStack)this.inventory.get(18), (ItemStack)this.inventory.get(19), (ItemStack)this.inventory.get(20), (ItemStack)this.inventory.get(21), (ItemStack)this.inventory.get(22), (ItemStack)this.inventory.get(23), (ItemStack)this.inventory.get(24));
if(result.isEmpty()) return false;
else {
ItemStack output = (ItemStack)this.inventory.get(25);
if(output.isEmpty()) return true;
if(!output.isItemEqual(result)) return false;
int res = output.getCount() + result.getCount();
return res <= getInventoryStackLimit() && res <= output.getMaxStackSize();
}
}
public void craftItem() {
if(this.canCraft()) {
ItemStack input11 = (ItemStack)this.inventory.get(0);
ItemStack input12 = (ItemStack)this.inventory.get(1);
ItemStack input13 = (ItemStack)this.inventory.get(2);
ItemStack input14 = (ItemStack)this.inventory.get(3);
ItemStack input15 = (ItemStack)this.inventory.get(4);
ItemStack input21 = (ItemStack)this.inventory.get(5);
ItemStack input22 = (ItemStack)this.inventory.get(6);
ItemStack input23 = (ItemStack)this.inventory.get(7);
ItemStack input24 = (ItemStack)this.inventory.get(8);
ItemStack input25 = (ItemStack)this.inventory.get(9);
ItemStack input31 = (ItemStack)this.inventory.get(10);
ItemStack input32 = (ItemStack)this.inventory.get(11);
ItemStack input33 = (ItemStack)this.inventory.get(12);
ItemStack input34 = (ItemStack)this.inventory.get(13);
ItemStack input35 = (ItemStack)this.inventory.get(14);
ItemStack input41 = (ItemStack)this.inventory.get(15);
ItemStack input42 = (ItemStack)this.inventory.get(16);
ItemStack input43 = (ItemStack)this.inventory.get(17);
ItemStack input44 = (ItemStack)this.inventory.get(18);
ItemStack input45 = (ItemStack)this.inventory.get(19);
ItemStack input51 = (ItemStack)this.inventory.get(20);
ItemStack input52 = (ItemStack)this.inventory.get(21);
ItemStack input53 = (ItemStack)this.inventory.get(22);
ItemStack input54 = (ItemStack)this.inventory.get(23);
ItemStack input55 = (ItemStack)this.inventory.get(24);
ItemStack result = CraftingAnvilRecipes.getInstance().getCraftingResult(input11, input12, input13, input14, input15, input21, input22, input23, input24, input25, input31, input32, input33, input34, input35, input41, input42, input43, input44, input45, input51, input52, input53, input54, input55);
ItemStack output = (ItemStack)this.inventory.get(25);
if(output.getItem() == Items.AIR) this.inventory.set(25, result.copy());
else if(output.getItem() == result.getItem()) {
output.grow(result.getCount());
}
if(!(input11 == ItemStack.EMPTY)) input11.shrink(1);
if(!(input12 == ItemStack.EMPTY)) input12.shrink(1);
if(!(input13 == ItemStack.EMPTY)) input13.shrink(1);
if(!(input14 == ItemStack.EMPTY)) input14.shrink(1);
if(!(input15 == ItemStack.EMPTY)) input15.shrink(1);
if(!(input21 == ItemStack.EMPTY)) input21.shrink(1);
if(!(input22 == ItemStack.EMPTY)) input22.shrink(1);
if(!(input23 == ItemStack.EMPTY)) input23.shrink(1);
if(!(input24 == ItemStack.EMPTY)) input24.shrink(1);
if(!(input25 == ItemStack.EMPTY)) input25.shrink(1);
if(!(input31 == ItemStack.EMPTY)) input31.shrink(1);
if(!(input32 == ItemStack.EMPTY)) input32.shrink(1);
if(!(input33 == ItemStack.EMPTY)) input33.shrink(1);
if(!(input34 == ItemStack.EMPTY)) input34.shrink(1);
if(!(input35 == ItemStack.EMPTY)) input35.shrink(1);
if(!(input41 == ItemStack.EMPTY)) input41.shrink(1);
if(!(input42 == ItemStack.EMPTY)) input42.shrink(1);
if(!(input43 == ItemStack.EMPTY)) input43.shrink(1);
if(!(input44 == ItemStack.EMPTY)) input44.shrink(1);
if(!(input45 == ItemStack.EMPTY)) input45.shrink(1);
if(!(input51 == ItemStack.EMPTY)) input51.shrink(1);
if(!(input52 == ItemStack.EMPTY)) input52.shrink(1);
if(!(input53 == ItemStack.EMPTY)) input53.shrink(1);
if(!(input54 == ItemStack.EMPTY)) input54.shrink(1);
if(!(input55 == ItemStack.EMPTY)) input55.shrink(1);
this.inventory.set(0, input11);
this.inventory.set(1, input12);
this.inventory.set(2, input13);
this.inventory.set(3, input14);
this.inventory.set(4, input15);
this.inventory.set(5, input21);
this.inventory.set(6, input22);
this.inventory.set(7, input23);
this.inventory.set(8, input24);
this.inventory.set(9, input25);
this.inventory.set(10, input31);
this.inventory.set(11, input32);
this.inventory.set(12, input33);
this.inventory.set(13, input34);
this.inventory.set(14, input35);
this.inventory.set(15, input41);
this.inventory.set(16, input42);
this.inventory.set(17, input43);
this.inventory.set(18, input44);
this.inventory.set(19, input45);
this.inventory.set(20, input51);
this.inventory.set(21, input52);
this.inventory.set(22, input53);
this.inventory.set(23, input54);
this.inventory.set(24, input55);
this.inventory.set(25, result);
markDirty();
}
}
@Override
public boolean isUsableByPlayer(EntityPlayer player) {
return this.world.getTileEntity(this.pos) != this ? false : player.getDistanceSq((double)this.pos.getX() + 0.5D, (double)this.pos.getY() + 0.5D, (double)this.pos.getZ() + 0.5D) <= 64.0D;
}
@Override
public void openInventory(EntityPlayer player) {}
@Override
public void closeInventory(EntityPlayer player) {}
@Override
public boolean isItemValidForSlot(int index, ItemStack stack) {
if(index == 25) return false;
else return true;
}
public String getGUIID() {
return "sow:crafting_anvil";
}
@Override
public void setField(int id, int value) {
}
@Override
public int getFieldCount() {
return 0;
}
@Override
public void clear() {
this.inventory.clear();
}
@Override
public int getField(int id) {
return 0;
}
@SideOnly(Side.CLIENT)
public static boolean isBurning(TileEntityCraftingAnvil te)
{
return te.getField(0) > 0;
}
}
GUI
package com.mindstorm3223.songsofwarmod.blocks.craftinganvil;
import java.io.IOException;
import com.mindstorm3223.songsofwarmod.util.Reference;
import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.IContainerListener;
import net.minecraft.util.ResourceLocation;
public class GUICraftingAnvil extends GuiContainer{
private static final ResourceLocation TEXTURES = new ResourceLocation(Reference.MOD_ID + ":textures/gui/crafting_anvil.png");
private final InventoryPlayer player;
private final TileEntityCraftingAnvil tileentity;
private int width = 176, height = 199;
private boolean i = false;
public GUICraftingAnvil(InventoryPlayer player, TileEntityCraftingAnvil tileentity) {
super(new ContainerCraftingAnvil(player, tileentity));
this.player = player;
this.tileentity = tileentity;
}
@Override
protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
String tileName = this.tileentity.getDisplayName().getUnformattedText();
this.fontRenderer.drawString(tileName, (width / 2 - this.fontRenderer.getStringWidth(tileName) / 2), 4, 4210752);
this.fontRenderer.drawString(this.player.getDisplayName().getUnformattedText(), 6, height - 96 + 2, 4210752);
}
@Override
protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
GlStateManager.color(1.0f, 1.0f, 1.0f, 1.0f);
this.mc.getTextureManager().bindTexture(TEXTURES);
this.drawTexturedModalRect(this.guiLeft, this.guiTop, 0, 0, width, height);
}
@Override
public void initGui() {
super.initGui();
this.buttonList.add(new GuiButton(0, this.guiLeft + 105, this.guiTop + 80, 50, 16, "Craft"));
}
@Override
protected void actionPerformed(GuiButton button) throws IOException {
if(button.id == 0) {
System.out.println("button");
tileentity.craftItem();
tileentity.markDirty();
updateScreen();
}
}
}
Container
package com.mindstorm3223.songsofwarmod.blocks.craftinganvil;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IContainerListener;
import net.minecraft.inventory.InventoryCraftResult;
import net.minecraft.inventory.InventoryCrafting;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.util.NonNullList;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
public class ContainerCraftingAnvil extends Container{
private final TileEntityCraftingAnvil tileentity;
private int craftTime, totalCraftTime;
public ContainerCraftingAnvil(InventoryPlayer player, TileEntityCraftingAnvil tileentity) {
this.tileentity = tileentity;
this.addSlotToContainer(new Slot(tileentity, 0, 8, 15));
this.addSlotToContainer(new Slot(tileentity, 1, 26, 15));
this.addSlotToContainer(new Slot(tileentity, 2, 44, 15));
this.addSlotToContainer(new Slot(tileentity, 3, 62, 15));
this.addSlotToContainer(new Slot(tileentity, 4, 80, 15));
this.addSlotToContainer(new Slot(tileentity, 5, 8, 33));
this.addSlotToContainer(new Slot(tileentity, 6, 26, 33));
this.addSlotToContainer(new Slot(tileentity, 7, 44, 33));
this.addSlotToContainer(new Slot(tileentity, 8, 62, 33));
this.addSlotToContainer(new Slot(tileentity, 9, 80, 33));
this.addSlotToContainer(new Slot(tileentity, 10, 8, 51));
this.addSlotToContainer(new Slot(tileentity, 11, 26, 51));
this.addSlotToContainer(new Slot(tileentity, 12, 44, 51));
this.addSlotToContainer(new Slot(tileentity, 13, 62, 51));
this.addSlotToContainer(new Slot(tileentity, 14, 80, 51));
this.addSlotToContainer(new Slot(tileentity, 15, 8, 69));
this.addSlotToContainer(new Slot(tileentity, 16, 26, 69));
this.addSlotToContainer(new Slot(tileentity, 17, 44, 69));
this.addSlotToContainer(new Slot(tileentity, 18, 62, 69));
this.addSlotToContainer(new Slot(tileentity, 19, 80, 69));
this.addSlotToContainer(new Slot(tileentity, 20, 8, 87));
this.addSlotToContainer(new Slot(tileentity, 21, 26, 87));
this.addSlotToContainer(new Slot(tileentity, 22, 44, 87));
this.addSlotToContainer(new Slot(tileentity, 23, 62, 87));
this.addSlotToContainer(new Slot(tileentity, 24, 80, 87));
this.addSlotToContainer(new SlotCraftingAnvilOutput(player.player, tileentity, 25, 140, 53));
for(int y = 0; y < 3; y++) {
for(int x = 0; x < 9; x++) {
this.addSlotToContainer(new Slot(player, x + y * 9 + 9, 8 + x * 18, 117 + y * 18));
}
}
for(int x = 0; x < 9; x++) {
this.addSlotToContainer(new Slot(player, x, 8 + x * 18, 175));
}
}
@Override
public void addListener(IContainerListener listener) {
super.addListener(listener);
listener.sendAllWindowProperties(this, this.tileentity);
listener.sendAllContents(this, this.inventoryItemStacks);
}
@Override
public boolean canInteractWith(EntityPlayer playerIn) {
return tileentity.isUsableByPlayer(playerIn);
}
@Override
public ItemStack transferStackInSlot(EntityPlayer playerIn, int index) {
ItemStack itemstack = ItemStack.EMPTY;
Slot slot = this.inventorySlots.get(index);
if (slot != null && slot.getHasStack())
{
ItemStack itemstack1 = slot.getStack();
itemstack = itemstack1.copy();
if (index == 0)
{
itemstack1.getItem().onCreated(itemstack1, this.tileentity.getWorld(), playerIn);
if (!this.mergeItemStack(itemstack1, 10, 46, true))
{
return ItemStack.EMPTY;
}
slot.onSlotChange(itemstack1, itemstack);
}
else if (index >= 10 && index < 37)
{
if (!this.mergeItemStack(itemstack1, 37, 46, false))
{
return ItemStack.EMPTY;
}
}
else if (index >= 37 && index < 46)
{
if (!this.mergeItemStack(itemstack1, 10, 37, false))
{
return ItemStack.EMPTY;
}
}
else if (!this.mergeItemStack(itemstack1, 10, 46, false))
{
return ItemStack.EMPTY;
}
if (itemstack1.isEmpty())
{
slot.putStack(ItemStack.EMPTY);
}
else
{
slot.onSlotChanged();
}
if (itemstack1.getCount() == itemstack.getCount())
{
return ItemStack.EMPTY;
}
ItemStack itemstack2 = slot.onTake(playerIn, itemstack1);
if (index == 0)
{
playerIn.dropItem(itemstack2, false);
}
}
return itemstack;
}
}