Chigoma333

thank you this works

I didn't give the EquipmentSlotType a type, thought would happen automatically with extends SwordItem

How can I make the attributes be added only for the mainhand. Currently it adds the values for Head, Legs, Chest, Mainhand, offhand and boots. The second problem is that it overwrites the standard values of the sword. I solved this by writing the values at the very front of amountIn and adding the actual calculation to it. @Override public Multimap<Attribute, AttributeModifier> getAttributeModifiers(EquipmentSlotType slot, ItemStack stack) { Multimap<Attribute, AttributeModifier> attss = LinkedHashMultimap.create(); if (stack.hasTag()){ attss.put(Attributes.ATTACK_SPEED, new AttributeModifier(ATTACK_SPEED_MODIFIER, Soulharvest.MOD_ID + ":speed_bonus", 2+((Math.sqrt((stack.getTag().getInt("KillCounterPhobos") +stack.getTag().getInt("KillCounterPhobosMob"))*2) + (stack.getTag().getInt("KillCounterPhobos") +stack.getTag().getInt("KillCounterPhobosMob"))) / 12.5)* ATTACK_SPEED_MULTIPLY_twin.get(), AttributeModifier.Operation.ADDITION)); attss.put(Attributes.ATTACK_DAMAGE, new AttributeModifier(ATTACK_DAMAGE_MODIFIER, Soulharvest.MOD_ID + ":damage_bonus", 4+((Math.sqrt((stack.getTag().getInt("KillCounterPhobos") + stack.getTag().getInt("KillCounterPhobosMob"))*2) + (stack.getTag().getInt("KillCounterPhobos") + stack.getTag().getInt("KillCounterPhobosMob"))) / 25)*Damage_MULTIPLY_twin.get(), AttributeModifier.Operation.ADDITION)); return attss; } return attss; }

my problem is that addInformation is not used. import net.minecraft.entity.Entity; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.nbt.*; import net.minecraft.util.Hand; import net.minecraft.util.text.ITextComponent; import net.minecraft.util.text.TranslationTextComponent; import net.minecraftforge.event.entity.living.LivingDeathEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import java.util.List; import org.jetbrains.annotations.NotNull; import static de.chigoma333.ringofblood.core.init.ItemInit.RING_OF_BLOOD; public class EventKillCounterHandler { @SubscribeEvent public ItemStack onLivingDeathEvent(LivingDeathEvent event) { ItemStack heldItem2 = null; if (!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if (killer instanceof PlayerEntity) { Item heldItem = ((PlayerEntity) killer).getHeldItem(Hand.MAIN_HAND).getItem(); //MUSS ZUM SLOT GEÄNDERT WERDEN if (heldItem.equals(RING_OF_BLOOD.get())) { heldItem2 = ((PlayerEntity) killer).getHeldItemMainhand(); CompoundNBT tag = new CompoundNBT(); if (heldItem2.hasTag()) { heldItem2.getTag().putInt("KillCounterRing", heldItem2.getTag().getInt("KillCounterRing") + 1); } else { tag.putInt("KillCounterRing", 1); heldItem2.setTag(tag); } } } } return heldItem2; } public void addInformation(@NotNull ItemStack heldItem2, List<String> lores, List<ITextComponent> tooltip) { if (heldItem2.hasTag()) { tooltip.add(new TranslationTextComponent("toolinfo.ringofblood.ring_of_blood")); lores.add("Kills: " + heldItem2.getTag().getInt("KillCounterRing")); } } }

.

I use iterator because without me it throws the error Cannot resolve method getItem in Iterable. Example: Iterable<ItemStack> b = Collections.singleton(((PlayerEntity) killer).getHeldItem(Hand.MAIN_HAND)); Item heldItem = b.getItem(); throws out the error "Cannot resolve method getItem in Iterable".

I think I have managed that there is now an id. public class EventKillCounterHandler { @SubscribeEvent public void onLivingDeathEvent(LivingDeathEvent event) { if(!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if(killer != null && killer instanceof PlayerEntity) { Iterable<ItemStack> b = Collections.singleton(((PlayerEntity) killer).getHeldItem(Hand.MAIN_HAND)); //MUSS ZUM SLOT GEÄNDERT WERDEN Item heldItem = b.iterator().next().getItem(); if(heldItem.equals(RING_OF_BLOOD.getId())) { PlayerEntity player = (PlayerEntity) killer; player.addPotionEffect(new EffectInstance(Effects.FIRE_RESISTANCE, 200)); } } } } } But unfortunately I still have the problem that Item heldItem = b.iterator().next().getItem(); still only throws out the number 1.

Ok it makes no sense. How do I get an item instance of the item I added? Also, when I kill a mob Item heldItem = b.iterator().next().getItem(); b: size = 1 what is also useless for comparison

I thought that the RegistryObject would be equal to the ID of the item.

RING_OF_BLOOD is an item I have added. public class ItemInit { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, Ringofblood.MOD_ID); public static final RegistryObject<Item> test = ITEMS.register("test", () -> new Item(new Item.Properties().group(ItemGroup.COMBAT))); public static final RegistryObject<Item> RING_OF_BLOOD = ITEMS.register("ring_of_blood", () -> new Ring_of_Blood(new Item.Properties().group(ItemGroup.COMBAT))); } My code is executed until if(heldItem.equals(RING_OF_BLOOD)) then it is not executed any further public class EventKillCounterHandler { @SubscribeEvent public void onLivingDeathEvent(LivingDeathEvent event) { if(!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if(killer != null && killer instanceof PlayerEntity) { Iterable<ItemStack> b = Collections.singleton(((PlayerEntity) killer).getHeldItem(Hand.MAIN_HAND)); //MUSS ZUM SLOT GEÄNDERT WERDEN Item heldItem = b.iterator().next().getItem(); if(heldItem.equals(RING_OF_BLOOD)) { PlayerEntity player = (PlayerEntity) killer; player.addPotionEffect(new EffectInstance(Effects.FIRE_RESISTANCE, 200)); } } } } }

I have written this now it does not throw me an error but it does not work. (Sorry I know that I'm annoying) public class Event { public void onLivingDeathEvent(LivingDeathEvent event) { if(!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if(killer != null && killer instanceof PlayerEntity) { Iterable<ItemStack> b = Collections.singleton(((PlayerEntity) killer).getHeldItem(Hand.MAIN_HAND)); //MUSS ZUM SLOT GEÄNDERT WERDEN Item heldItem = b.iterator().next().getItem(); if(heldItem.equals(RING_OF_BLOOD)) { PlayerEntity player = (PlayerEntity) killer; player.addPotionEffect(new EffectInstance(Effects.FIRE_RESISTANCE, 200)); } } } } }

Now I have the feeling that I am too stupid import net.minecraftforge.event.entity.living.LivingDeathEvent; import static de.chigoma333.ringofblood.core.init.ItemInit.RING_OF_BLOOD; public class Event { public void onLivingDeathEvent(LivingDeathEvent event) { if(!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if(killer != null && killer instanceof PlayerEntity) { Iterable<ItemStack> b = killer.getHeldEquipment(); //MUSS ZUM SLOT GEÄNDERT WERDEN ItemStack heldItem = b.iterator().next(); if(heldItem instanceof RING_OF_BLOOD) { System.out.println("Hello World!"); } } }

If I should not care about the IDs, how can I check if it's the right item?

I'm trying to make a kill counter on a weapon (actually for Curio Ring but I didn't know how to read the ring slot). So now I want to see if the ID of the item matches the ID of the item the player is holding. I know that you can't compare an ItemStack with an Item, is there another way to get the Item the player is holding or a way to see what id an Item has in an ItemStack? Of course System.out.println("Hello World!") is only for testing if it worked. package de.chigoma333.ringofblood.core.init; import de.chigoma333.ringofblood.core.init.customitem.Ring_of_Blood; import net.minecraft.block.material.Material; import net.minecraft.entity.Entity; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.inventory.ItemStackHelper; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.item.Items; import net.minecraft.potion.EffectInstance; import net.minecraft.potion.Effects; import net.minecraftforge.event.entity.living.LivingDeathEvent; import net.minecraftforge.items.ItemHandlerHelper; import top.theillusivec4.curios.api.type.ISlotType; import static de.chigoma333.ringofblood.core.init.ItemInit.RING_OF_BLOOD; public class Event { public void onLivingDeathEvent(LivingDeathEvent event) { if(!event.getEntity().getEntityWorld().isRemote) { Entity killer = event.getSource().getTrueSource(); if(killer != null && killer instanceof PlayerEntity) { Iterable<ItemStack> b = killer.getHeldEquipment(); //MUSS ZUM SLOT GEÄNDERT WERDEN ItemStack heldItem = b.iterator().next(); if(heldItem == RING_OF_BLOOD){ System.out.println("Hello World!"); } } } } }