-
PlayerEvent.HarvestCheck is not BlockPos-aware
Soo, the only thing which calls ForgeEventFactory#doPlayerHarvestCheck (which sends the event) is EntityPlayer#canHarvesBlock and the only thing which calls that is ForgeHooks#canHarvestBlock which has a BlockPos, but does not pass it to the event. Also, notice this forge->mc->forge jump
-
BlockPlacedEvent
Maybe SetBlockEvent? That called from World.setBlock(x, y, z, block, meta, flag)? I really need that kind of detection.
-
[Tabs in modlist]Separate lists of 'mods' and 'libs/APIs/cores/other junk'
For example, i have some mods in my list. But fo run some of them i need something like 'iChunUtil', 'CodeChickenCore', 'CofhCore', etc. and it annoys me, especially if a want to create my own 'lib'. And, as i know, CB uses coremod to autodownload and install his lib in VM, doing this by 'vanilla' Forge would be cool too. I think, it would be useful, if we have something like 'tabs' in modlist. Example: ===/Mods: -|PortalGun -|NEI -|Thermal Expansion -|ForgeMicroblocks ===/API's: -|ForgeMultipart -|GuiAPI -|PlayerAPI -|etc. ===/lib's: -|iChunUtil -|CodeChickenLib -|CofhCore
-
transferStackInSlot in ContainerPlayer
Shift does not affect non-ItemArmor items, if they override method 'isValidArmor'. Just add(or change isValidArmor to it) int getArmorIndex(ItemStack is) (by default return -1) method in item, and check it in transferStackInSlot, instead of (itemstack.getItem() instanceof ItemArmor).
-
Damage and metadata
Okay, i'm stupid, when i stopped using actual getDamage(don't use it!!), and started to use just getDisplayDamage(loaded from NBT) all works!
-
Damage and metadata
I have a bunch of metadata items, and some of they need to have damage values. In class Item i found ItemStack sensitive versions of getDamage, getMaxDamage, etc. But in ItemStack class integer itemDamage("metadata") is not public(its "default"). And in getter for that int it checks if item is not equal to null, then return item.getDamage(this). Because i override this to use NBT instead of par1ItemStack.itemDamage i have some problems, especially in my own Item(use metadata for all kinds of things, every method, that have ItemStack argument use .getItemDamage() to choose MetaItem class and invoke similar method in it), NEI completely froze minecraft threads, when i tryed to open GUI, etc. etc. So, my suggestion is to add method getMetadata() in the ItemStack class, that returns just itemDamage, and getItemDamage() can still return item.getDamage(this) value. P. S. Sorry about mistakes, my English is very bad actually =/
IPS spam blocked by CleanTalk.