TheImpure1

July 14, 2015

You are registering your packet again on the key press, instead of sending it - this is waaaaaay wrong. Only ever register your packet ONCE.

To send it, you need to use your simple network wrapper instance:
// this sends to the server, obviously
SummonCraft.network.sendToServer(new YourMessageClass(...));

Oh! Thanks!!!!

July 14, 2015

How would i go about sending a packet when a certain event occurs, it crashes every time

Main mod:

package rainbow.summonercraft;

import net.minecraft.client.settings.KeyBinding;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.fml.client.registry.ClientRegistry;

import net.minecraftforge.fml.common.FMLCommonHandler;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.SidedProxy;

import net.minecraftforge.fml.common.event.FMLInitializationEvent;

import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;

import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

import net.minecraftforge.fml.common.network.NetworkRegistry;

import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;

import net.minecraftforge.fml.relauncher.Side;

import org.apache.logging.log4j.LogManager;

import org.apache.logging.log4j.Logger;

import org.lwjgl.input.Keyboard;

import rainbow.summonercraft.init.ModBlocks;

import rainbow.summonercraft.init.ModItems;

import rainbow.summonercraft.proxy.CommonProxy;

@Mod(modid = ModInfo.modid, name = ModInfo.modname, version = ModInfo.version)

public class SummonCraft {

@SidedProxy(clientSide = ModInfo.clientproxy,

serverSide = ModInfo.serverproxy)

public static CommonProxy proxy;

public static final Logger logger = LogManager.getLogger(ModInfo.modid);

public static SimpleNetworkWrapper network;

@Mod.EventHandler

public void preInit(FMLPreInitializationEvent event) {

ModBlocks.init();

ModBlocks.register();

ModItems.init();

ModItems.register();

network = NetworkRegistry.INSTANCE.newSimpleChannel(ModInfo.modid);

network.registerMessage(SummonInventoryPacket.SummonInventoryPacketHandler.class, SummonInventoryPacket.class, 0, Side.SERVER);

FMLCommonHandler.instance().bus().register(new ModdedEventHandler());

proxy.init();

}

@Mod.EventHandler

public void init(FMLInitializationEvent event) {

proxy.registerRenders();

}

@Mod.EventHandler

public void postInit(FMLPostInitializationEvent event) {

}

Packet Class:

package rainbow.summonercraft;

import io.netty.buffer.ByteBuf;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemStack;

import net.minecraft.util.ChatComponentText;

import net.minecraft.util.IThreadListener;

import net.minecraft.world.WorldServer;

import net.minecraftforge.fml.common.network.ByteBufUtils;

import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;

import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class SummonInventoryPacket implements IMessage {

private static ItemStack itemstack;

private static EntityPlayer player;

public SummonInventoryPacket() {

}

public SummonInventoryPacket(ItemStack itemstack, EntityPlayer player) {

this.itemstack = itemstack;

this.player = player;

}

@Override

public void fromBytes(ByteBuf buf) {

}

@Override

public void toBytes(ByteBuf buf) {

}

public static class SummonInventoryPacketHandler implements IMessageHandler<SummonInventoryPacket, IMessage> {

@Override

public IMessage onMessage(SummonInventoryPacket message, MessageContext ctx) {

IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;

mainThread.addScheduledTask(new Runnable() {

@Override

public void run() {

if (itemstack == null) {

if (player.getHeldItem() == null) {

player.addChatMessage(new ChatComponentText("[summonercraft] You do not have an item in your hand!"));

return;

}

itemstack = player.getHeldItem();

player.getHeldItem().setItem(null);

player.addChatMessage(new ChatComponentText("[summonercraft] Your item has been desposited"));

} else if (itemstack != null) {

if (player.getHeldItem() == null) {

player.getHeldItem().setItem(itemstack.getItem());

itemstack = null;

player.addChatMessage(new ChatComponentText("[summonercraft] Your item has been summoned!"));

return;

}

ItemStack stack = player.getHeldItem();

player.getHeldItem().setItem(itemstack.getItem());

itemstack = stack;

player.addChatMessage(new ChatComponentText("[summonercraft] Your item has been exchanged!"));

}

});

return null;

}

Event Handler:

package rainbow.summonercraft;

import net.minecraft.client.Minecraft;

import net.minecraft.client.settings.KeyBinding;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemStack;

import net.minecraft.util.ChatComponentText;

import net.minecraft.util.IChatComponent;

import net.minecraftforge.fml.common.eventhandler.EventPriority;

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

import net.minecraftforge.fml.common.gameevent.InputEvent;

import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;

import net.minecraftforge.fml.relauncher.Side;

import net.minecraftforge.fml.relauncher.SideOnly;

import rainbow.summonercraft.proxy.ClientProxy;

public class ModdedEventHandler {

public static ItemStack itemstack;

@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)

public void onEvent(InputEvent.KeyInputEvent event) {

KeyBinding[] keyBindings = ClientProxy.keyBindings;

EntityPlayer p = Minecraft.getMinecraft().thePlayer;

if (keyBindings[0].isPressed()) {

SummonCraft.network.registerMessage(SummonInventoryPacket.SummonInventoryPacketHandler.class, SummonInventoryPacket.class, 0, Side.CLIENT);

}

Crash Log:

---- Minecraft Crash Report ----

// Oops.

Time: 7/14/15 12:14 AM

Description: Unexpected error

java.lang.IllegalArgumentException: Duplicate handler name: rainbow.summonercraft.SummonInventoryPacket$SummonInventoryPacketHandler

at io.netty.channel.DefaultChannelPipeline.checkDuplicateName(DefaultChannelPipeline.java:898)

at io.netty.channel.DefaultChannelPipeline.addAfter(DefaultChannelPipeline.java:191)

at io.netty.channel.DefaultChannelPipeline.addAfter(DefaultChannelPipeline.java:183)

at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.addClientHandlerAfter(SimpleNetworkWrapper.java:153)

at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.registerMessage(SimpleNetworkWrapper.java:140)

at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.registerMessage(SimpleNetworkWrapper.java:106)

at rainbow.summonercraft.ModdedEventHandler.onEvent(ModdedEventHandler.java:29)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_ModdedEventHandler_onEvent_KeyInputEvent.invoke(.dynamic)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:55)

at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:138)

at net.minecraftforge.fml.common.FMLCommonHandler.fireKeyInput(FMLCommonHandler.java:581)

at net.minecraft.client.Minecraft.runTick(Minecraft.java:2041)

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1087)

at net.minecraft.client.Minecraft.run(Minecraft.java:376)

at net.minecraft.client.main.Main.main(Main.java:117)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:497)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)

at GradleStart.main(Unknown Source)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:497)

at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace: