Ceras

I am trying to detect when a sound is playing at an arbitrary point in time. Yes I am trying to access client side only logic, since the server side will never have a use for it

Hi, so I've setup the code now to access sndManager and pull the playingSounds map, however I don't know how this is going to help with what the original post was about since all it returns is: The above is, of course a bite-sized version of what I received, the original post was about detecting certain sounds and I did a quick test a few times in a row to see if I could get the same results while playing a sound, however, nothing seemed to repeat after it had finished once (even though I didn't expect it to work) any ideas...?

Ok so now I have getSoundHandler() however the sndManager is private and before going and getting all the AT stuff for it I want to make sure that it would be right to unprivate that? Or am I missing something still since I can't see another way through to the sndManager or playingSounds?

Hi so I started using the playingSounds, I am using access transformers to change it from a private final to a public, I chose this method since I've never used reflection and apparently ATs are faster. If you think reflection would work better here then I'll look into that. Anyway after setting up the AT for playingSounds I started using it, however everything I've done to use it ends up returning "Cannot make a static reference to the non-static field SoundManager.playingSounds" however I am not calling it from a static method... Detection Systems: package net.ceras.minecraft.detection; import java.util.Map; import net.minecraft.client.audio.ISound; import net.minecraft.client.audio.SoundManager; public class DetectionSystems { public boolean soundBasedDetection() { Map<String, ISound> playingSounds = SoundManager.playingSounds; } } SoundManager: package net.minecraft.client.audio; import com.google.common.collect.BiMap; import com.google.common.collect.HashBiMap; import com.google.common.collect.HashMultimap; import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.common.collect.Multimap; import com.google.common.collect.Sets; import io.netty.util.internal.ThreadLocalRandom; import java.io.IOException; import java.io.InputStream; import java.net.MalformedURLException; import java.net.URL; import java.net.URLConnection; import java.net.URLStreamHandler; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Set; import java.util.Map.Entry; import net.minecraft.client.Minecraft; import net.minecraft.client.settings.GameSettings; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.util.ResourceLocation; import net.minecraft.util.SoundCategory; import net.minecraft.util.SoundEvent; import net.minecraft.util.math.MathHelper; import net.minecraftforge.fml.relauncher.Side; import net.minecraftforge.fml.relauncher.SideOnly; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Marker; import org.apache.logging.log4j.MarkerManager; import paulscode.sound.SoundSystem; import paulscode.sound.SoundSystemConfig; import paulscode.sound.SoundSystemException; import paulscode.sound.SoundSystemLogger; import paulscode.sound.Source; import paulscode.sound.codecs.CodecJOrbis; import paulscode.sound.libraries.LibraryLWJGLOpenAL; @SideOnly(Side.CLIENT) public class SoundManager { /** The marker used for logging */ private static final Marker LOG_MARKER = MarkerManager.getMarker("SOUNDS"); private static final Logger LOGGER = LogManager.getLogger(); private static final Set<ResourceLocation> UNABLE_TO_PLAY = Sets.<ResourceLocation>newHashSet(); /** A reference to the sound handler. */ public final SoundHandler sndHandler; /** Reference to the GameSettings object. */ private final GameSettings options; /** A reference to the sound system. */ private SoundManager.SoundSystemStarterThread sndSystem; /** Set to true when the SoundManager has been initialised. */ private boolean loaded; /** A counter for how long the sound manager has been running */ private int playTime; public Map<String, ISound> playingSounds = HashBiMap.<String, ISound>create(); private final Map<ISound, String> invPlayingSounds; private final Multimap<SoundCategory, String> categorySounds; private final List<ITickableSound> tickableSounds; private final Map<ISound, Integer> delayedSounds; private final Map<String, Integer> playingSoundsStopTime; private final List<ISoundEventListener> listeners; private final List<String> pausedChannels; public SoundManager(SoundHandler p_i45119_1_, GameSettings p_i45119_2_) { this.invPlayingSounds = ((BiMap)this.playingSounds).inverse(); this.categorySounds = HashMultimap.<SoundCategory, String>create(); this.tickableSounds = Lists.<ITickableSound>newArrayList(); this.delayedSounds = Maps.<ISound, Integer>newHashMap(); this.playingSoundsStopTime = Maps.<String, Integer>newHashMap(); this.listeners = Lists.<ISoundEventListener>newArrayList(); this.pausedChannels = Lists.<String>newArrayList(); this.sndHandler = p_i45119_1_; this.options = p_i45119_2_; try { SoundSystemConfig.addLibrary(LibraryLWJGLOpenAL.class); SoundSystemConfig.setCodec("ogg", CodecJOrbis.class); net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(new net.minecraftforge.client.event.sound.SoundSetupEvent(this)); } catch (SoundSystemException soundsystemexception) { LOGGER.error(LOG_MARKER, (String)"Error linking with the LibraryJavaSound plug-in", (Throwable)soundsystemexception); } } public void reloadSoundSystem() { UNABLE_TO_PLAY.clear(); for (SoundEvent soundevent : SoundEvent.REGISTRY) { ResourceLocation resourcelocation = soundevent.getSoundName(); if (this.sndHandler.getAccessor(resourcelocation) == null) { LOGGER.warn("Missing sound for event: {}", new Object[] {SoundEvent.REGISTRY.getNameForObject(soundevent)}); UNABLE_TO_PLAY.add(resourcelocation); } } this.unloadSoundSystem(); this.loadSoundSystem(); net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(new net.minecraftforge.client.event.sound.SoundLoadEvent(this)); } /** * Tries to add the paulscode library and the relevant codecs. If it fails, the master volume will be set to zero. */ private synchronized void loadSoundSystem() { if (!this.loaded) { try { (new Thread(new Runnable() { public void run() { SoundSystemConfig.setLogger(new SoundSystemLogger() { public void message(String p_message_1_, int p_message_2_) { if (!p_message_1_.isEmpty()) { SoundManager.LOGGER.info(p_message_1_); } } public void importantMessage(String p_importantMessage_1_, int p_importantMessage_2_) { if (!p_importantMessage_1_.isEmpty()) { SoundManager.LOGGER.warn(p_importantMessage_1_); } } public void errorMessage(String p_errorMessage_1_, String p_errorMessage_2_, int p_errorMessage_3_) { if (!p_errorMessage_2_.isEmpty()) { SoundManager.LOGGER.error("Error in class \'{}\'", new Object[] {p_errorMessage_1_}); SoundManager.LOGGER.error(p_errorMessage_2_); } } }); SoundManager.this.sndSystem = SoundManager.this.new SoundSystemStarterThread(); SoundManager.this.loaded = true; SoundManager.this.sndSystem.setMasterVolume(SoundManager.this.options.getSoundLevel(SoundCategory.MASTER)); SoundManager.LOGGER.info(SoundManager.LOG_MARKER, "Sound engine started"); } }, "Sound Library Loader")).start(); } catch (RuntimeException runtimeexception) { LOGGER.error(LOG_MARKER, (String)"Error starting SoundSystem. Turning off sounds & music", (Throwable)runtimeexception); this.options.setSoundLevel(SoundCategory.MASTER, 0.0F); this.options.saveOptions(); } } } private float getVolume(SoundCategory category) { return category != null && category != SoundCategory.MASTER ? this.options.getSoundLevel(category) : 1.0F; } public void setVolume(SoundCategory category, float volume) { if (this.loaded) { if (category == SoundCategory.MASTER) { this.sndSystem.setMasterVolume(volume); } else { for (String s : this.categorySounds.get(category)) { ISound isound = (ISound)this.playingSounds.get(s); float f = this.getClampedVolume(isound); if (f <= 0.0F) { this.stopSound(isound); } else { this.sndSystem.setVolume(s, f); } } } } } /** * Cleans up the Sound System */ public void unloadSoundSystem() { if (this.loaded) { this.stopAllSounds(); this.sndSystem.cleanup(); this.loaded = false; } } /** * Stops all currently playing sounds */ public void stopAllSounds() { if (this.loaded) { for (String s : this.playingSounds.keySet()) { this.sndSystem.stop(s); } this.pausedChannels.clear(); //Forge: MC-35856 Fixed paused sounds repeating when switching worlds this.playingSounds.clear(); this.delayedSounds.clear(); this.tickableSounds.clear(); this.categorySounds.clear(); this.playingSoundsStopTime.clear(); } } public void addListener(ISoundEventListener listener) { this.listeners.add(listener); } public void removeListener(ISoundEventListener listener) { this.listeners.remove(listener); } public void updateAllSounds() { ++this.playTime; for (ITickableSound itickablesound : this.tickableSounds) { itickablesound.update(); if (itickablesound.isDonePlaying()) { this.stopSound(itickablesound); } else { String s = (String)this.invPlayingSounds.get(itickablesound); this.sndSystem.setVolume(s, this.getClampedVolume(itickablesound)); this.sndSystem.setPitch(s, this.getClampedPitch(itickablesound)); this.sndSystem.setPosition(s, itickablesound.getXPosF(), itickablesound.getYPosF(), itickablesound.getZPosF()); } } Iterator<Entry<String, ISound>> iterator = this.playingSounds.entrySet().iterator(); while (iterator.hasNext()) { Entry<String, ISound> entry = (Entry)iterator.next(); String s1 = (String)entry.getKey(); ISound isound = (ISound)entry.getValue(); if (!this.sndSystem.playing(s1)) { int i = ((Integer)this.playingSoundsStopTime.get(s1)).intValue(); if (i <= this.playTime) { int j = isound.getRepeatDelay(); if (isound.canRepeat() && j > 0) { this.delayedSounds.put(isound, Integer.valueOf(this.playTime + j)); } iterator.remove(); LOGGER.debug(LOG_MARKER, "Removed channel {} because it\'s not playing anymore", new Object[] {s1}); this.sndSystem.removeSource(s1); this.playingSoundsStopTime.remove(s1); try { this.categorySounds.remove(isound.getCategory(), s1); } catch (RuntimeException var8) { ; } if (isound instanceof ITickableSound) { this.tickableSounds.remove(isound); } } } } Iterator<Entry<ISound, Integer>> iterator1 = this.delayedSounds.entrySet().iterator(); while (iterator1.hasNext()) { Entry<ISound, Integer> entry1 = (Entry)iterator1.next(); if (this.playTime >= ((Integer)entry1.getValue()).intValue()) { ISound isound1 = (ISound)entry1.getKey(); if (isound1 instanceof ITickableSound) { ((ITickableSound)isound1).update(); } this.playSound(isound1); iterator1.remove(); } } } /** * Returns true if the sound is playing or still within time */ public boolean isSoundPlaying(ISound sound) { if (!this.loaded) { return false; } else { String s = (String)this.invPlayingSounds.get(sound); return s == null ? false : this.sndSystem.playing(s) || this.playingSoundsStopTime.containsKey(s) && ((Integer)this.playingSoundsStopTime.get(s)).intValue() <= this.playTime; } } public void stopSound(ISound sound) { if (this.loaded) { String s = (String)this.invPlayingSounds.get(sound); if (s != null) { this.sndSystem.stop(s); } } } public void playSound(ISound p_sound) { if (this.loaded) { p_sound = net.minecraftforge.client.ForgeHooksClient.playSound(this, p_sound); if (p_sound == null) return; SoundEventAccessor soundeventaccessor = p_sound.createAccessor(this.sndHandler); ResourceLocation resourcelocation = p_sound.getSoundLocation(); if (soundeventaccessor == null) { if (UNABLE_TO_PLAY.add(resourcelocation)) { LOGGER.warn(LOG_MARKER, "Unable to play unknown soundEvent: {}", new Object[] {resourcelocation}); } } else { if (!this.listeners.isEmpty()) { for (ISoundEventListener isoundeventlistener : this.listeners) { isoundeventlistener.soundPlay(p_sound, soundeventaccessor); } } if (this.sndSystem.getMasterVolume() <= 0.0F) { LOGGER.debug(LOG_MARKER, "Skipped playing soundEvent: {}, master volume was zero", new Object[] {resourcelocation}); } else { Sound sound = p_sound.getSound(); if (sound == SoundHandler.MISSING_SOUND) { if (UNABLE_TO_PLAY.add(resourcelocation)) { LOGGER.warn(LOG_MARKER, "Unable to play empty soundEvent: {}", new Object[] {resourcelocation}); } } else { float f3 = p_sound.getVolume(); float f = 16.0F; if (f3 > 1.0F) { f *= f3; } SoundCategory soundcategory = p_sound.getCategory(); float f1 = this.getClampedVolume(p_sound); float f2 = this.getClampedPitch(p_sound); if (f1 == 0.0F) { LOGGER.debug(LOG_MARKER, "Skipped playing sound {}, volume was zero.", new Object[] {sound.getSoundLocation()}); } else { boolean flag = p_sound.canRepeat() && p_sound.getRepeatDelay() == 0; String s = MathHelper.getRandomUUID(ThreadLocalRandom.current()).toString(); ResourceLocation resourcelocation1 = sound.getSoundAsOggLocation(); if (sound.isStreaming()) { this.sndSystem.newStreamingSource(false, s, getURLForSoundResource(resourcelocation1), resourcelocation1.toString(), flag, p_sound.getXPosF(), p_sound.getYPosF(), p_sound.getZPosF(), p_sound.getAttenuationType().getTypeInt(), f); net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(new net.minecraftforge.client.event.sound.PlayStreamingSourceEvent(this, p_sound, s)); } else { this.sndSystem.newSource(false, s, getURLForSoundResource(resourcelocation1), resourcelocation1.toString(), flag, p_sound.getXPosF(), p_sound.getYPosF(), p_sound.getZPosF(), p_sound.getAttenuationType().getTypeInt(), f); net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(new net.minecraftforge.client.event.sound.PlaySoundSourceEvent(this, p_sound, s)); } LOGGER.debug(LOG_MARKER, "Playing sound {} for event {} as channel {}", new Object[] {sound.getSoundLocation(), resourcelocation, s}); this.sndSystem.setPitch(s, f2); this.sndSystem.setVolume(s, f1); this.sndSystem.play(s); this.playingSoundsStopTime.put(s, Integer.valueOf(this.playTime + 20)); this.playingSounds.put(s, p_sound); this.categorySounds.put(soundcategory, s); if (p_sound instanceof ITickableSound) { this.tickableSounds.add((ITickableSound)p_sound); } } } } } } } private float getClampedPitch(ISound soundIn) { return MathHelper.clamp(soundIn.getPitch(), 0.5F, 2.0F); } private float getClampedVolume(ISound soundIn) { return MathHelper.clamp(soundIn.getVolume() * this.getVolume(soundIn.getCategory()), 0.0F, 1.0F); } /** * Pauses all currently playing sounds */ public void pauseAllSounds() { for (Entry<String, ISound> entry : this.playingSounds.entrySet()) { String s = (String)entry.getKey(); boolean flag = this.isSoundPlaying((ISound)entry.getValue()); if (flag) { LOGGER.debug(LOG_MARKER, "Pausing channel {}", new Object[] {s}); this.sndSystem.pause(s); this.pausedChannels.add(s); } } } /** * Resumes playing all currently playing sounds (after pauseAllSounds) */ public void resumeAllSounds() { for (String s : this.pausedChannels) { LOGGER.debug(LOG_MARKER, "Resuming channel {}", new Object[] {s}); this.sndSystem.play(s); } this.pausedChannels.clear(); } /** * Adds a sound to play in n tick */ public void playDelayedSound(ISound sound, int delay) { this.delayedSounds.put(sound, Integer.valueOf(this.playTime + delay)); } private static URL getURLForSoundResource(final ResourceLocation p_148612_0_) { String s = String.format("%s:%s:%s", new Object[] {"mcsounddomain", p_148612_0_.getResourceDomain(), p_148612_0_.getResourcePath()}); URLStreamHandler urlstreamhandler = new URLStreamHandler() { protected URLConnection openConnection(final URL p_openConnection_1_) { return new URLConnection(p_openConnection_1_) { public void connect() throws IOException { } public InputStream getInputStream() throws IOException { return Minecraft.getMinecraft().getResourceManager().getResource(p_148612_0_).getInputStream(); } }; } }; try { return new URL((URL)null, s, urlstreamhandler); } catch (MalformedURLException var4) { throw new Error("TODO: Sanely handle url exception! :D"); } } /** * Sets the listener of sounds */ public void setListener(EntityPlayer player, float p_148615_2_) { if (this.loaded && player != null) { float f = player.prevRotationPitch + (player.rotationPitch - player.prevRotationPitch) * p_148615_2_; float f1 = player.prevRotationYaw + (player.rotationYaw - player.prevRotationYaw) * p_148615_2_; double d0 = player.prevPosX + (player.posX - player.prevPosX) * (double)p_148615_2_; double d1 = player.prevPosY + (player.posY - player.prevPosY) * (double)p_148615_2_ + (double)player.getEyeHeight(); double d2 = player.prevPosZ + (player.posZ - player.prevPosZ) * (double)p_148615_2_; float f2 = MathHelper.cos((f1 + 90.0F) * 0.017453292F); float f3 = MathHelper.sin((f1 + 90.0F) * 0.017453292F); float f4 = MathHelper.cos(-f * 0.017453292F); float f5 = MathHelper.sin(-f * 0.017453292F); float f6 = MathHelper.cos((-f + 90.0F) * 0.017453292F); float f7 = MathHelper.sin((-f + 90.0F) * 0.017453292F); float f8 = f2 * f4; float f9 = f3 * f4; float f10 = f2 * f6; float f11 = f3 * f6; this.sndSystem.setListenerPosition((float)d0, (float)d1, (float)d2); this.sndSystem.setListenerOrientation(f8, f5, f9, f10, f7, f11); } } public void stop(String p_189567_1_, SoundCategory p_189567_2_) { if (p_189567_2_ != null) { for (String s : this.categorySounds.get(p_189567_2_)) { ISound isound = (ISound)this.playingSounds.get(s); if (p_189567_1_.isEmpty()) { this.stopSound(isound); } else if (isound.getSoundLocation().equals(new ResourceLocation(p_189567_1_))) { this.stopSound(isound); } } } else if (p_189567_1_.isEmpty()) { this.stopAllSounds(); } else { for (ISound isound1 : this.playingSounds.values()) { if (isound1.getSoundLocation().equals(new ResourceLocation(p_189567_1_))) { this.stopSound(isound1); } } } } @SideOnly(Side.CLIENT) class SoundSystemStarterThread extends SoundSystem { private SoundSystemStarterThread() { } public boolean playing(String p_playing_1_) { synchronized (SoundSystemConfig.THREAD_SYNC) { if (this.soundLibrary == null) { return false; } else { Source source = (Source)this.soundLibrary.getSources().get(p_playing_1_); return source == null ? false : source.playing() || source.paused() || source.preLoad; } } } } }

Makes much more sense lol, I was like "never seen this before O_o"

Not to sound like Im a new at Java, since Im not but it has been a year since I did anything in it, and then it was Spigot plugins not modding. Anyway, how do I access the SoundManager::playingSounds? I feel like the :: is a Java 8 operator, right? If it is then I haven't done much in Java 8 either..