Jump to content

Recommended Posts

Posted (edited)

I have block which reads nbt data about position and dimension from an item in its inventory and sends any entities on top of it to that position and dimension. This works fine in most cases, but in particular when sending an item, player, or mob (that I have tested) from the end to the overworld, the entity will be sent to spawn instead of the specified position. I assume this is related to how hopping in the portal after defeating the dragon sends the player back to the overworld's spawn. Does anybody know how I can get around this?

Relevant code: https://github.com/eddie1101/Voidcraft/blob/master/src/main/java/erg/voidcraft/common/block/BlockPortalBase.java#L131-L181

Thanks

Edit: In addition, I noticed that when travelling to or from the nether near a nether portal, the entity will occasionally be teleported to the position of the portal rather than the specified position. Again, I assume this has something to do with how Minecraft syncs nether portals across dimensions, but the only way to change dimensions that I'm aware of is Entity#changeDimension, so I'm not sure how to get around this.

Edited by octa
  • octa changed the title to Issues with Changing an Entity's Dimension
Posted (edited)

So I tried this, and in looking at the vanilla code I'm making a few assumptions. It seems that when you call Entity#changeDimension, it will pass in the vanilla lambda for repositionEntity to your teleporter, which basically means in my code for Teleporter#placeEntity I want to completely ignore that lambda and do everything I need to do in placeEntity instead. I just want to teleport like normal, but without any of the vanilla portal shenanigans, so I basically just copied the vanilla lambda in changeDimension and removed the parts that I don't want, which gives me a null pointer. The problem is that using the EntityType factory gives me null instead of a ServerPlayerEntity. Maybe I'm missing something simple here, but for the life of me I can't figure this out. Any help is appreciated.

Here's my code

And here's my crash report

Edited by octa
Posted
  On 5/23/2021 at 4:44 AM, octa said:

I just want to teleport like normal, but without any of the vanilla portal shenanigans

Expand  

You can use repositionEntity in that case, but supply it with false to prevent a portal from spawning. I suggest reading the javadoc in ITeleporter, it is very detailed!

Posted
  On 5/23/2021 at 8:19 AM, vemerion said:

You can use repositionEntity in that case, but supply it with false to prevent a portal from spawning. I suggest reading the javadoc in ITeleporter, it is very detailed!

Expand  

This works, but it took me a little while to figure out why. I didn't realize that ITeleporter#getPortalInfo was responsible for a lot of the vanilla implementation. Thanks for the help!

Here's my code for anyone else struggling, but it's very simple.

  • octa changed the title to [SOLVED] Issues with Changing an Entity's Dimension

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.