Search the Forums BEFORE making a new post.

[1.16] Item operation of container is strange

Posted June 7, 20214 yr

There are the following container slots, and items can be displayed in the slots by changing the backpack.

However, if you try to move an item in the backpack slot, you will not be able to pick it up, and if you move it from the inventory to the backpack slot, the item will disappear.

I looked through the code and couldn't figure out the cause of this bug. How can I get it to work properly?

Container class:

Spoiler


public class BelongingsUMUPlayerContainer extends AbstractUMUPlayerContainer {

	private static final UMUEquipmentSlotType[] VALID_EQUIPMENT_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.HEAD, UMUEquipmentSlotType.CHEST, UMUEquipmentSlotType.LEGS, UMUEquipmentSlotType.FEET
	};
	private static final UMUEquipmentSlotType[] VALID_RING_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.MAINRING1, UMUEquipmentSlotType.MAINRING2, UMUEquipmentSlotType.OFFRING1, UMUEquipmentSlotType.OFFRING2
	};
	private static final UMUEquipmentSlotType[] VALID_MISCELLANEOUS_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.ENCYCLOPEDIA, UMUEquipmentSlotType.MAP
	};

	public BelongingsUMUPlayerContainer(int id, PlayerInventory playerInventory, PacketBuffer extraData) {
		this(UMUContainers.BELONGING_INVENTORY.get(), id, playerInventory, playerInventory.player);
	}

	public BelongingsUMUPlayerContainer(ContainerType<?> type, int id, PlayerInventory playerInventory, PlayerEntity player) {
		super(type, id, playerInventory, player);

		// index : 36 - 39
		for (int i = 0; i < 4; i++) {
			this.addSlot(new EquipmentSlot(playerInventory, 39 - i, 186, 18 + i * 18, VALID_EQUIPMENT_SLOTS[i]));
		}
		this.addSlot(new OffhandSlot(playerInventory, 40, 255, 72));
		this.addSlot(new EquipmentSlot(playerInventory, 41, 293, 27, UMUEquipmentSlotType.NECKLACE));
		// index : 42 - 45
		for (int iU = 0; iU < 2; iU++) {
			for (int iV = 0; iV < 2; iV++) {
				this.addSlot(new EquipmentSlot(playerInventory, 42 + iU * 2 + iV, 282 + iU * 18 + 4, 48 + iV * 18, VALID_RING_SLOTS[iU * 2 + iV]));
			}
		}
		for (int i = 0; i < 2; i++) {
			this.addSlot(new EquipmentSlot(playerInventory, 46 + i, 330, 72 + i * 18, VALID_MISCELLANEOUS_SLOTS[i]));
		}

		for (int iV = 0; iV < 4; iV++) {
			for (int iU = 0; iU < 9; iU++) {
				Slot slot = this.addSlot(new BackpackSlot(
						new ItemStackHandler(36), new ItemStackHandler(36), iU + iV * 9, 8 + iU * 18, 18 + iV * 18, player, iV + 1)
				);
				if (slot instanceof AbstractBelongingsSlot) {
					AbstractBelongingsSlot belongingsSlot = (AbstractBelongingsSlot) slot;
					belongingsSlot.updateInventory(38, this.player.getItemStackFromSlot(EquipmentSlotType.CHEST));
					this.addListener(belongingsSlot);
				}
			}
		}
	}
}


public abstract class AbstractUMUPlayerContainer extends Container {
	protected final PlayerEntity player;

	protected AbstractUMUPlayerContainer(ContainerType<?> type, int id, PlayerInventory playerInventory, PlayerEntity player) {
		super(type, id);

		this.player = player;

		//index : 9 - 35
		for(int iV = 0; iV < 3; iV++) {
			for(int iU = 0; iU < 9; iU++) {
				this.addSlot(new Slot(playerInventory, iU + (iV + 1) * 9, 186 + iU * 18, 104 + iV * 18));
			}
		}
		for(int i = 0; i < 9; i++) {
			this.addSlot(new Slot(playerInventory, i, 186 + i * 18, 162));
		}
	}

	@Override
	@SuppressWarnings("NullableProblems")
	public boolean canInteractWith(PlayerEntity playerIn) {
		return true;
	}

	@Override
	@SuppressWarnings({"ConstantConditions", "NullableProblems"})
	public final ItemStack transferStackInSlot(PlayerEntity playerIn, int index) {
		Slot slot = this.inventorySlots.get(index);
		ItemStack returnStack = ItemStack.EMPTY;

		if (slot == null || !slot.getHasStack()) return returnStack;

		ItemStack currentStack = slot.getStack();
		returnStack = currentStack.copy();

		if (index >= 0 && index < 27) {
			if (!this.mergeItemStack(currentStack, 27, 36, false)) {
				return ItemStack.EMPTY;
			}
		} else if (index >= 27 && index < 36) {
			if (!this.mergeItemStack(currentStack, 0, 27, false)) {
				return ItemStack.EMPTY;
			}
		} else {
			if (!this.mergeItemStack(currentStack, 0, 36, false)) {
				return ItemStack.EMPTY;
			}
		}

		if (currentStack.isEmpty()) {
			slot.putStack(ItemStack.EMPTY);
		} else {
			slot.onSlotChanged();
		}

		if (currentStack.getCount() == returnStack.getCount()) {
			return ItemStack.EMPTY;
		}

		return returnStack;
	}
}

Slot class:

Spoiler


public class BackpackSlot extends AbstractBelongingsSlot {
	private final PlayerEntity player;
	private final int size;

	public BackpackSlot(IItemHandler baseItemHandler, IItemHandler inventoryItemHandler, int index, int xPosition, int yPosition, PlayerEntity player, int size) {
		super(baseItemHandler, inventoryItemHandler, index, xPosition, yPosition);
		this.player = player;
		this.size = size;
	}

	@Override
	public boolean isEnabled() {
		this.updateInventory(38, this.player.getItemStackFromSlot(EquipmentSlotType.CHEST));
		if (UMUEntityUtil.hasBackpack(player)) {
			return UMUEntityUtil.getBackpackSize(Minecraft.getInstance().player) >= size;
		}

		return false;
	}

	@Override
	public void updateInventory(int slotIndex, ItemStack itemStack) {
		if (slotIndex != 38) return;
		if (itemStack.getItem() == UMUItems.BACKPACK.get()) {
			this.inventoryItemHandler = itemStack
					.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).orElse(new ItemStackHandler(36));
			return;
		}
		this.inventoryItemHandler = new ItemStackHandler(36);
	}
}


public abstract class AbstractBelongingsSlot extends SlotItemHandler implements IContainerListener {
	protected IItemHandler inventoryItemHandler;

	public AbstractBelongingsSlot(IItemHandler baseItemHandler, IItemHandler inventoryItemHandler, int index, int xPosition, int yPosition) {
		super(baseItemHandler, index, xPosition, yPosition);
		this.inventoryItemHandler = inventoryItemHandler;
	}

	@Override
	public IItemHandler getItemHandler() {
		return this.inventoryItemHandler;
	}

	@Override
	public void sendAllContents(Container containerToSend, NonNullList<ItemStack> itemsList) {
	}

	@Override
	public void sendSlotContents(Container containerToSend, int slotInd, ItemStack stack) {
		this.updateInventory(slotInd, stack);
	}

	@Override
	public void sendWindowProperty(Container containerIn, int varToUpdate, int newValue) {
	}

	public abstract void updateInventory(int slotIndex, ItemStack itemStack);
}

Quote

June 8, 20214 yr

Author

I've fixed the code so that item operations can now be done normally. However, the backpack inventory operations that you were equipped with when you opened the inventory are saved, but the inventory operations for the backpack that you replaced in that inventory after opening the inventory are not saved. I was wondering if the inventory I changed later wouldn't be saved because the inventory I saved when I opened the container was saved somewhere else, but I couldn't find a match by tracing the code in the IDE. did. Does anyone know why the modified inventory isn't saved?

Container class:

Spoiler



public class BelongingsUMUPlayerContainer extends AbstractUMUPlayerContainer {
	private NonNullList<ItemStack> inventoryItemStacks = NonNullList.create();

	private static final UMUEquipmentSlotType[] VALID_EQUIPMENT_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.HEAD, UMUEquipmentSlotType.CHEST, UMUEquipmentSlotType.LEGS, UMUEquipmentSlotType.FEET
	};
	private static final UMUEquipmentSlotType[] VALID_RING_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.MAINRING1, UMUEquipmentSlotType.MAINRING2, UMUEquipmentSlotType.OFFRING1, UMUEquipmentSlotType.OFFRING2
	};
	private static final UMUEquipmentSlotType[] VALID_MISCELLANEOUS_SLOTS = new UMUEquipmentSlotType[]{
			UMUEquipmentSlotType.ENCYCLOPEDIA, UMUEquipmentSlotType.MAP
	};

	public BelongingsUMUPlayerContainer(int id, PlayerInventory playerInventory, PacketBuffer extraData) {
		this(UMUContainers.BELONGING_INVENTORY.get(), id, playerInventory, playerInventory.player);
	}

	public BelongingsUMUPlayerContainer(ContainerType<?> type, int id, PlayerInventory playerInventory, PlayerEntity player) {
		super(type, id, playerInventory, player);

		// index : 36 - 39
		for (int i = 0; i < 4; i++) {
			this.addSlot(new EquipmentSlot(playerInventory, 39 - i, 186, 18 + i * 18, VALID_EQUIPMENT_SLOTS[i]));
		}
		this.addSlot(new OffhandSlot(playerInventory, 40, 255, 72));
		this.addSlot(new EquipmentSlot(playerInventory, 41, 293, 27, UMUEquipmentSlotType.NECKLACE));
		// index : 42 - 45
		for (int iU = 0; iU < 2; iU++) {
			for (int iV = 0; iV < 2; iV++) {
				this.addSlot(new EquipmentSlot(playerInventory, 42 + iU * 2 + iV, 282 + iU * 18 + 4, 48 + iV * 18, VALID_RING_SLOTS[iU * 2 + iV]));
			}
		}
		for (int i = 0; i < 2; i++) {
			this.addSlot(new EquipmentSlot(playerInventory, 46 + i, 330, 72 + i * 18, VALID_MISCELLANEOUS_SLOTS[i]));
		}

		for (int iV = 0; iV < 4; iV++) {
			for (int iU = 0; iU < 9; iU++) {
				Slot slot = this.addSlot(new BackpackSlot(
						new ItemStackHandler(36), new ItemStackHandler(36), iU + iV * 9, 8 + iU * 18, 18 + iV * 18, player, iV + 1)
				);
				if (slot instanceof AbstractBelongingsSlot) {
					((AbstractBelongingsSlot) slot).updateInventory(37, this.player.getItemStackFromSlot(EquipmentSlotType.CHEST));
				}
			}
		}
	}

	@Override
	public ItemStack slotClick(int slotId, int dragType, ClickType clickTypeIn, PlayerEntity player) {
		this.inventorySlots.subList(48, 83).stream()
				.filter(s -> s instanceof AbstractBelongingsSlot)
				.forEach(s -> ((AbstractBelongingsSlot) s)
						.updateInventory(slotId, player.inventory.getItemStack()));

		return super.slotClick(slotId, dragType, clickTypeIn, player);
	}
}



public abstract class AbstractUMUPlayerContainer extends Container {
	protected final PlayerEntity player;

	protected AbstractUMUPlayerContainer(ContainerType<?> type, int id, PlayerInventory playerInventory, PlayerEntity player) {
		super(type, id);

		this.player = player;

		//index : 9 - 35
		for(int iV = 0; iV < 3; iV++) {
			for(int iU = 0; iU < 9; iU++) {
				this.addSlot(new Slot(playerInventory, iU + (iV + 1) * 9, 186 + iU * 18, 104 + iV * 18));
			}
		}
		for(int i = 0; i < 9; i++) {
			this.addSlot(new Slot(playerInventory, i, 186 + i * 18, 162));
		}
	}

	@Override
	@SuppressWarnings("NullableProblems")
	public boolean canInteractWith(PlayerEntity playerIn) {
		return true;
	}

	@Override
	@SuppressWarnings({"ConstantConditions", "NullableProblems"})
	public final ItemStack transferStackInSlot(PlayerEntity playerIn, int index) {
		Slot slot = this.inventorySlots.get(index);
		ItemStack returnStack = ItemStack.EMPTY;

		if (slot == null || !slot.getHasStack()) return returnStack;

		ItemStack currentStack = slot.getStack();
		returnStack = currentStack.copy();

		if (index >= 0 && index < 27) {
			if (!this.mergeItemStack(currentStack, 27, 36, false)) {
				return ItemStack.EMPTY;
			}
		} else if (index >= 27 && index < 36) {
			if (!this.mergeItemStack(currentStack, 0, 27, false)) {
				return ItemStack.EMPTY;
			}
		} else {
			if (!this.mergeItemStack(currentStack, 0, 36, false)) {
				return ItemStack.EMPTY;
			}
		}

		if (currentStack.isEmpty()) {
			slot.putStack(ItemStack.EMPTY);
		} else {
			slot.onSlotChanged();
		}

		if (currentStack.getCount() == returnStack.getCount()) {
			return ItemStack.EMPTY;
		}

		return returnStack;
	}
}

Slot class:

Spoiler



public class BackpackSlot extends AbstractBelongingsSlot {
	private final PlayerEntity player;
	private final int size;

	public BackpackSlot(IItemHandler baseItemHandler, IItemHandler inventoryItemHandler, int index, int xPosition, int yPosition, PlayerEntity player, int size) {
		super(baseItemHandler, inventoryItemHandler, index, xPosition, yPosition);
		this.player = player;
		this.size = size;
	}

	@Override
	public boolean isEnabled() {
		if (UMUEntityUtil.hasBackpack(player)) {
			return UMUEntityUtil.getBackpackSize(Minecraft.getInstance().player) >= size;
		}

		return false;
	}

	@Override
	public void updateInventory(int slotIndex, ItemStack itemStack) {
		if (slotIndex != 37) return;
		if (itemStack.getItem() == UMUItems.BACKPACK.get()) {
			this.inventoryItemHandler = itemStack.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
					.orElse(new ItemStackHandler(36));
		} else {
			this.inventoryItemHandler = new ItemStackHandler(36);
		}
	}
}



public abstract class AbstractBelongingsSlot extends SlotItemHandler {
	protected IItemHandler inventoryItemHandler;

	public AbstractBelongingsSlot(IItemHandler baseItemHandler, IItemHandler inventoryItemHandler, int index, int xPosition, int yPosition) {
		super(baseItemHandler, index, xPosition, yPosition);
		this.inventoryItemHandler = inventoryItemHandler;
	}

	@Override
	public IItemHandler getItemHandler() {
		return this.inventoryItemHandler;
	}

	public abstract void updateInventory(int slotIndex, ItemStack itemStack);
}

Edited June 8, 20214 yr by Zemelua

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/101306-116-item-operation-of-container-is-strange/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Bad pathfinding for big mobs (1.21.1)

hey
do u want someone to make this for you

By dark phonis · 1 hour ago1 hr
(((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.

So, I tried this, and the world did load, but ALL of the modded items and things I had completely disappeared, as well as many unmodded things like my chests and items I was carrying. Any solutions?

By SyntaxError · 16 hours ago16 hr
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I do have to add that this is my answer for 1.12.2 but it should ALSO work for future versions.

By Tiny_Sly · Yesterday at 12:11 AM1 day
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I know this was posted almost 3 years ago but this is for anyone who is still looking for an answer.

First, find your config folder. -> C:\Users\ (desktop user's name) \curseforge(or the application where you've downloaded you mod)\minecraft\Instances\config (The config folder should be in the same folder as your mods folder.) Once you click on the config folder, search for CustomNpcs.cfg. Once found, click on it (you can edit it using notepad) and search for the line "headweartype". Set the value to 0 if you want a 2d head layer, set it to 1 for a 3d head layer. Then save the options and you should be good to go from there! :)

By Tiny_Sly · Yesterday at 12:05 AM1 day
[1.16.1]Render enchanted glint to item

ik this was 5 years ago but is this the same in 1.20? or is there a different method?

By FireDude123 · Sunday at 08:55 PM2 days

TileEntity

Sign In

[1.16] Item operation of container is strange

Featured Replies

Join the conversation

Posts

Bad pathfinding for big mobs (1.21.1)

(((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

[1.16.1]Render enchanted glint to item

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)