[1.16] Client-Side run command as op

[SonMooSans]

I want to execute Player from the server to run the /give command by sending a packet , I try to let player send a packet to the server then the server runs

 XXX.handleCommand(AdminLevelSource(Player), RunCommandPacket.getCommand());

But it will close the player's connection and throw an error

Quote

IllegalStateException-An invalid packet was received, and the connection was aborted

What is the solution?

Edited July 19, 2021 by SonMooSans

[diesieben07]

Show more of your code, specifically the packet.

Also show the full console log.

[SonMooSans]

hmm a new problem when I try to debug it

It throws error when buf.readString()

package xxx;

import net.minecraft.network.PacketBuffer;

public class RunCommandRequest
{
  public RunCommandRequest(String i_Command)
  {
    Command = i_Command;
  }

  public String GetCommand() {
    return Command;
  }

  private RunCommandRequest()
  {
  }
  public static RunCommandRequest decode(PacketBuffer buf)
  {
    RunCommandRequest retval = new RunCommandRequest();
    retval.Command = buf.readString(); //error
    return retval;
  }
  public void encode(PacketBuffer buf)
  {
    buf.writeString(Command);
  }

  private String Command;
}

 

[poopoodice]

The readString you are using is client only, you should use the one that takes an int as its argument.

Have you register you packet?

[SonMooSans]

ModTestChannel.registerMessage(RunCommandRequest_ID, RunCommandRequest.class,
              RunCommandRequest::encode, RunCommandRequest::decode,
              MessageHandlerServer::GetRunCommandRequest,
              Optional.of(PLAY_TO_SERVER));

i sure i have register it, anyway I will try the one that takes an int as its argument.

[diesieben07]

Note that this is a giant security hole. You should not just let any client just run any command.

[SonMooSans]

Okay thx, It seems worked! 

And that error also been fixed

Edited July 19, 2021 by SonMooSans