Jump to content

Metadata and armor?


SwordsMiner
 Share

Recommended Posts

Alrighty, so I have "special effect" armor in my mod but its glitching out a bit. What is happening is when the armor's metadata hits 0 (I use metadata as "power" for the armor, and I have the armor set as a enumtype of infinite, so it doesnt protect the player, just allows them to wear it) and when it hits 0 and the player logs out, it will exactly go to a metadata of 65532, and it will completly "regenerate" its power if the max is under that, I also noticed that it does this at values of things like 1 and 2. Help? Heres what my enum looks like

 

public static EnumArmorMaterial armorInfinite = EnumHelper.addArmorMaterial("INFINITE", 0, new int[] { 0, 0, 0, 0}, 0);

 

and heres a sample of my code from my tick hander:

 

 

 

		if(player.getCurrentItemOrArmor(4) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(4);
		if(itemPar1.getItem() == MoreMinecraft.helmetGogglesVision){
			if(itemPar1.getItem().getDamage(itemPar1) < 72000){
				player.addPotionEffect((new PotionEffect(Potion.nightVision.getId(), 219, 0)));
			}
			if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000){
			itemPar1.setItemDamage(1);
			} else if(itemPar1.getItemDamage() < 72000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
		}

	}

 

 

and I just use a custom crafting handler for adding to the metadata, it just looks like this

 

CraftingManager.getInstance().getRecipeList().add(new RecipeRepair(this.helmetGogglesVision.itemID, new ItemStack(Item.redstone), 1125));

 

Help? I suspect that minecraft is freaking out because the metadata is at 0, and since I have it to be "invincible" as far as actual vanilla armor goes I assume it just freaks and trys to fix it.

Link to comment
Share on other sites

As you've not given me any of the code I'd like to look at (I'd preferably see your whole class for each of those) I can only speculate based on the evidence. Make sure that you are using your tick handler on both the client and server sides, so make sure it is registered in the client and common proxies. As only the server world is saved, if it is only decremented on the client the server wil think it's full when loading the player, so the damage will be full.

Link to comment
Share on other sites

Ill give you my client, common, and tick handler.

 

Tick:

package mods.MoreMinecraft.Classes.common;

import java.util.EnumSet;

import mods.MoreMinecraft.Classes.MoreMinecraft;
import net.minecraft.block.material.Material;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;

import org.lwjgl.input.Keyboard;

import cpw.mods.fml.common.ITickHandler;
import cpw.mods.fml.common.TickType;

public class ServerTickHandler implements ITickHandler {
boolean scubaTank = false;
boolean alreadyJumped = false;
boolean alreadyJumpedDamaged = false;
private void OnPlayerTick(EntityPlayer player){

	if(player.getCurrentItemOrArmor(4) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(4);
		if(itemPar1.getItem() == MoreMinecraft.helmetGogglesVision){
			if(itemPar1.getItem().getDamage(itemPar1) < 72000){
				player.addPotionEffect((new PotionEffect(Potion.nightVision.getId(), 219, 0)));
			}
			if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000){
			itemPar1.setItemDamage(1);
			} else if(itemPar1.getItemDamage() < 72000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
		}

	}

	if(player.getCurrentItemOrArmor(3) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(3);
		if(itemPar1.getItem() == MoreMinecraft.plateDualHearts){
			if(itemPar1.getItem().getDamage(itemPar1) < 72000){
			player.addPotionEffect((new PotionEffect(Potion.regeneration.getId(), 21, 2)));
			player.addPotionEffect((new PotionEffect(Potion.field_76443_y.getId(), 21, 0)));
			}
			if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000){
			itemPar1.setItemDamage(1);
			} else if(itemPar1.getItemDamage() < 72000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
		}

	}
	if(player.getCurrentItemOrArmor(4) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(4);
		if(itemPar1.getItem() == MoreMinecraft.scubaHelmet && player.isInsideOfMaterial(Material.water)){
			if(itemPar1.getItem().getDamage(itemPar1) < 72000){	
			player.addPotionEffect((new PotionEffect(Potion.waterBreathing.getId(), 21, 0)));	
			}
			if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000 && scubaTank){
				itemPar1.setItemDamage(1);
				} else if(itemPar1.getItemDamage() < 72000 && scubaTank) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
			if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000 && !scubaTank){
				itemPar1.setItemDamage(4);
				} else if(itemPar1.getItemDamage() < 72000 && !scubaTank) itemPar1.setItemDamage(itemPar1.getItemDamage() + 4);
		}

	}
		if(player.getCurrentItemOrArmor(3) != null){
			ItemStack itemPar1 = player.getCurrentItemOrArmor(3);
			if(itemPar1.getItem() == MoreMinecraft.scubaTank){
				scubaTank = true;
				if(player.onGround){
					player.addPotionEffect((new PotionEffect(Potion.moveSlowdown.getId(), 21, 0)));	
				}
			} else scubaTank = false;

		} else scubaTank = false;

		if(player.getCurrentItemOrArmor(1) != null){
			ItemStack itemPar1 = player.getCurrentItemOrArmor(1);
			if(itemPar1.getItem() == MoreMinecraft.jumpBoots){
				boolean isJumping = Minecraft.getMinecraft().gameSettings.keyBindJump.pressed && !player.capabilities.isFlying;
				if(itemPar1.getItem().getDamage(itemPar1) < 60000 && isJumping && !alreadyJumped){
				player.addPotionEffect((new PotionEffect(Potion.jump.getId(), 1, 0)));
				if(!player.capabilities.isCreativeMode && !alreadyJumpedDamaged && !alreadyJumped){
				itemPar1.setItemDamage(itemPar1.getItemDamage() + 100);
				alreadyJumpedDamaged = true;
				}
				alreadyJumped = true;
				}
				/*if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 60000){
				itemPar1.setItemDamage(1);
				} else if(itemPar1.getItemDamage() < 60000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1); */
			}

		}
		if(player.onGround || player.isInWater()){
			alreadyJumped = false;
			alreadyJumpedDamaged = false;
		}
}

@Override
public void tickStart(EnumSet<TickType> type, Object... tickData) {

	if(type.equals(EnumSet.of(TickType.PLAYER))){
		OnPlayerTick((EntityPlayer) tickData[0]);
	}

}

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {
	// TODO Auto-generated method stub

}

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER, TickType.SERVER);
}

@Override
public String getLabel() {
	// TODO Auto-generated method stub
	return null;
}

}

 

Common:

package mods.MoreMinecraft.Classes.common;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;
import cpw.mods.fml.common.registry.TickRegistry;
import cpw.mods.fml.relauncher.Side;

public class CommonProxy implements IGuiHandler
{
    public void registerRenders()
    {
    }

    public int addArmor(String string)
    {
        return 0;
    }
    public void registerServerTickHandler(){
    	TickRegistry.registerTickHandler(new ServerTickHandler(), Side.SERVER);
    	TickRegistry.registerTickHandler(new ServerTickHandler(), Side.CLIENT);
    }

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z)
{
TileEntity tileEntity = world.getBlockTileEntity(x, y, z);

if(tileEntity != null)
{
switch(ID)
{
case 0:
	/* your Containers go here*/
}
}
return tileEntity;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world,
		int x, int y, int z) {
	return null;
}
    
}

Client:

package mods.MoreMinecraft.Classes.common;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;
import cpw.mods.fml.common.registry.TickRegistry;
import cpw.mods.fml.relauncher.Side;

public class CommonProxy implements IGuiHandler
{
    public void registerRenders()
    {
    }

    public int addArmor(String string)
    {
        return 0;
    }
    public void registerServerTickHandler(){
    	TickRegistry.registerTickHandler(new ServerTickHandler(), Side.SERVER);
    	TickRegistry.registerTickHandler(new ServerTickHandler(), Side.CLIENT);
    }

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z)
{
TileEntity tileEntity = world.getBlockTileEntity(x, y, z);

if(tileEntity != null)
{
switch(ID)
{
case 0:
	/* your Containers go here*/
}
}
return tileEntity;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world,
		int x, int y, int z) {
	return null;
}
    
}

 

Just a side note, registerServerTickHandler is called. So it is working as far as tick handlers go.

Link to comment
Share on other sites

I made this mistake the first time I played with making tick handlers

 

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER, TickType.SERVER);
}

 

should be

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER);
}

 

give that a go now, and tell me if it works (you only need the one think in there in most cases, I've not come across any cases yet where I've needed 2)

Link to comment
Share on other sites

I made this mistake the first time I played with making tick handlers

 

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER, TickType.SERVER);
}

 

should be

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER);
}

 

give that a go now, and tell me if it works (you only need the one think in there in most cases, I've not come across any cases yet where I've needed 2)

 

Actually, it works fine until it around the durability of 4000.. I dont understand. and I tried that

Link to comment
Share on other sites

I'm working on it. I'm not even sure you need a tick handler here (almost definite)

please don't pm me like that, If i don't reply to a post I commented on, it's ether because a.) I can't think of a solution yet. b.) I am working on a solution and it's taking me time. c.) I have no more to contribute to the thread. d.) I'm away from my laptop for real life reasons.

 

in this case I was AFK and will reply with my solution in a minute.

Link to comment
Share on other sites

there we go, did this in the project I use to test stuff

package mods.gaspoweredstick.code.item;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumArmorMaterial;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;
import net.minecraftforge.common.EnumHelper;

public class ItemModArmor extends ItemArmor
{
public static final EnumArmorMaterial ModArmor = EnumHelper
		.addArmorMaterial("ModArmor", 9001, new int[]{1,2,3,4}, 42);


public ItemModArmor(int par1, EnumArmorMaterial par2EnumArmorMaterial, int par3, int par4)
{
	super(par1, par2EnumArmorMaterial, par3, par4);
}

//put all you stuff that was in the player tick handler here.
@Override
public void onArmorTickUpdate(World world, EntityPlayer player,
		ItemStack itemStack)
{
	player.addPotionEffect(new PotionEffect(Potion.nightVision.id, 21, 0));
	itemStack.damageItem(1, player);
}
}

 

should all work fine, and you should be able to figure out what to do in the method. This will also give better performance than the tick handler.

Link to comment
Share on other sites

Ill try it out, but what about items, I have a item that uses it too:

package mods.MoreMinecraft.Classes.Items;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import mods.MoreMinecraft.Classes.MoreMinecraft;
import mods.MoreMinecraft.Classes.Entities.EntityBakedPotatoLaunched;
import mods.MoreMinecraft.Classes.Entities.EntityPoisonPotatoLaunched;
import mods.MoreMinecraft.Classes.Entities.EntityPotatoLaunched;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class PotatoLauncher extends Item
{
boolean potatoFired = false;
boolean potatoBakedFired = false;
boolean potatoPoisonFired = false;
public int thrownDamage = 6;
public static int current = 0;
    public PotatoLauncher(int par1)
    {
        super(par1);
        this.maxStackSize = 1;
        this.setMaxDamage(40000);
    }

    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister reg)
    {
        this.itemIcon = reg.registerIcon(MoreMinecraft.modID + ":" + this.getUnlocalizedName());
    }
    
    /**
     * Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer
     */
    
    
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	if(this.getDamage(par1ItemStack) < 40000 || par3EntityPlayer.capabilities.isCreativeMode){

    	
            //par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
            	if(par3EntityPlayer.inventory.hasItem(Item.potato.itemID) && !par3EntityPlayer.capabilities.isCreativeMode){
                par2World.spawnEntityInWorld(new EntityPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
                this.setDamage(par1ItemStack, this.getDamage(par1ItemStack)+500);
                par3EntityPlayer.inventory.consumeInventoryItem(Item.potato.itemID);
                return par1ItemStack;
            } else if(par3EntityPlayer.capabilities.isCreativeMode){
            	par2World.spawnEntityInWorld(new EntityPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
            	return par1ItemStack;
            }
            	
            	
            	if(par3EntityPlayer.inventory.hasItem(Item.bakedPotato.itemID) && !par3EntityPlayer.capabilities.isCreativeMode){
                par2World.spawnEntityInWorld(new EntityBakedPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
                this.setDamage(par1ItemStack, this.getDamage(par1ItemStack)+500);
                par3EntityPlayer.inventory.consumeInventoryItem(Item.bakedPotato.itemID);
                return par1ItemStack;
            } else if(par3EntityPlayer.capabilities.isCreativeMode){
            	par2World.spawnEntityInWorld(new EntityBakedPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
            	return par1ItemStack;
            }

            
            	if(par3EntityPlayer.inventory.hasItem(Item.poisonousPotato.itemID) && !par3EntityPlayer.capabilities.isCreativeMode){
                    par2World.spawnEntityInWorld(new EntityPoisonPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
                    this.setDamage(par1ItemStack, this.getDamage(par1ItemStack)+500);
                    par3EntityPlayer.inventory.consumeInventoryItem(Item.poisonousPotato.itemID);
                    return par1ItemStack;
                } else if(par3EntityPlayer.capabilities.isCreativeMode){
                	par2World.spawnEntityInWorld(new EntityPoisonPotatoLaunched(par2World, par3EntityPlayer, thrownDamage, par3EntityPlayer));
                	return par1ItemStack;
                }
            	

            par3EntityPlayer.addChatMessage("You dont have any Potatoes!");

        
            
            return par1ItemStack;
    } else par3EntityPlayer.addChatMessage("This potato launcher is out of charge!");
	return par1ItemStack;
    }
    }

 

 

Sorry about being impatient!

 

Link to comment
Share on other sites

Doesnt work  >:(, but I do notice a decrease in lag (it used to give out for a second before)

 

Heres what I have in place of my server tick handler now:

 

package mods.MoreMinecraft.Classes.Items;

import mods.MoreMinecraft.Classes.MoreMinecraft;
import net.minecraft.block.material.Material;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumArmorMaterial;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

public class ItemArmorRedstoneMod extends ItemArmor
{
String path = "/textures/armor/";
String Extension = ".png";
    String armorFile;

    public ItemArmorRedstoneMod(int par1, EnumArmorMaterial par2EnumArmorMaterial,
            int par3, int par4, String armorFile)
    {
        super(par1, par2EnumArmorMaterial, par3, par4);
        this.armorFile = armorFile;
    }
    @Override
    public void registerIcons(IconRegister reg)
    {
        this.itemIcon = reg.registerIcon(MoreMinecraft.modID + ":"
                + this.getUnlocalizedName());
    }
@Override
    public String getArmorTexture(ItemStack stack, Entity entity, int slot, int layer)
    {
return "moreminecraft"+":" + armorFile + Extension;
}
@Override
public boolean getIsRepairable(ItemStack par1ItemStack, ItemStack par2ItemStack)
{
return Item.redstone.itemID == par2ItemStack.itemID ? true : super.getIsRepairable(par1ItemStack, par2ItemStack);
}

boolean scubaTank = false;
boolean alreadyJumped = false;
boolean alreadyJumpedDamaged = false;

@Override
public void onArmorTickUpdate(World par1World, EntityPlayer player, ItemStack par3ItemStack){

if(player.getCurrentItemOrArmor(4) != null){
	ItemStack itemPar1 = player.getCurrentItemOrArmor(4);
	if(itemPar1.getItem() == MoreMinecraft.helmetGogglesVision){
		if(itemPar1.getItem().getDamage(itemPar1) < 72000){
			player.addPotionEffect((new PotionEffect(Potion.nightVision.getId(), 219, 0)));
		}
		if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000){
		itemPar1.setItemDamage(1);
		} else if(itemPar1.getItemDamage() < 72000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
	}

}

if(player.getCurrentItemOrArmor(3) != null){
	ItemStack itemPar1 = player.getCurrentItemOrArmor(3);
	if(itemPar1.getItem() == MoreMinecraft.plateDualHearts){
		if(itemPar1.getItem().getDamage(itemPar1) < 72000){
		player.addPotionEffect((new PotionEffect(Potion.regeneration.getId(), 21, 2)));
		player.addPotionEffect((new PotionEffect(Potion.field_76443_y.getId(), 21, 0)));
		}
		if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000){
		itemPar1.setItemDamage(1);
		} else if(itemPar1.getItemDamage() < 72000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
	}

}
if(player.getCurrentItemOrArmor(4) != null){
	ItemStack itemPar1 = player.getCurrentItemOrArmor(4);
	if(itemPar1.getItem() == MoreMinecraft.scubaHelmet && player.isInsideOfMaterial(Material.water)){
		if(itemPar1.getItem().getDamage(itemPar1) < 72000){	
		player.addPotionEffect((new PotionEffect(Potion.waterBreathing.getId(), 21, 0)));	
		}
		if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000 && scubaTank){
			itemPar1.setItemDamage(1);
			} else if(itemPar1.getItemDamage() < 72000 && scubaTank) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1);
		if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 72000 && !scubaTank){
			itemPar1.setItemDamage(4);
			} else if(itemPar1.getItemDamage() < 72000 && !scubaTank) itemPar1.setItemDamage(itemPar1.getItemDamage() + 4);
	}

}
	if(player.getCurrentItemOrArmor(3) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(3);
		if(itemPar1.getItem() == MoreMinecraft.scubaTank){
			scubaTank = true;
			if(player.onGround){
				player.addPotionEffect((new PotionEffect(Potion.moveSlowdown.getId(), 21, 0)));	
			}
		} else scubaTank = false;

	} else scubaTank = false;

	if(player.getCurrentItemOrArmor(1) != null){
		ItemStack itemPar1 = player.getCurrentItemOrArmor(1);
		if(itemPar1.getItem() == MoreMinecraft.jumpBoots){
			boolean isJumping = Minecraft.getMinecraft().gameSettings.keyBindJump.pressed && !player.capabilities.isFlying;
			if(itemPar1.getItem().getDamage(itemPar1) < 60000 && isJumping && !alreadyJumped){
			player.addPotionEffect((new PotionEffect(Potion.jump.getId(), 1, 0)));
			if(!player.capabilities.isCreativeMode && !alreadyJumpedDamaged && !alreadyJumped){
			itemPar1.setItemDamage(itemPar1.getItemDamage() + 100);
			alreadyJumpedDamaged = true;
			}
			alreadyJumped = true;
			}
			/*if(itemPar1.getItemDamage() == 0 && itemPar1.getItemDamage() < 60000){
			itemPar1.setItemDamage(1);
			} else if(itemPar1.getItemDamage() < 60000) itemPar1.setItemDamage(itemPar1.getItemDamage() + 1); */
		}

	}
	if(player.onGround || player.isInWater()){
		alreadyJumped = false;
		alreadyJumpedDamaged = false;
	}
}

}

Link to comment
Share on other sites

??? not a clue, If you're talking about the damage number, that increases as it get's damaged so should be high. The item i used in my first example for this works fine for me... so you sot me stumped, it should all be working so I'm not sure anymore. just play about with it a bit more, run in debug etc and see what't happening as it runs it all. good luck.
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.