Jump to content

[Solved] [1.16.5] Custom capability doesn't save after player leaves world


mclich

Recommended Posts

So i made my custom capability and attach it to all players. I also made serialization and synchronization using my own packet (at least i think i do) to allow client (player) always access updated capability data after some changes. In my capability event handler class i've subscribed to PlayerLoggedInEvent and send updated data through my packet. The problem is the data just doesn't save after player leaves the world and sets to default values after player joins the world again. Any ideas how to fix that?

Edited by mclich
Link to comment
Share on other sites

9 minutes ago, diesieben07 said:

Post your code.

Capability class:

public class ManaCapability
{
	public static final ResourceLocation LOCATION=new ResourceLocation(ElderNorseGods.MOD_ID, "mana");
	
	@CapabilityInject(IManaHandler.class)
	public static Capability<IManaHandler> CAP_INSTANCE=null;
	
	public static class ManaStorage implements IStorage<IManaHandler>
	{
		@Override
		public INBT writeNBT(Capability<IManaHandler> cap, IManaHandler manaHandler, Direction side)
		{
			CompoundNBT tag=new CompoundNBT();
			tag.putFloat("Mana", manaHandler.getMana());
			tag.putBoolean("Status", manaHandler.getStatus());
			return tag;
		}

		@Override
		public void readNBT(Capability<IManaHandler> cap, IManaHandler manaHandler, Direction side, INBT nbt)
		{
			manaHandler.setMana(((CompoundNBT)nbt).getFloat("Mana"));
			manaHandler.setStatus(((CompoundNBT)nbt).getBoolean("Status"));
		}
	}
	
	public static class ManaProvider implements ICapabilitySerializable<CompoundNBT>
	{
		private final ManaHandler mana=new ManaHandler();
		private final LazyOptional<IManaHandler> manaOptional=LazyOptional.of(()->this.mana);
		
		public void invalidate()
		{
			this.manaOptional.invalidate();
		}
		
		@Override
		public CompoundNBT serializeNBT()
		{
			if(ManaCapability.CAP_INSTANCE==null) return new CompoundNBT();
			else return (CompoundNBT)ManaCapability.CAP_INSTANCE.writeNBT(this.mana, null);
		}

		@Override
		public void deserializeNBT(CompoundNBT nbt)
		{
			if(ManaCapability.CAP_INSTANCE!=null) ManaCapability.CAP_INSTANCE.readNBT(this.mana, null, nbt);
		}
		
		@Override
		public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side)
		{
			return cap==ManaCapability.CAP_INSTANCE?this.manaOptional.cast():LazyOptional.empty();
		}
	}
}

Capability handler class:

public class ManaHandler implements IManaHandler
{
	private float mana;
	private boolean active;
	
	public ManaHandler()
	{
		this.mana=0F;
		this.active=false;
	}
	
	@Override
	public void setMana(float amount)
	{
		if(amount<0F) this.mana=0F;
		else if(amount>20F) this.mana=20F;
		else this.mana=amount;
	}

	@Override
	public float getMana()
	{
		return this.mana;
	}

	@Override
	public void setStatus(boolean value)
	{
		this.active=value;
	}

	@Override
	public boolean getStatus()
	{
		return this.active;
	}

	@Override
	public void update(ServerPlayerEntity player)
	{
		NetworkHandler.sendToPlayer(player, new ManaDataPacket(this.getMana(), this.getStatus()));
	}
}

Capability event handler class:

@EventBusSubscriber(modid=ElderNorseGods.MOD_ID, bus=EventBusSubscriber.Bus.FORGE)
public abstract class ManaEventHandler
{
	private static void sendUpdates(ServerPlayerEntity player)
	{
		if(!player.getCommandSenderWorld().isClientSide())
		{
			player.getCapability(ManaCapability.CAP_INSTANCE).ifPresent(mana->mana.update(player));
		}
	}
	
	@SubscribeEvent
	public static void onPlayerChangedDimension(PlayerChangedDimensionEvent event)
	{
		ManaEventHandler.sendUpdates((ServerPlayerEntity)event.getPlayer());
	}
	
	@SubscribeEvent
	public static void onPlayerRespawn(PlayerRespawnEvent event)
	{
		ManaEventHandler.sendUpdates((ServerPlayerEntity)event.getPlayer());
	}
	
	@SubscribeEvent
	public static void onPlayerLoggedIn(PlayerLoggedInEvent event)
	{
		ManaEventHandler.sendUpdates((ServerPlayerEntity)event.getPlayer());
	}
	
	@SubscribeEvent
	public static void onPlayerClone(PlayerEvent.Clone event)
	{
		if(!event.isWasDeath()) return;
		IManaHandler oldMana=event.getOriginal().getCapability(ManaCapability.CAP_INSTANCE).orElse(null);
		IManaHandler newMana=event.getPlayer().getCapability(ManaCapability.CAP_INSTANCE).orElse(null);
		if(oldMana!=null&&newMana!=null)
		{
			newMana.setMana(oldMana.getMana());
			newMana.setStatus(oldMana.getStatus());
		}
	}
}

Packet class:

public class ManaDataPacket
{
	private float value;
	private boolean status;
	
	public ManaDataPacket(float value, boolean status)
	{
		this.value=value;
		this.status=status;
	}
	
	public static void encode(ManaDataPacket packet, PacketBuffer buffer)
	{
		buffer.writeFloat(packet.value);
		buffer.writeBoolean(packet.status);
	}
	
	public static ManaDataPacket decode(PacketBuffer buffer)
	{
		return new ManaDataPacket(buffer.readFloat(), buffer.readBoolean());
	}
	
	public static void handle(ManaDataPacket packet, Supplier<NetworkEvent.Context> ctx)
	{
		ctx.get().enqueueWork(()->DistExecutor.unsafeRunWhenOn(Dist.CLIENT, ()->()->PacketHandler.handlePacket(packet, ctx)));
		ctx.get().setPacketHandled(true);
	}
	
	private static class PacketHandler
	{
		private static void handlePacket(ManaDataPacket packet, Supplier<NetworkEvent.Context> ctx)
		{
			Minecraft mc=Minecraft.getInstance();
			mc.player.getCapability(ManaCapability.CAP_INSTANCE).ifPresent
			(
				mana->
				{
					mana.setMana(packet.value);
					mana.setStatus(packet.status);
				}
			);
		}
	}
}
Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Where are you modifying the values?

At the moment i have only one item that change values after use. There is code:
 

public class ManaTinctureItem extends Item
{
	public static final String ID="mana_tincture";
	
	public ManaTinctureItem()
	{
		super(new Item.Properties().food(new Food.Builder().nutrition(2).saturationMod(0.6F).alwaysEat().build()).stacksTo(1).rarity(Rarity.RARE).tab(ENGTabs.FOOD));
	}
	
	@Override
	public ItemStack finishUsingItem(ItemStack itemStack, World world, LivingEntity entity)
	{
		itemStack=entity.eat(world, itemStack);
		if(!world.isClientSide()&&entity instanceof ServerPlayerEntity)
		{
			ServerPlayerEntity player=(ServerPlayerEntity)entity;
			player.getCapability(ManaCapability.CAP_INSTANCE).ifPresent
			(
				mana->
				{
					if(!mana.getStatus())
					{
						mana.setStatus(true);
						mana.setMana(20F);
						mana.update(player);
					}
				}
			);
			if(player.gameMode.isSurvival())
			{
				if(itemStack.getCount()==0&&!player.inventory.contains(new ItemStack(Items.BOWL)))
				{
					player.inventory.removeItem(itemStack);
					player.inventory.add(player.inventory.selected, new ItemStack(Items.BOWL));
				}
				else player.inventory.add(new ItemStack(Items.BOWL));
			}
		}
		return itemStack;
	}
	
	@Override
	public boolean isFoil(ItemStack itemStack)
	{
		return true;
	}
}

 

Link to comment
Share on other sites

16 minutes ago, diesieben07 said:

Are the NBT serialization methods called? Do they operate correctly? Check using the debugger.

If i understood correctly, something is broken here. When i check for capability instance being null:

@Override
public CompoundNBT serializeNBT()
{
	if(ManaCapability.CAP_INSTANCE==null) return new CompoundNBT();
	else return (CompoundNBT)ManaCapability.CAP_INSTANCE.writeNBT(this.mana, null);
}

it always returns true, so serializeNBT() always returns new CompoundNBT(), i don't know why

Edited by mclich
Link to comment
Share on other sites

Show where you register your capability.

And this "Oh, it's null... guess I'll do nothing then and not report this error" behavior is terrible. This is not PHP. If something so fundamental is wrong, throw an exception! Crashing the game is OK if your code has bugs. Don't try to sweep the errors under the rug. It makes things way more hard to debug.

Link to comment
Share on other sites

6 hours ago, diesieben07 said:

Show where you register your capability.

 

@EventBusSubscriber(modid=ElderNorseGods.MOD_ID, bus=EventBusSubscriber.Bus.FORGE)
public abstract class ENGCapabilities
{
	@SubscribeEvent
	public static void registerCapabilities(final FMLCommonSetupEvent event)
	{
		CapabilityManager.INSTANCE.register(IManaHandler.class, new ManaStorage(), ManaHandler::new);
	}
	
	@SubscribeEvent
	public static void attachCapabilities(final AttachCapabilitiesEvent<Entity> event)
	{
		if(!(event.getObject() instanceof PlayerEntity)) return;
		ManaProvider provider=new ManaProvider();
		event.addCapability(ManaCapability.LOCATION, provider);
		event.addListener(provider::invalidate);
	}
}
Edited by mclich
Link to comment
Share on other sites

18 minutes ago, diesieben07 said:

That is the wrong event bus for FMLCommonSetupEvent.

My god, i'm an idiot... I changed registration class like this:

@EventBusSubscriber(modid=ElderNorseGods.MOD_ID, bus=EventBusSubscriber.Bus.MOD)
public abstract class ENGCapabilities
{
	@SubscribeEvent
	public static void registerCapabilities(final FMLCommonSetupEvent event)
	{
		CapabilityManager.INSTANCE.register(IManaHandler.class, new ManaStorage(), ManaHandler::new);
	}
	
	@EventBusSubscriber(modid=ElderNorseGods.MOD_ID, bus=EventBusSubscriber.Bus.FORGE)
	private static class AttachCapabilities
	{
		@SubscribeEvent
		public static void attachCapabilities(final AttachCapabilitiesEvent<Entity> event)
		{
			if(!(event.getObject() instanceof PlayerEntity)) return;
			ManaProvider provider=new ManaProvider();
			event.addCapability(ManaCapability.LOCATION, provider);
			event.addListener(provider::invalidate);
		}
	}
}

and it works now! Thank you for your help!

Link to comment
Share on other sites

  • mclich changed the title to [Solved] [1.16.5] Custom capability doesn't save after player leaves world

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • During the start of my server, I get a couple of errors which I can't find the solution. The server if started Debug Log: https://paste.me/paste/e4053560-55d8-4665-778c-bcc46394a9de#07b5c63a9b61091b00182b427fe037034fd21da210d4a10c5fc5b33309cac175 Console Log: https://paste.me/paste/a63968df-f938-4360-65fa-b133e0470b7b#7decf3b6fd3e42de2376446df45fe9709144b28faaf1bd3c89299f343e78c77b   Main errors:  1: [Worker-Main-2/ERROR] [minecraft/TagLoader]: Couldn't load tag [dimensional_expansion:end_rose (from dimensional_expansion-0.7a.jar)] as it is missing following references: dimensional_expansion:end_rose (from dimensional_expansion-0.7a.jar) 2: [main/ERROR] [minecraft/RecipeManager]: Parsing error loading recipe deeperdarker:sculk_affinity
    • Guys I am really at my wits end with this stupid Forge Version I am TRYING to play the latest update of the FNaF Mod updated to 1.19.2. But for whatever reason, everytime I TRY to open the Forge Version, it keeps crashing, even if I have ABSOUTLETLY ZERO Mods Installed. It keeps giving me the Exit Code of 1 Someone on the FNaF Mod Discord Server states that Exit Code 1 relates to Memory issues, but I have ALOT of Storage on my Computer still I am at my witsend with what is causing this and how it can be fixed  this is what shows in the latest.log (If this isnt where you guys can find what is causing this, then tell me where I CAN find it)  [03Jun2023 16:36:35.256] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, grasshopperjb, --version, 1.19.2-forge-43.2.0, --gameDir, C:\Users\jbaut\AppData\Roaming\.minecraft, --assetsDir, C:\Users\jbaut\AppData\Roaming\.minecraft\assets, --assetIndex, 1.19, --uuid, c2896eae7c544faa9b7e0da7eb635b65, --accessToken, ????????, --clientId, NTMzN2Q0ZTctMjA2ZS00NzI1LTkzNGUtNDk0YzA4ZTY0Yzhj, --xuid, 2535428451400008, --userType, msa, --versionType, release, --launchTarget, forgeclient, --fml.forgeVersion, 43.2.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [03Jun2023 16:36:35.261] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.3 by Microsoft; OS Windows 10 arch amd64 version 10.0 [03Jun2023 16:36:35.359] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2397!/ Service=ModLauncher Env=CLIENT [03Jun2023 16:36:35.391] [main/WARN] [net.minecraftforge.fml.loading.FMLConfig/CORE]: Configuration file C:\Users\jbaut\AppData\Roaming\.minecraft\config\fml.toml is not correct. Correcting [03Jun2023 16:36:35.397] [main/WARN] [net.minecraftforge.fml.loading.FMLConfig/CORE]: Incorrect key [disableOptimizedDFU] was corrected from null to true [03Jun2023 16:36:35.573] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\fmlcore\1.19.2-43.2.0\fmlcore-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.578] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\javafmllanguage\1.19.2-43.2.0\javafmllanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.582] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\lowcodelanguage\1.19.2-43.2.0\lowcodelanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.587] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\mclanguage\1.19.2-43.2.0\mclanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.655] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: No dependencies to load found. Skipping! [03Jun2023 16:36:36.504] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeclient' with arguments [--version, 1.19.2-forge-43.2.0, --gameDir, C:\Users\jbaut\AppData\Roaming\.minecraft, --assetsDir, C:\Users\jbaut\AppData\Roaming\.minecraft\assets, --uuid, c2896eae7c544faa9b7e0da7eb635b65, --username, grasshopperjb, --assetIndex, 1.19, --accessToken, ????????, --clientId, NTMzN2Q0ZTctMjA2ZS00NzI1LTkzNGUtNDk0YzA4ZTY0Yzhj, --xuid, 2535428451400008, --userType, msa, --versionType, release] [03Jun2023 16:36:39.314] [pool-3-thread-1/INFO] [net.minecraft.util.datafix.DataFixers/]: Building unoptimized datafixer [03Jun2023 16:36:40.660] [Render thread/WARN] [net.minecraft.server.packs.VanillaPackResources/]: Assets URL 'union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.19.2-20220805.130853/client-1.19.2-20220805.130853-srg.jar%23151!/assets/.mcassetsroot' uses unexpected schema [03Jun2023 16:36:40.662] [Render thread/WARN] [net.minecraft.server.packs.VanillaPackResources/]: Assets URL 'union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.19.2-20220805.130853/client-1.19.2-20220805.130853-srg.jar%23151!/data/.mcassetsroot' uses unexpected schema [03Jun2023 16:36:40.675] [Render thread/INFO] [com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService/]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [03Jun2023 16:36:41.013] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Setting user: grasshopperjb [03Jun2023 16:36:41.096] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Backend library: LWJGL version 3.3.1 build 7
    • So I've created a boss mob, whether it is naturally generated or spawned by the player, after some time it despawns, what can I do so that it doesn't despawn at all? Thanks in advance
    • Hello, I'm making a mod and everything was going well until I enabled accesstransformers. After that, every gradle build attempt fails. What I tried to do to solve the problem: Deleted the forge_gradle folder several times Deleted the caches folder several times Used ./gradlew build, ./gradlew genIntellijRuns and ./gradlew --refresh-dependencies I created a new mod project with only the main file and everything goes well until the inclusion of accesstransformers. Here is the error itself: https://pastebin.com/SQhrqpzr
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.