Hey!

So I tried changing loot drops to diamonds, whenever a custom emerald tool is used.

This is my json:

{
  "conditions": [
    {
      "condition": "minecraft:alternative",
      "terms": [
        {
          "condition": "minecraft:match_tool",
          "predicate": {
            "item": "bannedtools:emerald_shovel"
          }
        },
        {
          "condition": "minecraft:match_tool",
          "predicate": {
            "item": "bannedtools:emerald_pickaxe"
          }
        }
      ]
    }
  ],
  "replacement": "minecraft:diamond"
}

It kinda works, but it seems like the condition always passes, because every drop is now a diamond, no matter which tool you use.

Any idea why it's not working correctly?

This is my LootModifier:

Spoiler

public class EmeraldItemConverterModifier extends LootModifier {

    public EmeraldItemConverterModifier(LootItemCondition[] conditionsIn) {
        super(conditionsIn);
    }

    @Nonnull
    @Override
    protected List<ItemStack> doApply(List<ItemStack> generatedLoot, LootContext context) {
        generatedLoot.clear();
        generatedLoot.add(new ItemStack(Items.DIAMOND, 1));
        return generatedLoot;
    }

    public static class Serializer extends GlobalLootModifierSerializer<EmeraldItemConverterModifier> {

        @Override
        public EmeraldItemConverterModifier read(ResourceLocation location, JsonObject object, LootItemCondition[] conditions) {
            return new EmeraldItemConverterModifier(conditions);
        }

        @Override
        public JsonObject write(EmeraldItemConverterModifier instance) {
            return makeConditions(instance.conditions);
        }
    }
}

 

Spoiler

public class LootModifiers {

    public static DeferredRegister<GlobalLootModifierSerializer<?>> LOOT_MODIFIERS =
            DeferredRegister.create(ForgeRegistries.LOOT_MODIFIER_SERIALIZERS, BannedTools.MODID);

    public static RegistryObject<GlobalLootModifierSerializer<?>> EMERALD_ITEM =
            LOOT_MODIFIERS.register("emerald_item", EmeraldItemConverterModifier.Serializer::new);
}

 

My global_loot_modifiers.json:

Spoiler

{
  "replace": false,
  "entries": [
    "bannedtools:emerald_item"
  ]
}

 

Which exact debugger do you mean?