(1.16.5) Execute command

[ElTotisPro50]

i have an item and if i right click i want to execute a command(from the code) for example /kill @a, i thinked this was going to work but nope, with !world.isRemote is not doing anything and without !world.isRemote minecraft crashes

@Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn)
    {
        ItemStack stack = playerIn.getHeldItemMainhand();
        if(!worldIn.isRemote)//do nothing
        {
            Minecraft.getInstance().player.getServer().getCommandManager().handleCommand(playerIn.getCommandSource(),"/kill @e");
        }
      
      	//crashes
        Minecraft.getInstance().player.getServer().getCommandManager().handleCommand(playerIn.getCommandSource(),"/kill @e");
      return blahblahblah;
    }

 

[ElTotisPro50]

  On 12/29/2021 at 11:06 AM, diesieben07 said:

Can't say I have seen this one before, the double reaching across logical sides...

You have to use the player that is given to you by the method. Minecraft#player is always the client player. In single player this will do nothing useful if you are on the server thread and on servers it will just crash entirely.

Expand  

i meant that how can i execute a command(just tell me exactly how to do it im not asking help for you to create my mod please)

[ElTotisPro50]

  On 12/29/2021 at 6:06 PM, diesieben07 said:

Not sure why you would execute a command. Just execute the code directly.

Expand  

well just tell me how, i need to execute a command

[ElTotisPro50]

  On 12/30/2021 at 11:05 AM, diesieben07 said:

No, you don't. You want to kill all entities, which you should just do directly, instead of executing the command.

Expand  

killing entities was a example dude, why you dont want me to execute a commandm is like if you tell me why i use kill command in game for deleting entities when i have lava...

[ElTotisPro50]

  On 12/30/2021 at 3:26 PM, diesieben07 said:

Because executing commands from code is wonky and strange. It is the interface that players have with the game, using it from code is strange and inefficient.

Commands#performCommand to run a command. But like I said, this is bad way to achieve what you want to do.

Expand  

there is no a performCommand(i used Commands class as you said), im in 1.16.5; 

[ElTotisPro50]

  On 12/31/2021 at 8:29 AM, diesieben07 said:

handleCommand if you are still using MCP names.

Expand  

Hi, it worked, so i used my command to make a gui with a textfield and a button and get the variable of the textfield and kill all the entities with that name, so i could imagine a way to kill so i wanted the /kill @e[name=textfield.getText()], but is not working(if i use something like sendStatusMessage to the player it works and the command is working but not in here)

 

public class ResearcherScreen extends ContainerScreen<ResearcherContainer> {
    private final ResourceLocation GUI = new ResourceLocation(TotisMod.MOD_ID,
            "textures/gui/researcher_gui.png");
    public static TextFieldWidget nameField;

    public ResearcherScreen(ResearcherContainer screenContainer, PlayerInventory inv, ITextComponent titleIn) {
        super(screenContainer, inv, titleIn);
    }

    @Override
    public void tick() {
        super.tick();
        this.nameField.tick();
    }

    @Override
    public void init(Minecraft minecraft, int width, int height) {
        super.init(minecraft, width, height);
        this.minecraft.keyboardListener.enableRepeatEvents(true);
        buttons.clear();
        this.addButton(new Button(66,60,103,20,new StringTextComponent("hola"),this::actionPerformed));
        this.nameField = new TextFieldWidget(this.font, 62,24,103,12,new StringTextComponent("hola"));
        this.nameField.setCanLoseFocus(false);
        this.nameField.setTextColor(-1);
        this.nameField.setDisabledTextColour(-1);
        this.nameField.setEnableBackgroundDrawing(false);
        this.nameField.setMaxStringLength(35);
        this.children.add(this.nameField);
        this.setFocusedDefault(this.nameField);
    }

    @Override
    public void onClose() {
        super.onClose();
        this.minecraft.keyboardListener.enableRepeatEvents(false);
    }

    public boolean keyPressed(int keyCode, int scanCode, int modifiers) {
        if (keyCode == 256) {
            this.minecraft.player.closeScreen();
        }
        return !this.nameField.keyPressed(keyCode, scanCode, modifiers) && !this.nameField.canWrite() ? super.keyPressed(keyCode, scanCode, modifiers) : true;
    }

  //HERE IS THE PROBLEM
    public void actionPerformed(Button button)
    {
        PlayerEntity player = Minecraft.getInstance().player;
        World world = Minecraft.getInstance().player.world;
        String pl1 = this.nameField.getText();

        if(!world.isRemote)
        {
            Commands command = new Commands(Commands.EnvironmentType.ALL);
            command.handleCommand(player.getCommandSource(),"kill @e[name=" + pl1 + "]");
            String el = "" + command.handleCommand(player.getCommandSource(),"kill @e[name=" + pl1 + "]");
            System.out.print(el);
        }
    }

    private void drawItemStack(ItemStack stack, int x, int y, float scale)
    {
        GL11.glPushMatrix();
        GL11.glScalef(scale, scale, scale);
        GlStateManager.translatef(0, 0, 32.0F);
        this.itemRenderer.zLevel = 200.0F;
        net.minecraft.client.gui.FontRenderer font = null;
        if (!stack.isEmpty()) font = stack.getItem().getFontRenderer(stack);
        if (font == null) font = font;
        this.itemRenderer.renderItemAndEffectIntoGUI(stack, x, y);
        this.itemRenderer.renderItemOverlayIntoGUI(font, stack, x, y, null);
        this.itemRenderer.zLevel = 0.0F;
        GL11.glPopMatrix();
    }

    @Override
    public void render(MatrixStack matrixStack, int mouseX, int mouseY, float partialTicks) {
        this.renderBackground(matrixStack);
        super.render(matrixStack, mouseX, mouseY, partialTicks);
        this.nameField.render(matrixStack, mouseX, mouseY, partialTicks);
        drawItemStack(new ItemStack(Items.APPLE),60,60,50f);
        this.renderHoveredTooltip(matrixStack, mouseX, mouseY);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(MatrixStack matrixStack, float partialTicks, int x, int y) {
        RenderSystem.color4f(1f, 1f, 1f, 1f);
        this.minecraft.getTextureManager().bindTexture(GUI);
        int i = this.guiLeft;
        int j = this.guiTop;
        this.blit(matrixStack, i, j, 0, 0, this.xSize, this.ySize);
        drawItemStack(new ItemStack(Items.APPLE),60,60,50f);
    }
}

is not doing anything or giving errors, is not printing anything either