Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.18.1] Unable to generate leafblocks with a high randomTickSpeed?

Aecht_Rob

By Aecht_Rob
in Modder Support

 Share

Recommended Posts

Aecht_Rob Tree Puncher

Aecht_Rob

Posted
Posted

I am working in 1.18.1 Forge (39.0.9).

I have a set of code which runs to put a tree in the world from a sapling (I am placing blocks directly in an AbstractTreeGrower class, without using the ConfiguredFeature methods of vanilla trees).

When generating the tree at regular randomTickSpeed = 3 and then setting the randomTickSpeed = 1000 afterwards, the tree is stable. Logs are correctly tagged etc. Nothing decays.

However, if I set randomTickSpeed = 1000 and then generate the tree, the leaves decay as the tree is generated and it falls apart as it is built. How can this happen? It is as if the blocks are being ticked before the code has completed?

My repository for this is here, and includes just about only this one set of trial tree code: https://github.com/AechtRob/PrehistoricNature/tree/master/src/main

 

Many thanks to anyone who can help me here!

Rob

Aecht_Rob Tree Puncher

Aecht_Rob

Posted
  • Author
Posted (edited)

Well, to follow up, these have been my activities with this:

I moved the placement of all the tree blocks to the expected Trunk and FoliagePlacer classes: it just seems that I ought to do what the framework wants me to, in case there is a special reason I don't know about.

My trees place more than just logs and leaves (other blocks too), so at first I tried out using the Trunk placer itself to add all the variety of blocks (and then pass a null list to the foliageplacer). This also had the effect that when tick speed was high the tree leaves decayed before/while it was placed. I then moved all the foliage placement to a real custom FoliagePlacer class via the List of foliage coordinates (and managed the various different kinds of leafblock in a different way). Setting all leaf blocks in the LeafPlacer results in a stable placement with no decay during generation at high tick speeds. Setting then in the TrunkPlacer does not. This is all very weird, and I am not sure if this is uncovering a bug or something actually wrong in my code.
 

It's an open question about whether other methods placing a large amount of blocks including leaves might result in some decaying before the full lot have been set.
 

Edited by Aecht_Rob

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • poudou91
      forge-1.20.1-47.4.0-installer not launching

      By poudou91 · Posted

      Hello , when I try to launch the forge installer it just crash with a message for 0,5 secondes. I'm using java 17 to launch it. Here's the link of the error :https://cdn.corenexis.com/view/?img=d/ma24/qs7u4U.jpg  
    • TileEntity
      crash dump

      By TileEntity · Posted

      You will find the crash-report or log in your minecraft directory (crash-report or logs folder)
    • TileEntity
      Croptopia Delight no funcia en mi pack de mods

      By TileEntity · Posted

      Use a modpack which is using these 2 mods as working base:   https://www.curseforge.com/minecraft/modpacks/life-in-the-village-3
    • Lizataro
      Croptopia Delight no funcia en mi pack de mods

      By Lizataro · Posted

      inicie un mundo donde instale Croptopia y Farmer's Delight, entonces instale el addon Croptopia Delight pero no funciona. es la version 1.18.2
    • Sandermall
      updateShape functionality deep dive

      By Sandermall · Posted

      Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept