Jump to content

1.5.2 Ore Generation help in a custom biomes


Heltrato

Recommended Posts

 

heres my test code

public class BiomeGenWyverniaDesert extends BiomeGenBase {

public BiomeGenWyverniaDesert(int par1) {
	super(par1);
	this.setBiomeName("Wide Desert");
	this.setMinMaxHeight(0.3F, 0.8F);
	this.spawnableMonsterList.clear();
	this.spawnableWaterCreatureList.clear();
	this.spawnableCreatureList.clear();
	this.topBlock = (byte)MainBlock.blockDesertSand_1.blockID;
        this.fillerBlock = (byte)MainBlock.blockDesertSand_1.blockID;
        this.theBiomeDecorator.treesPerChunk = -999;
        this.theBiomeDecorator.deadBushPerChunk = 2;
        this.theBiomeDecorator.generateLakes = true;
        
}
@Override
public void decorate(World par1World, Random par2Random, int par3, int par4)
{
	super.decorate(par1World, par2Random, par3, par4);
	int var5 = 12 + par2Random.nextInt(6);

	for (int var6 = 0; var6 < var5; ++var6)
	{
		int var7 = par3 + par2Random.nextInt(16);
		int var8 = par2Random.nextInt(28) + 4;
		int var9 = par4 + par2Random.nextInt(16);
		int var10 = par1World.getBlockId(var7, var8, var9);

		if (var10 == MainBlock.wyverniaStone.blockID)
		{
			par1World.setBlock(var7, var8, var9, MainBlock.MachaliteOre.blockID, 15, 4);
		}
	}
}

}



Link to comment
Share on other sites

Still no luck i cant seem to find my ore

 

heres the code

WorldGenMinable

package MHF.World.gen.layer;


import java.util.Random;

import MHF.Block.MainBlock;

import net.minecraft.block.Block;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;

public class WorldGenMinableWyvernia extends WorldGenerator
{
/** The block ID of the ore to be placed using this generator. */
private int minableBlockId;
private int minableBlockMeta = 0;

/** The number of blocks to generate. */
private int numberOfBlocks;
private int field_94523_c;

public WorldGenMinableWyvernia(int par1, int par2)
{
// Change this block to the block generated in the End, Nether, Your dimension, my dimension has my custom stone in it so for me
// i would have TutorialStone
this(par1, par2, MainBlock.wyverniaStone.blockID);
}

public WorldGenMinableWyvernia(int par1, int par2, int par3)
{
this.minableBlockId = par1;
this.numberOfBlocks = par2;
this.field_94523_c = par3;
}

public WorldGenMinableWyvernia(int id, int meta, int number, int target)
{
this(id, number, target);
minableBlockMeta = meta;
}

public boolean generate(World par1World, Random par2Random, int par3, int par4, int par5)
{
float f = par2Random.nextFloat() * (float)Math.PI;
double d0 = (double)((float)(par3 +  + MathHelper.sin(f) * (float)this.numberOfBlocks / 8.0F);
double d1 = (double)((float)(par3 +  - MathHelper.sin(f) * (float)this.numberOfBlocks / 8.0F);
double d2 = (double)((float)(par5 +  + MathHelper.cos(f) * (float)this.numberOfBlocks / 8.0F);
double d3 = (double)((float)(par5 +  - MathHelper.cos(f) * (float)this.numberOfBlocks / 8.0F);
double d4 = (double)(par4 + par2Random.nextInt(3) - 2);
double d5 = (double)(par4 + par2Random.nextInt(3) - 2);

for (int l = 0; l <= this.numberOfBlocks; ++l)
{
double d6 = d0 + (d1 - d0) * (double)l / (double)this.numberOfBlocks;
double d7 = d4 + (d5 - d4) * (double)l / (double)this.numberOfBlocks;
double d8 = d2 + (d3 - d2) * (double)l / (double)this.numberOfBlocks;
double d9 = par2Random.nextDouble() * (double)this.numberOfBlocks / 16.0D;
double d10 = (double)(MathHelper.sin((float)l * (float)Math.PI / (float)this.numberOfBlocks) + 1.0F) * d9 + 1.0D;
double d11 = (double)(MathHelper.sin((float)l * (float)Math.PI / (float)this.numberOfBlocks) + 1.0F) * d9 + 1.0D;
int i1 = MathHelper.floor_double(d6 - d10 / 2.0D);
int j1 = MathHelper.floor_double(d7 - d11 / 2.0D);
int k1 = MathHelper.floor_double(d8 - d10 / 2.0D);
int l1 = MathHelper.floor_double(d6 + d10 / 2.0D);
int i2 = MathHelper.floor_double(d7 + d11 / 2.0D);
int j2 = MathHelper.floor_double(d8 + d10 / 2.0D);

for (int k2 = i1; k2 <= l1; ++k2)
{
double d12 = ((double)k2 + 0.5D - d6) / (d10 / 2.0D);

if (d12 * d12 < 1.0D)
{
for (int l2 = j1; l2 <= i2; ++l2)
{
double d13 = ((double)l2 + 0.5D - d7) / (d11 / 2.0D);

if (d12 * d12 + d13 * d13 < 1.0D)
{
for (int i3 = k1; i3 <= j2; ++i3)
{
double d14 = ((double)i3 + 0.5D - d8) / (d10 / 2.0D);

Block block = Block.blocksList[par1World.getBlockId(k2, l2, i3)];
if (d12 * d12 + d13 * d13 + d14 * d14 < 1.0D && (block != null && block.isGenMineableReplaceable(par1World, k2, l2, i3, field_94523_c)))
{
par1World.setBlock(k2, l2, i3, this.minableBlockId, minableBlockMeta, 2);
}
}
}
}
}
}
}

return true;
}
}


MainOregen

package MHF.World.gen;

import java.util.Random;

import MHF.Block.MainBlock;
import MHF.World.gen.layer.WorldGenMinableWyvernia;

import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import cpw.mods.fml.common.IWorldGenerator;


public class MainOreGen implements IWorldGenerator
{

public static int rarity = 50;

/** Methods For Ore Generation **/
@Override
public void generate(Random random, int chunkX, int chunkZ, World world,
		IChunkProvider chunkGenerator, IChunkProvider chunkProvider)
{
	/** switchs between dimension's**/
	// the case number must match the dimension id !!!!!!!!!!! i dont no y ? it just does lol
	switch(world.provider.dimensionId)
	{
	case 2 :
		generateWyvernia(world, random, chunkX * 16, chunkZ * 16);
	}
}

private void generateWyvernia(World world, Random random, int chunkX, int chunkZ)
{
	for(int i = 0; i < 3; i++)
	{
		//this below just tells me if its generating or not
		int xCoord = chunkX + random.nextInt(16);
		int yCoord = random.nextInt(128);// the 128 is the max height the ore/block will generate
		int zCoord = chunkZ + random.nextInt(16);

		//The 230 on the line below is how meny will generate per vain, as an example i think diamond is like 2 or 4
		//and the Block.blockIron is what it will spawn
		(new WorldGenMinableWyvernia(MainBlock.MachaliteOre.blockID, 7)).generate(world, random, xCoord, yCoord, zCoord);
		(new WorldGenMinableWyvernia(MainBlock.ArmorSphere.blockID, ).generate(world, random, xCoord, yCoord, zCoord);
	}
	// the 4 below is for how rare it will be
	for(int i = 0; i < 2; i++)
	{
		//this below just tells me if its generating or not
		int xCoord = chunkX + random.nextInt(16);
		int yCoord = random.nextInt(128);// the 128 is the max height the ore/block will generate
		int zCoord = chunkZ + random.nextInt(16);

		//The 230 on the line below is how meny will generate per vain, as an example i think diamond is like 2 or 4
		//and the Block.blockIron is what it will spawn

	}

		for(int i = 0; i < 1; i++)
		{
			//this below just tells me if its generating or not
			int xCoord = chunkX + random.nextInt(16);
			int yCoord = random.nextInt(128);// the 128 is the max height the ore/block will generate
			int zCoord = chunkZ + random.nextInt(16);

			//The 230 on the line below is how meny will generate per vain, as an example i think diamond is like 2 or 4
			//and the Block.blockIron is what it will spawn

	}

}
}

 

Psi already register it on GameRegistry in my modfile

Link to comment
Share on other sites

I think it might be because after this:

for(int i = 0; i < 3; i++)
	{
		//this below just tells me if its generating or not
		int xCoord = chunkX + random.nextInt(16);
		int yCoord = random.nextInt(128);// the 128 is the max height the ore/block will generate
		int zCoord = chunkZ + random.nextInt(16);

		//The 230 on the line below is how meny will generate per vain, as an example i think diamond is like 2 or 4
		//and the Block.blockIron is what it will spawn
		(new WorldGenMinableWyvernia(MainBlock.MachaliteOre.blockID, 7)).generate(world, random, xCoord, yCoord, zCoord);
		(new WorldGenMinableWyvernia(MainBlock.ArmorSphere.blockID, ).generate(world, random, xCoord, yCoord, zCoord);
	}

You used 2 more for loops with the same variable "i". Every time you make a new for loop, you must use a different variable. But you might as well delete those two last for loops because they're not doing anything if you don't tell them what blocks to generate.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • version used : minecraft forge 1.20.1 Logs : https://bytebin.lucko.me/rtG4EA0vfb hi! so when i try to create a new minecraft world in single player, it just crashes?? does anyone has an idea what could be causing this ?
    • Hey today I was trying to play in 1.21 modpack that I made on fabric (my version of fabric is in 0.16.0) with this list of mods : - Entity Model Features (by traben_0) - Entity Texture Features (by traben_0) - Advanced Chat (by Wesley8081) - Ambient Environment (by Jaredlll08) - Ambient Souds 6 (by CreativeMD) - Animatica (by FoundationGames) - Armor Statues (by Fuzs) - Auto HUD (by Crendgrim) - Bad Packets (by badasintended) - Balm (by BlayTheNinth) - Better Beds (by Motschen) - Better Chunk Loading (by someaddon) - Better Compatibility Checker (by Gaz-) - Better FPS [Render Distance] (by someaddon) - Better Ping Display (by Quintinity) - Better Statistics Screen (by TheCSDev) - Better Armor HUD (by efekos) - Better F3 ( by cominixo) - Blur + (by Motschen) - Bobby (by Johni0702) - Cat Jam (by shmove) - Catalogue (by MrCrayfish) - Chat Heads (by dzwdz) - Cherished Worlds (by TheIllusiveC4) - Chunk Sending (by someaddon) - Chunks Fade In (by kerudion) - Chunky (by pop4959) - Cloth Config (by shedaniel) - Clumps (by Jaredlll08) - Cobweb (CrystalSpider) - Collective (by Serilum) - Configured (by MrCrayfish) - Connectivity (by someaddon) - Continuity (by Pepper_Bell) - Creative Core (by CreativeMD) - Cupboard (by someaddon) - Cut Through (by Fuzs) - Dark Loading Screen (by Neecko5b84) - Debugify (by XanderIsDev) - Double Doors (by Serilum) - Dynamic FPS (by juliand665) - Dynamic Lights (by Tschipcraft) - Easy Anvils (by Fuzs) - Easy Magic (by Fuzs) - Easy Shulker Boxes (by Fuzs) - Eating Animation (by theone-ss) - Enhanced Attack Indicator (by Mineash) - Enhanced Block Entities (by FoundationGames) - Enhanced Visuals (by CreativeMD) - Entity Culling (by tr7zw) - Environmental Water (by AgentMindStorm) - Essential (by SparkUniverse_) - Extra Thicc Packets (by JaselUmena) - Fabric (by modmuss50) - Fabric Language Kotlin (by modmuss50) - Falling Leaves (by RandomMcSomethin) - Fancy Block Particles (by Hantonik) - Fancy Health Bar (by efekos) - Farsight (by someaddon) - Fast IP Ping (by Fallen_Breath) - Ferrite Core (by  malte0811) - Fish On The Line (by Serilum) - Fix GPU Memory Leak  (by someaddon) - Forge Config API Port (by Fuzs) - FPS Reducer (by bre2el) - Freecam (by hashalite) - Fzzy Config (by fzzyhmstrs) - Get It Together (by bl4ckscor3) - Global Packs (by JTK222) - Harvest With Ease (by CrystalSpider) - Ichuntil Util (by iChun) - Immediately Fast (by RaphilMC) - Immersive UI (by SSKirillSS) - Indium (by comp500) - Inventory HUD+ (by dmitrylovin) - Iris Shaders (by coderbot) - Item Physic Full (by CreativeMD) - Jade (by Snownee) - Journey Map (by techbrew) - Just Enough Breeding (by Christofmeg) - Just Enough Items (by mezz) - Just Enough Professions (by Mrbysco) - Language Reload (by Jerozgen) - Leaves Be Gone (by Fuzs) - Let Me Despawn (by frikinjay) - Let Sleeping Dogs Lie (by iChun) - Lithium (by JellySquid) - Loading Backgrounds (by Lupin) - Mineblock's Repeated Utilities (by itsmineblock11) - Menulogue (by MrCrayfish) - Mob Plaques (by Fuzs) - Mod Menu (by Prospector) - Model Gap Fix (by MehVahdJukaar) - Mouse Tweaks (by YaLTeR) - Nether Portal Fix (by BlayTheNinth) - Nicer Skies (by ztereohype) - Noisium (by Steveplays28) - Not Enough Animations (by tr7zw) - Opti GUI (by opekope2) - Packet Fixer (by TonimatasDEV) - Particle Core (by fzzyhmstrs) - Passive Shields (by Serilum) - Pick Up Notifier (by Fuzs) - Ping Wheel (by LukenSkyne) - Puzzle (by Motschen) - Puzzles LIB (by Fuzs) - Reese's Sodium Options (by FlashyReese) - Resource Pack Overrides (by Fuzs) - Server Country Flags (by khajiitos) - Server Performance (by someaddon) - Skin Layer 3D (by tr7zw) - Sodium (by JellySquid) - Sodium Extra (by FlashyReese) - Sodium Shadowy Path Blocks (by Rynnavinx) - Sound Physics Remastered (by henkelmax) - Sounds (by itsmineblock11) - Spark (by lucko) - Stack Refill (by Serilum) - Structure Essentials (by someaddon) - TCD Commons API (by TheCSDev) - Text Placeholder API (by Patbox) - Villager Names (by Serilum) - Visual Overhaul (by Motschen) - Visual Workbench (by Fuzs) - Visuality (by PinkGoosik) - Wakes (by Goby56) - Wavey Capes (by tr7zw) - YDM'S Weapon Master  (by YourDailyModderx) - Yet Another Config LIB (by XanderIsDev) - Zoomify (by XanderIsDev) And When I load it it work, I can create a world and even let him open forever at least I didn't move cause if so the game just crash and tell me this message :   Encountered an unexpected exception net.minecraft.class_148: Ticking entity at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1025) at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:912) at net.minecraft.class_1132.method_3748(class_1132.java:114) at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:697) at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) at java.base/java.lang.Thread.run(Thread.java:1583) Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_4706.isEmpty()" because "tickets" is null at net.minecraft.class_3204.canNoneExpire(class_3204.java:1034) at net.minecraft.class_3204.handler$dln000$lithium$unregisterExpiringTicket(class_3204.java:1075) at net.minecraft.class_3204.method_17645(class_3204.java:172) at net.minecraft.class_3204.method_17292(class_3204.java:194) at net.minecraft.class_3215.method_17300(class_3215.java:443) at com.betterchunkloading.chunk.PlayerChunkData.checkPrediction(PlayerChunkData.java:406) at com.betterchunkloading.chunk.PlayerChunkData.checkDirection(PlayerChunkData.java:353) at com.betterchunkloading.chunk.PlayerChunkData.trackPlayerMovement(PlayerChunkData.java:177) at com.betterchunkloading.chunk.PlayerChunkData.onChunkChanged(PlayerChunkData.java:130) at com.betterchunkloading.event.EventHandler.onPlayerTick(EventHandler.java:200) at net.minecraft.class_3222.handler$zed000$betterchunkloading$onPlayerTick(class_3222.java:2618) at net.minecraft.class_3222.method_5773(class_3222.java:564) at net.minecraft.class_3218.mixinextras$bridge$method_5773$202(class_3218.java) at net.minecraft.class_3218.wrapOperation$eei000$puzzleslib$tickNonPassenger(class_3218.java:7797) at net.minecraft.class_3218.method_18762(class_3218.java:770) at net.minecraft.class_1937.method_18472(class_1937.java:498) at net.minecraft.class_3218.method_31420(class_3218.java:408) at net.minecraft.class_5574.method_31791(class_5574.java:54) at net.minecraft.class_3218.method_18765(class_3218.java:372) at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1021) ... 5 more Sorry guys if it obvious but actually I'm an old player of Minecraft but I'm new in modding so yup. But Thanks everyone by advance to help me with this.
    • These forums are for Minecraft Forge, not Fabric. You would probably be better served posting this question wherever fabric support is given, most likely their discord server.
    • Add the new latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here
    • Update: I tried to reproduce the bug and found out that if I place a flare on a block and then dismantle it with the pickarang (Quark), the flare gets no NBT Tag after getting assigned an empty one through the offhand.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.